Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for terraform-provider-aws v5.27.0 or later. #21

Merged
merged 4 commits into from
Dec 8, 2023
Merged

fix for terraform-provider-aws v5.27.0 or later. #21

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62f06fe
fix for terraform-provider-aws v5.27.0 or later.
yseto Dec 7, 2023
fa9236f
fix type
yseto Dec 8, 2023
3c9f683
fix typo
yseto Dec 8, 2023
5dda55c
added required version
yseto Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cloudwatch-logs-aggregator/rule/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ provider "aws" {
}

resource "aws_cloudwatch_event_rule" "this" {
name = var.rule_name
description = "created by mackerel-monitoring-modules"
is_enabled = var.is_enabled
name = var.rule_name
description = "created by mackerel-monitoring-modules"
// TODO we will follow upstream?
state = var.is_enabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[should] Former parameter "is_enabled" is boolean but now "state" is DISABLED, ENABLED or ENABLED_WITH_ALL_CLOUDTRAIL_MANAGEMENT_EVENTS. It is confusing to change the type with the same variable, so we recommend creating a new variable.

schedule_expression = var.schedule_expression
}

Expand Down
Loading