fix for terraform-provider-aws v5.27.0 or later. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthur1
reviewed
Dec 8, 2023
| name = var.rule_name | ||
| description = "created by mackerel-monitoring-modules" | ||
| // TODO we will follow upstream? | ||
| state = var.is_enabled |
There was a problem hiding this comment.
[should] Former parameter "is_enabled" is boolean but now "state" is DISABLED, ENABLED or ENABLED_WITH_ALL_CLOUDTRAIL_MANAGEMENT_EVENTS. It is confusing to change the type with the same variable, so we recommend creating a new variable.
Arthur1
reviewed
Dec 8, 2023
| description = "Whether the rules is enabled or not." | ||
| type = bool | ||
| default = true | ||
| type = "string" |
There was a problem hiding this comment.
Suggested change
| type = "string" | |
| type = string |
|
thanks for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20