Skip to content

Fix into_owned String not having enough provenance #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maciejhirsz merged 2 commits into from
May 27, 2022
Merged

Fix into_owned String not having enough provenance #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68db7d7
Fix `into_owned` `String` not having enough provenance
Noratrieb May 26, 2022
c945cfc
Run `-Zmiri-strict-provenance` in CI
Noratrieb May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/miri.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ rustup default "$MIRI_NIGHTLY"
rustup component add miri
cargo miri setup

cargo miri test --all-features
MIRIFLAGS='-Zmiri-strict-provenance' cargo miri test --all-features
4 changes: 3 additions & 1 deletion src/traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ pub(crate) mod internal {
U: Capacity,
{
// Convert to `String::into_raw_parts` once stabilized
let mut owned = ManuallyDrop::new(owned);
// We need to go through Vec here to get provenance for the entire allocation
// instead of just the initialized parts.
let mut owned = ManuallyDrop::new(owned.into_bytes());
let (fat, cap) = U::store(owned.len(), owned.capacity());

(
Expand Down