Fix into_owned String not having enough provenance#47
Merged
maciejhirsz merged 2 commits intomaciejhirsz:masterfrom May 27, 2022
Noratrieb:fix-provenance-out-of-bounds-write
Merged
Fix into_owned String not having enough provenance#47maciejhirsz merged 2 commits intomaciejhirsz:masterfrom Noratrieb:fix-provenance-out-of-bounds-write
into_owned String not having enough provenance#47maciejhirsz merged 2 commits intomaciejhirsz:masterfrom
Noratrieb:fix-provenance-out-of-bounds-write
Conversation
Calling `.as_mut_ptr` on a `String` actually goes through `&mut str`, which shrinks the provenance of the pointer to only contain the initialized bytes. This caused issues when a reconstructed `String` tried to write to the uninitialized part of it. The fix is to go through `Vec::<u8>::as_mut_ptr`, which gives provenance for the entire allocation.
Owner
|
Cheers! |
|
Maybe this is worth adding the method to |
Contributor
Author
|
I think that's a good idea. I will open a PR over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
.as_mut_ptron aStringactually goes through&mut str, which shrinks the provenance of the pointer to only contain the initialized bytes. This caused issues when a reconstructedStringtried to write to the uninitialized part of it. The fix is to go throughVec::<u8>::as_mut_ptr, which gives provenance for the entire allocation.