Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken IsVTXDisabled detection on AMD CPU #16

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

afbjorklund
Copy link

VMX is in FeatureNames, but SVM is in ExtraFeatureNames
This meant that detection always failed for SVM (AMD)

VMX is in FeatureNames, but SVM is in ExtraFeatureNames
This meant that detection *always* failed for SVM (AMD)

Thanks to user @hilbertxia

Signed-off-by: Anders F Björklund <[email protected]>
@afbjorklund
Copy link
Author

afbjorklund commented Mar 3, 2019

Cherry-picked from docker#4679
Only affects the VirtualBox driver.

Copy link

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer it fixed in upstream, but if they delay any longer, let's get the fix in here.

@tstromberg
Copy link

Perhaps it's time to merge this? :|

@afbjorklund afbjorklund merged commit 533ea58 into machine-drivers:master Mar 6, 2019
@afbjorklund afbjorklund deleted the amd branch March 6, 2019 20:31
anjannath pushed a commit to anjannath/machine that referenced this pull request Aug 27, 2019
Add HyperV driver and bundle handling functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants