-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix broken IsVTXDisabled detection on AMD CPU #4679
Conversation
Please sign your commits following these rules: $ git clone -b "svm" [email protected]:afbjorklund/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
VMX is in FeatureNames, but SVM is in ExtraFeatureNames This meant that detection *always* failed for SVM (AMD) Thanks to user @hilbertxia Signed-off-by: Anders F Björklund <[email protected]>
Thanks for sending this PR in. I'm excited to see this new bug get fixed for our users. |
Is there any additional work required before this PR gets merged? |
I noticed this on a AMD/windows laptop. The fix provided is only in linux/darwin files. |
Did you actually look at the change ? |
Sorry my bad. I had looked at the links to original files (_linux.go & _darwin.go) referred to in the pull description. |
Thanks! |
I believe this closes #4709 as well. |
VMX is in FeatureNames, but SVM is in ExtraFeatureNames
This meant that detection always failed for SVM (AMD)
Thanks to user @hilbertxia
Description
The new library approach to cpuid introduced in 5a8ce1a was broken on AMD CPU (SVM).
Unfortunately it also disabled all tests that were in the previous file-based version 850e264
Related issue(s)
Closes #4669