Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Ruff as formatter #346

Merged
merged 9 commits into from
Feb 9, 2024
Merged

Introduce Ruff as formatter #346

merged 9 commits into from
Feb 9, 2024

Conversation

hirosassa
Copy link
Collaborator

What I did in this PR

related to #344 #345

I replaced yapf with ruff as formatter.

discussion

Coding style of YAPF and Ruff is slightly different. We need to discuss on the style.
The big difference is as follows:

  • remove a blank line after class ref
  • insert a whitespace between index ref
  • remove unnecessary new line operator ref
  • change long arguments indentation style ref

@hirosassa hirosassa marked this pull request as draft January 21, 2024 23:47
@hirosassa hirosassa changed the title Replace yapf Introduce Ruff as formatter Jan 21, 2024
kitagry
kitagry approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@kitagry kitagry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I love fewer dependencies! Thank you!

.github/workflows/format.yml Outdated
with:
python-version: 3.11
python-version: 3.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hirosassa hirosassa marked this pull request as ready for review January 23, 2024 03:18
@hirosassa
Copy link
Collaborator Author

@Hi-king @yokomotod @mski-iksm pls check

@hirosassa
Copy link
Collaborator Author

hirosassa commented Jan 27, 2024 •
edited
Loading

The Configurations is changed in this commit.
Ruff formatter is applied in this commit

@Hi-king
Copy link
Member

Hi-king commented Feb 9, 2024

LGTM. Let's make a bold change!

@Hi-king Hi-king merged commit 962f1e2 into m3dev:master Feb 9, 2024
5 checks passed
@yokomotod
Copy link
Collaborator

Sorry for late the late reply!

@hirosassa hirosassa deleted the replace-yapf branch February 10, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitagry kitagry kitagry approved these changes

@yokomotod yokomotod Awaiting requested review from yokomotod

@Hi-king Hi-king Awaiting requested review from Hi-king

@mski-iksm mski-iksm Awaiting requested review from mski-iksm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hirosassa @Hi-king @yokomotod @kitagry