introduce Ruff as linter #345
Merged
+197
−230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirosassa
commented
Jan 21, 2024
| ignore = "B006,B008,W503" | ||
| max-line-length = 160 | ||
| exclude = "venv/*,tox/*" | ||
| ignore = ["B006", "B008"] |
There was a problem hiding this comment.
W503 is not currently supported in ruff and it will not be implemented.
ref: astral-sh/ruff#4125
Is anyone who want to ignore this error?
test/test_redis_lock.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| import random | |||
| import random # noqa: I001 | |||
There was a problem hiding this comment.
This noqa is needed for line 8.
If I remove this noqa the line will fixed as following format by ruff
from gokart.redis_lock import (
RedisClient,
RedisParams,
make_redis_key,
make_redis_params,
wrap_with_dump_lock,
wrap_with_load_lock,
wrap_with_remove_lock,
wrap_with_run_lock,
)To minimize diff in this PR I added it but it needs to discuss with this issue.
There was a problem hiding this comment.
[imo] +1 to ruff's one, and +10 to accept default behaviors.
There was a problem hiding this comment.
applied! e834ad0
|
@hirosassa Great! Can you compare exection time? |
|
@yokomotod In my local PC, using |
yokomotod
reviewed
Jan 21, 2024
yokomotod
reviewed
Jan 21, 2024
yokomotod
reviewed
Jan 21, 2024
|
@yokomotod All of your suggestions are fixed! plz check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did in this PR
related to #344
I introduce
ruffas linter.I replaced
flake8andisortto simplify the configuration.What I did not do
Replacing
yapfwithruffis next task.