Raise better error when mjml binary is not found #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-brousse
changed the title
nicolas-brousse
force-pushed
the
improve-errors
branch
from
85a5749 to
9a0b01a
Compare
nicolas-brousse
force-pushed
the
improve-errors
branch
from
9a0b01a to
6ebb962
Compare
|
@kolybasov let me know if some part of my PR is not okay for you. |
|
@nicolas-brousse looks great. Nice job! 👍 I will add you as collaborator in case you are interested to support this project. I am not into Ruby anymore but seems people still use it so it will be great if it will continue to work :) |
|
@nicolas-brousse v0.3.3 published to RubyGems https://github.com/kolybasov/mjml-ruby/releases/tag/v0.3.3 |
|
Thanks for it and for the invitation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12