Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when mjml is not installed #12

Closed
nicolas-brousse opened this issue May 10, 2019 · 2 comments · Fixed by #13
Closed

Improve error message when mjml is not installed #12

nicolas-brousse opened this issue May 10, 2019 · 2 comments · Fixed by #13

Comments

@nicolas-brousse
Copy link
Collaborator

In a server I've got an issue where mails was not sent anymore.

We've got the following error, because mjml was not installed (it was before):

ActionView::Template::Error
No such file or directory - 

I think #extract_executable_version method needs to catch Errno::ENOENT exception, or something like that.

It may help a lot for debug.

In our case, on each deploys packages are installed. But some server changes made that yarn install doesn't installed mjml.
For me the main issue here was that the error message came from ActionMailer and not MJML gem.

@m-basov
Copy link
Owner

m-basov commented May 13, 2019

@nicolas-brousse thank you for pointing this out! I do not have time to work on this project yet so if you can make PR with better error it may help someone in the future! :)

@nicolas-brousse
Copy link
Collaborator Author

@kolybasov I'll try to have a look and open a PR this week if I found a bit of time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants