chore: add more tests for fp-only-test by PupilTong · Pull Request #850 · lynx-family/lynx-stack

PupilTong · 2025-05-19T14:02:18Z

No description provided.

changeset-bot · 2025-05-19T14:02:22Z

🦋 Changeset detected

Latest commit: 2bcde26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@lynx-js/offscreen-document	Patch
@lynx-js/web-constants	Patch
@lynx-js/web-core-server	Patch
@lynx-js/web-core	Patch
@lynx-js/web-worker-runtime	Patch
@lynx-js/web-mainthread-apis	Patch
@lynx-js/web-worker-rpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull Request Overview

This PR adds additional tests for the fp-only workflow while updating styles and offscreen document behavior to support new requirements.

Adds several new test cases in fp-only.spec.ts for SSR, basic CSS, and configuration scenarios.
Updates various CSS files by removing outdated :defined selectors and refines their display rules.
Introduces innerHTML handling in OffscreenElement and adjusts OffscreenDocument accordingly, and updates the CI workflow to run the new playwright-linux-fp-only test.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/web-platform/web-tests/tests/fp-only.spec.ts	Introduces new test suites and temporary fixme tests including a minor typo in a skip message.
packages/web-platform/web-elements/*	Updates CSS selectors, removing reliance on :defined for improved style handling.
packages/web-platform/offscreen-document/*	Adds innerHTML support and updates innerHTML construction logic in offscreen document serialization.
.github/workflows/test.yml	Adds a new CI job for playwright-linux-fp-only testing.
.changeset/stale-zebras-add.md	Removes a changeset related to a previous innerHTML revert.

packages/web-platform/web-tests/tests/fp-only.spec.ts

.github/workflows/test.yml

codecov · 2025-05-19T14:15:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2025-05-19T14:19:09Z

CodSpeed Performance Report

Merging #850 will not alter performance

_{Comparing PupilTong:p/hw/fp-only-more-tests (2bcde26) with main (5876659)}

Summary

✅ 9 untouched benchmarks

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: PupilTong <12288479+PupilTong@users.noreply.github.com>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/react@0.109.0 ### Minor Changes - Support MTS functions running on the first screen. ([#840](#840)) ### Patch Changes - Fix type error when using `Suspense` with `"jsx": "react-jsx"`. ([#854](#854)) - Support lazy bundle in ReactLynx testing library. ([#869](#869)) - Fix a bug in HMR that snapshots are always updated because the same unique ID check is not performed correctly. ([#869](#869)) - Fix missing types of `key` on components when using `"jsx": "react-jsx"`. ([#872](#872)) ## @lynx-js/react-rsbuild-plugin@0.10.0 ### Minor Changes - **BREAKING CHANGE**: Remove the unused `jsx` option. ([#903](#903)) ### Patch Changes - Support `output.inlineScripts`, which controls whether to inline scripts into Lynx bundle (`.lynx.bundle`). ([#874](#874)) Only background thread scripts can remain non-inlined, whereas the main thread script is always inlined. example: ```js import { defineConfig } from "@lynx-js/rspeedy"; export default defineConfig({ output: { inlineScripts: false, }, }); ``` - Support `@lynx-js/react` v0.109.0. ([#840](#840)) - Use `WebEncodePlugin` instead of `WebWebpackPlugin`. ([#904](#904)) - Updated dependencies \[[`7beb35e`](7beb35e), [`b6e27da`](b6e27da), [`5ddec12`](5ddec12), [`77524bc`](77524bc), [`fdab5dc`](fdab5dc), [`ff63b58`](ff63b58), [`fdab5dc`](fdab5dc), [`2b83934`](2b83934), [`3520031`](3520031)]: - @lynx-js/template-webpack-plugin@0.7.0 - @lynx-js/css-extract-webpack-plugin@0.5.4 - @lynx-js/react-refresh-webpack-plugin@0.3.3 - @lynx-js/react-webpack-plugin@0.6.14 - @lynx-js/react-alias-rsbuild-plugin@0.10.0 ## @lynx-js/template-webpack-plugin@0.7.0 ### Minor Changes - Rename `lepus` to `mainThreadAssets` in `beforeEmit` hook. ([#901](#901)) - Remove the unused `encodeBinary` option of `LynxEncodePlugin`. ([#880](#880)) ### Patch Changes - Support `output.inlineScripts`, which controls whether to inline scripts into Lynx bundle (`.lynx.bundle`). ([#874](#874)) Only background thread scripts can remain non-inlined, whereas the main thread script is always inlined. example: ```js import { defineConfig } from "@lynx-js/rspeedy"; export default defineConfig({ output: { inlineScripts: false, }, }); ``` - refactor: code clean ([#897](#897)) rename many internal apis to make logic be clear: multi-thread: startMainWorker -> prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) all-on-ui: prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) - Add `WebEncodePlugin`. ([#904](#904)) This is previously known as `WebWebpackPlugin` from `@lynx-js/web-webpack-plugin`. - Fix a bug that the `lepus` arg of `beforeEmit` hook does not contains the `root` main chunk of the main thread. ([#898](#898)) ## @lynx-js/rspeedy@0.9.6 ### Patch Changes - Support `output.inlineScripts`, which controls whether to inline scripts into Lynx bundle (`.lynx.bundle`). ([#874](#874)) Only background thread scripts can remain non-inlined, whereas the main thread script is always inlined. example: ```js import { defineConfig } from "@lynx-js/rspeedy"; export default defineConfig({ output: { inlineScripts: false, }, }); ``` - Bump Rsbuild v1.3.21 with Rspack v1.3.11. ([#863](#863)) - Updated dependencies \[[`5b67bde`](5b67bde)]: - @lynx-js/chunk-loading-webpack-plugin@0.2.1 ## @lynx-js/offscreen-document@0.0.4 ### Patch Changes - fix: remove all children after the innerHTML setter is called ([#850](#850)) - refactor: code clean ([#897](#897)) rename many internal apis to make logic be clear: multi-thread: startMainWorker -> prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) all-on-ui: prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) - perf: improve dom operation performance ([#881](#881)) - code clean for offscreen-document, cut down inheritance levels - add `appendChild` method for OffscreenElement, improve performance for append one node - bypass some JS getter for dumping SSR string ## @lynx-js/web-constants@0.13.3 ### Patch Changes - refactor: code clean ([#897](#897)) rename many internal apis to make logic be clear: multi-thread: startMainWorker -> prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) all-on-ui: prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.13.3 ## @lynx-js/web-core@0.13.3 ### Patch Changes - refactor: code clean ([#897](#897)) rename many internal apis to make logic be clear: multi-thread: startMainWorker -> prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) all-on-ui: prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) - perf: improve dom operation performance ([#881](#881)) - code clean for offscreen-document, cut down inheritance levels - add `appendChild` method for OffscreenElement, improve performance for append one node - bypass some JS getter for dumping SSR string - fix: worker not released when backgroundWorkerContextCount != 1 ([#845](#845)) - Updated dependencies \[[`bb1f9d8`](bb1f9d8), [`b6e27da`](b6e27da), [`3d716d7`](3d716d7)]: - @lynx-js/offscreen-document@0.0.4 - @lynx-js/web-mainthread-apis@0.13.3 - @lynx-js/web-worker-runtime@0.13.3 - @lynx-js/web-constants@0.13.3 - @lynx-js/web-worker-rpc@0.13.3 ## @lynx-js/web-core-server@0.13.3 ### Patch Changes - refactor: code clean ([#897](#897)) rename many internal apis to make logic be clear: multi-thread: startMainWorker -> prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) all-on-ui: prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) - feat: support to dump ssrEncode string ([#876](#876)) - perf: improve dom operation performance ([#881](#881)) - code clean for offscreen-document, cut down inheritance levels - add `appendChild` method for OffscreenElement, improve performance for append one node - bypass some JS getter for dumping SSR string - feat: dump dehydrate string with shadow root template ([#838](#838)) ## @lynx-js/web-elements@0.7.3 ### Patch Changes - refactor: allow elements to be rendered before :defined ([#855](#855)) Before this commit, we don't allow developers to render these elements before they're defined. In this commit, we will remove these restrictions. - fix: remove the style `contain: content` of x-foldview-ng, otherwise it will cause the `position: fixed` elements to be positioned incorrectly after scrolling. ([#878](#878)) - fix: x-list should observe property list-type change. ([#862](#862)) Before this commit, list-type only works when it was first assigned. use `requestAnimationFrame` instead of `queueMicrotask` to layoutListItem, this is because it may cause crashes in webkit. - fix: list-item should support linear layout. ([#859](#859)) - Updated dependencies \[]: - @lynx-js/web-elements-template@0.7.3 ## @lynx-js/web-explorer@0.0.9 ### Patch Changes - chore: update dependencies: ([#868](#868)) - @lynx-js/web-elements@0.7.2 - @lynx-js/web-core@0.13.2 ## @lynx-js/web-mainthread-apis@0.13.3 ### Patch Changes - refactor: code clean ([#897](#897)) rename many internal apis to make logic be clear: multi-thread: startMainWorker -> prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) all-on-ui: prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) - perf: improve dom operation performance ([#881](#881)) - code clean for offscreen-document, cut down inheritance levels - add `appendChild` method for OffscreenElement, improve performance for append one node - bypass some JS getter for dumping SSR string - Updated dependencies \[[`b6e27da`](b6e27da)]: - @lynx-js/web-constants@0.13.3 ## @lynx-js/web-worker-runtime@0.13.3 ### Patch Changes - refactor: code clean ([#897](#897)) rename many internal apis to make logic be clear: multi-thread: startMainWorker -> prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) all-on-ui: prepareMainThreadAPIs -> startMainThread -> createMainThreadContext(new MainThreadRuntime) - Updated dependencies \[[`bb1f9d8`](bb1f9d8), [`b6e27da`](b6e27da), [`3d716d7`](3d716d7)]: - @lynx-js/offscreen-document@0.0.4 - @lynx-js/web-mainthread-apis@0.13.3 - @lynx-js/web-constants@0.13.3 - @lynx-js/web-worker-rpc@0.13.3 ## @lynx-js/chunk-loading-webpack-plugin@0.2.1 ### Patch Changes - Add `StartupChunkDependenciesRuntimeModule` to fix `RuntimeGlobals.ensureChunkHandler` not found when using chunk splitting ([#798](#798)) ## @lynx-js/css-extract-webpack-plugin@0.5.4 ### Patch Changes - Support `@lynx-js/template-webpack-plugin` v0.7.0. ([#880](#880)) - Support Rspack v1.3.11. ([#866](#866)) ## @lynx-js/react-refresh-webpack-plugin@0.3.3 ### Patch Changes - Support `@lynx-js/template-webpack-plugin` v0.7.0. ([#880](#880)) ## @lynx-js/react-webpack-plugin@0.6.14 ### Patch Changes - Support `@lynx-js/template-webpack-plugin` v0.7.0. ([#880](#880)) - Support `@lynx-js/react` v0.109.0. ([#840](#840)) ## create-rspeedy@0.9.6 ## @lynx-js/react-alias-rsbuild-plugin@0.10.0 ## upgrade-rspeedy@0.9.6 ## @lynx-js/web-elements-template@0.7.3 ## @lynx-js/web-worker-rpc@0.13.3 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

PupilTong requested review from Sherry-hue, colinaaa and Copilot May 19, 2025 14:02

Copilot AI reviewed May 19, 2025

View reviewed changes

packages/web-platform/web-tests/tests/fp-only.spec.ts Outdated Show resolved Hide resolved

PupilTong force-pushed the p/hw/fp-only-more-tests branch from c1dcca7 to 00af1bf Compare May 19, 2025 14:06

PupilTong self-assigned this May 19, 2025

PupilTong added the platform:Web label May 19, 2025

PupilTong added this to Lynx for Web May 19, 2025

colinaaa reviewed May 19, 2025

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

PupilTong force-pushed the p/hw/fp-only-more-tests branch from 515a517 to 87438cc Compare May 20, 2025 04:20

colinaaa previously approved these changes May 20, 2025

View reviewed changes

PupilTong dismissed colinaaa’s stale review via 1f22f0a May 20, 2025 07:16

PupilTong force-pushed the p/hw/fp-only-more-tests branch 2 times, most recently from 1f22f0a to 7ba7d7e Compare May 20, 2025 11:58

PupilTong and others added 5 commits May 20, 2025 22:08

chore: add more tests for fp-only-test

3f2bb4f

Update packages/web-platform/web-tests/tests/fp-only.spec.ts

5df7c88

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: PupilTong <12288479+PupilTong@users.noreply.github.com>

enable more tests

1178dd3

update snapshot

31af524

remove some meaningless snapshot tests

2bcde26

PupilTong force-pushed the p/hw/fp-only-more-tests branch from 7ba7d7e to 2bcde26 Compare May 20, 2025 14:08

PupilTong requested a review from colinaaa May 20, 2025 14:25

PupilTong enabled auto-merge May 20, 2025 14:25

colinaaa approved these changes May 20, 2025

View reviewed changes

PupilTong added this pull request to the merge queue May 20, 2025

Merged via the queue into lynx-family:main with commit bb1f9d8 May 20, 2025
38 checks passed

PupilTong deleted the p/hw/fp-only-more-tests branch May 20, 2025 15:08

github-project-automation bot moved this to Done in Lynx for Web May 20, 2025

github-actions bot mentioned this pull request May 20, 2025

chore: Release 2025-05-23 15:46:22 #844

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add more tests for fp-only-test#850

chore: add more tests for fp-only-test#850
PupilTong merged 5 commits intolynx-family:mainfrom
PupilTong:p/hw/fp-only-more-tests

PupilTong commented May 19, 2025

Uh oh!

changeset-bot bot commented May 19, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented May 19, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented May 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

PupilTong commented May 19, 2025

Uh oh!

changeset-bot bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

codecov bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #850 will not alter performance

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented May 19, 2025 •

edited

Loading

codecov bot commented May 19, 2025 •

edited

Loading

codspeed-hq bot commented May 19, 2025 •

edited

Loading