Skip to content

docs(react/transform): mark jsx as internal and add docs for defineDCE#846

Merged
colinaaa merged 8 commits intolynx-family:mainfrom
colinaaa:colin/0519/type-internal
May 20, 2025
Merged

docs(react/transform): mark jsx as internal and add docs for defineDCE#846
colinaaa merged 8 commits intolynx-family:mainfrom
colinaaa:colin/0519/type-internal

Conversation

@colinaaa
Copy link
Copy Markdown
Collaborator

@colinaaa colinaaa commented May 19, 2025

Summary

Following up on #843 and #841, mark defineDCE and jsx as internal, as they are not intended to be configured by users.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 19, 2025

🦋 Changeset detected

Latest commit: 8bb3f90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 19, 2025

CodSpeed Performance Report

Merging #846 will not alter performance

Comparing colinaaa:colin/0519/type-internal (8bb3f90) with main (243473e)

Summary

✅ 9 untouched benchmarks

@colinaaa colinaaa marked this pull request as ready for review May 19, 2025 12:26
@colinaaa colinaaa requested a review from Yradex May 19, 2025 12:26
Yradex
Yradex previously approved these changes May 19, 2025
@Yradex Yradex enabled auto-merge May 19, 2025 12:38
@colinaaa colinaaa disabled auto-merge May 19, 2025 12:41
@codecov
Copy link
Copy Markdown

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

github-merge-queue bot pushed a commit that referenced this pull request May 19, 2025
## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

Following up #843, #841 and #846. Add docs for every fields in
`ExtractStrConfig`.

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

## Checklist

<!--- Check and mark with an "x" -->

- [ ] Tests updated (or not required).
- [x] Documentation updated (or not required).
PupilTong pushed a commit to PupilTong/lynx-stack that referenced this pull request May 20, 2025
## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

Following up lynx-family#843, lynx-family#841 and lynx-family#846. Add docs for every fields in
`ExtractStrConfig`.

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

## Checklist

<!--- Check and mark with an "x" -->

- [ ] Tests updated (or not required).
- [x] Documentation updated (or not required).
@colinaaa colinaaa changed the title docs(react/transform): mark defineDCE and jsx as internal docs(react/transform): mark jsx as internal and add docs for defineDCE May 20, 2025
@colinaaa colinaaa enabled auto-merge May 20, 2025 08:13
@colinaaa colinaaa added this pull request to the merge queue May 20, 2025
Merged via the queue into lynx-family:main with commit d0b07d8 May 20, 2025
40 of 41 checks passed
@colinaaa colinaaa deleted the colin/0519/type-internal branch May 20, 2025 08:45
github-merge-queue bot pushed a commit that referenced this pull request May 20, 2025
## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

Following up #841, #843, #846 and #847. Add the transform-related
options to API reference.

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

## Checklist

<!--- Check and mark with an "x" -->

- [ ] Tests updated (or not required).
- [x] Documentation updated (or not required).
colinaaa added a commit that referenced this pull request May 23, 2025
## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

The `jsx` was marked as internal in #846, but it serves no purpose and
should be removed entirely.

A minor bump has been made since removing an option is a breaking
change.

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

## Checklist

<!--- Check and mark with an "x" -->

- [x] Tests updated (or not required).
- [x] Documentation updated (or not required).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants