Skip to content

ci: use different keys for different projects#743

Merged
colinaaa merged 2 commits intolynx-family:mainfrom
colinaaa:colin/0509/key
May 8, 2025
Merged

ci: use different keys for different projects#743
colinaaa merged 2 commits intolynx-family:mainfrom
colinaaa:colin/0509/key

Conversation

@colinaaa
Copy link
Copy Markdown
Collaborator

@colinaaa colinaaa commented May 8, 2025

Summary

We should use different key for different projects in a monorepo.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2025

⚠️ No Changeset found

Latest commit: f452d4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread .github/workflows/relative-ci.yml Fixed
@colinaaa colinaaa merged commit c513526 into lynx-family:main May 8, 2025
6 checks passed
@colinaaa colinaaa mentioned this pull request May 8, 2025
2 tasks
colinaaa added a commit that referenced this pull request May 8, 2025
<!--
  Thank you for submitting a pull request!

We appreciate the time and effort you have invested in making these
changes. Please ensure that you provide enough information to allow
others to review your pull request.

Upon submission, your pull request will be automatically assigned with
reviewers.

If you want to learn more about contributing to this project, please
visit:
https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md.
-->

## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

We accidentally removed "Deploy" and "Test" in #743. :)

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

## Checklist

<!--- Check and mark with an "x" -->

- [ ] Tests updated (or not required).
- [ ] Documentation updated (or not required).
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2025

Bundle Report

Changes will increase total bundle size by 3.21kB (0.5%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@lynx-js/example-react-lynx-cjs 321.0kB 3.21kB (1.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @lynx-js/example-react-lynx-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
main.lynx.bundle 1.67kB 89.8kB 1.89%
.rspeedy/main/main-thread.js 728 bytes 40.78kB 1.82%
.rspeedy/main/background.*.js 810 bytes 39.86kB 2.07%

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 8, 2025

CodSpeed Performance Report

Merging #743 will not alter performance

Comparing colinaaa:colin/0509/key (4cae120) with main (5c16b9e)

Summary

✅ 1 untouched benchmarks

@relativeci
Copy link
Copy Markdown

relativeci Bot commented May 8, 2025

React Example

#13 Bundle Size — 233.45KiB (-25.36%).

4cae120(current) vs 5c16b9e main#2(baseline)

Warning

Bundle introduced 2 new packages: @hongzhiyuan/preact, @swc/helpers – View changed packages

Bundle metrics  Change 8 changes Regression 1 regression Improvement 3 improvements
                 Current
#13
     Baseline
#2
Improvement  Initial JS 0B(-100%) 151.26KiB
Improvement  Initial CSS 0B(-100%) 33.15KiB
No change  Cache Invalidation 0% 0%
Change  Chunks 0(-100%) 5
Change  Assets 4(-20%) 5
Change  Modules 140(-31.71%) 205
Regression  Duplicate Modules 55(+323.08%) 13
Change  Duplicate Code 46.22%(+1771.26%) 2.47%
Improvement  Packages 2(-60%) 5
No change  Duplicate Packages 0 0
Bundle size by type  Change 4 changes Regression 2 regressions Improvement 2 improvements
                 Current
#13
     Baseline
#2
Regression  IMG 145.76KiB (+100%) 0B
Regression  Other 87.69KiB (+100%) 0B
Improvement  JS 0B (-100%) 279.62KiB
Improvement  CSS 0B (-100%) 33.15KiB

Bundle analysis reportBranch colinaaa:colin/0509/keyProject dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants