Skip to content

feat(background-only): add source and integrate into monorepo#711

Merged
colinaaa merged 2 commits intolynx-family:mainfrom
Huxpro:main
May 8, 2025
Merged

feat(background-only): add source and integrate into monorepo#711
colinaaa merged 2 commits intolynx-family:mainfrom
Huxpro:main

Conversation

@Huxpro
Copy link
Copy Markdown
Collaborator

@Huxpro Huxpro commented May 7, 2025

Add back background-only package to monorepo.

Note that the package was already published to npm: https://www.npmjs.com/package/background-only

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 7, 2025

⚠️ No Changeset found

Latest commit: dcd32ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Huxpro Huxpro requested review from colinaaa and upupming May 7, 2025 22:20
@Huxpro
Copy link
Copy Markdown
Collaborator Author

Huxpro commented May 7, 2025

⚠️ No Changeset found

We are good as there is no need to republish the package

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 7, 2025

CodSpeed Performance Report

Merging #711 will not alter performance

Comparing Huxpro:main (dcd32ee) with main (379b8e5)

Summary

✅ 1 untouched benchmarks

colinaaa
colinaaa previously approved these changes May 8, 2025
Comment thread packages/background-only/README.md Outdated
Oops you are right

Co-authored-by: Qingyu Wang <40660121+colinaaa@users.noreply.github.com>
Signed-off-by: Xuan Huang (黄玄) <5563315+Huxpro@users.noreply.github.com>
@colinaaa colinaaa enabled auto-merge May 8, 2025 03:10
@codecov
Copy link
Copy Markdown

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/background-only/error.js 0.00% 7 Missing ⚠️
packages/background-only/empty.js 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@colinaaa colinaaa added this pull request to the merge queue May 8, 2025
Merged via the queue into lynx-family:main with commit 6cbf288 May 8, 2025
29 of 30 checks passed
github-merge-queue bot pushed a commit that referenced this pull request May 8, 2025
## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

Following up #711, use the `background-only` package from workspace.

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

## Checklist

<!--- Check and mark with an "x" -->

- [ ] Tests updated (or not required).
- [ ] Documentation updated (or not required).
Huxpro pushed a commit to Huxpro/lynx-stack that referenced this pull request May 9, 2025
…ly#721)

## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

Following up lynx-family#711, use the `background-only` package from workspace.

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

## Checklist

<!--- Check and mark with an "x" -->

- [ ] Tests updated (or not required).
- [ ] Documentation updated (or not required).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants