Skip to content

refactor(rspeedy/cli): merge duplicated code#690

Merged
gaoachao merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0504/cli-init
May 6, 2025
Merged

refactor(rspeedy/cli): merge duplicated code#690
gaoachao merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0504/cli-init

Conversation

@colinaaa
Copy link
Collaborator

@colinaaa colinaaa commented May 4, 2025

Summary

This patch adds a new init() function in src/cli, enabling multiple CLI commands to share the argv parsing implementation efficiently.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2025

🦋 Changeset detected

Latest commit: ad9bcac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented May 4, 2025

CodSpeed Performance Report

Merging #690 will not alter performance

Comparing colinaaa:colin/0504/cli-init (ad9bcac) with main (f4bbda2)

Summary

✅ 1 untouched benchmarks

@colinaaa colinaaa requested review from gaoachao and luhc228 May 6, 2025 04:01
@colinaaa colinaaa marked this pull request as ready for review May 6, 2025 04:01
@gaoachao gaoachao added this pull request to the merge queue May 6, 2025
Merged via the queue into lynx-family:main with commit cdd1268 May 6, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants