fix: resolve page crash on development mode when enabling `experimental_isLazyBundle: true` #653

upupming · 2025-04-28T13:17:57Z

Summary

Fixes #504

In this PR, we disabled HMR for standalone lazy bundle to ensure it works normally when it is served using rspeedy dev.

When HMR is enabled, the bundle result will be like:

/************************************************************************/
// module cache are used so entry inlining is disabled
// startup
// Load entry module and return exports
__webpack_require__("(react:background)/./src/index.tsx");
__webpack_require__("(react:background)/./node_modules/.pnpm/@rspack+core@1.3.6_@swc+helpers@0.5.17/node_modules/@rspack/core/hot/dev-server.js");
__webpack_require__("(react:background)/./node_modules/.pnpm/@lynx-js+webpack-dev-transport@0.1.2/node_modules/@lynx-js/webpack-dev-transport/lib/client/index.js?hostname=192.168.5.55&port=3000&pathname=/rsbuild-hmr&hot=true&live-reload=true&protocol=ws");
var __webpack_exports__ = __webpack_require__("(react:background)/./node_modules/.pnpm/@lynx-js+react@0.107.0_@lynx-js+types@3.2.1_@types+react@18.3.20/node_modules/@lynx-js/react/refresh/dist/index.js");

It wrongly exports @lynx-js/react/refresh/dist/index.js as the default export, however (react:background)/./src/index.tsx is expected.

Checklist

Tests updated (or not required).
Documentation updated (or not required).

…t mode

changeset-bot · 2025-04-28T13:18:02Z

🦋 Changeset detected

Latest commit: 8edddb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@lynx-js/react-webpack-plugin	Patch
@lynx-js/react-rsbuild-plugin	Patch
@lynx-js/runtime-wrapper-webpack-plugin	Patch
@lynx-js/react-alias-rsbuild-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2025-04-28T13:29:17Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
1533	1	1532	3

View the top 1 failed test(s) by shortest run time

packages/rspeedy/plugin-react/test/background-only.test.ts > Build background-only > build fail

Stack Traces | 0.108s run time

AssertionError: expected 'ENOENT: no such file or directory, op…' to be 'Rspack build failed.' // Object.is equality

Expected: "Rspack build failed."
Received: "ENOENT: no such file or directory, open '.../lynx-stack/dist/.rspeedy/rspeedy.config.js'"

 ❯ test/background-only.test.ts:171:40

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

codspeed-hq · 2025-04-28T13:30:03Z

CodSpeed Performance Report

Merging #653 will not alter performance

_{Comparing upupming:fix/isLazyBundle (8edddb3) with main (f4ac0f1)}

Summary

✅ 1 untouched benchmarks

colinaaa

Generally looks good to me.

packages/rspeedy/plugin-react/src/entry.ts

.changeset/short-crabs-lead.md

codecov · 2025-04-29T09:15:25Z

Bundle Report

Bundle size has no change ✅

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/react@0.108.0 ### Minor Changes - Reverts #239: "batch multiple patches for main thread communication" ([#649](#649)) This reverts the change that batched updates sent to the main thread in a single render pass. ### Patch Changes - Add support for batch rendering in `<list>` with async resolution of sub-tree properties and element trees. ([#624](#624)) Use the `experimental-batch-render-strategy` attribute of `<list>`: ```tsx <list /** * Batch render strategy: * 0: (Default) Disabled - No batch rendering * 1: Basic - Only batch rendering enabled * 2: Property Resolution - Batch render with async property resolution for list item subtree * 3: Full Resolution - Batch render with async property and element tree resolution for list item subtree */ experimental-batch-render-strategy={3} ></list> ``` - rename @lynx-js/test-environment to @lynx-js/testing-environment ([#704](#704)) - Auto import `@lynx-js/react/experimental/lazy/import` when using `import(url)` ([#667](#667)) - Auto import `@lynx-js/react/experimental/lazy/import` when using `<component is={url} />` ([#666](#666)) - Fixed a race condition when updating states and GlobalProps simultaneously. ([#707](#707)) This fix prevents the "Attempt to render more than one `<page />`" error from occurring during normal application usage. - Fix error like `Unterminated string constant` when using multi-line JSX StringLiteral. ([#654](#654)) ## @lynx-js/testing-environment@0.1.0 ### Minor Changes - Switch to ESM package format by setting `"type": "module"`. ([#703](#703)) ### Patch Changes - rename @lynx-js/test-environment to @lynx-js/testing-environment ([#704](#704)) ## @lynx-js/web-platform-rsbuild-plugin@0.1.0 ### Minor Changes - feat: add new parameter `nativeModulesPath` to `pluginWebPlatform({})`. ([#668](#668)) After this commit, you can use `nativeModulesPath` to package custom nativeModules directly into the worker, and no longer need to pass `nativeModulesMap` to lynx-view. Here is an example: - `native-modules.ts`: ```ts // index.native-modules.ts export default { CustomModule: function (NativeModules, NativeModulesCall) { return { async getColor(data, callback) { const color = await NativeModulesCall("getColor", data); callback(color); }, }; }, }; ``` - plugin config: ```ts // rsbuild.config.ts import { pluginWebPlatform } from "@lynx-js/web-platform-rsbuild-plugin"; import { defineConfig } from "@rsbuild/core"; export default defineConfig({ plugins: [ pluginWebPlatform({ // replace with your actual native-modules file path nativeModulesPath: path.resolve(__dirname, "./index.native-modules.ts"), }), ], }); ``` - feat: Provides Rsbuild plugin for Web projects in Lynx Web Platform, currently supports polyfill about lynx. ([#606](#606)) ## @lynx-js/rspeedy@0.9.4 ### Patch Changes - Bump Rsbuild v1.3.17 with Rspack v1.3.9. ([#708](#708)) - Support `performance.profile`. ([#691](#691)) - Support CLI flag `--mode` to specify the build mode. ([#723](#723)) - Enable native Rsdoctor plugin by default. ([#688](#688)) Set `tools.rsdoctor.experiments.enableNativePlugin` to `false` to use the old JS plugin. ```js import { defineConfig } from "@lynx-js/rspeedy"; export default defineConfig({ tools: { rsdoctor: { experiments: { enableNativePlugin: false, }, }, }, }); ``` See [Rsdoctor - 1.0](https://rsdoctor.dev/blog/release/release-note-1_0#-faster-analysis) for more details. - Bump Rsbuild v1.3.14 with Rspack v1.3.8. ([#630](#630)) ## @lynx-js/react-rsbuild-plugin@0.9.9 ### Patch Changes - Fix runtime error: "SyntaxError: Identifier 'i' has already been declared". ([#651](#651)) - Enable runtime profiling when `performance.profile` is set to true. ([#722](#722)) - fix: resolve page crash on development mode when enabling `experimental_isLazyBundle: true` ([#653](#653)) - Support `@lynx-js/react` v0.108.0. ([#649](#649)) - Updated dependencies \[[`ea4da1a`](ea4da1a), [`ca15dda`](ca15dda), [`f8d369d`](f8d369d), [`ea4da1a`](ea4da1a)]: - @lynx-js/react-webpack-plugin@0.6.13 - @lynx-js/runtime-wrapper-webpack-plugin@0.0.10 - @lynx-js/react-alias-rsbuild-plugin@0.9.9 - @lynx-js/react-refresh-webpack-plugin@0.3.2 ## @lynx-js/tailwind-preset@0.0.3 ### Patch Changes - Support `hidden`, `no-underline` and `line-through` utilities. ([#745](#745)) ## @lynx-js/offscreen-document@0.0.2 ### Patch Changes - feat: support touch events ([#641](#641)) ## @lynx-js/web-constants@0.13.1 ### Patch Changes - feat: support touch events for MTS ([#641](#641)) now we support - main-thread:bindtouchstart - main-thread:bindtouchend - main-thread:bindtouchmove - main-thread:bindtouchcancel - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.13.1 ## @lynx-js/web-core@0.13.1 ### Patch Changes - fix: some inline style properties cause crash ([#647](#647)) add support for the following css properties - mask - mask-repeat - mask-position - mask-clip - mask-origin - mask-size - gap - column-gap - row-gap - image-rendering - hyphens - offset-path - offset-distance - feat: support touch events for MTS ([#641](#641)) now we support - main-thread:bindtouchstart - main-thread:bindtouchend - main-thread:bindtouchmove - main-thread:bindtouchcancel - feat: add SystemInfo.screenWidth and SystemInfo.screenHeight ([#641](#641)) - Updated dependencies \[[`c9ccad6`](c9ccad6), [`9ad394e`](9ad394e), [`f4cfb70`](f4cfb70), [`c9ccad6`](c9ccad6), [`839d61c`](839d61c)]: - @lynx-js/offscreen-document@0.0.2 - @lynx-js/web-mainthread-apis@0.13.1 - @lynx-js/web-worker-runtime@0.13.1 - @lynx-js/web-constants@0.13.1 - @lynx-js/web-worker-rpc@0.13.1 ## @lynx-js/web-elements@0.7.1 ### Patch Changes - fix(web): x-swiper-item threshold updated to 20 ([#639](#639)) - fix: In React19, setter and getter functions are treated as properties, making it impossible to retrieve the current value via attributes. ([#639](#639)) ## @lynx-js/web-explorer@0.0.7 ### Patch Changes - feat: use nativeModulesPath instead of nativeModulesMap to lynx-view. ([#668](#668)) - fix: fork @vant/touch-emulator and make it work with shadowroot ([#662](#662)) - fix: loading errors caused by script import order ([#665](#665)) - chore: update homepage ([#645](#645)) ## @lynx-js/web-mainthread-apis@0.13.1 ### Patch Changes - fix: some inline style properties cause crash ([#647](#647)) add support for the following css properties - mask - mask-repeat - mask-position - mask-clip - mask-origin - mask-size - gap - column-gap - row-gap - image-rendering - hyphens - offset-path - offset-distance - feat: support touch events for MTS ([#641](#641)) now we support - main-thread:bindtouchstart - main-thread:bindtouchend - main-thread:bindtouchmove - main-thread:bindtouchcancel - Updated dependencies \[[`c9ccad6`](c9ccad6)]: - @lynx-js/web-constants@0.13.1 ## @lynx-js/web-worker-runtime@0.13.1 ### Patch Changes - feat: support for using `lynx.queueMicrotask`. ([#702](#702)) - feat: support touch events for MTS ([#641](#641)) now we support - main-thread:bindtouchstart - main-thread:bindtouchend - main-thread:bindtouchmove - main-thread:bindtouchcancel - feat: provide comments for `@lynx-js/web-platform-rsbuild-plugin`. ([#668](#668)) - Updated dependencies \[[`c9ccad6`](c9ccad6), [`9ad394e`](9ad394e), [`c9ccad6`](c9ccad6)]: - @lynx-js/offscreen-document@0.0.2 - @lynx-js/web-mainthread-apis@0.13.1 - @lynx-js/web-constants@0.13.1 - @lynx-js/web-worker-rpc@0.13.1 ## @lynx-js/react-webpack-plugin@0.6.13 ### Patch Changes - feat: add `experimental_isLazyBundle` option, it will disable snapshot HMR for standalone lazy bundle ([#653](#653)) - Add the `profile` option to control whether `__PROFILE__` is enabled. ([#722](#722)) - Support `@lynx-js/react` v0.108.0. ([#649](#649)) ## @lynx-js/runtime-wrapper-webpack-plugin@0.0.10 ### Patch Changes - feat: add `experimental_isLazyBundle` option, it will disable lynxChunkEntries for standalone lazy bundle ([#653](#653)) ## create-rspeedy@0.9.4 ## @lynx-js/react-alias-rsbuild-plugin@0.9.9 ## upgrade-rspeedy@0.9.4 ## @lynx-js/web-worker-rpc@0.13.1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: bundle result of experimental_isLazyBundle: true on developmen…

c333eee

…t mode

upupming requested a review from colinaaa as a code owner April 28, 2025 13:17

upupming requested review from Yradex, gaoachao and hzy April 28, 2025 13:20

colinaaa previously approved these changes Apr 29, 2025

View reviewed changes

packages/rspeedy/plugin-react/src/entry.ts Show resolved Hide resolved

packages/rspeedy/plugin-react/src/entry.ts Outdated Show resolved Hide resolved

.changeset/short-crabs-lead.md Outdated Show resolved Hide resolved

feat: add config test and use prepend for entry

e6ae5b3

upupming dismissed colinaaa’s stale review via e6ae5b3 April 29, 2025 09:01

upupming changed the title ~~fix: bundle result of experimental_isLazyBundle: true on development mode~~ fix: resolve page crash on development mode when enabling experimental_isLazyBundle: true Apr 29, 2025

Merge branch 'main' into fix/isLazyBundle

8edddb3

upupming requested a review from colinaaa April 29, 2025 09:56

hzy approved these changes Apr 29, 2025

View reviewed changes

colinaaa approved these changes Apr 29, 2025

View reviewed changes

colinaaa added this pull request to the merge queue Apr 29, 2025

Merged via the queue into lynx-family:main with commit ea4da1a Apr 29, 2025
25 of 29 checks passed

github-actions bot mentioned this pull request Apr 29, 2025

chore: Release 2025-05-09 12:55:59 #644

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: resolve page crash on development mode when enabling `experimental_isLazyBundle: true` #653

fix: resolve page crash on development mode when enabling `experimental_isLazyBundle: true` #653

Uh oh!

upupming commented Apr 28, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Apr 28, 2025 •

edited

Loading

Uh oh!

codecov bot commented Apr 28, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Apr 28, 2025 •

edited

Loading

Uh oh!

colinaaa left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: resolve page crash on development mode when enabling experimental_isLazyBundle: true #653

fix: resolve page crash on development mode when enabling experimental_isLazyBundle: true #653

Uh oh!

Conversation

upupming commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

changeset-bot bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 1 Tests Failed:

Uh oh!

codspeed-hq bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #653 will not alter performance

Summary

Uh oh!

colinaaa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: resolve page crash on development mode when enabling `experimental_isLazyBundle: true` #653

fix: resolve page crash on development mode when enabling `experimental_isLazyBundle: true` #653

upupming commented Apr 28, 2025 •

edited

Loading

changeset-bot bot commented Apr 28, 2025 •

edited

Loading

codecov bot commented Apr 28, 2025 •

edited

Loading

codspeed-hq bot commented Apr 28, 2025 •

edited

Loading

codecov bot commented Apr 29, 2025 •

edited

Loading