ci: remove duplicated playwright test on deploy#646
ci: remove duplicated playwright test on deploy#646colinaaa merged 2 commits intolynx-family:mainfrom
Conversation
|
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
CodSpeed Performance ReportMerging #646 will not alter performanceComparing Summary
|
Signed-off-by: Qingyu Wang <40660121+colinaaa@users.noreply.github.com>
Bundle ReportChanges will increase total bundle size by 3.21kB (0.5%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @lynx-js/example-react-lynx-cjsAssets Changed:
|
## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> Fix a regression of #646. The event name should be `merge_group` instead of `merge_queue`. See: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#merge_group. Also fix an issue that `publish` and `build-all` share the same `concurrency.group`. <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required).
Summary
We are removing the
playwright-linuxtest from the deployment process, as it has already been executed in the merge queue.Note that we are using the
override_branchoption of thecodecov/test-results-actionto upload the test results. So that we could still know which tests are flaky.Checklist