Skip to content

ci: remove duplicated playwright test on deploy#646

Merged
colinaaa merged 2 commits intolynx-family:mainfrom
colinaaa:colin/0428/deploy
May 8, 2025
Merged

ci: remove duplicated playwright test on deploy#646
colinaaa merged 2 commits intolynx-family:mainfrom
colinaaa:colin/0428/deploy

Conversation

@colinaaa
Copy link
Collaborator

Summary

We are removing the playwright-linux test from the deployment process, as it has already been executed in the merge queue.

Note that we are using the override_branch option of the codecov/test-results-action to upload the test results. So that we could still know which tests are flaky.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2025

⚠️ No Changeset found

Latest commit: 149e48a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Apr 28, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2254 1 2253 97
View the top 1 failed test(s) by shortest run time
react.spec.ts reactlynx3 testselementsx-inputbasic-element-x-input-bindfocus
Stack Traces | 5.27s run time
react.spec.ts:2086:7 basic-element-x-input-bindfocus

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 28, 2025

CodSpeed Performance Report

Merging #646 will not alter performance

Comparing colinaaa:colin/0428/deploy (4569400) with main (c9ccad6)

Summary

✅ 1 untouched benchmarks

@colinaaa colinaaa marked this pull request as ready for review May 8, 2025 10:52
@colinaaa colinaaa requested a review from PupilTong May 8, 2025 10:52
Signed-off-by: Qingyu Wang <40660121+colinaaa@users.noreply.github.com>
@colinaaa colinaaa merged commit d34ff9d into lynx-family:main May 8, 2025
4 checks passed
@codecov
Copy link

codecov bot commented May 8, 2025

Bundle Report

Changes will increase total bundle size by 3.21kB (0.5%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@lynx-js/example-react-lynx-cjs 321.0kB 3.21kB (1.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @lynx-js/example-react-lynx-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
main.lynx.bundle 1.67kB 89.8kB 1.89%
.rspeedy/main/main-thread.js 728 bytes 40.78kB 1.82%
.rspeedy/main/background.*.js 810 bytes 39.86kB 2.07%

github-merge-queue bot pushed a commit that referenced this pull request May 13, 2025
## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

Fix a regression of #646. The event name should be `merge_group` instead
of `merge_queue`. See:
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#merge_group.

Also fix an issue that `publish` and `build-all` share the same
`concurrency.group`.

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

## Checklist

<!--- Check and mark with an "x" -->

- [ ] Tests updated (or not required).
- [ ] Documentation updated (or not required).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant