fix(testing-library): rollup dts files#615
Merged
upupming merged 6 commits intolynx-family:mainfrom Apr 24, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: c69032c The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
upupming
force-pushed
the
fix/dts-rollup
branch
from
431a4be to
725cb4a
Compare
colinaaa
reviewed
Apr 24, 2025
CodSpeed Performance ReportMerging #615 will not alter performanceComparing Summary
|
upupming
force-pushed
the
fix/dts-rollup
branch
2 times, most recently
from
d3a0424 to
e32b3b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
upupming
force-pushed
the
fix/dts-rollup
branch
from
e32b3b8 to
9055bad
Compare
colinaaa
previously approved these changes
Apr 24, 2025
colinaaa
approved these changes
Apr 24, 2025
colinaaa
added a commit
to colinaaa/lynx-stack
that referenced
this pull request
Apr 24, 2025
<!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> ## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> Fix the type issue of testing library, we should bundle the dts file since we have bundled `@lynx-js/test-environment` package. ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or **not required**). - [ ] Documentation updated (or **not required**). --------- Co-authored-by: Qingyu Wang <40660121+colinaaa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the type issue of testing library, we should bundle the dts file since we have bundled
@lynx-js/test-environmentpackage.Checklist