fix: create a new lynx-view for lynxjs.org#578
Conversation
|
| Name | Type |
|---|---|
| @lynx-js/web-explorer | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the lynx-view behavior on lynxjs.org by switching to a dynamic recreation of the lynx-view element when receiving a URL update via postMessage.
- Changed lynxView variable from const to let to allow reassignment.
- Updated the event listener to remove and recreate the lynx-view element with new inline style.
- Adjusted the changeset message accordingly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web-platform/web-explorer/index.ts | Updates the element handling to recreate lynx-view on URL updates. |
| .changeset/angry-buckets-chew.md | Updates the changeset note to reflect the new lynx-view behavior. |
Bundle ReportChanges will increase total bundle size by 67 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @lynx-js/web-explorer-web-array-pushAssets Changed:
|
CodSpeed Performance ReportMerging #578 will not alter performanceComparing Summary
|
No description provided.