Skip to content

fix: create a new lynx-view for lynxjs.org#578

Merged
PupilTong merged 1 commit intolynx-family:mainfrom
PupilTong:p/hw/fix-preview
Apr 17, 2025
Merged

fix: create a new lynx-view for lynxjs.org#578
PupilTong merged 1 commit intolynx-family:mainfrom
PupilTong:p/hw/fix-preview

Conversation

@PupilTong
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2025

⚠️ No Changeset found

Latest commit: 02a4cb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@lynx-js/web-explorer Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the lynx-view behavior on lynxjs.org by switching to a dynamic recreation of the lynx-view element when receiving a URL update via postMessage.

  • Changed lynxView variable from const to let to allow reassignment.
  • Updated the event listener to remove and recreate the lynx-view element with new inline style.
  • Adjusted the changeset message accordingly.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/web-platform/web-explorer/index.ts Updates the element handling to recreate lynx-view on URL updates.
.changeset/angry-buckets-chew.md Updates the changeset note to reflect the new lynx-view behavior.

@codecov
Copy link

codecov bot commented Apr 17, 2025

Bundle Report

Changes will increase total bundle size by 67 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@lynx-js/web-explorer-web-array-push 315.28kB 67 bytes (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @lynx-js/web-explorer-web-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/js/index.js 67 bytes 148.41kB 0.05%

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 17, 2025

CodSpeed Performance Report

Merging #578 will not alter performance

Comparing PupilTong:p/hw/fix-preview (02a4cb5) with main (07dc5e3)

Summary

✅ 1 untouched benchmarks

@PupilTong PupilTong added this pull request to the merge queue Apr 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2025
@PupilTong PupilTong added this pull request to the merge queue Apr 17, 2025
Merged via the queue into lynx-family:main with commit 66ff012 Apr 17, 2025
26 checks passed
@PupilTong PupilTong deleted the p/hw/fix-preview branch April 17, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants