-
Notifications
You must be signed in to change notification settings - Fork 120
ci: add PR id and merge-base to restore-keys #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #552 will not alter performanceComparing Summary
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/workflow-build.yml:74
- [nitpick] The condition 'if: runner.debug == '1'' may be non-standard; please verify that 'runner.debug' is reliably set for debug runs, or consider using a documented flag to control this step.
- name: Upload turbo summary
Co-authored-by: Copilot <[email protected]> Signed-off-by: Qingyu Wang <[email protected]>
Summary
Following up #549. We use the PR id and merge-base to select the sha to restore cache.
This would ensure getting the best cache even if lynx-infra/cache does not return the last modified cache.
See: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request
Also see: https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request
Checklist