Skip to content

Conversation

@colinaaa
Copy link
Collaborator

@colinaaa colinaaa commented Apr 15, 2025

Summary

Following up #549. We use the PR id and merge-base to select the sha to restore cache.

This would ensure getting the best cache even if lynx-infra/cache does not return the last modified cache.

See: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request

Also see: https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 15, 2025

CodSpeed Performance Report

Merging #552 will not alter performance

Comparing colinaaa:colin/0415/cache-1 (b211249) with main (632bddd)

Summary

✅ 1 untouched benchmarks

@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2025

⚠️ No Changeset found

Latest commit: b211249

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@colinaaa colinaaa changed the title ci: add merge-base to restore-keys ci: add PR id and merge-base to restore-keys Apr 15, 2025
@colinaaa colinaaa requested a review from PupilTong April 16, 2025 02:20
@colinaaa colinaaa marked this pull request as ready for review April 16, 2025 02:20
@colinaaa colinaaa requested a review from coolkiid April 16, 2025 02:20
coolkiid
coolkiid previously approved these changes Apr 16, 2025
coolkiid
coolkiid previously approved these changes Apr 16, 2025
@PupilTong PupilTong requested a review from Copilot April 16, 2025 06:37
PupilTong
PupilTong previously approved these changes Apr 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/workflow-build.yml:74

  • [nitpick] The condition 'if: runner.debug == '1'' may be non-standard; please verify that 'runner.debug' is reliably set for debug runs, or consider using a documented flag to control this step.
- name: Upload turbo summary

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Qingyu Wang <[email protected]>
@colinaaa colinaaa dismissed stale reviews from PupilTong and coolkiid via 1fa3709 April 16, 2025 06:45
PupilTong
PupilTong previously approved these changes Apr 16, 2025
@colinaaa colinaaa added this pull request to the merge queue Apr 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2025
PupilTong
PupilTong previously approved these changes Apr 16, 2025
@colinaaa colinaaa added this pull request to the merge queue Apr 16, 2025
@colinaaa colinaaa removed this pull request from the merge queue due to a manual request Apr 16, 2025
@colinaaa colinaaa added this pull request to the merge queue Apr 16, 2025
Merged via the queue into lynx-family:main with commit a8bf91f Apr 16, 2025
25 checks passed
@colinaaa colinaaa deleted the colin/0415/cache-1 branch April 16, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants