fix: the input event of x-input with number type should have raw value#517
Merged
PupilTong merged 3 commits intolynx-family:mainfrom Apr 11, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: d8972b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- packages/web-platform/web-tests/tests/web-elements/x-input/event-input-number-dot.html: Language not supported
Comments suppressed due to low confidence (1)
packages/web-platform/web-elements/src/XInput/XInputEvents.ts:47
- Replacing an addEventListener call with removeEventListener in the else branch appears unintended. Please verify that the removal of the 'input' event listener is correct as per your design.
input.removeEventListener(
Bundle ReportChanges will decrease total bundle size by 36 bytes (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @lynx-js/web-explorer-web-array-pushAssets Changed:
|
CodSpeed Performance ReportMerging #517 will not alter performanceComparing Summary
|
PupilTong
force-pushed
the
p/hw/input-raw-value
branch
from
dc077e5 to
26db559
Compare
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
packages/web-platform/web-elements/src/XInput/InputBaseAttributes.ts
Outdated
Show resolved
Hide resolved
We use the "text" type for number input to get the raw value of input
…tes.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: PupilTong <12288479+PupilTong@users.noreply.github.com>
PupilTong
force-pushed
the
p/hw/input-raw-value
branch
from
a701715 to
d8972b1
Compare
colinaaa
approved these changes
Apr 11, 2025
colinaaa
pushed a commit
that referenced
this pull request
Apr 11, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/web-core@0.11.0 ### Minor Changes - feat: upgrade @lynx-js/lynx-core to 0.1.2 ([#465](#465)) refactor some internal logic - \_\_OnLifeCycleEvent - \_\_OnNativeAppReady ### Patch Changes - feat: support mts event handler (1/n) ([#495](#495)) now the main-thread:bind handler could be invoked. The params of the handler will be implemented later. - feat: allow multi lynx-view to share bts worker ([#520](#520)) Now we allow users to enable so-called "shared-context" feature on the Web Platform. Similar to the same feature for Lynx iOS/Android, this feature let multi lynx cards to share one js context. The `lynx.getSharedData` and `lynx.setSharedData` are also supported in this commit. To enable this feature, set property `lynxGroupId` or attribute `lynx-group-id` before a lynx-view starts rendering. Those card with same context id will share one web worker for the bts scripts. - perf: dispatchLynxViewEventEndpoint is a void call ([#506](#506)) - Updated dependencies \[[`ea42e62`](ea42e62), [`a0f5ca4`](a0f5ca4)]: - @lynx-js/web-worker-runtime@0.11.0 - @lynx-js/web-constants@0.11.0 - @lynx-js/web-worker-rpc@0.11.0 ## @lynx-js/react@0.106.4 ### Patch Changes - Disable MTS HMR functionality temporarily to address stability issues. This is a temporary fix while we work on a more robust solution. ([#512](#512)) ## @lynx-js/rspeedy@0.9.1 ### Patch Changes - Bump Rsbuild v1.3.5 with Rspack v1.3.3. ([#467](#467)) ## @lynx-js/react-rsbuild-plugin@0.9.6 ### Patch Changes - Updated dependencies \[[`ea42e62`](ea42e62), [`12e3afe`](12e3afe)]: - @lynx-js/web-webpack-plugin@0.6.4 - @lynx-js/template-webpack-plugin@0.6.9 - @lynx-js/react-alias-rsbuild-plugin@0.9.6 - @lynx-js/react-refresh-webpack-plugin@0.3.2 - @lynx-js/react-webpack-plugin@0.6.10 - @lynx-js/css-extract-webpack-plugin@0.5.3 ## @lynx-js/web-constants@0.11.0 ### Patch Changes - feat: support mts event handler (1/n) ([#495](#495)) now the main-thread:bind handler could be invoked. The params of the handler will be implemented later. - feat: allow multi lynx-view to share bts worker ([#520](#520)) Now we allow users to enable so-called "shared-context" feature on the Web Platform. Similar to the same feature for Lynx iOS/Android, this feature let multi lynx cards to share one js context. The `lynx.getSharedData` and `lynx.setSharedData` are also supported in this commit. To enable this feature, set property `lynxGroupId` or attribute `lynx-group-id` before a lynx-view starts rendering. Those card with same context id will share one web worker for the bts scripts. - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.11.0 ## @lynx-js/web-elements@0.5.4 ### Patch Changes - chore: bump the output target to es2024 ([#518](#518)) - fix: the `\n` character should create a new line ([#522](#522)) add `white-space-collapse: preserve-breaks` to raw-text - fix: the `input` event of x-input with number type should have raw value ([#517](#517)) For `type:=number` x-input with typed value "2." Before this commit: the value is "2" After this commit the value is "2." ## @lynx-js/web-explorer@0.0.4 ### Patch Changes - feat: add a touch emulator that allows the explorer to respond to touch events triggered by mouse events ([#516](#516)) ## @lynx-js/web-mainthread-apis@0.11.0 ### Patch Changes - feat: support mts event handler (1/n) ([#495](#495)) now the main-thread:bind handler could be invoked. The params of the handler will be implemented later. - Updated dependencies \[[`ea42e62`](ea42e62), [`a0f5ca4`](a0f5ca4)]: - @lynx-js/web-constants@0.11.0 ## @lynx-js/web-worker-runtime@0.11.0 ### Patch Changes - feat: support mts event handler (1/n) ([#495](#495)) now the main-thread:bind handler could be invoked. The params of the handler will be implemented later. - feat: allow multi lynx-view to share bts worker ([#520](#520)) Now we allow users to enable so-called "shared-context" feature on the Web Platform. Similar to the same feature for Lynx iOS/Android, this feature let multi lynx cards to share one js context. The `lynx.getSharedData` and `lynx.setSharedData` are also supported in this commit. To enable this feature, set property `lynxGroupId` or attribute `lynx-group-id` before a lynx-view starts rendering. Those card with same context id will share one web worker for the bts scripts. - Updated dependencies \[[`ea42e62`](ea42e62), [`a0f5ca4`](a0f5ca4)]: - @lynx-js/web-mainthread-apis@0.11.0 - @lynx-js/web-constants@0.11.0 - @lynx-js/web-worker-rpc@0.11.0 ## @lynx-js/template-webpack-plugin@0.6.9 ### Patch Changes - Fix incorrect hash of `background.[contenthash].js` in `.lynx.bundle` files. ([#498](#498)) ## @lynx-js/web-webpack-plugin@0.6.4 ### Patch Changes - feat: support mts event handler (1/n) ([#495](#495)) now the main-thread:bind handler could be invoked. The params of the handler will be implemented later. ## create-rspeedy@0.9.1 ## @lynx-js/react-alias-rsbuild-plugin@0.9.6 ## upgrade-rspeedy@0.9.1 ## @lynx-js/web-worker-rpc@0.11.0 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the "text" type for number input to get the raw value of input