fix(genui-cli): export dist files#2802
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b9d0a4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📝 WalkthroughWalkthroughAdds CLI artifacts to package publishing and Turbo build caching, updates CLI docs and rstest config, removes workspace devDeps from the nested CLI manifest, and refactors the A2UI create flow to resolve workspace dependency versions from multiple loaded manifests. ChangesGenUI CLI integration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
commit: |
gaoachao
previously approved these changes
Jun 5, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
UI JudgeGEQI weighted score: 61.3 / 100 across 8 examples.
DetailsResult 1
Result 2
Result 3
Result 4
Result 5
Result 6
Result 7
Result 8
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/genui/cli/src/a2ui/create.ts (1)
143-149:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winHandle all
workspace:forms during dependency rewriteOnly
workspace:*is currently replaced. If a template usesworkspace:^/workspace:~, the specifier is left behind and can leak into generatedpackage.json.Suggested fix
- if (deps[name] === 'workspace:*') { + if (deps[name]?.startsWith('workspace:')) { const resolved = versionMap[name] ?? resolvePackageVersion(name, requireFn); if (resolved) { deps[name] = resolved; } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/genui/cli/src/a2ui/create.ts` around lines 143 - 149, The current check only matches the exact string 'workspace:*' and misses other workspace specifiers like 'workspace:^' or 'workspace:~', so change the condition to detect any workspace: prefix (e.g., use deps[name]?.startsWith('workspace:')) in the dependency rewrite block where deps[name] is checked, then resolve the version the same way (using versionMap[name] ?? resolvePackageVersion(name, requireFn)) and replace deps[name] with the resolved version; references: deps[name], versionMap, resolvePackageVersion, requireFn.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/genui/package.json`:
- Around line 116-119: Update the three new devDependency entries that use the
workspace:^ protocol to use workspace:* for consistency with the existing
manifest; specifically change the package specifiers for
"`@lynx-js/qrcode-rsbuild-plugin`", "`@lynx-js/react`", and
"`@lynx-js/react-rsbuild-plugin`" (and "`@lynx-js/rspeedy`") from "workspace:^" to
"workspace:*" in package.json so they match the other workspace dependencies.
---
Outside diff comments:
In `@packages/genui/cli/src/a2ui/create.ts`:
- Around line 143-149: The current check only matches the exact string
'workspace:*' and misses other workspace specifiers like 'workspace:^' or
'workspace:~', so change the condition to detect any workspace: prefix (e.g.,
use deps[name]?.startsWith('workspace:')) in the dependency rewrite block where
deps[name] is checked, then resolve the version the same way (using
versionMap[name] ?? resolvePackageVersion(name, requireFn)) and replace
deps[name] with the resolved version; references: deps[name], versionMap,
resolvePackageVersion, requireFn.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 61bc6ddc-22ee-4f91-8610-6552cfd23b57
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
.changeset/fruity-months-add.md.github/genui-cli.instructions.mdpackages/genui/cli/README.mdpackages/genui/cli/package.jsonpackages/genui/cli/src/a2ui/create.tspackages/genui/package.jsonpackages/genui/turbo.jsonrstest.config.ts
💤 Files with no reviewable changes (1)
- packages/genui/cli/package.json
✅ Files skipped from review due to trivial changes (4)
- rstest.config.ts
- packages/genui/cli/README.md
- .github/genui-cli.instructions.md
- .changeset/fruity-months-add.md
gaoachao
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Documentation
New Features
Checklist