fix: export catalog jsx components#2734
Merged
Merged
Conversation
HuJean
requested review from
PupilTong,
Sherry-hue,
fzx2666-fz and
gaoachao
as code owners
🦋 Changeset detectedLatest commit: 857aa37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📝 WalkthroughWalkthroughThis PR refactors the GenUI A2UI package to properly export JSX components using explicit ChangesCatalog JSX Component Export Refactor
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/genui/a2ui/src/react/A2UI.tsx (1)
16-18: ⚡ Quick winAlign
A2UIRenderertype import extension with the.jsxrefactor.
A2UI.tsxnow importsA2UIRenderer/UnsupportedInfofrom./A2UIRenderer.jsx, but the type annotation still usesimport('./A2UIRenderer.js').A2UIRendererProps(around line 261). Keep the specifier consistent (e.g., switch to./A2UIRenderer.jsx) to avoid resolution/drift issues.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/genui/a2ui/src/react/A2UI.tsx` around lines 16 - 18, Update the type import specifier to match the refactorded JSX module: change any type reference using import('./A2UIRenderer.js').A2UIRendererProps to import('./A2UIRenderer.jsx').A2UIRendererProps so it aligns with the runtime imports of A2UIRenderer and UnsupportedInfo in A2UI.tsx; search for symbols A2UIRenderer, UnsupportedInfo, and A2UIRendererProps in the file and update the import specifier accordingly to avoid resolution drift.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/genui/a2ui/src/react/A2UI.tsx`:
- Around line 16-18: Update the type import specifier to match the refactorded
JSX module: change any type reference using
import('./A2UIRenderer.js').A2UIRendererProps to
import('./A2UIRenderer.jsx').A2UIRendererProps so it aligns with the runtime
imports of A2UIRenderer and UnsupportedInfo in A2UI.tsx; search for symbols
A2UIRenderer, UnsupportedInfo, and A2UIRendererProps in the file and update the
import specifier accordingly to avoid resolution drift.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: afcd8d7a-0cf4-427a-adb2-055688498d0d
📒 Files selected for processing (13)
.changeset/sad-knives-return.mdpackages/genui/a2ui/src/catalog/Button/index.tsxpackages/genui/a2ui/src/catalog/Card/index.tsxpackages/genui/a2ui/src/catalog/Column/index.tsxpackages/genui/a2ui/src/catalog/List/index.tsxpackages/genui/a2ui/src/catalog/Modal/index.tsxpackages/genui/a2ui/src/catalog/Row/index.tsxpackages/genui/a2ui/src/catalog/Tabs/index.tsxpackages/genui/a2ui/src/catalog/index.tspackages/genui/a2ui/src/react/A2UI.tsxpackages/genui/a2ui/src/react/index.tspackages/genui/a2ui/src/react/useA2UIContext.tspackages/genui/a2ui/tsconfig.build.json
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gaoachao
approved these changes
May 28, 2026
Merging this PR will improve performance by 5.06%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | 002-hello-reactLynx-destroyBackground |
943.9 µs | 898.4 µs | +5.06% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing p/fix-catalog (857aa37) with main (f38e285)2
Footnotes
-
26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(ec73c30) during the generation of this report, so f38e285 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Contributor
UI JudgeGEQI weighted score: 61 / 100 across 8 examples.
DetailsResult 1
Result 2
Result 3
Result 4
Result 5
Result 6
Result 7
Result 8
|
Sherry-hue
approved these changes
May 28, 2026
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Checklist