fix: a2ui agent catalog handoff#2730
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR establishes a playground-specific A2UI catalog, wires it through playground agent requests, and updates server-side caching to use the full catalog content rather than just the catalog id to ensure consistent agent behavior across catalog updates. ChangesA2UI Catalog Propagation and Server Caching
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
20b5a9f to
62427e4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will not alter performance
Comparing Footnotes
|
UI JudgeGEQI weighted score: 60.9 / 100 across 8 examples.
DetailsResult 1
Result 2
Result 3
Result 4
Result 5
Result 6
Result 7
Result 8
|
Summary
Root Cause
The playground preview rendered with its own built-in catalog, but requests to the A2UI server omitted catalog data. The server therefore fell back to
BASIC_CATALOG, which could miss components such asPieChartand function definitions, causing the agent prompt and validation rules to drift from the renderer.Validation
CI=1 pnpm dprint fmt .github/a2ui-catalog.instructions.md .github/a2ui-server.instructions.md packages/genui/a2ui-playground/src/catalog/a2uiAgentCatalog.ts packages/genui/a2ui-playground/src/pages/AIChatPage.tsx packages/genui/server/app/a2ui/_shared.ts packages/genui/server/service/a2ui-agent.tsCI=1 pnpm exec tsc -p tsconfig.json --noEmitinpackages/genui/serverCI=1 pnpm turbo build --filter a2ui-playgroundSummary by CodeRabbit
New Features
Documentation
Improvements