Skip to content

fix: fix modal overlay positioning#2724

Merged
MoonfaceX merged 2 commits into
lynx-family:mainfrom
MoonfaceX:codex/fix-modal-view-inset
May 27, 2026
Merged

fix: fix modal overlay positioning#2724
MoonfaceX merged 2 commits into
lynx-family:mainfrom
MoonfaceX:codex/fix-modal-view-inset

Conversation

@MoonfaceX
Copy link
Copy Markdown
Collaborator

@MoonfaceX MoonfaceX commented May 27, 2026

Summary

  • add inset: 0 to the A2UI Modal dialog view so the overlay fills its containing viewport

Validation

  • pre-commit staged-file hooks: eslint, biome lint, dprint

Summary by CodeRabbit

  • Style
    • Modal dialogs now use full-edge positioning so they align consistently with their containers. This improves layout stability, overlay coverage, and visual consistency across screen sizes and nested contexts, reducing placement issues and unexpected gaps while keeping existing modal behavior otherwise unchanged.

Review Change Stack

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 27, 2026

⚠️ No Changeset found

Latest commit: 73b0ef0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0a50016c-c5bb-448b-b4ec-8b260b15f6ba

📥 Commits

Reviewing files that changed from the base of the PR and between 0c969eb and 47ab794.

📒 Files selected for processing (1)
  • packages/genui/a2ui/styles/catalog/Modal.css
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/genui/a2ui/styles/catalog/Modal.css

📝 Walkthrough

Walkthrough

This PR adds the inset: 0; CSS property to the .modal-view class in packages/genui/a2ui/styles/catalog/Modal.css, constraining the modal to all edges of its positioned ancestor.

Changes

Modal Positioning Update

Layer / File(s) Summary
Modal inset positioning
packages/genui/a2ui/styles/catalog/Modal.css
Added inset: 0; property to .modal-view CSS rule to establish modal positioning constraints.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A window that floated, unsure where to go,
I nudged it with pixels, set margins to zero.
Now snug in its corner, all edges held tight,
A tiny CSS hop makes placement just right. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: fix modal overlay positioning' directly describes the main change: adding inset positioning to fix how the modal overlay is positioned relative to its containing viewport.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MoonfaceX MoonfaceX marked this pull request as ready for review May 27, 2026 06:23
@MoonfaceX MoonfaceX changed the title [codex] fix modal overlay positioning fix: fix modal overlay positioning May 27, 2026
@MoonfaceX MoonfaceX enabled auto-merge (squash) May 27, 2026 06:23
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 27, 2026

Merging this PR will not alter performance

✅ 81 untouched benchmarks
⏩ 26 skipped benchmarks1


Comparing MoonfaceX:codex/fix-modal-view-inset (73b0ef0) with main (5d9e194)

Open in CodSpeed

Footnotes

  1. 26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@MoonfaceX MoonfaceX merged commit 0578c8d into lynx-family:main May 27, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants