Skip to content

feat(a2ui): convert icon to tff for lynx#2711

Merged
HuJean merged 1 commit into
mainfrom
p/a2ui-font
May 26, 2026
Merged

feat(a2ui): convert icon to tff for lynx#2711
HuJean merged 1 commit into
mainfrom
p/a2ui-font

Conversation

@HuJean
Copy link
Copy Markdown
Collaborator

@HuJean HuJean commented May 25, 2026

Summary by CodeRabbit

Style

  • Refined typography with adjusted font sizes across heading, body, caption, link, and label text styles.
  • Enhanced icon spacing.
  • Updated send button icon.
  • Adjusted time field presentation level.

Review Change Stack

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 25, 2026

⚠️ No Changeset found

Latest commit: c111d02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR updates the typography system by reducing font sizes across heading, body, caption, label, and link text classes in Text.css, adjusts icon letter-spacing, updates dependent gallery and chat UI component styling configurations, and adds a formatter exclude entry.

Changes

Typography System Refactoring

Layer / File(s) Summary
Text CSS styling updates
packages/genui/a2ui/styles/catalog/Text.css, packages/genui/a2ui/styles/catalog/Icon.css
Heading variants (.text-h1.text-h5) are reduced from 28px/22px/18px/15px/13px to 24px/20px/16px/14px/12px; .text-h1 line-height increases to 1.2. Body, caption, label, and link are scaled down 1px. Price explicitly sets font-size: 15px. Icon letter-spacing changes from normal to 1px.
Gallery and chat UI adjustments
packages/genui/a2ui-playground/src/mock/a2ui-gallery/flight-status.json, packages/genui/a2ui-playground/src/pages/AIChatPage.tsx
Flight gallery departure and arrival time Text components change variant from "h3" to "h4". Chat Send button icon glyph changes from -> to .
Formatter exclude update
biome.jsonc
Adds packages/genui/a2ui/style/theme.css to the Biome linter ignore list.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops through typography's tale,
With heading sizes trimmed without fail,
Icons now spaced with precision and care,
Send buttons point up-left, floating through air! ↖✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions converting icons to TTF format, but the actual changes involve typography scaling adjustments, icon letter-spacing updates, flight status component variant changes, and a send button icon change—none of which involve TTF font conversion. Update the PR title to accurately reflect the main changes, such as 'refactor(a2ui): adjust typography scales and icon spacing' or similar, to match the actual modifications in the changeset.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch p/a2ui-font

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/genui/a2ui-playground/src/pages/AIChatPage.tsx`:
- Line 1505: The send button currently renders a NORTH WEST ARROW character
inside the span with className 'chatSendIcon' (in AIChatPage component) which is
semantically wrong for a "send" action; replace the character with a more
appropriate arrow such as ↗ (UP RIGHT ARROW) or → (RIGHTWARDS ARROW) and update
the accessibility metadata (remove or change aria-hidden to provide an
appropriate aria-label or title for the button) so screen readers convey "Send"
correctly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bc810df5-9830-44f2-a02e-c8820800e14e

📥 Commits

Reviewing files that changed from the base of the PR and between ab3c742 and 28e505e.

📒 Files selected for processing (5)
  • packages/genui/a2ui-playground/lynx-src/a2ui/index.css
  • packages/genui/a2ui-playground/src/mock/a2ui-gallery/flight-status.json
  • packages/genui/a2ui-playground/src/pages/AIChatPage.tsx
  • packages/genui/a2ui/styles/catalog/Text.css
  • packages/genui/a2ui/styles/theme.css

Comment thread packages/genui/a2ui-playground/src/pages/AIChatPage.tsx
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2026

UI Judge

GEQI weighted score: 62.4 / 100 across 8 examples.
Average visual-correctness score: 3.3 / 5.

Dimension Weight Average Results Status
Usability & Interaction 30% 3.1 / 5 8 OK
Visual & Aesthetics 25% 3.3 / 5 8 OK
Consistency & Standards 15% 3.3 / 5 8 OK
Architecture & UX Writing 15% 2.9 / 5 8 OK
Accessibility & Performance 15% 3 / 5 8 OK
# Example Visual Correctness Usability & Interaction (30%) Visual & Aesthetics (25%) Consistency & Standards (15%) Architecture & UX Writing (15%) Accessibility & Performance (15%) GEQI Page Status
1 recs 2 / 5 2 / 5 3 / 5 2 / 5 2 / 5 2 / 5 45 / 100 preview OK
2 cast-grid 5 / 5 5 / 5 4 / 5 5 / 5 4 / 5 4 / 5 89 / 100 preview OK
3 citywalk-list 2 / 5 2 / 5 3 / 5 2 / 5 1 / 5 1 / 5 39 / 100 preview OK
4 fridge-search 3 / 5 3 / 5 4 / 5 4 / 5 3 / 5 4 / 5 71 / 100 preview OK
5 trip-planner 2 / 5 3 / 5 2 / 5 2 / 5 2 / 5 2 / 5 46 / 100 preview OK
6 weather-current 5 / 5 4 / 5 4 / 5 5 / 5 5 / 5 5 / 5 89 / 100 preview OK
7 product-card 5 / 5 4 / 5 4 / 5 4 / 5 4 / 5 4 / 5 80 / 100 preview OK
8 workout-plan 2 / 5 2 / 5 2 / 5 2 / 5 2 / 5 2 / 5 40 / 100 preview OK
Details

Result 1

  • Example: recs
  • Dimension: visual-correctness
  • Visual correctness: 2 / 5
  • GEQI dimensions:
    • Usability & Interaction: 2 / 5 (30%)
    • Visual & Aesthetics: 3 / 5 (25%)
    • Consistency & Standards: 2 / 5 (15%)
    • Architecture & UX Writing: 2 / 5 (15%)
    • Accessibility & Performance: 2 / 5 (15%)
  • Task: The A2UI playground preview should show date-night dining recommendations for Moonlight Terrace, Pinewood Bistro, and Sea Breeze Kitchen.

Result 2

  • Example: cast-grid
  • Dimension: visual-correctness
  • Visual correctness: 5 / 5
  • GEQI dimensions:
    • Usability & Interaction: 5 / 5 (30%)
    • Visual & Aesthetics: 4 / 5 (25%)
    • Consistency & Standards: 5 / 5 (15%)
    • Architecture & UX Writing: 4 / 5 (15%)
    • Accessibility & Performance: 4 / 5 (15%)
  • Task: The A2UI playground preview should show a cast grid for the short film Night Notes, including Lin Xia and Zhou Ning cast cards.

Result 3

  • Example: citywalk-list
  • Dimension: visual-correctness
  • Visual correctness: 2 / 5
  • GEQI dimensions:
    • Usability & Interaction: 2 / 5 (30%)
    • Visual & Aesthetics: 3 / 5 (25%)
    • Consistency & Standards: 2 / 5 (15%)
    • Architecture & UX Writing: 1 / 5 (15%)
    • Accessibility & Performance: 1 / 5 (15%)
  • Task: The A2UI playground preview should show weekend citywalk coffee picks with Rooftop Brew Room, Corner Canvas Lab, and Late Sun Roastery.

Result 4

  • Example: fridge-search
  • Dimension: visual-correctness
  • Visual correctness: 3 / 5
  • GEQI dimensions:
    • Usability & Interaction: 3 / 5 (30%)
    • Visual & Aesthetics: 4 / 5 (25%)
    • Consistency & Standards: 4 / 5 (15%)
    • Architecture & UX Writing: 3 / 5 (15%)
    • Accessibility & Performance: 4 / 5 (15%)
  • Task: The A2UI playground preview should show refrigerator search results with Siemens, Hualing, Haier, and Midea product cards.

Result 5

  • Example: trip-planner
  • Dimension: visual-correctness
  • Visual correctness: 2 / 5
  • GEQI dimensions:
    • Usability & Interaction: 3 / 5 (30%)
    • Visual & Aesthetics: 2 / 5 (25%)
    • Consistency & Standards: 2 / 5 (15%)
    • Architecture & UX Writing: 2 / 5 (15%)
    • Accessibility & Performance: 2 / 5 (15%)
  • Task: The A2UI playground preview should show a Kyoto 48-hour trip planner with Day 1 and Day 2 itinerary sections, including Monkey Park Viewpoint.

Result 6

  • Example: weather-current
  • Dimension: visual-correctness
  • Visual correctness: 5 / 5
  • GEQI dimensions:
    • Usability & Interaction: 4 / 5 (30%)
    • Visual & Aesthetics: 4 / 5 (25%)
    • Consistency & Standards: 5 / 5 (15%)
    • Architecture & UX Writing: 5 / 5 (15%)
    • Accessibility & Performance: 5 / 5 (15%)
  • Task: The A2UI playground preview should show the current weather for Austin, TX, including clear skies with light breeze.

Result 7

  • Example: product-card
  • Dimension: visual-correctness
  • Visual correctness: 5 / 5
  • GEQI dimensions:
    • Usability & Interaction: 4 / 5 (30%)
    • Visual & Aesthetics: 4 / 5 (25%)
    • Consistency & Standards: 4 / 5 (15%)
    • Architecture & UX Writing: 4 / 5 (15%)
    • Accessibility & Performance: 4 / 5 (15%)
  • Task: The A2UI playground preview should show a Wireless Headphones Pro product card with a visible Add to Cart action.

Result 8

  • Example: workout-plan
  • Dimension: visual-correctness
  • Visual correctness: 2 / 5
  • GEQI dimensions:
    • Usability & Interaction: 2 / 5 (30%)
    • Visual & Aesthetics: 2 / 5 (25%)
    • Consistency & Standards: 2 / 5 (15%)
    • Architecture & UX Writing: 2 / 5 (15%)
    • Accessibility & Performance: 2 / 5 (15%)
  • Task: The A2UI playground preview should show a weekly workout plan with five days from Monday Ramp-Up through Friday Conditioning.

Workflow run

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 25, 2026

Merging this PR will not alter performance

✅ 81 untouched benchmarks
⏩ 26 skipped benchmarks1


Comparing p/a2ui-font (c111d02) with main (1eb420d)

Open in CodSpeed

Footnotes

  1. 26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci Bot commented May 25, 2026

React Example with Element Template

#930 Bundle Size — 204.36KiB (0%).

c111d02(current) vs 1eb420d main#928(baseline)

Bundle metrics  no changes
                 Current
#930
     Baseline
#928
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 124 124
No change  Duplicate Modules 50 50
No change  Duplicate Code 45.19% 45.19%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#930
     Baseline
#928
No change  IMG 145.76KiB 145.76KiB
No change  Other 58.61KiB 58.61KiB

Bundle analysis reportBranch p/a2ui-fontProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci Bot commented May 25, 2026

React MTF Example

#1795 Bundle Size — 208.94KiB (0%).

c111d02(current) vs 1eb420d main#1793(baseline)

Bundle metrics  no changes
                 Current
#1795
     Baseline
#1793
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 3 3
No change  Modules 199 199
No change  Duplicate Modules 78 78
No change  Duplicate Code 44.08% 44.08%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#1795
     Baseline
#1793
No change  IMG 111.23KiB 111.23KiB
No change  Other 97.71KiB 97.71KiB

Bundle analysis reportBranch p/a2ui-fontProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci Bot commented May 25, 2026

React External

#1777 Bundle Size — 699.5KiB (0%).

c111d02(current) vs 1eb420d main#1775(baseline)

Bundle metrics  no changes
                 Current
#1777
     Baseline
#1775
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
Change  Cache Invalidation 0% 41.1%
No change  Chunks 0 0
No change  Assets 3 3
No change  Modules 17 17
No change  Duplicate Modules 5 5
No change  Duplicate Code 7.13% 7.13%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#1777
     Baseline
#1775
No change  Other 699.5KiB 699.5KiB

Bundle analysis reportBranch p/a2ui-fontProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci Bot commented May 25, 2026

React Example

#8661 Bundle Size — 238KiB (0%).

c111d02(current) vs 1eb420d main#8659(baseline)

Bundle metrics  no changes
                 Current
#8661
     Baseline
#8659
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 204 204
No change  Duplicate Modules 81 81
No change  Duplicate Code 44.59% 44.59%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#8661
     Baseline
#8659
No change  IMG 145.76KiB 145.76KiB
No change  Other 92.24KiB 92.24KiB

Bundle analysis reportBranch p/a2ui-fontProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci Bot commented May 25, 2026

Web Explorer

#10238 Bundle Size — 903.53KiB (0%).

c111d02(current) vs 1eb420d main#10236(baseline)

Bundle metrics  no changes
                 Current
#10238
     Baseline
#10236
No change  Initial JS 45.06KiB 45.06KiB
No change  Initial CSS 2.22KiB 2.22KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 9 9
No change  Assets 11 11
No change  Modules 230 230
No change  Duplicate Modules 11 11
No change  Duplicate Code 27.13% 27.13%
No change  Packages 10 10
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#10238
     Baseline
#10236
No change  JS 499.15KiB 499.15KiB
No change  Other 402.16KiB 402.16KiB
No change  CSS 2.22KiB 2.22KiB

Bundle analysis reportBranch p/a2ui-fontProject dashboard


Generated by RelativeCIDocumentationReport issue

@HuJean HuJean force-pushed the p/a2ui-font branch 3 times, most recently from 2c9b43f to 8e43c0c Compare May 25, 2026 16:07
@HuJean HuJean enabled auto-merge (squash) May 25, 2026 16:07
@HuJean HuJean merged commit 0d8a8b1 into main May 26, 2026
85 of 88 checks passed
@HuJean HuJean deleted the p/a2ui-font branch May 26, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants