feat(a2ui): convert icon to tff for lynx#2711
Conversation
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR updates the typography system by reducing font sizes across heading, body, caption, label, and link text classes in ChangesTypography System Refactoring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/genui/a2ui-playground/src/pages/AIChatPage.tsx`:
- Line 1505: The send button currently renders a NORTH WEST ARROW character
inside the span with className 'chatSendIcon' (in AIChatPage component) which is
semantically wrong for a "send" action; replace the character with a more
appropriate arrow such as ↗ (UP RIGHT ARROW) or → (RIGHTWARDS ARROW) and update
the accessibility metadata (remove or change aria-hidden to provide an
appropriate aria-label or title for the button) so screen readers convey "Send"
correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bc810df5-9830-44f2-a02e-c8820800e14e
📒 Files selected for processing (5)
packages/genui/a2ui-playground/lynx-src/a2ui/index.csspackages/genui/a2ui-playground/src/mock/a2ui-gallery/flight-status.jsonpackages/genui/a2ui-playground/src/pages/AIChatPage.tsxpackages/genui/a2ui/styles/catalog/Text.csspackages/genui/a2ui/styles/theme.css
UI JudgeGEQI weighted score: 62.4 / 100 across 8 examples.
DetailsResult 1
Result 2
Result 3
Result 4
Result 5
Result 6
Result 7
Result 8
|
Merging this PR will not alter performance
Comparing Footnotes
|
React Example with Element Template#930 Bundle Size — 204.36KiB (0%).c111d02(current) vs 1eb420d main#928(baseline) Bundle metrics
|
| Current #930 |
Baseline #928 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
4 |
4 |
|
124 |
124 |
|
50 |
50 |
|
45.19% |
45.19% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #930 |
Baseline #928 |
|
|---|---|---|
145.76KiB |
145.76KiB |
|
58.61KiB |
58.61KiB |
Bundle analysis report Branch p/a2ui-font Project dashboard
Generated by RelativeCI Documentation Report issue
React MTF Example#1795 Bundle Size — 208.94KiB (0%).c111d02(current) vs 1eb420d main#1793(baseline) Bundle metrics
|
| Current #1795 |
Baseline #1793 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
3 |
3 |
|
199 |
199 |
|
78 |
78 |
|
44.08% |
44.08% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #1795 |
Baseline #1793 |
|
|---|---|---|
111.23KiB |
111.23KiB |
|
97.71KiB |
97.71KiB |
Bundle analysis report Branch p/a2ui-font Project dashboard
Generated by RelativeCI Documentation Report issue
React External#1777 Bundle Size — 699.5KiB (0%).c111d02(current) vs 1eb420d main#1775(baseline) Bundle metrics
|
| Current #1777 |
Baseline #1775 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
41.1% |
|
0 |
0 |
|
3 |
3 |
|
17 |
17 |
|
5 |
5 |
|
7.13% |
7.13% |
|
0 |
0 |
|
0 |
0 |
Bundle analysis report Branch p/a2ui-font Project dashboard
Generated by RelativeCI Documentation Report issue
React Example#8661 Bundle Size — 238KiB (0%).c111d02(current) vs 1eb420d main#8659(baseline) Bundle metrics
|
| Current #8661 |
Baseline #8659 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
4 |
4 |
|
204 |
204 |
|
81 |
81 |
|
44.59% |
44.59% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #8661 |
Baseline #8659 |
|
|---|---|---|
145.76KiB |
145.76KiB |
|
92.24KiB |
92.24KiB |
Bundle analysis report Branch p/a2ui-font Project dashboard
Generated by RelativeCI Documentation Report issue
Web Explorer#10238 Bundle Size — 903.53KiB (0%).c111d02(current) vs 1eb420d main#10236(baseline) Bundle metrics
|
| Current #10238 |
Baseline #10236 |
|
|---|---|---|
45.06KiB |
45.06KiB |
|
2.22KiB |
2.22KiB |
|
0% |
0% |
|
9 |
9 |
|
11 |
11 |
|
230 |
230 |
|
11 |
11 |
|
27.13% |
27.13% |
|
10 |
10 |
|
0 |
0 |
Bundle size by type no changes
| Current #10238 |
Baseline #10236 |
|
|---|---|---|
499.15KiB |
499.15KiB |
|
402.16KiB |
402.16KiB |
|
2.22KiB |
2.22KiB |
Bundle analysis report Branch p/a2ui-font Project dashboard
Generated by RelativeCI Documentation Report issue
2c9b43f to
8e43c0c
Compare
Summary by CodeRabbit
Style
Checklist