fix: web-core touch event cloning by PupilTong · Pull Request #2636 · lynx-family/lynx-stack

PupilTong · 2026-05-14T08:28:51Z

Summary:

Always run touches, targetTouches, and changedTouches through toCloneableObject in createCrossThreadEvent.
Add regression coverage for synthetic/untrusted touch events so non-cloneable fields are filtered consistently.
Add a patch changeset for @lynx-js/web-core.

Validation:

pnpm dprint check .changeset/clone-touch-events.md packages/web-platform/web-core/ts/client/mainthread/elementAPIs/createCrossThreadEvent.ts packages/web-platform/web-core/tests/element-apis.spec.ts
pnpm build:wasm
pnpm exec tsc --build packages/tools/css-serializer/tsconfig.json packages/web-platform/web-worker-rpc/tsconfig.json packages/web-platform/web-elements/tsconfig.json
pnpm test tests/element-apis.spec.ts (74 tests)
pnpm changeset status --since=upstream/main

Summary by CodeRabbit

Bug Fixes
- Touch event lists are now consistently cloned when creating cross-thread events, ensuring only structured-clone-safe primitive fields are included in synthetic touch events.
Tests
- Added test coverage verifying proper cloning of touch event data during cross-thread event creation.

changeset-bot · 2026-05-14T08:28:57Z

🦋 Changeset detected

Latest commit: 96cbb39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@lynx-js/web-core	Patch
upgrade-rspeedy	Patch
@lynx-js/web-rsbuild-server-middleware	Patch
@lynx-js/template-webpack-plugin	Patch
@lynx-js/react-rsbuild-plugin	Patch
create-rspeedy	Patch
@lynx-js/web-worker-rpc	Patch
@lynx-js/react-alias-rsbuild-plugin	Patch
@lynx-js/rspeedy	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-14T08:28:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f1d0b5c6-9adb-4796-8a60-d9a2f0bf5c0a

📥 Commits

Reviewing files that changed from the base of the PR and between 66f6ecf and 96cbb39.

📒 Files selected for processing (3)

.changeset/clone-touch-events.md
packages/web-platform/web-core/tests/element-apis.spec.ts
packages/web-platform/web-core/ts/client/mainthread/elementAPIs/createCrossThreadEvent.ts

📝 Walkthrough

Walkthrough

Touch event handling in createCrossThreadEvent now unconditionally clones touch arrays to ensure only structured-clone-safe primitive fields are included, removing the prior condition that checked domEvent.isTrusted. A test validates this sanitization behavior, and a changelog entry documents the patch-level change.

Changes

Touch Event Cloning

Layer / File(s)	Summary
Touch cloning implementation `packages/web-platform/web-core/ts/client/mainthread/elementAPIs/createCrossThreadEvent.ts`	Removes the `isTrusted` branching variable and always maps `touches`, `targetTouches`, and `changedTouches` through `toCloneableObject` to produce serializable plain objects.
Test validation and release notes `packages/web-platform/web-core/tests/element-apis.spec.ts`, `.changeset/clone-touch-events.md`	New test case verifies untrusted touch events are sanitized to a minimal shape with only primitive fields. Changeset documents the patch-level behavior change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

platform:Web

Suggested reviewers

Sherry-hue

Poem

🐰 Touch events now dance without a trust check,
Cloned and sanitized—no structured wreck!
Plain fields only, safe to serialize,
Cross-thread messages that won't mesmerize.
A patch of safety, hopping through the code! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: fixing touch event cloning in web-core, which is the central objective of the PR.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-05-14T08:54:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-05-14T08:58:29Z

Merging this PR will degrade performance by 25.87%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 78 untouched benchmarks
⏩ 26 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`008-many-use-state-destroyBackground`	8 ms	9.5 ms	-16.12%
⚡	`transform 1000 view elements`	47.2 ms	44.7 ms	+5.43%
❌	`basic-performance-large-css`	16.1 ms	35.1 ms	-53.93%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing PupilTong:codex/clone-touch-events (96cbb39) with main (66f6ecf)}

26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-05-14T09:08:57Z

React Example

#8208 Bundle Size — 236.51KiB (0%).

96cbb39(current) vs 66f6ecf main#8200(baseline)

Bundle metrics no changes

	Current #8208	Baseline #8200
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`197`	`197`
Duplicate Modules	`80`	`80`
Duplicate Code	`44.87%`	`44.87%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #8208	Baseline #8200
IMG	`145.76KiB`	`145.76KiB`
Other	`90.75KiB`	`90.75KiB`

Bundle analysis report Branch PupilTong:codex/clone-touch-even... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-14T09:08:57Z

React External

#1322 Bundle Size — 693.04KiB (0%).

96cbb39(current) vs 66f6ecf main#1314(baseline)

Bundle metrics no changes

	Current #1322	Baseline #1314
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #1322	Baseline #1314
Other	`693.04KiB`	`693.04KiB`

Bundle analysis report Branch PupilTong:codex/clone-touch-even... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-14T09:08:57Z

React MTF Example

#1341 Bundle Size — 207.46KiB (0%).

96cbb39(current) vs 66f6ecf main#1333(baseline)

Bundle metrics no changes

	Current #1341	Baseline #1333
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`192`	`192`
Duplicate Modules	`77`	`77`
Duplicate Code	`44.38%`	`44.38%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #1341	Baseline #1333
IMG	`111.23KiB`	`111.23KiB`
Other	`96.23KiB`	`96.23KiB`

Bundle analysis report Branch PupilTong:codex/clone-touch-even... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-14T09:09:01Z

Web Explorer

#9782 Bundle Size — 901.35KiB (~-0.01%).

96cbb39(current) vs 66f6ecf main#9775(baseline)

Bundle metrics

2 changes

	Current #9782	Baseline #9775
Initial JS	`45.06KiB`	`45.06KiB`
Initial CSS	`2.22KiB`	`2.22KiB`
Cache Invalidation	`8.13%`	`0%`
Chunks	`9`	`9`
Assets	`11`	`11`
Modules	`230`(`+0.88%`)	`228`
Duplicate Modules	`11`	`11`
Duplicate Code	`27.22%`	`27.22%`
Packages	`10`	`10`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #9782	Baseline #9775
JS	`497.08KiB` (`~-0.01%`)	`497.1KiB`
Other	`402.06KiB`	`402.06KiB`
CSS	`2.22KiB`	`2.22KiB`

Bundle analysis report Branch PupilTong:codex/clone-touch-even... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-14T09:09:03Z

React Example with Element Template

#474 Bundle Size — 199.83KiB (0%).

96cbb39(current) vs 66f6ecf main#466(baseline)

Bundle metrics

2 changes

	Current #474	Baseline #466
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`87`(`+2.35%`)	`85`
Duplicate Modules	`25`	`25`
Duplicate Code	`39.93%`(`-0.1%`)	`39.97%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #474	Baseline #466
IMG	`145.76KiB`	`145.76KiB`
Other	`54.08KiB`	`54.08KiB`

Bundle analysis report Branch PupilTong:codex/clone-touch-even... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

After merging main (lynx-family#2636 dropped the isTrusted touch-cloning gate) the shifted touch helper became unused, breaking the Ubuntu/Windows build. Re-apply the lynx-view-relative shift as an addition rather than a replacement: every touch in `touches`/`targetTouches`/`changedTouches` now carries a new `x`/`y` pair in lynx-view-local space while keeping its original `clientX`/`clientY`/`pageX`/`pageY` (viewport/document). Same shape for mouse events (top-level `x`/`y` lynx-view-relative, `clientX`-and-friends untouched) and for `click`/`touch*` detail (gains `clientX`/`clientY`/`pageX`/`pageY` alongside `x`/`y`). This preserves Web interop (overlays, drag-drop, viewport alignment) while still giving Lynx handlers the local coordinates they expect. Touch e2e fixture and changeset updated to match.

fix(web-core): clone touch event lists

96cbb39

PupilTong changed the title ~~[codex] fix web-core touch event cloning~~ fix: web-core touch event cloning May 14, 2026

PupilTong self-assigned this May 14, 2026

PupilTong added this to Lynx for Web May 14, 2026

PupilTong marked this pull request as ready for review May 14, 2026 08:34

PupilTong requested a review from Sherry-hue as a code owner May 14, 2026 08:34

coderabbitai Bot added the platform:Web label May 14, 2026

Sherry-hue approved these changes May 14, 2026

View reviewed changes

Sherry-hue merged commit ee79eff into lynx-family:main May 14, 2026
83 of 87 checks passed

github-project-automation Bot moved this to Done in Lynx for Web May 14, 2026

github-actions Bot mentioned this pull request May 14, 2026

chore: Release 2026-05-15 12:19:18 #2535

Open

Conversation

PupilTong commented May 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented May 14, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

codecov Bot commented May 14, 2026

Codecov Report

Uh oh!

codspeed-hq Bot commented May 14, 2026

Merging this PR will degrade performance by 25.87%

Performance Changes

Footnotes

Uh oh!

relativeci Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#8208 Bundle Size — 236.51KiB (0%).

Uh oh!

relativeci Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React External

#1322 Bundle Size — 693.04KiB (0%).

Uh oh!

relativeci Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#1341 Bundle Size — 207.46KiB (0%).

Uh oh!

relativeci Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#9782 Bundle Size — 901.35KiB (~-0.01%).

Uh oh!

relativeci Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example with Element Template

#474 Bundle Size — 199.83KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PupilTong commented May 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 14, 2026 •

edited

Loading

relativeci Bot commented May 14, 2026 •

edited

Loading

relativeci Bot commented May 14, 2026 •

edited

Loading

relativeci Bot commented May 14, 2026 •

edited

Loading

relativeci Bot commented May 14, 2026 •

edited

Loading

relativeci Bot commented May 14, 2026 •

edited

Loading