fix(web-core): hide XMLHttpRequest from bts chunks by PupilTong · Pull Request #2580 · lynx-family/lynx-stack

PupilTong · 2026-05-08T09:39:24Z

Summary

comment out XMLHttpRequest injection for BTS chunk initialization
keep the BTS chunk type signature aligned
add an empty changeset

Tests

git diff --check
pnpm dprint fmt packages/web-platform/web-core/ts/client/background/background-apis/createChunkLoading.ts packages/web-platform/web-core/ts/types/BTSChunk.ts .changeset/comment-out-bts-xhr.md (fails: local dprint binary is unavailable; node_modules/.bin/dprint does not exist)

Summary by CodeRabbit

Refactor
- Removed a legacy global injection from the dynamic module loader so dynamically loaded modules no longer receive that injected global. This simplifies internal module wiring and type signatures but does not change page loading or any user-visible behavior.

changeset-bot · 2026-05-08T09:39:31Z

🦋 Changeset detected

Latest commit: dd94fd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-08T09:39:36Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cfb6165e-a1df-480b-9b54-4703253e8536

📥 Commits

Reviewing files that changed from the base of the PR and between c899f2a and dd94fd2.

📒 Files selected for processing (3)

.changeset/comment-out-bts-xhr.md
packages/web-platform/web-core/ts/client/background/background-apis/createChunkLoading.ts
packages/web-platform/web-core/ts/types/BTSChunk.ts

✅ Files skipped from review due to trivial changes (1)

.changeset/comment-out-bts-xhr.md

🚧 Files skipped from review as they are similar to previous changes (2)

packages/web-platform/web-core/ts/types/BTSChunk.ts
packages/web-platform/web-core/ts/client/background/background-apis/createChunkLoading.ts

📝 Walkthrough

Walkthrough

XMLHttpRequest was removed from the BTS chunk entry API and from the chunk loader's injected globals: the BTSChunkEntry callable signature no longer lists XMLHttpRequest, the new Function(...) parameter list no longer includes it, and the initializer call no longer passes tt.XMLHttpRequest. A changeset file was updated (now empty).

Changes

XMLHttpRequest Removal from Chunk Initialization

Layer / File(s)	Summary
Type Contract `packages/web-platform/web-core/ts/types/BTSChunk.ts`	`BTSChunkEntry` callable type removes `XMLHttpRequest: unknown` from its parameter list.
Chunk Initialization Implementation `packages/web-platform/web-core/ts/client/background/background-apis/createChunkLoading.ts`	Chunk loader stops injecting `XMLHttpRequest` into `new Function(...)` parameters and stops passing `tt.XMLHttpRequest` into the chunk initializer call.
Changeset `.changeset/comment-out-bts-xhr.md`	Changeset Markdown now contains only two blank lines (no frontmatter/body).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

lynx-family/lynx-stack#1834: Modifies chunk-loading wiring related to XMLHttpRequest injection.
lynx-family/lynx-stack#2562: Removes injected globals (fetch) from chunk-loading and updates BTSChunk types.

Suggested reviewers

Sherry-hue

Poem

🐰 I nibbled at globals, one by one,
XMLHttpRequest now on the run,
Type trimmed neat, loader light and spry,
Chunks hop onward, catching sky,
A tiny hop — the change is done.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and specifically describes the main change: commenting out XMLHttpRequest from BTS chunk initialization to hide it from chunks.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.changeset/comment-out-bts-xhr.md (1)
1-3: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Changeset file is missing required metadata and description.

The changeset file contains only empty frontmatter delimiters with no content. This means:

No packages will be versioned/bumped

No changelog entry will be generated for this change

The change won't be properly tracked in release notes

The frontmatter should specify which packages are affected and the bump type (patch/minor/major), and the body should describe the change for end users.
📝 Proposed fix: Add proper changeset content
 ---
+"@lynx/web-core": patch
 ---
-
+
+Remove XMLHttpRequest injection from BTS chunk initialization to improve compatibility.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.changeset/comment-out-bts-xhr.md around lines 1 - 3, The changeset file
.changeset/comment-out-bts-xhr.md contains only empty frontmatter delimiters
('---') and no metadata or description; update this file by adding proper
frontmatter that lists the affected package(s) and the version bump type
(patch/minor/major) and a short body description of the change for end users so
the package will be versioned and a changelog entry generated. Locate the file
by name and replace the empty frontmatter with YAML keys (e.g., the package
name(s) and bump type) and add a concise human-readable summary below the
frontmatter describing what was changed.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.changeset/comment-out-bts-xhr.md:
- Around line 1-3: The changeset file .changeset/comment-out-bts-xhr.md contains
only empty frontmatter delimiters ('---') and no metadata or description; update
this file by adding proper frontmatter that lists the affected package(s) and
the version bump type (patch/minor/major) and a short body description of the
change for end users so the package will be versioned and a changelog entry
generated. Locate the file by name and replace the empty frontmatter with YAML
keys (e.g., the package name(s) and bump type) and add a concise human-readable
summary below the frontmatter describing what was changed.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c032664f-00d5-4922-a8d8-c7ae567fb6ab

📥 Commits

Reviewing files that changed from the base of the PR and between 736ba38 and ec6dfc7.

📒 Files selected for processing (3)

.changeset/comment-out-bts-xhr.md
packages/web-platform/web-core/ts/client/background/background-apis/createChunkLoading.ts
packages/web-platform/web-core/ts/types/BTSChunk.ts

codecov · 2026-05-08T10:53:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-05-08T10:57:22Z

Merging this PR will not alter performance

✅ 81 untouched benchmarks
⏩ 26 skipped benchmarks¹

_{Comparing PupilTong:codex/comment-out-bts-xhr (dd94fd2) with main (5b6a33d)}

26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-05-08T11:04:26Z

React External

#1104 Bundle Size — 690.27KiB (0%).

dd94fd2(current) vs 4b27356 main#1100(baseline)

Bundle metrics no changes

	Current #1104	Baseline #1100
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #1104	Baseline #1100
Other	`690.27KiB`	`690.27KiB`

Bundle analysis report Branch PupilTong:codex/comment-out-bts-... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-08T11:04:27Z

React Example

#7990 Bundle Size — 235.77KiB (0%).

dd94fd2(current) vs 4b27356 main#7986(baseline)

Bundle metrics no changes

	Current #7990	Baseline #7986
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`197`	`197`
Duplicate Modules	`80`	`80`
Duplicate Code	`44.85%`	`44.85%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7990	Baseline #7986
IMG	`145.76KiB`	`145.76KiB`
Other	`90.01KiB`	`90.01KiB`

Bundle analysis report Branch PupilTong:codex/comment-out-bts-... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-08T11:04:33Z

Web Explorer

#9562 Bundle Size — 899.99KiB (~-0.01%).

dd94fd2(current) vs 4b27356 main#9558(baseline)

Bundle metrics

1 change

	Current #9562	Baseline #9558
Initial JS	`44.46KiB`	`44.46KiB`
Initial CSS	`2.22KiB`	`2.22KiB`
Cache Invalidation	`1.53%`	`0%`
Chunks	`9`	`9`
Assets	`11`	`11`
Modules	`227`	`227`
Duplicate Modules	`11`	`11`
Duplicate Code	`27.29%`	`27.29%`
Packages	`10`	`10`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #9562	Baseline #9558
JS	`495.85KiB` (`~-0.01%`)	`495.88KiB`
Other	`401.92KiB`	`401.92KiB`
CSS	`2.22KiB`	`2.22KiB`

Bundle analysis report Branch PupilTong:codex/comment-out-bts-... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-08T11:04:33Z

React Example with Element Template

#255 Bundle Size — 197.77KiB (-0.01%).

dd94fd2(current) vs 4b27356 main#251(baseline)

Bundle metrics

2 changes

	Current #255	Baseline #251
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`26.31%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`79`	`79`
Duplicate Modules	`23`	`23`
Duplicate Code	`40.43%`(`+0.25%`)	`40.33%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #255	Baseline #251
IMG	`145.76KiB`	`145.76KiB`
Other	`52.01KiB` (`-0.04%`)	`52.03KiB`

Bundle analysis report Branch PupilTong:codex/comment-out-bts-... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-08T11:04:34Z

React MTF Example

#1120 Bundle Size — 206.69KiB (+0.04%).

dd94fd2(current) vs 4b27356 main#1116(baseline)

Bundle metrics

1 change

	Current #1120	Baseline #1116
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`46.16%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`192`	`192`
Duplicate Modules	`77`	`77`
Duplicate Code	`44.36%`	`44.36%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #1120	Baseline #1116
IMG	`111.23KiB`	`111.23KiB`
Other	`95.46KiB` (`+0.09%`)	`95.37KiB`

Bundle analysis report Branch PupilTong:codex/comment-out-bts-... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

PupilTong requested a review from Sherry-hue as a code owner May 8, 2026 09:39

coderabbitai Bot added the platform:Web label May 8, 2026

coderabbitai Bot reviewed May 8, 2026

View reviewed changes

PupilTong force-pushed the codex/comment-out-bts-xhr branch from ec6dfc7 to 6b445fa Compare May 8, 2026 10:33

PupilTong force-pushed the codex/comment-out-bts-xhr branch from 6b445fa to c899f2a Compare May 8, 2026 12:06

fix(web-core): hide XMLHttpRequest from bts chunks

dd94fd2

PupilTong force-pushed the codex/comment-out-bts-xhr branch from c899f2a to dd94fd2 Compare May 8, 2026 12:45

PupilTong self-assigned this May 11, 2026

Sherry-hue approved these changes May 11, 2026

View reviewed changes

PupilTong merged commit 09b9ef0 into lynx-family:main May 11, 2026
109 of 116 checks passed

Conversation

PupilTong commented May 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

relativeci Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React External

#1104 Bundle Size — 690.27KiB (0%).

Uh oh!

relativeci Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#7990 Bundle Size — 235.77KiB (0%).

Uh oh!

relativeci Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#9562 Bundle Size — 899.99KiB (~-0.01%).

Uh oh!

relativeci Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example with Element Template

#255 Bundle Size — 197.77KiB (-0.01%).

Uh oh!

relativeci Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#1120 Bundle Size — 206.69KiB (+0.04%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PupilTong commented May 8, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented May 8, 2026 •

edited

Loading

coderabbitai Bot commented May 8, 2026 •

edited

Loading

codecov Bot commented May 8, 2026 •

edited

Loading

codspeed-hq Bot commented May 8, 2026 •

edited

Loading

relativeci Bot commented May 8, 2026 •

edited

Loading

relativeci Bot commented May 8, 2026 •

edited

Loading

relativeci Bot commented May 8, 2026 •

edited

Loading

relativeci Bot commented May 8, 2026 •

edited

Loading

relativeci Bot commented May 8, 2026 •

edited

Loading