refactor(react): contain snapshot runtime paths#2498
refactor(react): contain snapshot runtime paths#2498Yradex merged 6 commits intolynx-family:mainfrom
Conversation
|
Important Review skippedToo many files! This PR contains 196 files, which is 46 over the limit of 150. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (196)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: 90e8687 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will degrade performance by 18.84%
Performance Changes
Comparing Footnotes
|
React Example#7474 Bundle Size — 224.41KiB (0%).90e8687(current) vs 02be891 main#7453(baseline) Bundle metrics
Bundle size by type
|
| Current #7474 |
Baseline #7453 |
|
|---|---|---|
145.76KiB |
145.76KiB |
|
78.65KiB |
78.65KiB |
Bundle analysis report Branch Yradex:wt/snapshot-containment-p... Project dashboard
Generated by RelativeCI Documentation Report issue
React External#592 Bundle Size — 583.28KiB (~+0.01%).90e8687(current) vs 02be891 main#571(baseline) Bundle metrics
Bundle size by type
Bundle analysis report Branch Yradex:wt/snapshot-containment-p... Project dashboard Generated by RelativeCI Documentation Report issue |
Web Explorer#9048 Bundle Size — 898.15KiB (0%).90e8687(current) vs 02be891 main#9028(baseline) Bundle metrics
Bundle size by type
|
| Current #9048 |
Baseline #9028 |
|
|---|---|---|
494.3KiB |
494.3KiB |
|
401.63KiB |
401.63KiB |
|
2.22KiB |
2.22KiB |
Bundle analysis report Branch Yradex:wt/snapshot-containment-p... Project dashboard
Generated by RelativeCI Documentation Report issue
React MTF Example#607 Bundle Size — 195.57KiB (0%).90e8687(current) vs 02be891 main#586(baseline) Bundle metrics
Bundle size by type
|
| Current #607 |
Baseline #586 |
|
|---|---|---|
111.23KiB |
111.23KiB |
|
84.34KiB |
84.34KiB |
Bundle analysis report Branch Yradex:wt/snapshot-containment-p... Project dashboard
Generated by RelativeCI Documentation Report issue
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1963d17a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
@coderabbitai summary
Overview
Key Points
packages/react/runtime/src/snapshot/instead of introducing a broad facade layer.packages/react/runtime/__test__/snapshot/and keeps non-Snapshot runtime tests outside that subtree.__SetClassesDarkModeis not exported from the runtime root today; the guardrail documents that as a narrow known exception.Checklist