fix: prevent invalid uniqueId of -1 from being added to bubblePath in… by PupilTong · Pull Request #2493 · lynx-family/lynx-stack

PupilTong · 2026-04-21T09:21:40Z

… WASMJSBinding

Summary by CodeRabbit

Bug Fixes
- Resolved an issue where invalid identifiers were being included in event propagation paths, ensuring more reliable event handling and dispatching.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

… WASMJSBinding

changeset-bot · 2026-04-21T09:21:44Z

🦋 Changeset detected

Latest commit: b361331

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@lynx-js/web-core	Patch
upgrade-rspeedy	Patch
@lynx-js/web-rsbuild-server-middleware	Patch
@lynx-js/template-webpack-plugin	Patch
@lynx-js/react-rsbuild-plugin	Patch
create-rspeedy	Patch
@lynx-js/web-worker-rpc	Patch
@lynx-js/react-alias-rsbuild-plugin	Patch
@lynx-js/rspeedy	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-04-21T09:21:57Z

📝 Walkthrough

Walkthrough

This PR introduces a patch-level fix for @lynx-js/web-core to filter out sentinel -1 values when constructing the bubble path in the commonEventHandler. Changes include the implementation fix in WASMJSBinding.ts, a corresponding test case, and a changelog entry.

Changes

Cohort / File(s)	Summary
Changeset Entry `.changeset/fix-event-handler-unique-id.md`	Added patch-level release note documenting the fix to filter `-1` uniqueId values in `commonEventHandler`.
Test Coverage `packages/web-platform/web-core/tests/element-apis.spec.ts`	New test case verifying that mocked `common_event_handler` is invoked with a bubble path that excludes the sentinel `-1` value (represented as `4294967295` in `Uint32Array`).
Implementation Fix `packages/web-platform/web-core/ts/client/mainthread/elementAPIs/WASMJSBinding.ts`	Updated bubble-path construction logic to skip invalid `uniqueId` values (`-1`) before appending to `bubblePath`, ensuring array resizing only accounts for valid entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

fix: web-core-wasm triggerEvent & lazy component for special DSL usage #2399: Modifies the same commonEventHandler event handling path and wasm binding logic.
feat: implement global-bind event support for decoupled cross-element… #2438: Augments the common event handler pipeline to dispatch global-bind events using the corrected bubble path.

Suggested labels

platform:Web

Suggested reviewers

Sherry-hue

Poem

🐰 A sentinel crept through the bubble path so wide,
But -1 had no place here, we filter with pride!
Test and code align now, no invalid IDs stay,
The event chain flows cleaner, hooray hooray! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: preventing invalid uniqueId value of -1 from being added to bubblePath in WASMJSBinding, which aligns with the code modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-04-21T09:24:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

coderabbitai

🧹 Nitpick comments (1)

packages/web-platform/web-core/tests/element-apis.spec.ts (1)

71-79: Assert the valid ancestor remains in bubblePath.

This test would still pass if #commonEventHandler returned an empty path. Please also assert that node1’s valid unique ID is preserved.

Proposed test tightening

     expect(mtsBinding.wasmContext!.common_event_handler).toHaveBeenCalled();
     const calls =
       (mtsBinding.wasmContext!.common_event_handler as any).mock.calls;
-    const bubblePath = calls[0][1] as Uint32Array;
+    const bubblePath = Array.from(calls[0][1] as Uint32Array);
+    const invalidUniqueIdInUint32Array = 0xffffffff;
 
-    // Check that -1 (4294967295 in Uint32Array) is NOT in the bubblePath
-    for (let i = 0; i < bubblePath.length; i++) {
-      expect(bubblePath[i] !== 4294967295).toBe(true);
-    }
+    expect(bubblePath).toEqual([mtsGlobalThis.__GetElementUniqueID(node1)]);
+    expect(bubblePath).not.toContain(invalidUniqueIdInUint32Array);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/web-platform/web-core/tests/element-apis.spec.ts` around lines 71 -
79, The test currently only asserts that -1 isn't present in the bubblePath
returned from mtsBinding.wasmContext!.common_event_handler but would still pass
if the path were empty; update the assertion to also verify that node1's valid
unique ID is included in the bubblePath. After retrieving bubblePath (from
(mtsBinding.wasmContext!.common_event_handler as any).mock.calls[0][1]), compute
or read node1's unique ID (the same identifier used when creating node1) and
assert that bubblePath contains that ID (e.g., convert bubblePath to a normal
array and expect it to contain node1's ID) so the test ensures the ancestor is
preserved.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/web-platform/web-core/tests/element-apis.spec.ts`:
- Around line 71-79: The test currently only asserts that -1 isn't present in
the bubblePath returned from mtsBinding.wasmContext!.common_event_handler but
would still pass if the path were empty; update the assertion to also verify
that node1's valid unique ID is included in the bubblePath. After retrieving
bubblePath (from (mtsBinding.wasmContext!.common_event_handler as
any).mock.calls[0][1]), compute or read node1's unique ID (the same identifier
used when creating node1) and assert that bubblePath contains that ID (e.g.,
convert bubblePath to a normal array and expect it to contain node1's ID) so the
test ensures the ancestor is preserved.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 48258bf1-107a-4d4e-ad95-5046f713296a

📥 Commits

Reviewing files that changed from the base of the PR and between 02be891 and b361331.

📒 Files selected for processing (3)

.changeset/fix-event-handler-unique-id.md
packages/web-platform/web-core/tests/element-apis.spec.ts
packages/web-platform/web-core/ts/client/mainthread/elementAPIs/WASMJSBinding.ts

codspeed-hq · 2026-04-21T09:41:59Z

Merging this PR will degrade performance by 16.16%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 79 untouched benchmarks
⏩ 26 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`008-many-use-state-destroyBackground`	8 ms	9.5 ms	-16.16%
⚡	`transform 1000 view elements`	44.6 ms	40 ms	+11.59%

_{Comparing PupilTong:p/hw/fix-event-with-invalid-uniqueid (b361331) with main (02be891)}

26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-04-21T09:43:22Z

React External

#574 Bundle Size — 583.27KiB (0%).

b361331(current) vs 02be891 main#571(baseline)

Bundle metrics no changes

	Current #574	Baseline #571
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #574	Baseline #571
Other	`583.27KiB`	`583.27KiB`

Bundle analysis report Branch PupilTong:p/hw/fix-event-with-in... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-21T09:43:23Z

Web Explorer

#9031 Bundle Size — 898.16KiB (~+0.01%).

b361331(current) vs 02be891 main#9028(baseline)

Bundle metrics

1 change

	Current #9031	Baseline #9028
Initial JS	`44.47KiB`	`44.47KiB`
Initial CSS	`2.22KiB`	`2.22KiB`
Cache Invalidation	`7.99%`	`0%`
Chunks	`9`	`9`
Assets	`11`	`11`
Modules	`229`	`229`
Duplicate Modules	`11`	`11`
Duplicate Code	`27.22%`	`27.22%`
Packages	`10`	`10`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #9031	Baseline #9028
JS	`494.31KiB` (`~+0.01%`)	`494.3KiB`
Other	`401.63KiB`	`401.63KiB`
CSS	`2.22KiB`	`2.22KiB`

Bundle analysis report Branch PupilTong:p/hw/fix-event-with-in... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-21T09:43:23Z

React Example

#7456 Bundle Size — 224.41KiB (0%).

b361331(current) vs 02be891 main#7453(baseline)

Bundle metrics no changes

	Current #7456	Baseline #7453
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`179`	`179`
Duplicate Modules	`69`	`69`
Duplicate Code	`44.5%`	`44.5%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7456	Baseline #7453
IMG	`145.76KiB`	`145.76KiB`
Other	`78.65KiB`	`78.65KiB`

Bundle analysis report Branch PupilTong:p/hw/fix-event-with-in... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-21T09:43:48Z

React MTF Example

#589 Bundle Size — 195.57KiB (0%).

b361331(current) vs 02be891 main#586(baseline)

Bundle metrics no changes

	Current #589	Baseline #586
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`173`	`173`
Duplicate Modules	`66`	`66`
Duplicate Code	`43.99%`	`43.99%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #589	Baseline #586
IMG	`111.23KiB`	`111.23KiB`
Other	`84.34KiB`	`84.34KiB`

Bundle analysis report Branch PupilTong:p/hw/fix-event-with-in... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

fix: prevent invalid uniqueId of -1 from being added to bubblePath in…

b361331

… WASMJSBinding

PupilTong requested a review from Sherry-hue as a code owner April 21, 2026 09:21

coderabbitai Bot added the platform:Web label Apr 21, 2026

coderabbitai Bot reviewed Apr 21, 2026

View reviewed changes

PupilTong self-assigned this Apr 21, 2026

Sherry-hue approved these changes Apr 22, 2026

View reviewed changes

PupilTong merged commit 25e196b into lynx-family:main Apr 22, 2026
76 of 79 checks passed

github-actions Bot mentioned this pull request Apr 22, 2026

chore: Release 2026-04-24 14:53:52 #2477

Open

Conversation

PupilTong commented Apr 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot Bot commented Apr 21, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq Bot commented Apr 21, 2026

Merging this PR will degrade performance by 16.16%

Performance Changes

Footnotes

Uh oh!

relativeci Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React External

#574 Bundle Size — 583.27KiB (0%).

Uh oh!

relativeci Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#9031 Bundle Size — 898.16KiB (~+0.01%).

Uh oh!

relativeci Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#7456 Bundle Size — 224.41KiB (0%).

Uh oh!

relativeci Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#589 Bundle Size — 195.57KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PupilTong commented Apr 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 21, 2026 •

edited

Loading

codecov Bot commented Apr 21, 2026 •

edited

Loading

relativeci Bot commented Apr 21, 2026 •

edited

Loading

relativeci Bot commented Apr 21, 2026 •

edited

Loading

relativeci Bot commented Apr 21, 2026 •

edited

Loading

relativeci Bot commented Apr 21, 2026 •

edited

Loading