Skip to content

feat: update preact version#2456

Merged
HuJean merged 1 commit intomainfrom
p/update-preact
Apr 14, 2026
Merged

feat: update preact version#2456
HuJean merged 1 commit intomainfrom
p/update-preact

Conversation

@HuJean
Copy link
Copy Markdown
Collaborator

@HuJean HuJean commented Apr 14, 2026

Summary by CodeRabbit

  • Chores
    • Updated the pinned Preact dependency used by the React package to a new build reference.
    • Added a changeset declaring a patch release to reflect the dependency update.
    • Minor metadata adjustments to ensure release tooling recognizes the new dependency reference.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@HuJean HuJean requested review from Yradex and hzy as code owners April 14, 2026 03:21
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 14, 2026

🦋 Changeset detected

Latest commit: 8124d5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lynx-js/react Patch
@lynx-js/react-umd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f9c16b70-dcee-47c3-b070-bb1d042c8359

📥 Commits

Reviewing files that changed from the base of the PR and between 280c02e and 8124d5d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • .changeset/sharp-icons-guess.md
  • packages/react/package.json
✅ Files skipped from review due to trivial changes (1)
  • packages/react/package.json

📝 Walkthrough

Walkthrough

Added a changeset for @lynx-js/react and bumped the pinned preact alias in packages/react/package.json from one internal-preact build tag to a newer build tag.

Changes

Cohort / File(s) Summary
Changeset metadata
\.changeset/sharp-icons-guess.md
Added a new changeset marking a patch release for @lynx-js/react, indicating the preact dependency should be updated.
Preact dependency update
packages/react/package.json
Updated dependencies.preact from npm:@lynx-js/internal-preact@10.28.4-4842985 to npm:@lynx-js/internal-preact@10.28.4-2d1d67a (pinned internal-preact alias change).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • hzy
  • Yradex

Poem

🐰 I hopped through diffs with nimble paws,

Swapped one preact tag without a pause,
A tiny changeset, neat and spry,
Patch tucked in — a carrot in the sky,
Cheers from a rabbit — quick applause! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: update preact version' accurately summarizes the main change—updating the preact dependency in packages/react/package.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch p/update-preact

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/sharp-icons-guess.md (1)

5-5: Make the release note line more specific.

“Update preact version” is a bit vague; include the exact target version/commit so changelog readers can trace the dependency change quickly.

Suggested wording
-Update preact version
+Update preact dependency to internal-preact commit de96922
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.changeset/sharp-icons-guess.md at line 5, Replace the vague release note
"Update preact version" in the .changeset entry by stating the exact target
dependency update for preact (e.g., "Bump preact to vX.Y.Z" or "Update preact to
commit <SHA/branch>"), include the full version number or commit SHA and
optional brief reason/impact; ensure the wording references "preact" and the
precise version/commit so changelog readers can trace the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/react/package.json`:
- Line 177: The package.json currently pins "preact" to a preview URL; replace
that URL with the published npm package `@lynx-js/internal-preact` at the released
version that corresponds to commit de96922. Locate the correct version for
`@lynx-js/internal-preact` (via your npm registry, package release notes or the
package's repo tags/CHANGELOG) and update the "preact" entry in
packages/react/package.json to use "@lynx-js/internal-preact":
"<resolved-version>" so consumers install from npm rather than the preview host.

---

Nitpick comments:
In @.changeset/sharp-icons-guess.md:
- Line 5: Replace the vague release note "Update preact version" in the
.changeset entry by stating the exact target dependency update for preact (e.g.,
"Bump preact to vX.Y.Z" or "Update preact to commit <SHA/branch>"), include the
full version number or commit SHA and optional brief reason/impact; ensure the
wording references "preact" and the precise version/commit so changelog readers
can trace the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4f2cb0ee-2b44-426c-8a26-a6ccc2bd2d5c

📥 Commits

Reviewing files that changed from the base of the PR and between a9f8d05 and dff0a08.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • .changeset/sharp-icons-guess.md
  • packages/react/package.json

Comment thread packages/react/package.json Outdated
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.changeset/sharp-icons-guess.md (1)

5-5: Prefer product-name capitalization in release note text.

Consider changing Update preact version to Update Preact version for consistency/readability in generated notes.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.changeset/sharp-icons-guess.md at line 5, Change the release note text in
.changeset/sharp-icons-guess.md from "Update preact version" to use product-name
capitalization: "Update Preact version" so generated notes are consistent;
update the string exactly (look for the line containing "Update preact version")
and commit the adjusted phrase.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.changeset/sharp-icons-guess.md:
- Line 5: Change the release note text in .changeset/sharp-icons-guess.md from
"Update preact version" to use product-name capitalization: "Update Preact
version" so generated notes are consistent; update the string exactly (look for
the line containing "Update preact version") and commit the adjusted phrase.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ec8cb251-454b-433f-b72f-43a5b7bb0401

📥 Commits

Reviewing files that changed from the base of the PR and between dff0a08 and aa5cca1.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • .changeset/sharp-icons-guess.md
  • packages/react/package.json
✅ Files skipped from review due to trivial changes (1)
  • packages/react/package.json

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 14, 2026

Merging this PR will degrade performance by 42.73%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 9 improved benchmarks
❌ 6 regressed benchmarks
✅ 66 untouched benchmarks
⏩ 21 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
004-various-update/background.js_LoadScript 392.6 µs 373.8 µs +5.02%
006-static-raw-text/background.js_LoadScript 491.3 µs 463.1 µs +6.1%
006-static-raw-text/main-thread.js_LoadScript 387.5 µs 342.6 µs +13.13%
003-hello-list__main-thread-componentAtIndex__reuse 2.4 ms 3.3 ms -26.13%
002-hello-reactLynx/background.js_LoadScript 491.5 µs 462.8 µs +6.19%
002-hello-reactLynx/main-thread.js_LoadScript 389.1 µs 343.2 µs +13.39%
007-four-layer-views/main-thread.js_LoadScript 395.7 µs 351.2 µs +12.69%
007-four-layer-views/background.js_LoadScript 499.4 µs 470.2 µs +6.21%
transform 1000 view elements 43.7 ms 47.6 ms -8.13%
008-many-use-state__main-thread-serializeRoot 149.4 µs 158.4 µs -5.67%
basic-performance-div-1000 26.3 ms 35.3 ms -25.45%
008-many-use-state/background.js_LoadScript 501.2 µs 472.6 µs +6.06%
008-many-use-state/main-thread.js_LoadScript 394.5 µs 348.9 µs +13.07%
basic-performance-scroll-view-100 8.1 ms 8.6 ms -5.48%
basic-performance-text-200 11.9 ms 20.7 ms -42.73%

Comparing p/update-preact (8124d5d) with main (a9f8d05)

Open in CodSpeed

Footnotes

  1. 21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci bot commented Apr 14, 2026

React External

#385 Bundle Size — 582.81KiB (-1.51%).

8124d5d(current) vs a9f8d05 main#369(baseline)

Bundle metrics  Change 1 change
                 Current
#385
     Baseline
#369
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
Change  Cache Invalidation 31.07% 0%
No change  Chunks 0 0
No change  Assets 3 3
No change  Modules 17 17
No change  Duplicate Modules 5 5
No change  Duplicate Code 8.59% 8.59%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#385
     Baseline
#369
Improvement  Other 582.81KiB (-1.51%) 591.76KiB

Bundle analysis reportBranch p/update-preactProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci bot commented Apr 14, 2026

Web Explorer

#8841 Bundle Size — 748.66KiB (0%).

8124d5d(current) vs a9f8d05 main#8825(baseline)

Bundle metrics  no changes
                 Current
#8841
     Baseline
#8825
No change  Initial JS 44.27KiB 44.27KiB
No change  Initial CSS 2.16KiB 2.16KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 10 10
No change  Modules 150 150
No change  Duplicate Modules 11 11
No change  Duplicate Code 35.01% 35.01%
No change  Packages 3 3
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#8841
     Baseline
#8825
No change  Other 401.63KiB 401.63KiB
No change  JS 344.87KiB 344.87KiB
No change  CSS 2.16KiB 2.16KiB

Bundle analysis reportBranch p/update-preactProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci bot commented Apr 14, 2026

React Example

#7267 Bundle Size — 223.58KiB (-5.59%).

8124d5d(current) vs a9f8d05 main#7251(baseline)

Bundle metrics  Change 2 changes
                 Current
#7267
     Baseline
#7251
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
Change  Cache Invalidation 38.45% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 179 179
No change  Duplicate Modules 70 70
Change  Duplicate Code 45.76%(-0.8%) 46.13%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#7267
     Baseline
#7251
No change  IMG 145.76KiB 145.76KiB
Improvement  Other 77.82KiB (-14.55%) 91.07KiB

Bundle analysis reportBranch p/update-preactProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci bot commented Apr 14, 2026

React MTF Example

#400 Bundle Size — 192.85KiB (-6.44%).

8124d5d(current) vs a9f8d05 main#384(baseline)

Bundle metrics  Change 2 changes
                 Current
#400
     Baseline
#384
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
Change  Cache Invalidation 46.04% 0%
No change  Chunks 0 0
No change  Assets 3 3
No change  Modules 173 173
No change  Duplicate Modules 67 67
Change  Duplicate Code 45.36%(-0.94%) 45.79%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#400
     Baseline
#384
No change  IMG 111.23KiB 111.23KiB
Improvement  Other 81.61KiB (-13.99%) 94.89KiB

Bundle analysis reportBranch p/update-preactProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.changeset/sharp-icons-guess.md (1)

5-5: Make the release note text more specific.

Line 5 is very generic; consider mentioning what changed (e.g., dependency source switch/commit) so release notes are more actionable.

✏️ Suggested wording
-Update preact version
+Update preact dependency source to the new internal-preact build
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.changeset/sharp-icons-guess.md at line 5, Replace the generic "Update
preact version" line with a specific release note that names the dependency
("preact"), the new version number or range, and what changed about the source
(e.g., "switched from npm registry to GitHub commit <sha>" or "bumped from
vA.B.C to vX.Y.Z"), and include context/reason (e.g., bugfix, security, or
compatibility) so consumers can act on it; update the sentence currently reading
"Update preact version" in .changeset/sharp-icons-guess.md to follow this
format.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.changeset/sharp-icons-guess.md:
- Line 5: Replace the generic "Update preact version" line with a specific
release note that names the dependency ("preact"), the new version number or
range, and what changed about the source (e.g., "switched from npm registry to
GitHub commit <sha>" or "bumped from vA.B.C to vX.Y.Z"), and include
context/reason (e.g., bugfix, security, or compatibility) so consumers can act
on it; update the sentence currently reading "Update preact version" in
.changeset/sharp-icons-guess.md to follow this format.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c6c312e1-c682-4eb2-a081-bcfee45e8aef

📥 Commits

Reviewing files that changed from the base of the PR and between 39eb9be and 280c02e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • .changeset/sharp-icons-guess.md
  • packages/react/package.json
✅ Files skipped from review due to trivial changes (1)
  • packages/react/package.json

@HuJean HuJean enabled auto-merge (squash) April 14, 2026 08:11
@HuJean HuJean merged commit 018be76 into main Apr 14, 2026
76 of 80 checks passed
@HuJean HuJean deleted the p/update-preact branch April 14, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants