refactor: code structure of runtime by HuJean · Pull Request #2436 · lynx-family/lynx-stack

HuJean · 2026-04-07T11:21:50Z

Summary by CodeRabbit

Release Notes

Chores
- Internal module reorganization to improve code structure and maintainability across the React runtime package. Import paths updated to reflect new module organization.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2026-04-07T11:21:58Z

🦋 Changeset detected

Latest commit: c7d9721

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-04-07T11:22:08Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d40cbd3b-c32e-4870-9013-c3e1b2904e5f

📥 Commits

Reviewing files that changed from the base of the PR and between 3c3d9b0 and c7d9721.

📒 Files selected for processing (28)

.changeset/bumpy-lizards-wear.md
packages/react/runtime/__test__/lifecycle.test.jsx
packages/react/runtime/__test__/list.test.jsx
packages/react/runtime/__test__/snapshot/ref.test.jsx
packages/react/runtime/__test__/utils/envManager.ts
packages/react/runtime/src/debug/profile.ts
packages/react/runtime/src/lifecycle/constant.ts
packages/react/runtime/src/lifecycle/event/delayLifecycleEvents.ts
packages/react/runtime/src/lifecycle/event/jsReady.ts
packages/react/runtime/src/lifecycle/patch/commit.ts
packages/react/runtime/src/lifecycle/patch/updateMainThread.ts
packages/react/runtime/src/lifecycle/reload.ts
packages/react/runtime/src/list/list.ts
packages/react/runtime/src/list/listUpdateInfo.ts
packages/react/runtime/src/list/pendingListUpdates.ts
packages/react/runtime/src/lynx-api.ts
packages/react/runtime/src/lynx/calledByNative.ts
packages/react/runtime/src/lynx/tt.ts
packages/react/runtime/src/renderToOpcodes/hydrate.ts
packages/react/runtime/src/renderToOpcodes/opcodes.ts
packages/react/runtime/src/snapshot/backgroundSnapshot.ts
packages/react/runtime/src/snapshot/list.ts
packages/react/runtime/src/snapshot/platformInfo.ts
packages/react/runtime/src/snapshot/snapshot.ts
packages/react/runtime/src/snapshot/spread.ts
packages/react/runtime/src/worklet/ref/updateInitValue.ts
packages/react/runtime/types/types.d.ts
packages/react/testing-library/src/__tests__/list.test.jsx

✅ Files skipped from review due to trivial changes (23)

.changeset/bumpy-lizards-wear.md
packages/react/runtime/src/lifecycle/patch/commit.ts
packages/react/runtime/test/utils/envManager.ts
packages/react/runtime/src/lifecycle/patch/updateMainThread.ts
packages/react/runtime/types/types.d.ts
packages/react/runtime/src/lifecycle/reload.ts
packages/react/testing-library/src/tests/list.test.jsx
packages/react/runtime/src/snapshot/platformInfo.ts
packages/react/runtime/src/snapshot/list.ts
packages/react/runtime/src/list/listUpdateInfo.ts
packages/react/runtime/src/renderToOpcodes/opcodes.ts
packages/react/runtime/src/lifecycle/event/delayLifecycleEvents.ts
packages/react/runtime/test/lifecycle.test.jsx
packages/react/runtime/src/snapshot/backgroundSnapshot.ts
packages/react/runtime/src/renderToOpcodes/hydrate.ts
packages/react/runtime/src/list/list.ts
packages/react/runtime/src/lynx-api.ts
packages/react/runtime/src/worklet/ref/updateInitValue.ts
packages/react/runtime/src/lynx/calledByNative.ts
packages/react/runtime/test/list.test.jsx
packages/react/runtime/src/lifecycle/event/jsReady.ts
packages/react/runtime/test/snapshot/ref.test.jsx
packages/react/runtime/src/lynx/tt.ts

🚧 Files skipped from review as they are similar to previous changes (3)

packages/react/runtime/src/snapshot/spread.ts
packages/react/runtime/src/snapshot/snapshot.ts
packages/react/runtime/src/debug/profile.ts

📝 Walkthrough

Walkthrough

This PR reorganizes module paths across the React runtime package by moving constants and utilities into more specific subdirectories (e.g., lifecycleConstant.js → lifecycle/constant.js, hydrate.js → renderToOpcodes/hydrate.js). No functional logic or exported API signatures change.

Changes

Cohort / File(s)	Summary
Lifecycle constant imports `packages/react/runtime/__test__/lifecycle.test.jsx`, `packages/react/runtime/src/lifecycle/event/delayLifecycleEvents.ts`, `packages/react/runtime/src/lifecycle/event/jsReady.ts`, `packages/react/runtime/src/lifecycle/patch/commit.ts`, `packages/react/runtime/src/lifecycle/patch/updateMainThread.ts`, `packages/react/runtime/src/lifecycle/reload.ts`, `packages/react/runtime/src/list/list.ts`, `packages/react/runtime/src/lynx-api.ts`, `packages/react/runtime/src/lynx/calledByNative.ts`, `packages/react/runtime/src/lynx/tt.ts`, `packages/react/runtime/src/worklet/ref/updateInitValue.ts`, `packages/react/runtime/types/types.d.ts`	Updated `LifecycleConstant` import source from `lifecycleConstant.js` to `lifecycle/constant.js` across multiple files.
Hydrate module relocation `packages/react/runtime/__test__/list.test.jsx`, `packages/react/runtime/src/lifecycle/reload.ts`, `packages/react/runtime/src/list/listUpdateInfo.ts`, `packages/react/runtime/src/lynx/calledByNative.ts`, `packages/react/runtime/src/renderToOpcodes/hydrate.ts`, `packages/react/runtime/src/renderToOpcodes/opcodes.ts`, `packages/react/runtime/src/snapshot/backgroundSnapshot.ts`, `packages/react/runtime/src/snapshot/list.ts`	Redirected `hydrate` and related hydration utilities from `hydrate.js` to `renderToOpcodes/hydrate.js`.
Pending list updates relocation `packages/react/runtime/__test__/list.test.jsx`, `packages/react/runtime/__test__/snapshot/ref.test.jsx`, `packages/react/runtime/__test__/utils/envManager.ts`, `packages/react/runtime/src/lifecycle/patch/updateMainThread.ts`, `packages/react/runtime/src/lifecycle/reload.ts`, `packages/react/runtime/src/lynx/calledByNative.ts`, `packages/react/runtime/src/snapshot/platformInfo.ts`, `packages/react/runtime/src/snapshot/snapshot.ts`, `packages/react/runtime/src/snapshot/spread.ts`, `packages/react/testing-library/src/__tests__/list.test.jsx`	Updated `__pendingListUpdates` and related list update imports from top-level to `list/pendingListUpdates.js` and `list/listUpdateInfo.js`.
Debug profiling refinement `packages/react/runtime/src/debug/profile.ts`	Replaced locally defined `noop` function with imported `noop` from `utils.js`; fallback behavior for missing profiling methods now uses the shared utility.
Metadata `.changeset/bumpy-lizards-wear.md`	Added new empty changeset metadata file with YAML frontmatter.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

refactor(react/runtime): move delayedRunOnMainThreadData to a separate file #1750: Updates import paths in packages/react/runtime/src/lifecycle/patch/commit.ts for lifecycle constant relocation.
feat: add dual-thread commutation logs #2081: Modifies packages/react/runtime/src/lifecycle/patch/updateMainThread.ts with coordinated import path changes.
refactor(react/runtime): reorganize worklet dir #1753: Performs coordinated module reorganization within packages/react/runtime with overlapping path updates.

Suggested reviewers

Yradex
hzy

Poem

🐰 Through module paths we hop and skip,
Constants grouped in organized clips,
Hydrate flows where it should dwell,
Pending lists in their own shell,
The runtime's structure, cleaner still! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'refactor: code structure of runtime' accurately reflects the main changeset, which consists of reorganizing import paths across the runtime module structure to reflect a new directory hierarchy (e.g., moving lifecycle-related files into a lifecycle/ subdirectory, list utilities into list/, and render opcodes into renderToOpcodes/).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch p/code-structure

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-04-07T11:24:53Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-04-07T11:37:22Z

Merging this PR will degrade performance by 25.46%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 70 untouched benchmarks
⏩ 21 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`transform 1000 view elements`	47.2 ms	40.3 ms	+17.02%
❌	`basic-performance-div-1000`	26.3 ms	35.3 ms	-25.46%

_{Comparing p/code-structure (c7d9721) with main (5f2cea3)}

21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-04-07T11:37:43Z

React Example

#7133 Bundle Size — 236.8KiB (-0.02%).

c7d9721(current) vs 5f2cea3 main#7111(baseline)

Bundle metrics

1 change

	Current #7133	Baseline #7111
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`38.46%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`179`	`179`
Duplicate Modules	`70`	`70`
Duplicate Code	`46.11%`	`46.11%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #7133	Baseline #7111
IMG	`145.76KiB`	`145.76KiB`
Other	`91.05KiB` (`-0.05%`)	`91.09KiB`

Bundle analysis report Branch p/code-structure Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-07T11:37:44Z

React MTF Example

#266 Bundle Size — 206.05KiB (0%).

c7d9721(current) vs 5f2cea3 main#244(baseline)

Bundle metrics no changes

	Current #266	Baseline #244
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`173`	`173`
Duplicate Modules	`67`	`67`
Duplicate Code	`45.77%`	`45.77%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #266	Baseline #244
IMG	`111.23KiB`	`111.23KiB`
Other	`94.81KiB`	`94.81KiB`

Bundle analysis report Branch p/code-structure Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-07T11:37:52Z

Web Explorer

#8708 Bundle Size — 728.84KiB (0%).

c7d9721(current) vs 5f2cea3 main#8686(baseline)

Bundle metrics

2 changes

	Current #8708	Baseline #8686
Initial JS	`43.31KiB`	`43.31KiB`
Initial CSS	`2.16KiB`	`2.16KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`10`	`10`
Modules	`149`(`-0.67%`)	`150`
Duplicate Modules	`11`	`11`
Duplicate Code	`34.69%`(`+0.03%`)	`34.68%`
Packages	`3`	`3`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #8708	Baseline #8686
Other	`384.62KiB`	`384.62KiB`
JS	`342.07KiB`	`342.07KiB`
CSS	`2.16KiB`	`2.16KiB`

Bundle analysis report Branch p/code-structure Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-07T11:37:58Z

React External

#252 Bundle Size — 590.6KiB (~+0.01%).

c7d9721(current) vs 5f2cea3 main#230(baseline)

Bundle metrics

1 change

	Current #252	Baseline #230
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`30.93%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #252	Baseline #230
Other	`590.6KiB` (`~+0.01%`)	`590.59KiB`

Bundle analysis report Branch p/code-structure Project dashboard

^{Generated by RelativeCI Documentation Report issue}

HuJean requested review from Yradex and hzy as code owners April 7, 2026 11:21

coderabbitai bot added the framework:React label Apr 7, 2026

refactor: code structure of runtime

c7d9721

HuJean force-pushed the p/code-structure branch from 3c3d9b0 to c7d9721 Compare April 7, 2026 12:31

Yradex approved these changes Apr 8, 2026

View reviewed changes

HuJean merged commit 338dc1c into main Apr 8, 2026
49 of 50 checks passed

HuJean deleted the p/code-structure branch April 8, 2026 02:42

coderabbitai bot mentioned this pull request Apr 9, 2026

feat: simplify implement of hooks for main-thread runtime #2441

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: code structure of runtime#2436

refactor: code structure of runtime#2436
HuJean merged 1 commit intomainfrom
p/code-structure

HuJean commented Apr 7, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 7, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

codecov bot commented Apr 7, 2026

Uh oh!

codspeed-hq bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

relativeci bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

relativeci bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

relativeci bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

relativeci bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

HuJean commented Apr 7, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Checklist

Uh oh!

changeset-bot bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

codecov bot commented Apr 7, 2026

Codecov Report

Uh oh!

codspeed-hq bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 25.46%

Performance Changes

Footnotes

Uh oh!

relativeci bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#7133 Bundle Size — 236.8KiB (-0.02%).

Uh oh!

relativeci bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#266 Bundle Size — 206.05KiB (0%).

Uh oh!

relativeci bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#8708 Bundle Size — 728.84KiB (0%).

Uh oh!

relativeci bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React External

#252 Bundle Size — 590.6KiB (~+0.01%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HuJean commented Apr 7, 2026 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Apr 7, 2026 •

edited

Loading

coderabbitai bot commented Apr 7, 2026 •

edited

Loading

codspeed-hq bot commented Apr 7, 2026 •

edited

Loading

relativeci bot commented Apr 7, 2026 •

edited

Loading

relativeci bot commented Apr 7, 2026 •

edited

Loading

relativeci bot commented Apr 7, 2026 •

edited

Loading

relativeci bot commented Apr 7, 2026 •

edited

Loading