Skip to content

fix(create-rspeedy): use correct source#2427

Merged
colinaaa merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0407/cra-skill
Apr 7, 2026
Merged

fix(create-rspeedy): use correct source#2427
colinaaa merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0407/cra-skill

Conversation

@colinaaa
Copy link
Copy Markdown
Collaborator

@colinaaa colinaaa commented Apr 7, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an error occurring when installing the Lynx DevTool skill during project scaffolding.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 7, 2026

🦋 Changeset detected

Latest commit: e72a4f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
create-rspeedy Patch
@lynx-js/rspeedy Patch
upgrade-rspeedy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6e7bb1c7-d7f4-4f4f-a5ed-8d750f049f53

📥 Commits

Reviewing files that changed from the base of the PR and between 55602e2 and e72a4f3.

📒 Files selected for processing (3)
  • .changeset/fruity-rules-agree.md
  • .github/workflows/test.yml
  • packages/rspeedy/create-rspeedy/src/index.ts

📝 Walkthrough

Walkthrough

This PR fixes an installation error with the Lynx DevTool skill in create-rspeedy by reformatting the skill configuration from an array-based structure to a source/value pair format, adding test coverage for the skill installation, and releasing a patch version.

Changes

Cohort / File(s) Summary
Lynx DevTool Skill Configuration
packages/rspeedy/create-rspeedy/src/index.ts
Refactored the extraSkills configuration for "Lynx DevTool" from skills: ['lynx-community/skills/lynx-devtool'] to source: 'lynx-community/skills' and value: 'lynx-devtool', restructuring how the skill identifier is specified.
Test Coverage
.github/workflows/test.yml
Extended the test-publish workflow to include --skill lynx-devtool when scaffolding the create-rspeedy-regression test project.
Release Metadata
.changeset/fruity-rules-agree.md
Added changeset entry marking create-rspeedy for a patch release with message addressing the Lynx DevTool skill installation error fix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • upupming
  • luhc228

Poem

🐰 A skill that stumbled, now stands tall,
From lynx-community, we heed the call,
Source and value, a cleaner way,
DevTools shine bright, hip-hip-hooray! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing the Lynx DevTool skill configuration by updating the source specification in create-rspeedy from an inline skills array to a source/value format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/rspeedy/create-rspeedy/src/index.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e72a4f3f7f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pnpm --recursive publish --no-git-checks --access public --registry=http://localhost:4873
cd `mktemp -d`
npx --registry http://localhost:4873 create-rspeedy-canary@latest --template react --dir create-rspeedy-regression --tools eslint
npx --registry http://localhost:4873 create-rspeedy-canary@latest --template react --dir create-rspeedy-regression --tools eslint --skill lynx-devtool
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep skill install off the mock npm registry

In .github/workflows/test.yml (test-publish job), adding --skill lynx-devtool to the npx --registry http://localhost:4873 create-rspeedy-canary@latest ... invocation causes create-rspeedy to execute its skill installer path, and create-rstack runs that via npx skills add ... without overriding registry. Because npm_config_registry from the outer npx --registry is inherited by child processes, npx skills is resolved against the mock Verdaccio registry (which only contains the published canary packages), so skill installation fails before the regression project can build/lint.

Useful? React with 👍 / 👎.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 7, 2026

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 21 skipped benchmarks1


Comparing colinaaa:colin/0407/cra-skill (e72a4f3) with main (55602e2)

Open in CodSpeed

Footnotes

  1. 21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci bot commented Apr 7, 2026

React Example

#7086 Bundle Size — 237.81KiB (0%).

e72a4f3(current) vs 55602e2 main#7082(baseline)

Bundle metrics  no changes
                 Current
#7086
     Baseline
#7082
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 180 180
No change  Duplicate Modules 71 71
No change  Duplicate Code 46.39% 46.39%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#7086
     Baseline
#7082
No change  IMG 145.76KiB 145.76KiB
No change  Other 92.05KiB 92.05KiB

Bundle analysis reportBranch colinaaa:colin/0407/cra-skillProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci bot commented Apr 7, 2026

React MTF Example

#219 Bundle Size — 207.38KiB (0%).

e72a4f3(current) vs 55602e2 main#215(baseline)

Bundle metrics  no changes
                 Current
#219
     Baseline
#215
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 3 3
No change  Modules 174 174
No change  Duplicate Modules 68 68
No change  Duplicate Code 46.08% 46.08%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#219
     Baseline
#215
No change  IMG 111.23KiB 111.23KiB
No change  Other 96.15KiB 96.15KiB

Bundle analysis reportBranch colinaaa:colin/0407/cra-skillProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci bot commented Apr 7, 2026

Web Explorer

#8661 Bundle Size — 728.84KiB (0%).

e72a4f3(current) vs 55602e2 main#8657(baseline)

Bundle metrics  Change 2 changes
                 Current
#8661
     Baseline
#8657
No change  Initial JS 43.31KiB 43.31KiB
No change  Initial CSS 2.16KiB 2.16KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 10 10
Change  Modules 148(-0.67%) 149
No change  Duplicate Modules 11 11
Change  Duplicate Code 34.7%(+0.06%) 34.68%
No change  Packages 3 3
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#8661
     Baseline
#8657
No change  Other 384.62KiB 384.62KiB
No change  JS 342.07KiB 342.07KiB
No change  CSS 2.16KiB 2.16KiB

Bundle analysis reportBranch colinaaa:colin/0407/cra-skillProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci bot commented Apr 7, 2026

React External

#205 Bundle Size — 591.44KiB (0%).

e72a4f3(current) vs 55602e2 main#201(baseline)

Bundle metrics  no changes
                 Current
#205
     Baseline
#201
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 3 3
No change  Modules 17 17
No change  Duplicate Modules 5 5
No change  Duplicate Code 8.59% 8.59%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#205
     Baseline
#201
No change  Other 591.44KiB 591.44KiB

Bundle analysis reportBranch colinaaa:colin/0407/cra-skillProject dashboard


Generated by RelativeCIDocumentationReport issue

@colinaaa colinaaa merged commit 8c0e483 into lynx-family:main Apr 7, 2026
48 of 50 checks passed
@colinaaa colinaaa deleted the colin/0407/cra-skill branch April 7, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant