fix(create-rspeedy): use correct source#2427
Conversation
🦋 Changeset detectedLatest commit: e72a4f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR fixes an installation error with the Lynx DevTool skill in create-rspeedy by reformatting the skill configuration from an array-based structure to a source/value pair format, adding test coverage for the skill installation, and releasing a patch version. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e72a4f3f7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pnpm --recursive publish --no-git-checks --access public --registry=http://localhost:4873 | ||
| cd `mktemp -d` | ||
| npx --registry http://localhost:4873 create-rspeedy-canary@latest --template react --dir create-rspeedy-regression --tools eslint | ||
| npx --registry http://localhost:4873 create-rspeedy-canary@latest --template react --dir create-rspeedy-regression --tools eslint --skill lynx-devtool |
There was a problem hiding this comment.
Keep skill install off the mock npm registry
In .github/workflows/test.yml (test-publish job), adding --skill lynx-devtool to the npx --registry http://localhost:4873 create-rspeedy-canary@latest ... invocation causes create-rspeedy to execute its skill installer path, and create-rstack runs that via npx skills add ... without overriding registry. Because npm_config_registry from the outer npx --registry is inherited by child processes, npx skills is resolved against the mock Verdaccio registry (which only contains the published canary packages), so skill installation fails before the regression project can build/lint.
Useful? React with 👍 / 👎.
Merging this PR will not alter performance
Comparing Footnotes
|
React Example#7086 Bundle Size — 237.81KiB (0%).e72a4f3(current) vs 55602e2 main#7082(baseline) Bundle metrics
|
| Current #7086 |
Baseline #7082 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
4 |
4 |
|
180 |
180 |
|
71 |
71 |
|
46.39% |
46.39% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #7086 |
Baseline #7082 |
|
|---|---|---|
145.76KiB |
145.76KiB |
|
92.05KiB |
92.05KiB |
Bundle analysis report Branch colinaaa:colin/0407/cra-skill Project dashboard
Generated by RelativeCI Documentation Report issue
React MTF Example#219 Bundle Size — 207.38KiB (0%).e72a4f3(current) vs 55602e2 main#215(baseline) Bundle metrics
|
| Current #219 |
Baseline #215 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
3 |
3 |
|
174 |
174 |
|
68 |
68 |
|
46.08% |
46.08% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #219 |
Baseline #215 |
|
|---|---|---|
111.23KiB |
111.23KiB |
|
96.15KiB |
96.15KiB |
Bundle analysis report Branch colinaaa:colin/0407/cra-skill Project dashboard
Generated by RelativeCI Documentation Report issue
Web Explorer#8661 Bundle Size — 728.84KiB (0%).e72a4f3(current) vs 55602e2 main#8657(baseline) Bundle metrics
Bundle size by type
|
| Current #8661 |
Baseline #8657 |
|
|---|---|---|
384.62KiB |
384.62KiB |
|
342.07KiB |
342.07KiB |
|
2.16KiB |
2.16KiB |
Bundle analysis report Branch colinaaa:colin/0407/cra-skill Project dashboard
Generated by RelativeCI Documentation Report issue
React External#205 Bundle Size — 591.44KiB (0%).e72a4f3(current) vs 55602e2 main#201(baseline) Bundle metrics
|
| Current #205 |
Baseline #201 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
3 |
3 |
|
17 |
17 |
|
5 |
5 |
|
8.59% |
8.59% |
|
0 |
0 |
|
0 |
0 |
Bundle analysis report Branch colinaaa:colin/0407/cra-skill Project dashboard
Generated by RelativeCI Documentation Report issue
Summary by CodeRabbit
Checklist