refactor(runtime): export vnode constants from internal by HuJean · Pull Request #2415 · lynx-family/lynx-stack

HuJean · 2026-04-03T03:52:52Z

Summary by CodeRabbit

Refactor
- Updated internal React runtime data structures for improved encapsulation and maintainability.
- Optimized internal property handling within the React rendering system.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2026-04-03T03:53:00Z

🦋 Changeset detected

Latest commit: 0259d2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-04-03T03:53:08Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d148cbf7-be32-4d4b-81f6-61323dc8bf4f

📥 Commits

Reviewing files that changed from the base of the PR and between 44b966c and 0259d2c.

📒 Files selected for processing (5)

.changeset/tall-taxis-laugh.md
packages/react/runtime/lazy/internal.js
packages/react/runtime/lepus/jsx-runtime/index.js
packages/react/runtime/src/internal.ts
packages/react/runtime/src/renderToOpcodes/constants.ts

📝 Walkthrough

Walkthrough

The pull request introduces symbol-keyed properties for VNode internal fields across the React runtime. Constants INDEX and FLAGS are added, symbol identifiers are exported through multiple modules, and fixed property names in the JSX runtime are replaced with computed symbol-keyed properties while preserving initialization semantics.

Changes

Cohort / File(s)	Summary
Changeset `.changeset/tall-taxis-laugh.md`	Empty frontmatter changeset file added.
Symbol Constants Definition `packages/react/runtime/src/renderToOpcodes/constants.ts`	Added two new property constants: `INDEX = '__i'` and `FLAGS = '__u'`.
Symbol Exports and Re-exports `packages/react/runtime/lazy/internal.js`, `packages/react/runtime/src/internal.ts`	Added exports and re-exports of symbol identifiers (`CHILDREN`, `COMPONENT`, `DIFF`, `DIRTY`, `DOM`, `FLAGS`, `INDEX`, `PARENT`) from internal module surfaces.
VNode Field Refactoring `packages/react/runtime/lepus/jsx-runtime/index.js`	Renamed fixed property names (`__k`, `__`, `__b`, `__e`, `__d`, `__c`, `__i`, `__u`) to symbol-keyed properties (`[CHILDREN]`, `[PARENT]`, `[DIFF]`, `[DOM]`, `[DIRTY]`, `[COMPONENT]`, `[INDEX]`, `[FLAGS]`) with preserved initialization semantics.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

framework:React

Suggested reviewers

Yradex
hzy

Poem

🐰 With symbols bold we hop along,
Old property names now changed to song—
__k and friends in new attire,
Symbol-keyed, the fields now fire!
A refactor swift, with constants true. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: exporting vnode constants from the internal module, which is reflected across multiple files in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/runtime-vnode-constants

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-04-03T03:55:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-04-03T04:07:29Z

Merging this PR will degrade performance by 14.83%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 70 untouched benchmarks
⏩ 21 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`002-hello-reactLynx-destroyBackground`	930.3 µs	679.3 µs	+36.95%
❌	`transform 1000 view elements`	40.3 ms	47.3 ms	-14.83%

_{Comparing chore/runtime-vnode-constants (0259d2c) with main (44b966c)}

21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-04-03T04:10:27Z

React MTF Example

#184 Bundle Size — 207.38KiB (0%).

0259d2c(current) vs 44b966c main#178(baseline)

Bundle metrics

1 change

	Current #184	Baseline #178
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`46.36%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`174`	`174`
Duplicate Modules	`68`	`68`
Duplicate Code	`46.08%`(`-0.02%`)	`46.09%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #184	Baseline #178
IMG	`111.23KiB`	`111.23KiB`
Other	`96.15KiB`	`96.15KiB`

Bundle analysis report Branch chore/runtime-vnode-constants Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-03T04:10:29Z

React Example

#7052 Bundle Size — 237.81KiB (0%).

0259d2c(current) vs 44b966c main#7046(baseline)

Bundle metrics

1 change

	Current #7052	Baseline #7046
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`38.7%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`180`	`180`
Duplicate Modules	`71`	`71`
Duplicate Code	`46.39%`(`-0.02%`)	`46.4%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7052	Baseline #7046
IMG	`145.76KiB`	`145.76KiB`
Other	`92.05KiB`	`92.05KiB`

Bundle analysis report Branch chore/runtime-vnode-constants Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-03T04:10:29Z

React External

#170 Bundle Size — 591.44KiB (+0.08%).

0259d2c(current) vs 44b966c main#164(baseline)

Bundle metrics no changes

	Current #170	Baseline #164
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`30.97%`	`30.97%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #170	Baseline #164
Other	`591.44KiB` (`+0.08%`)	`590.96KiB`

Bundle analysis report Branch chore/runtime-vnode-constants Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-03T04:10:30Z

Web Explorer

#8627 Bundle Size — 728.84KiB (0%).

0259d2c(current) vs 44b966c main#8621(baseline)

Bundle metrics no changes

	Current #8627	Baseline #8621
Initial JS	`43.31KiB`	`43.31KiB`
Initial CSS	`2.16KiB`	`2.16KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`10`	`10`
Modules	`150`	`150`
Duplicate Modules	`11`	`11`
Duplicate Code	`34.68%`	`34.68%`
Packages	`3`	`3`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #8627	Baseline #8621
Other	`384.62KiB`	`384.62KiB`
JS	`342.07KiB`	`342.07KiB`
CSS	`2.16KiB`	`2.16KiB`

Bundle analysis report Branch chore/runtime-vnode-constants Project dashboard

^{Generated by RelativeCI Documentation Report issue}

Yradex

Is a 0.5 KB increase in the React externals example bundle size expected?

refactor(runtime): export vnode constants from internal

0259d2c

HuJean requested review from Yradex and hzy as code owners April 3, 2026 03:52

coderabbitai bot added the framework:React label Apr 3, 2026

upupming approved these changes Apr 3, 2026

View reviewed changes

Yradex approved these changes Apr 3, 2026

View reviewed changes

Yradex reviewed Apr 3, 2026

View reviewed changes

HuJean merged commit 7cb10db into main Apr 3, 2026
78 of 80 checks passed

HuJean deleted the chore/runtime-vnode-constants branch April 3, 2026 06:02

coderabbitai bot mentioned this pull request Apr 11, 2026

feat: export constants in @lynx-js/react/constants #2451

Closed

3 tasks

Conversation

HuJean commented Apr 3, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot bot commented Apr 3, 2026

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

codecov bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq bot commented Apr 3, 2026

Merging this PR will degrade performance by 14.83%

Performance Changes

Footnotes

Uh oh!

relativeci bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#184 Bundle Size — 207.38KiB (0%).

Uh oh!

relativeci bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#7052 Bundle Size — 237.81KiB (0%).

Uh oh!

relativeci bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React External

#170 Bundle Size — 591.44KiB (+0.08%).

Uh oh!

relativeci bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#8627 Bundle Size — 728.84KiB (0%).

Uh oh!

Yradex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HuJean commented Apr 3, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 3, 2026 •

edited

Loading

codecov bot commented Apr 3, 2026 •

edited

Loading

relativeci bot commented Apr 3, 2026 •

edited

Loading

relativeci bot commented Apr 3, 2026 •

edited

Loading

relativeci bot commented Apr 3, 2026 •

edited

Loading

relativeci bot commented Apr 3, 2026 •

edited

Loading