chore: bump rsdoctor to ~1.5.6 by yifancong · Pull Request #2410 · lynx-family/lynx-stack

yifancong · 2026-03-31T08:32:02Z

Summary by CodeRabbit

Chores
- Loosened rspack plugin version constraints to allow compatible newer 1.5.x releases.
- Added a development-only typing package to improve developer tooling and IDE support.
Refactor
- Made plugin configuration typing explicit and normalized runtime config handling to be more robust at plugin boundaries.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

coderabbitai · 2026-03-31T08:32:16Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Relaxed @rsdoctor/rspack-plugin version constraints in two package.json files, added @rsdoctor/types to devDependencies, replaced a derived plugin-options type with an explicit exported interface, removed an unused import, and added an explicit cast at Rsdoctor plugin instantiation.

Changes

Cohort / File(s)	Summary
Dependency updates `packages/rspeedy/core/package.json`, `packages/web-platform/web-explorer/package.json`	Changed `@rsdoctor/rspack-plugin` from exact `1.2.3` to `~1.5.6`; added `@rsdoctor/types` `~1.5.6` to `packages/rspeedy/core/package.json` devDependencies.
Config type refactor `packages/rspeedy/core/src/config/tools/index.ts`	Removed import of `RsdoctorRspackPlugin`; replaced `RsdoctorRspackPluginOptions` derived from `ConstructorParameters<typeof RsdoctorRspackPlugin>` with an explicit exported `interface RsdoctorRspackPluginOptions` (optional keys, `linter` sub-object, index signature).
Plugin instantiation cast `packages/rspeedy/core/src/plugins/rsdoctor.plugin.ts`	Changed instantiation to pass a merged config cast as `unknown as ConstructorParameters<typeof RsdoctorRspackPlugin<[]>>[0]` into `new RsdoctorRspackPlugin(...)`; no control-flow changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

PupilTong
upupming
colinaaa

Poem

🐰 I nudged a version, hopped through some lines,
I shaped a type and left the import behind.
A gentle cast, configs tucked in place,
builds keep humming at a tidier pace. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: bump rsdoctor to ~1.5.6' clearly and concisely summarizes the main change: updating the rsdoctor dependency to version ~1.5.6 across multiple package files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

changeset-bot · 2026-03-31T08:32:16Z

🦋 Changeset detected

Latest commit: 741ee95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@lynx-js/rspeedy	Patch
@lynx-js/web-explorer	Patch
create-rspeedy	Patch
upgrade-rspeedy	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/rspeedy/core/package.json`:
- Line 64: Dependency version for "@rsdoctor/rspack-plugin" is inconsistent
across packages; update the declaration in packages/rspeedy/core/package.json
(where it currently reads "~1.5.0") to match the other package's range (use
"^1.5.6") so both manifest minimums and ranges align with
packages/web-platform/web-explorer/package.json; modify only the value for the
"@rsdoctor/rspack-plugin" entry and run install to refresh the lockfile.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 625e7ff1-69e5-4f5a-b520-37c2b24d387f

📥 Commits

Reviewing files that changed from the base of the PR and between 0f9d14b and 6df3270.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

packages/rspeedy/core/package.json
packages/web-platform/web-explorer/package.json

Copilot

Pull request overview

Updates the repo’s Rsdoctor integration by bumping @rsdoctor/rspack-plugin from 1.2.3 to the 1.5.x line, updating workspace manifests and the pnpm lockfile to match.

Changes:

Bump @rsdoctor/rspack-plugin in workspace package.json files.
Update pnpm-lock.yaml to resolve @rsdoctor/* packages to 1.5.6 and refresh related transitive dependencies.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File	Description
pnpm-lock.yaml	Lockfile refreshed for rsdoctor `1.5.6`, pulling in new/updated transitive dependencies (including some downgrades).
packages/web-platform/web-explorer/package.json	Updates `@rsdoctor/rspack-plugin` devDependency to `^1.5.6`.
packages/rspeedy/core/package.json	Updates `@rsdoctor/rspack-plugin` dependency to `~1.5.0` (resolves to `1.5.6` via lockfile).

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-03-31T08:42:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codspeed-hq · 2026-04-14T06:56:56Z

Merging this PR will degrade performance by 43.02%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 78 untouched benchmarks
⏩ 21 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`transform 1000 view elements`	47.6 ms	43.9 ms	+8.38%
⚡	`basic-performance-scroll-view-100`	8.6 ms	8 ms	+6.88%
❌	`basic-performance-text-200`	11.8 ms	20.8 ms	-43.02%

_{Comparing yifancong:chore/update-rsdoctor (741ee95) with main (7332eb4)}

21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-04-14T06:58:57Z

React Example

#7289 Bundle Size — 223.58KiB (0%).

741ee95(current) vs 7332eb4 main#7283(baseline)

Bundle metrics no changes

	Current #7289	Baseline #7283
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`179`	`179`
Duplicate Modules	`70`	`70`
Duplicate Code	`45.76%`	`45.76%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7289	Baseline #7283
IMG	`145.76KiB`	`145.76KiB`
Other	`77.82KiB`	`77.82KiB`

Bundle analysis report Branch yifancong:chore/update-rsdoctor Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-14T06:59:01Z

React MTF Example

#422 Bundle Size — 192.85KiB (0%).

741ee95(current) vs 7332eb4 main#416(baseline)

Bundle metrics no changes

	Current #422	Baseline #416
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`173`	`173`
Duplicate Modules	`67`	`67`
Duplicate Code	`45.36%`	`45.36%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #422	Baseline #416
IMG	`111.23KiB`	`111.23KiB`
Other	`81.61KiB`	`81.61KiB`

Bundle analysis report Branch yifancong:chore/update-rsdoctor Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-14T06:59:16Z

Web Explorer

#8863 Bundle Size — 749.3KiB (0%).

741ee95(current) vs 7332eb4 main#8857(baseline)

Bundle metrics

1 change

	Current #8863	Baseline #8857
Initial JS	`44.45KiB`	`44.45KiB`
Initial CSS	`2.16KiB`	`2.16KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`10`	`10`
Modules	`149`(`-0.67%`)	`150`
Duplicate Modules	`11`	`11`
Duplicate Code	`35%`	`35%`
Packages	`3`	`3`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #8863	Baseline #8857
Other	`401.63KiB`	`401.63KiB`
JS	`345.51KiB`	`345.51KiB`
CSS	`2.16KiB`	`2.16KiB`

Bundle analysis report Branch yifancong:chore/update-rsdoctor Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-14T07:01:05Z

React External

#407 Bundle Size — 582.81KiB (0%).

741ee95(current) vs 7332eb4 main#401(baseline)

Bundle metrics no changes

	Current #407	Baseline #401
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #407	Baseline #401
Other	`582.81KiB`	`582.81KiB`

Bundle analysis report Branch yifancong:chore/update-rsdoctor Project dashboard

^{Generated by RelativeCI Documentation Report issue}

chore: update rsdoctor update rsdoctor to 1.5.6 update rsdoctor to 1.5.6 update rsdoctor to 1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6 chore: bump rsdoctor to ~1.5.6

yifancong requested a review from colinaaa as a code owner March 31, 2026 08:32

Copilot AI review requested due to automatic review settings March 31, 2026 08:32

yifancong requested review from PupilTong, Sherry-hue, luhc228 and upupming as code owners March 31, 2026 08:32

Copilot started reviewing on behalf of yifancong March 31, 2026 08:32 View session

coderabbitai bot added the platform:Web label Mar 31, 2026

coderabbitai bot reviewed Mar 31, 2026

View reviewed changes

Comment thread packages/rspeedy/core/package.json Outdated

Copilot AI reviewed Mar 31, 2026

View reviewed changes

Comment thread packages/rspeedy/core/package.json

Comment thread packages/web-platform/web-explorer/package.json Outdated

Comment thread pnpm-lock.yaml Outdated

yifancong force-pushed the chore/update-rsdoctor branch 2 times, most recently from 22d876f to 011e615 Compare April 14, 2026 04:47

yifancong requested a review from Copilot April 14, 2026 04:54

Copilot started reviewing on behalf of yifancong April 14, 2026 04:55 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread packages/rspeedy/core/src/config/tools/index.ts Outdated

yifancong force-pushed the chore/update-rsdoctor branch from c86dc42 to 674f4f2 Compare April 14, 2026 08:41

yifancong force-pushed the chore/update-rsdoctor branch from 52edf27 to e0bb47e Compare April 14, 2026 08:58

yifancong added 2 commits April 14, 2026 17:07

chore: bump rsdoctor to ~1.5.6

2e62a6e

chore: bump rsdoctor to ~1.5.6

b5018ee

yifancong requested a review from gaoachao as a code owner April 14, 2026 09:32

chore: bump rsdoctor to ~1.5.6

741ee95

colinaaa approved these changes Apr 14, 2026

View reviewed changes

yifancong enabled auto-merge (squash) April 14, 2026 11:54

gaoachao approved these changes Apr 14, 2026

View reviewed changes

colinaaa disabled auto-merge April 14, 2026 14:26

Conversation

yifancong commented Mar 31, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

coderabbitai bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

changeset-bot bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

codspeed-hq bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 43.02%

Performance Changes

Footnotes

Uh oh!

relativeci bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#7289 Bundle Size — 223.58KiB (0%).

Uh oh!

relativeci bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#422 Bundle Size — 192.85KiB (0%).

Uh oh!

relativeci bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#8863 Bundle Size — 749.3KiB (0%).

Uh oh!

relativeci bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React External

#407 Bundle Size — 582.81KiB (0%).

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yifancong commented Mar 31, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 31, 2026 •

edited

Loading

changeset-bot bot commented Mar 31, 2026 •

edited

Loading

codecov bot commented Mar 31, 2026 •

edited

Loading

codspeed-hq bot commented Apr 14, 2026 •

edited

Loading

relativeci bot commented Apr 14, 2026 •

edited

Loading

relativeci bot commented Apr 14, 2026 •

edited

Loading

relativeci bot commented Apr 14, 2026 •

edited

Loading

relativeci bot commented Apr 14, 2026 •

edited

Loading