Skip to content

chore: fix web-core coverage report#2378

Merged
PupilTong merged 1 commit intolynx-family:mainfrom
PupilTong:p/hw/fix-coverage-report
Mar 26, 2026
Merged

chore: fix web-core coverage report#2378
PupilTong merged 1 commit intolynx-family:mainfrom
PupilTong:p/hw/fix-coverage-report

Conversation

@PupilTong
Copy link
Copy Markdown
Collaborator

@PupilTong PupilTong commented Mar 26, 2026

Summary by CodeRabbit

  • Chores
    • Enhanced continuous integration configuration to automatically collect test coverage metrics during the automated testing pipeline.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@PupilTong PupilTong self-assigned this Mar 26, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026

⚠️ No Changeset found

Latest commit: 914b106

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@PupilTong PupilTong requested a review from colinaaa March 26, 2026 04:37
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

📝 Walkthrough

Walkthrough

The pull request adds a PNPM command to the web-core-e2e CI job in the test workflow. After Playwright tests complete and the JUnit report is generated, the workflow now additionally runs pnpm --filter @lynx-js/web-core-e2e run coverage:ci to collect code coverage metrics.

Changes

Cohort / File(s) Summary
CI Workflow Enhancement
.github/workflows/test.yml
Added coverage collection step (pnpm --filter @lynx-js/web-core-e2e run coverage:ci) to run immediately after Playwright tests in the web-core-e2e job.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

platform:Web

Suggested reviewers

  • Sherry-hue
  • colinaaa

Poem

🐰 A coverage command hops into place,
After tests sprint through the race,
PNPM gathers metrics with care,
Web-core's health? Now crystal clear! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a coverage collection step to the web-core E2E test workflow to fix coverage report generation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
4685 4 4681 77
View the top 3 failed test(s) by shortest run time
packages/rspeedy/plugin-react/test/config.test.ts > Config > transform configs > minify should remove thread-specific pure funcs from built outputs
Stack Traces | 0.124s run time
AssertionError: expected main-thread and background outputs to exist
 ❯ test/config.test.ts:2141:16
tests/lynx.spec.ts > kitten-lynx testing framework > can click
Stack Traces | 5.01s run time
Error: No response found for deviceId: emulator-5554 port: 8901
 ❯ Connector.#sendMessageWithTransport ../...../devtool-connector/src/index.ts:433:11
 ❯ Connector.sendCDPMessage ../...../devtool-connector/src/index.ts:210:12
 ❯ CDPChannel.send src/CDPChannel.ts:158:12
 ❯ KittenLynxView.locator src/KittenLynxView.ts:257:24
 ❯ tests/lynx.spec.ts:88:24
tests/lynx.spec.ts > kitten-lynx testing framework > can fetch computed style map of an element
Stack Traces | 5.01s run time
Error: No response found for deviceId: emulator-5554 port: 8901
 ❯ Connector.#sendMessageWithTransport ../...../devtool-connector/src/index.ts:433:11
 ❯ Connector.sendCDPMessage ../...../devtool-connector/src/index.ts:210:12
 ❯ CDPChannel.send src/CDPChannel.ts:158:12
 ❯ KittenLynxView.locator src/KittenLynxView.ts:257:24
 ❯ tests/lynx.spec.ts:77:26
tests/lynx.spec.ts > kitten-lynx testing framework > can get attributes from an element
Stack Traces | 5.01s run time
Error: No response found for deviceId: emulator-5554 port: 8901
 ❯ Connector.#sendMessageWithTransport ../...../devtool-connector/src/index.ts:433:11
 ❯ Connector.sendCDPMessage ../...../devtool-connector/src/index.ts:210:12
 ❯ CDPChannel.send src/CDPChannel.ts:158:12
 ❯ ElementNode.getAttribute src/ElementNode.ts:125:17
 ❯ tests/lynx.spec.ts:68:25
tests/lynx.spec.ts > kitten-lynx testing framework > can take a screenshot
Stack Traces | 50s run time
Error: Test timed out in 50000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
 ❯ tests/lynx.spec.ts:100:3

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 26, 2026

Merging this PR will degrade performance by 6.31%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 61 untouched benchmarks
⏩ 21 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
transform 1000 view elements 44.9 ms 40.4 ms +11.27%
basic-performance-scroll-view-100 8.4 ms 8.9 ms -6.31%

Comparing PupilTong:p/hw/fix-coverage-report (914b106) with main (d162bda)

Open in CodSpeed

Footnotes

  1. 21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci bot commented Mar 26, 2026

Web Explorer

#8429 Bundle Size — 724.73KiB (0%).

914b106(current) vs 6d71e3e main#8428(baseline)

Bundle metrics  no changes
                 Current
#8429
     Baseline
#8428
No change  Initial JS 41.99KiB 41.99KiB
No change  Initial CSS 1.99KiB 1.99KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 10 10
No change  Modules 149 149
No change  Duplicate Modules 11 11
No change  Duplicate Code 34.75% 34.75%
No change  Packages 3 3
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#8429
     Baseline
#8428
No change  Other 382.38KiB 382.38KiB
No change  JS 340.36KiB 340.36KiB
No change  CSS 1.99KiB 1.99KiB

Bundle analysis reportBranch PupilTong:p/hw/fix-coverage-repo...Project dashboard


Generated by RelativeCIDocumentationReport issue

@PupilTong PupilTong enabled auto-merge (squash) March 26, 2026 06:15
@PupilTong PupilTong merged commit cadd332 into lynx-family:main Mar 26, 2026
66 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants