fix: avoid ref lint failures in create-rspeedy flappy templates#2344
fix: avoid ref lint failures in create-rspeedy flappy templates#2344
Conversation
🦋 Changeset detectedLatest commit: 48e8fe7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis pull request standardizes engine reference initialization across multiple template files by replacing falsy checks with explicit null/undefined checks in useFlappy hooks. Additionally, it includes minor test snapshot formatting adjustments and a new changeset file entry. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Merging this PR will degrade performance by 7.89%
Performance Changes
Comparing Footnotes
|
Web Explorer#8199 Bundle Size — 385.21KiB (0%).48e8fe7(current) vs 2efecc2 main#8186(baseline) Bundle metrics
Bundle size by type
|
| Current #8199 |
Baseline #8186 |
|
|---|---|---|
254.26KiB |
254.26KiB |
|
95.85KiB |
95.85KiB |
|
35.1KiB |
35.1KiB |
Bundle analysis report Branch codex/create-rspeedy-useflappy-r... Project dashboard
Generated by RelativeCI Documentation Report issue
Summary
Fix CI error: https://github.com/lynx-family/lynx-stack/actions/runs/23188569941/job/67379679533?pr=2343
create-rspeedyflappy templates to initialize the engine ref withengineRef.current == nullreact-hooks/refsCI failure in scaffolded apps generated from the React templatesChecklist
Summary by CodeRabbit
Refactor
Tests