feat(react-externals): automate bundle serving and fix typings#2331
Merged
feat(react-externals): automate bundle serving and fix typings#2331
Conversation
🦋 Changeset detectedLatest commit: 71c50f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds a new workspace package Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
upupming
force-pushed
the
fix-react-externals-umd-setup
branch
2 times, most recently
from
d12464d to
f0eecdb
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
examples/react-externals/package.json (1)
10-12: Keep a dev-only ReactLynx build path for local iteration.
examples/react-externals/lynx.config.tsonly servespackages/react-umd/dist/react-dev.lynx.bundle, butbuild:reactlynxnow runs the full package build and generates the production bundle too. Restoring abuild:reactlynx:devalias, or pointing the local docs/scripts at@lynx-js/react-umd build:development, would avoid the extra production build in the normal dev loop.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@examples/react-externals/package.json` around lines 10 - 12, Add a dev-only script so local iteration doesn't trigger the production bundle: keep the existing "build:reactlynx" but add a new script "build:reactlynx:dev" (or similar) that runs the package build in development mode for `@lynx-js/react-umd` (the same mode that produces packages/react-umd/dist/react-dev.lynx.bundle) and update any local docs/dev tooling that references packages/react-umd/dist/react-dev.lynx.bundle or lynx.config.ts to use this dev script instead of the full production build.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@examples/react-externals/lynx.config.ts`:
- Around line 41-71: The current route handlers for /react.lynx.bundle and
/comp-lib.lynx.bundle are registered only inside dev.setupMiddlewares
(dev.setupMiddlewares) so they won't run during rspeedy preview; move the
file-serving logic out of dev.setupMiddlewares and register it at a top-level
server middleware that runs for both dev and preview (or duplicate the same
middleware into the preview server config), ensuring the same checks for
fs.existsSync, Content-Type and Access-Control headers and streaming via
fs.createReadStream are preserved for the routes /react.lynx.bundle and
/comp-lib.lynx.bundle so preview can access the bundles.
In `@packages/react-umd/package.json`:
- Around line 33-35: The "build:development" npm script uses POSIX-only syntax
("NODE_ENV=development rslib build"); update the script named
"build:development" in package.json to use cross-env (e.g., "cross-env
NODE_ENV=development rslib build") so it runs on Windows and POSIX, and ensure
"cross-env" is present in devDependencies so the script can run in CI and
locally.
In `@packages/react-umd/README.md`:
- Line 29: Update the README line that mentions using
`@lynx-js/external-bundle-rsbuild-plugin` to reference the correct config file
extension: replace `lynx.config.js` with `lynx.config.ts` (or change to a
generic phrase like "your Lynx config file") so it matches the TypeScript
examples in this PR and avoids confusion when mapping `@lynx-js/react` and its
internal modules to the UMD bundle URL.
---
Nitpick comments:
In `@examples/react-externals/package.json`:
- Around line 10-12: Add a dev-only script so local iteration doesn't trigger
the production bundle: keep the existing "build:reactlynx" but add a new script
"build:reactlynx:dev" (or similar) that runs the package build in development
mode for `@lynx-js/react-umd` (the same mode that produces
packages/react-umd/dist/react-dev.lynx.bundle) and update any local docs/dev
tooling that references packages/react-umd/dist/react-dev.lynx.bundle or
lynx.config.ts to use this dev script instead of the full production build.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 351f4138-8fdc-4e5a-8686-b4e6d1393120
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (10)
.changeset/react-externals-setup-umd.mdexamples/react-externals/README.mdexamples/react-externals/lynx.config.tsexamples/react-externals/package.jsonexamples/react-externals/tsconfig.jsonpackages/react-umd/README.mdpackages/react-umd/package.jsonpackages/react-umd/rslib.config.tspackages/react-umd/src/index.tspnpm-workspace.yaml
upupming
force-pushed
the
fix-react-externals-umd-setup
branch
from
f0eecdb to
b71fc52
Compare
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (2)
packages/react-umd/package.json (1)
33-41:⚠️ Potential issue | 🟠 MajorMake
build:developmentcross-platform.
NODE_ENV=development rslib buildis still POSIX-only, sopnpm --filter@lynx-js/react-umdbuildwill fail on Windows before the dev bundle is emitted. Switch this script tocross-envand declare it locally.Proposed fix
"scripts": { "build": "rimraf dist && pnpm build:development && pnpm build:production", - "build:development": "NODE_ENV=development rslib build", + "build:development": "cross-env NODE_ENV=development rslib build", "build:production": "rslib build" }, "devDependencies": { "@lynx-js/lynx-bundle-rslib-config": "workspace:*", "@lynx-js/react": "workspace:*", "@lynx-js/react-rsbuild-plugin": "workspace:*", + "cross-env": "^7.0.3", "rimraf": "^6.1.3" }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/react-umd/package.json` around lines 33 - 41, The build script "build:development" in package.json uses a POSIX-only env prefix (NODE_ENV=development rslib build); change it to use cross-env by adding "cross-env" to devDependencies and update the "build:development" script to run via cross-env (e.g., cross-env NODE_ENV=development rslib build) so the script is cross-platform; ensure "cross-env" is declared in devDependencies alongside existing entries so pnpm --filter `@lynx-js/react-umd` build works on Windows.examples/react-externals/lynx.config.ts (1)
41-80:⚠️ Potential issue | 🟠 Major
previewstill won't serve these bundles.These routes are registered only under
dev.setupMiddlewares, sorspeedy previewdoes not expose/react.lynx.bundleor/comp-lib.lynx.bundle. That leaves the new preview flow broken unless the serving logic moves to a hook that also runs in preview, or the script is removed.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@examples/react-externals/lynx.config.ts` around lines 41 - 80, The middleware that serves /react.lynx.bundle and /comp-lib.lynx.bundle is only registered in api.modifyRsbuildConfig under dev.setupMiddlewares, so rspeedy preview won't expose those routes; move or duplicate this serving logic into the preview server hook (so preview also registers the same handlers) or remove the script. Concretely, take the middleware function that checks req.url for '/react.lynx.bundle' and '/comp-lib.lynx.bundle' (the closure added in dev.setupMiddlewares via api.modifyRsbuildConfig) and register it with the preview server hook your framework provides (e.g., the api.modifyPreviewConfig / preview.setupMiddlewares / onPreviewServer equivalent) so rspeedy preview serves the same bundles. Ensure headers and fs.createReadStream usage are preserved when copying the logic.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@examples/react-externals/lynx.config.ts`:
- Around line 41-80: The middleware that serves /react.lynx.bundle and
/comp-lib.lynx.bundle is only registered in api.modifyRsbuildConfig under
dev.setupMiddlewares, so rspeedy preview won't expose those routes; move or
duplicate this serving logic into the preview server hook (so preview also
registers the same handlers) or remove the script. Concretely, take the
middleware function that checks req.url for '/react.lynx.bundle' and
'/comp-lib.lynx.bundle' (the closure added in dev.setupMiddlewares via
api.modifyRsbuildConfig) and register it with the preview server hook your
framework provides (e.g., the api.modifyPreviewConfig / preview.setupMiddlewares
/ onPreviewServer equivalent) so rspeedy preview serves the same bundles. Ensure
headers and fs.createReadStream usage are preserved when copying the logic.
In `@packages/react-umd/package.json`:
- Around line 33-41: The build script "build:development" in package.json uses a
POSIX-only env prefix (NODE_ENV=development rslib build); change it to use
cross-env by adding "cross-env" to devDependencies and update the
"build:development" script to run via cross-env (e.g., cross-env
NODE_ENV=development rslib build) so the script is cross-platform; ensure
"cross-env" is declared in devDependencies alongside existing entries so pnpm
--filter `@lynx-js/react-umd` build works on Windows.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 85c640c0-5513-400a-bbe5-4ba8ec000c16
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (10)
.changeset/react-externals-setup-umd.mdexamples/react-externals/README.mdexamples/react-externals/lynx.config.tsexamples/react-externals/package.jsonexamples/react-externals/tsconfig.jsonpackages/react-umd/README.mdpackages/react-umd/package.jsonpackages/react-umd/rslib.config.tspackages/react-umd/src/index.tspnpm-workspace.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
- packages/react-umd/rslib.config.ts
- examples/react-externals/tsconfig.json
- packages/react-umd/README.md
- .changeset/react-externals-setup-umd.md
upupming
force-pushed
the
fix-react-externals-umd-setup
branch
4 times, most recently
from
0dfe253 to
b52efbf
Compare
upupming
force-pushed
the
fix-react-externals-umd-setup
branch
from
b52efbf to
bd41528
Compare
luhc228
reviewed
Mar 11, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
examples/react-externals/lynx.config.ts (1)
51-62: Bundle filename is hardcoded to development build.The path
react-dev.lynx.bundleis hardcoded, but thepackages/react-umd/rslib.config.tsgenerates different filenames based onNODE_ENV(react-dev.lynx.bundlefor development,react-prod.lynx.bundlefor production). If someone runs this example withNODE_ENV=production, the dev server will fail to find the bundle.Consider making the bundle path environment-aware:
♻️ Proposed fix
if (req.url === '/react.lynx.bundle') { + const bundleName = process.env.NODE_ENV === 'production' + ? 'react-prod.lynx.bundle' + : 'react-dev.lynx.bundle'; const bundlePath = path.resolve( __dirname, - '../../packages/react-umd/dist/react-dev.lynx.bundle', + `../../packages/react-umd/dist/${bundleName}`, );🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@examples/react-externals/lynx.config.ts` around lines 51 - 62, The dev server is hardcoded to serve "react-dev.lynx.bundle" which breaks when NODE_ENV=production; update the bundlePath logic in the request handler (the block that checks if req.url === '/react.lynx.bundle' and defines bundlePath) to choose the filename based on process.env.NODE_ENV (e.g., use "react-prod.lynx.bundle" for production and "react-dev.lynx.bundle" otherwise), and optionally implement a fallback check (or try both names) before streaming the file so the server can find the correct bundle regardless of environment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/react-umd/package.json`:
- Around line 32-43: The package.json scripts "build:development" and
"build:production" call rslib (via "rslib build") but rslib is not declared in
devDependencies; add an explicit devDependency entry for "rslib" (or
"@rslib/core" if you prefer that package name) to the "devDependencies" object
so the tool is installed for isolated builds—e.g., add "rslib":
"<appropriate-version>" under devDependencies alongside "rimraf" and
"cross-env".
---
Nitpick comments:
In `@examples/react-externals/lynx.config.ts`:
- Around line 51-62: The dev server is hardcoded to serve
"react-dev.lynx.bundle" which breaks when NODE_ENV=production; update the
bundlePath logic in the request handler (the block that checks if req.url ===
'/react.lynx.bundle' and defines bundlePath) to choose the filename based on
process.env.NODE_ENV (e.g., use "react-prod.lynx.bundle" for production and
"react-dev.lynx.bundle" otherwise), and optionally implement a fallback check
(or try both names) before streaming the file so the server can find the correct
bundle regardless of environment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: df252c7f-0deb-44cb-a8fe-dd52fa7ba12d
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (10)
.changeset/react-externals-setup-umd.mdexamples/react-externals/README.mdexamples/react-externals/lynx.config.tsexamples/react-externals/package.jsonexamples/react-externals/tsconfig.jsonpackages/react-umd/README.mdpackages/react-umd/package.jsonpackages/react-umd/rslib.config.tspackages/react-umd/src/index.tspnpm-workspace.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
- pnpm-workspace.yaml
- examples/react-externals/tsconfig.json
- examples/react-externals/README.md
- examples/react-externals/package.json
Merging this PR will not alter performance
Comparing 
Footnotes
|
luhc228
previously approved these changes
Mar 11, 2026
Web Explorer#8127 Bundle Size — 384.5KiB (0%).71c50f0(current) vs ed566f0 main#8118(baseline) Bundle metrics
|
| Current #8127 |
Baseline #8118 |
|
|---|---|---|
 Initial JS |
155.59KiB |
155.59KiB |
| Initial CSS |
35.1KiB |
35.1KiB |
| Cache Invalidation |
0% |
0% |
| Chunks |
8 |
8 |
| Assets |
8 |
8 |
 Modules |
238(+0.42%) |
237 |
| Duplicate Modules |
16 |
16 |
| Duplicate Code |
2.98% |
2.98% |
| Packages |
4 |
4 |
| Duplicate Packages |
0 |
0 |
Bundle size by type no changes
| Current #8127 |
Baseline #8118 |
|
|---|---|---|
| JS |
253.55KiB |
253.55KiB |
| Other |
95.85KiB |
95.85KiB |
| CSS |
35.1KiB |
35.1KiB |
Bundle analysis report Branch fix-react-externals-umd-setup Project dashboard
Generated by RelativeCI Documentation Report issue
colinaaa
previously approved these changes
Mar 12, 2026
Unable to generate the performance reportThere was an internal error while processing the run's data. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists. |
luhc228
approved these changes
Mar 12, 2026
colinaaa
pushed a commit
that referenced
this pull request
Mar 24, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/react@0.117.0 ### Minor Changes - feat: export `GlobalPropsProvider`, `GlobalPropsConsumer`, `useGlobalProps` and `useGlobalPropsChanged` for `__globalProps` ([#2346](#2346)) - `GlobalPropsProvider`: A Provider component that accepts `children`. It is used to provide the `lynx.__globalProps` context. - `GlobalPropsConsumer`: A Consumer component that accepts a function as a child. It is used to consume the `lynx.__globalProps` context. - `useGlobalProps`: A hook that returns the `lynx.__globalProps` object. It triggers a re-render when `lynx.__globalProps` changes. - `useGlobalPropsChanged`: A hook that accepts a callback function. The callback is invoked when `lynx.__globalProps` changes. Note: When `globalPropsMode` is not set to `'event'` (default is `'reactive'`), these APIs will be ineffective (pass-through) and will log a warning in development mode, as updates are triggered automatically by full re-render. - **BREAKING CHANGE**: ([#2319](#2319)) Change preact package from `@hongzhiyuan/preact` to `@lynx-js/internal-preact`. Upgrade preact from [f7693b72](preactjs/preact@f7693b7) to [55254ef7](preactjs/preact@55254ef), see diffs at [f7693b72...55254ef7](https://github.com/preactjs/preact/compare/f7693b72ecb4a40c66e6e47f54e2d4edc374c9f0...preactjs:preact:55254ef7021e563cc1a86fb816058964a1b6a29a?expand=1). - feat: add `globalPropsMode` option to `PluginReactLynxOptions` ([#2346](#2346)) - When configured to `"event"`, `updateGlobalProps` will only trigger a global event and skip the `runWithForce` flow. - Defaults to `"reactive"`, which means `updateGlobalProps` will trigger re-render automatically. ### Patch Changes - Add `__BACKGROUND__` guard on `onBackgroundSnapshotInstanceUpdateId` event to prevent bundling to main-thread on dev environment. ([#2332](#2332)) - refactor: extract static string in template literal ([#2334](#2334)) - fix: avoid crash when spread undefined ref ([#2333](#2333)) - Avoid registering lifecycle refs for main-thread functions (MTF) that have not received an `execId` during `renderPage()` first-screen binding. ([#2320](#2320)) ## @lynx-js/react-umd@0.117.0 ### Minor Changes - Add standalone UMD build of the ReactLynx runtime. ([#2331](#2331)) ## @lynx-js/react-rsbuild-plugin@0.13.0 ### Minor Changes - **BREAKING CHANGE**: ([#2319](#2319)) Change preact package from `@hongzhiyuan/preact` to `@lynx-js/internal-preact`. Upgrade preact from [f7693b72](preactjs/preact@f7693b7) to [55254ef7](preactjs/preact@55254ef), see diffs at [f7693b72...55254ef7](https://github.com/preactjs/preact/compare/f7693b72ecb4a40c66e6e47f54e2d4edc374c9f0...preactjs:preact:55254ef7021e563cc1a86fb816058964a1b6a29a?expand=1). - feat: add `globalPropsMode` option to `PluginReactLynxOptions` ([#2346](#2346)) - When configured to `"event"`, `updateGlobalProps` will only trigger a global event and skip the `runWithForce` flow. - Defaults to `"reactive"`, which means `updateGlobalProps` will trigger re-render automatically. ### Patch Changes - Updated dependencies \[[`f1129ea`](f1129ea), [`27f1cff`](27f1cff), [`ed566f0`](ed566f0), [`402ec2b`](402ec2b)]: - @lynx-js/react-webpack-plugin@0.8.0 - @lynx-js/react-refresh-webpack-plugin@0.3.5 - @lynx-js/react-alias-rsbuild-plugin@0.13.0 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/template-webpack-plugin@0.10.6 - @lynx-js/css-extract-webpack-plugin@0.7.0 ## @lynx-js/react-webpack-plugin@0.8.0 ### Minor Changes - feat: add `globalPropsMode` option to `PluginReactLynxOptions` ([#2346](#2346)) - When configured to `"event"`, `updateGlobalProps` will only trigger a global event and skip the `runWithForce` flow. - Defaults to `"reactive"`, which means `updateGlobalProps` will trigger re-render automatically. ### Patch Changes - Fix sourcemap misalignment when wrapping lazy bundle main-thread chunks. ([#2361](#2361)) The lazy bundle IIFE wrapper is now injected in `processAssets` at `PROCESS_ASSETS_STAGE_OPTIMIZE_SIZE + 1` by walking chunk groups instead of patching assets in `beforeEncode`. - With `experimental_isLazyBundle: true`, the wrapper is applied to lazy-bundle chunk groups. - Without lazy bundle mode, the wrapper is applied to async main-thread chunk groups generated by dynamic import. Injecting the wrapper in this stage keeps the emitted JS stable after optimization while still running before `DEV_TOOLING` sourcemap finalization, so the generated `.js` and `.js.map` stay aligned. - Set `__DEV__` and `__PROFILE__` to `true` on `NODE_ENV === 'development'`. ([#2324](#2324)) ## @lynx-js/rspeedy@0.13.6 ### Patch Changes - Rename Web Preview label to fix URL alignment ([#2355](#2355)) - Updated dependencies \[[`799fda8`](799fda8)]: - @lynx-js/cache-events-webpack-plugin@0.0.3 - @lynx-js/web-rsbuild-server-middleware@0.19.9 ## @lynx-js/lynx-bundle-rslib-config@0.2.3 ### Patch Changes - Fix snapshot not found error when dev with external bundle ([#2316](#2316)) ## @lynx-js/external-bundle-rsbuild-plugin@0.0.4 ### Patch Changes - Updated dependencies \[[`ed566f0`](ed566f0)]: - @lynx-js/externals-loading-webpack-plugin@0.0.5 ## @lynx-js/kitten-lynx-test-infra@0.1.1 ### Patch Changes - feat: support page.screenshot() ([#2364](#2364)) - feat: initial commit ([#2272](#2272)) ## @lynx-js/testing-environment@0.1.12 ### Patch Changes - Implement `__ElementAnimate` PAPI for web platform animation lifecycle ([#2329](#2329)) ## @lynx-js/web-constants@0.19.9 ### Patch Changes - Implement `__ElementAnimate` PAPI for web platform animation lifecycle ([#2329](#2329)) - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.19.9 ## @lynx-js/web-core@0.19.9 ### Patch Changes - Updated dependencies \[[`2efecc2`](2efecc2)]: - @lynx-js/web-constants@0.19.9 - @lynx-js/web-mainthread-apis@0.19.9 - @lynx-js/web-worker-runtime@0.19.9 - @lynx-js/web-worker-rpc@0.19.9 ## @lynx-js/web-core-wasm@0.0.6 ### Patch Changes - reexports essential utils & types in @lynx-js/web-elements from @lynx-js/web-core-wasm/client ([#2321](#2321)) - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.19.9 ## @lynx-js/web-mainthread-apis@0.19.9 ### Patch Changes - Updated dependencies \[[`2efecc2`](2efecc2)]: - @lynx-js/web-constants@0.19.9 ## @lynx-js/web-worker-runtime@0.19.9 ### Patch Changes - Updated dependencies \[[`2efecc2`](2efecc2)]: - @lynx-js/web-constants@0.19.9 - @lynx-js/web-mainthread-apis@0.19.9 - @lynx-js/web-worker-rpc@0.19.9 ## @lynx-js/cache-events-webpack-plugin@0.0.3 ### Patch Changes - Cache `globalThis.loadDynamicComponent` in the cache events runtime and add tests covering tt methods, performance events, and globalThis replay behavior. ([#2343](#2343)) ## @lynx-js/externals-loading-webpack-plugin@0.0.5 ### Patch Changes - Fix snapshot not found error when dev with external bundle ([#2316](#2316)) ## @lynx-js/react-refresh-webpack-plugin@0.3.5 ### Patch Changes - Fix snapshot not found error when dev with external bundle ([#2316](#2316)) ## @lynx-js/template-webpack-plugin@0.10.6 ### Patch Changes - Updated dependencies \[[`d034dae`](d034dae)]: - @lynx-js/web-core-wasm@0.0.6 ## create-rspeedy@0.13.6 ## @lynx-js/react-alias-rsbuild-plugin@0.13.0 ## upgrade-rspeedy@0.13.6 ## @lynx-js/web-core-server@0.19.9 ## @lynx-js/web-rsbuild-server-middleware@0.19.9 ## @lynx-js/web-worker-rpc@0.19.9 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR automates external bundle serving in the
react-externalsexample without requiring an externalhttp-serverprocess, by cleanly utilizing the DevServer's local middleware inlynx.config.ts. Additionally, it adds dedicated README documentation for the@lynx-js/react-umdpre-packaged bundle.Specifically, this PR:
@lynx-js/react-umdREADME: Explains the purpose of the UMD pre-packaged build and how to build/serve it.@lynx-js/rspeedy: AddssetupMiddlewaresto theConfig.devinterface so it natively aligns with Rsbuild 1.X semantic shapes, fixing downstream typescript resolution.lynx.config.tsTypescript Error: Resolves theNo overload matches this callTS error by migrating the obsolete WebpackdevServerproperty into Rsbuild's expectedserveranddevproperties.RsbuildPluginStructure: Resolves apnpm devexit 1 crash inreact-externalsby correctly shaping the middleware URL routing into a named plugin using theapi.modifyRsbuildConfiglifecycle hook.Summary by CodeRabbit
New Features
Documentation
Chores
Checklist