fix: Exclude the XFoldviewSlotNg element from touch event element lis… by PupilTong · Pull Request #2304 · lynx-family/lynx-stack

PupilTong · 2026-03-05T04:01:50Z

…ts to resolve a stuck issue.

Summary by CodeRabbit

Bug Fixes
- Fixed an issue where the foldview component could become stuck during touch interactions.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

…ts to resolve a stuck issue.

changeset-bot · 2026-03-05T04:01:55Z

🦋 Changeset detected

Latest commit: aeb2884

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@lynx-js/web-elements	Patch
@lynx-js/web-core-wasm	Patch
@lynx-js/template-webpack-plugin	Patch
@lynx-js/react-rsbuild-plugin	Patch
@lynx-js/react-alias-rsbuild-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-03-05T04:02:15Z

📝 Walkthrough

Walkthrough

This PR introduces a changelog entry for a patch release and fixes a bug in the XFoldViewNg touch event handler. The fix excludes the DOM element itself from element collections during path and touch start handling to resolve a foldview stuck issue.

Changes

Cohort / File(s)	Summary
Changelog Entry `.changeset/spotty-dryers-cry.md`	New changelog entry documenting patch release for `@lynx-js/web-elements` with foldview stuck issue fix.
Touch Event Handler Fix `packages/web-platform/web-elements/src/elements/XFoldViewNg/XFoldviewSlotNgTouchEventsHandler.ts`	Added check to exclude DOM element from collected elements in `pathElements` and `touchStart` methods via `element !== this.#dom` condition.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

feat: add wheel event handling and corresponding tests for x-foldview-ng #2145: Modifies the same XFoldviewSlotNgTouchEventsHandler.ts file with related changes to element collection and touch/scroll handling logic.

Suggested labels

platform:Web

Poem

🐰 A foldview was stuck in a bind,
Elements collected, jumbled and twined,
But a rabbit's quick fix, precise and true,
Excluded the DOM with a !== this.#dom view,
Now the folds flow freely, no stuckness in sight! 🎉

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: excluding the XFoldviewSlotNg element from touch event element lists to fix a stuck issue, which aligns with the file modifications and PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-03-05T04:04:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

packages/web-platform/web-elements/src/elements/XFoldViewNg/XFoldviewSlotNgTouchEventsHandler.ts (1)
97-107: ⚠️ Potential issue | 🟡 Minor

Consider excluding this.#dom from pointElements for consistency.

The fix correctly excludes this.#dom from pathElements on line 101, but pointElements on lines 104-106 omits this exclusion. Since Element.contains() returns true for the element itself, this.#dom can be included in pointElements when the touch point falls within its bounds. This would add the container element to this.#elements where it shouldn't belong, inconsistent with the #touchStart method (line 130) which explicitly filters with && e !== this.#dom.
Suggested fix for consistency
     const pointElements = document.elementsFromPoint(clientX, clientY).filter(
-      e => this.#dom.contains(e),
+      e => this.#dom.contains(e) && e !== this.#dom,
     );
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@packages/web-platform/web-elements/src/elements/XFoldViewNg/XFoldviewSlotNgTouchEventsHandler.ts`
around lines 97 - 107, pathElements excludes the container element (this.#dom)
but pointElements does not, causing this.#dom to be included in this.#elements
inconsistently; update the filtering of pointElements in
XFoldviewSlotNgTouchEventsHandler (the pointElements variable) to also exclude
this.#dom (same predicate used for pathElements: element instanceof Element &&
this.#dom.contains(element) && element !== this.#dom) so that when you compute
this.#elements = [...new Set([...pathElements, ...pointElements])], the
container is never added; mirror the check used in `#touchStart` to ensure
consistent behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In
`@packages/web-platform/web-elements/src/elements/XFoldViewNg/XFoldviewSlotNgTouchEventsHandler.ts`:
- Around line 97-107: pathElements excludes the container element (this.#dom)
but pointElements does not, causing this.#dom to be included in this.#elements
inconsistently; update the filtering of pointElements in
XFoldviewSlotNgTouchEventsHandler (the pointElements variable) to also exclude
this.#dom (same predicate used for pathElements: element instanceof Element &&
this.#dom.contains(element) && element !== this.#dom) so that when you compute
this.#elements = [...new Set([...pathElements, ...pointElements])], the
container is never added; mirror the check used in `#touchStart` to ensure
consistent behavior.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c633e8ea-ad1a-40b0-bdb5-55a0d31a4f35

📥 Commits

Reviewing files that changed from the base of the PR and between e7d94be and aeb2884.

📒 Files selected for processing (2)

.changeset/spotty-dryers-cry.md
packages/web-platform/web-elements/src/elements/XFoldViewNg/XFoldviewSlotNgTouchEventsHandler.ts

codspeed-hq · 2026-03-05T04:37:49Z

Merging this PR will degrade performance by 8.4%

❌ 1 regressed benchmark
✅ 71 untouched benchmarks
⏩ 3 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`basic-performance-nest-level-100`	6.8 ms	7.4 ms	-8.4%

_{Comparing PupilTong:p/hw/try-to-fix-foldview-ng-stuck (aeb2884) with main (e7d94be)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-03-05T04:37:57Z

Web Explorer

#7967 Bundle Size — 383.56KiB (~+0.01%).

aeb2884(current) vs e7d94be main#7961(baseline)

Bundle metrics

3 changes

1 regression

	Current #7967	Baseline #7961
Initial JS	`154.66KiB`(`+0.02%`)	`154.63KiB`
Initial CSS	`35.1KiB`	`35.1KiB`
Cache Invalidation	`40.32%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`239`(`+0.42%`)	`238`
Duplicate Modules	`16`	`16`
Duplicate Code	`2.99%`	`2.99%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #7967	Baseline #7961
JS	`252.6KiB` (`+0.01%`)	`252.58KiB`
Other	`95.85KiB`	`95.85KiB`
CSS	`35.1KiB`	`35.1KiB`

Bundle analysis report Branch PupilTong:p/hw/try-to-fix-foldvi... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/devtool-mcp-server@0.5.0 ### Minor Changes - Use `@lynx-js/devtool-connector` instead of `@lynx-js/debug-router-connector`. ([#2284](#2284)) The new connector avoids using keep-alive connections, which makes the connection much more reliable. - **BREAKING CHANGE**: Remove the `./debug-router-connector` exports. ([#2284](#2284)) ## @lynx-js/web-elements@0.12.0 ### Minor Changes - feat: add `willchange` event to `x-viewpager-ng` ([#2305](#2305)) ### Patch Changes - fix: firefox `@supports(width:1rex)` ([#2288](#2288)) - fix: check computed overflow style in `getTheMostScrollableKid` to avoid treating `overflow: visible` elements as scroll containers ([#2309](#2309)) - fix: the inline-truncation should only work as a direct child of x-text ([#2287](#2287)) - fix: getVisibleCells cannot work in firefox due to contentvisibilityautostatechange not propagate list-item ([#2308](#2308)) - fix: foldview stuck issue ([#2304](#2304)) ## @lynx-js/gesture-runtime@2.1.3 ### Patch Changes - Optimize gesture callbacks and relationships to prevent unnecessary gesture registration and rerenders. ([#2277](#2277)) ## @lynx-js/react@0.116.5 ### Patch Changes - Improve React runtime hook profiling. ([#2235](#2235)) Enable Profiling recording first, then enter the target page so the trace includes full render/hydrate phases. - Record trace events for `useEffect` / `useLayoutEffect` hook entry, callback, and cleanup phases. - Log trace events for `useState` setter calls. - Wire `profileFlowId` support in debug profile utilities and attach flow IDs to related hook traces. - Instrument hydrate/background snapshot profiling around patch operations with richer args (e.g. snapshot id/type, dynamic part index, value type, and source when available). - Capture vnode source mapping in dev and use it in profiling args to improve trace attribution. - Expand debug test coverage for profile utilities, hook profiling behavior, vnode source mapping, and hydrate profiling branches. - refactor: call loadWorkletRuntime once in each module ([#2315](#2315)) ## @lynx-js/rspeedy@0.13.5 ### Patch Changes - feat: opt-in the web platform's new binary output format ([#2281](#2281)) Introduce a new flag to enable the new binary output format. Currently it's an internal-use-only flag that will be removed in the future; set the corresponding environment variable to 'true' to enable it. - Avoid generating `Rsbuild vundefined` in greeting message. ([#2275](#2275)) - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.19.8 ## @lynx-js/lynx-bundle-rslib-config@0.2.2 ### Patch Changes - Support bundle and load css in external bundle ([#2143](#2143)) ## @lynx-js/external-bundle-rsbuild-plugin@0.0.3 ### Patch Changes - Updated dependencies \[[`c28b051`](c28b051), [`4cbf809`](4cbf809)]: - @lynx-js/externals-loading-webpack-plugin@0.0.4 ## @lynx-js/react-rsbuild-plugin@0.12.10 ### Patch Changes - Support bundle and load css in external bundle ([#2143](#2143)) - Updated dependencies \[[`59f2933`](59f2933), [`453e006`](453e006)]: - @lynx-js/template-webpack-plugin@0.10.5 - @lynx-js/css-extract-webpack-plugin@0.7.0 - @lynx-js/react-webpack-plugin@0.7.4 - @lynx-js/react-alias-rsbuild-plugin@0.12.10 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.4 ## @lynx-js/web-core-wasm@0.0.5 ### Patch Changes - Updated dependencies \[[`4963907`](4963907), [`8fd936a`](8fd936a), [`0d41253`](0d41253), [`d32c4c6`](d32c4c6), [`7518b72`](7518b72), [`fca9d4a`](fca9d4a)]: - @lynx-js/web-elements@0.12.0 ## @lynx-js/externals-loading-webpack-plugin@0.0.4 ### Patch Changes - perf: optimize external bundle loading by merging multiple `fetchBundle` calls for the same URL into a single request. ([#2307](#2307)) - Support bundle and load css in external bundle ([#2143](#2143)) ## @lynx-js/template-webpack-plugin@0.10.5 ### Patch Changes - feat: allow `templateDebugUrl` to be customized via `output.publicPath` or the `beforeEncode` hook. ([#2274](#2274)) - feat: opt-in the web platform's new binary output format ([#2281](#2281)) Introduce a new flag to enable the new binary output format. Currently it's an internal-use-only flag that will be removed in the future; set the corresponding environment variable to 'true' to enable it. - Updated dependencies \[]: - @lynx-js/web-core-wasm@0.0.5 ## create-rspeedy@0.13.5 ## @lynx-js/react-alias-rsbuild-plugin@0.12.10 ## upgrade-rspeedy@0.13.5 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: Exclude the XFoldviewSlotNg element from touch event element lis…

aeb2884

…ts to resolve a stuck issue.

PupilTong requested a review from Sherry-hue as a code owner March 5, 2026 04:01

PupilTong self-assigned this Mar 5, 2026

coderabbitai bot added the platform:Web label Mar 5, 2026

coderabbitai bot reviewed Mar 5, 2026

View reviewed changes

Sherry-hue approved these changes Mar 5, 2026

View reviewed changes

PupilTong merged commit fca9d4a into lynx-family:main Mar 5, 2026
109 of 114 checks passed

github-actions bot mentioned this pull request Mar 5, 2026

chore: Release 2026-03-09 08:57:23 #2280

Merged

coderabbitai bot mentioned this pull request Mar 5, 2026

feat: reimplement XFoldViewNg scrolling using CSS transforms and cust… #2299

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Exclude the XFoldviewSlotNg element from touch event element lis…#2304

fix: Exclude the XFoldviewSlotNg element from touch event element lis…#2304
PupilTong merged 1 commit intolynx-family:mainfrom
PupilTong:p/hw/try-to-fix-foldview-ng-stuck

PupilTong commented Mar 5, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Mar 5, 2026

Uh oh!

coderabbitai bot commented Mar 5, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

codecov bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

codspeed-hq bot commented Mar 5, 2026

Uh oh!

relativeci bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

PupilTong commented Mar 5, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot bot commented Mar 5, 2026

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

codecov bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Mar 5, 2026

Merging this PR will degrade performance by 8.4%

Performance Changes

Footnotes

Uh oh!

relativeci bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#7967 Bundle Size — 383.56KiB (~+0.01%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PupilTong commented Mar 5, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 5, 2026 •

edited

Loading

codecov bot commented Mar 5, 2026 •

edited

Loading

relativeci bot commented Mar 5, 2026 •

edited

Loading