Skip to content

fix(devtool-mcp-server): failed to OpenPage#2301

Merged
colinaaa merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0305/devtool-mcp-server
Mar 5, 2026
Merged

fix(devtool-mcp-server): failed to OpenPage#2301
colinaaa merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0305/devtool-mcp-server

Conversation

@colinaaa
Copy link
Copy Markdown
Collaborator

@colinaaa colinaaa commented Mar 5, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Resolved error-handling issue in page operations to ensure proper management of request origin metadata during failure scenarios.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 5, 2026

🦋 Changeset detected

Latest commit: bcc895d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 5, 2026

📝 Walkthrough

Walkthrough

This PR introduces a new changeset file and updates error-handling logic in OpenPage.ts. The changeset entry is a placeholder with minimal YAML structure. The OpenPage.ts modification alters fallback message payload fields, setting sender and from to -1 instead of clientId in the error-handling path.

Changes

Cohort / File(s) Summary
Changeset Entry
.changeset/fifty-trains-cheer.md
Added placeholder changeset file with minimal YAML structure, no functional impact.
Error Handling Update
packages/mcp-servers/devtool-mcp-server/src/tools/Device/OpenPage.ts
Modified fallback message payload to set sender and from fields to -1 instead of clientId in error-handling path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • hzy

Poem

A changeset blooms, a placeholder fair, 🐰
While fallback paths get special care,
Where -1 now marks the error's way,
Small tweaks that brighten up the day! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(devtool-mcp-server): failed to OpenPage' is directly related to the main changes in the PR, which involve fixing the OpenPage tool in devtool-mcp-server by correcting sender and from field values in error-handling fallback paths.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rs/devtool-mcp-server/src/tools/Device/OpenPage.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@relativeci
Copy link
Copy Markdown

relativeci bot commented Mar 5, 2026

Web Explorer

#7956 Bundle Size — 383.53KiB (0%).

bcc895d(current) vs 8517e2c main#7953(baseline)

Bundle metrics  Change 1 change
                 Current
#7956
     Baseline
#7953
No change  Initial JS 154.63KiB 154.63KiB
No change  Initial CSS 35.1KiB 35.1KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 8 8
Change  Modules 238(-0.42%) 239
No change  Duplicate Modules 16 16
No change  Duplicate Code 2.99% 2.99%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#7956
     Baseline
#7953
No change  JS 252.58KiB 252.58KiB
No change  Other 95.85KiB 95.85KiB
No change  CSS 35.1KiB 35.1KiB

Bundle analysis reportBranch colinaaa:colin/0305/devtool-mcp-...Project dashboard


Generated by RelativeCIDocumentationReport issue

@colinaaa colinaaa marked this pull request as ready for review March 5, 2026 03:20
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcc895d84a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/mcp-servers/devtool-mcp-server/src/tools/Device/OpenPage.ts`:
- Around line 35-37: The fallback message currently sets sender and from to -1
which is invalid; update the fallback in OpenPage (the object where sender and
from are hardcoded) to use a real port identifier consistent with other
Customized messages—e.g., replace sender: -1 and from: -1 with the actual port
variable used in this scope (such as port or options.port) so handlers receive a
valid sender/from value for routing.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cba31e49-b7d5-4c0c-ba3d-eb44cba32a21

📥 Commits

Reviewing files that changed from the base of the PR and between 8517e2c and bcc895d.

📒 Files selected for processing (2)
  • .changeset/fifty-trains-cheer.md
  • packages/mcp-servers/devtool-mcp-server/src/tools/Device/OpenPage.ts

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 5, 2026

Merging this PR will improve performance by 16.46%

⚡ 2 improved benchmarks
✅ 70 untouched benchmarks
⏩ 3 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
basic-performance-nest-level-100 7.5 ms 6.9 ms +9.13%
transform 1000 view elements 47.1 ms 40.4 ms +16.46%

Comparing colinaaa:colin/0305/devtool-mcp-server (bcc895d) with main (8517e2c)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@colinaaa colinaaa merged commit 60071c2 into lynx-family:main Mar 5, 2026
78 of 81 checks passed
@colinaaa colinaaa deleted the colin/0305/devtool-mcp-server branch March 5, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants