fix(devtool-mcp-server): failed to OpenPage#2301
Conversation
🦋 Changeset detectedLatest commit: bcc895d The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughThis PR introduces a new changeset file and updates error-handling logic in OpenPage.ts. The changeset entry is a placeholder with minimal YAML structure. The OpenPage.ts modification alters fallback message payload fields, setting sender and from to -1 instead of clientId in the error-handling path. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Web Explorer#7956 Bundle Size — 383.53KiB (0%).bcc895d(current) vs 8517e2c main#7953(baseline) Bundle metrics
Bundle size by type
|
| Current #7956 |
Baseline #7953 |
|
|---|---|---|
252.58KiB |
252.58KiB |
|
95.85KiB |
95.85KiB |
|
35.1KiB |
35.1KiB |
Bundle analysis report Branch colinaaa:colin/0305/devtool-mcp-... Project dashboard
Generated by RelativeCI Documentation Report issue
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcc895d84a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/mcp-servers/devtool-mcp-server/src/tools/Device/OpenPage.ts`:
- Around line 35-37: The fallback message currently sets sender and from to -1
which is invalid; update the fallback in OpenPage (the object where sender and
from are hardcoded) to use a real port identifier consistent with other
Customized messages—e.g., replace sender: -1 and from: -1 with the actual port
variable used in this scope (such as port or options.port) so handlers receive a
valid sender/from value for routing.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cba31e49-b7d5-4c0c-ba3d-eb44cba32a21
📒 Files selected for processing (2)
.changeset/fifty-trains-cheer.mdpackages/mcp-servers/devtool-mcp-server/src/tools/Device/OpenPage.ts
Merging this PR will improve performance by 16.46%
Performance Changes
Comparing Footnotes
|
Summary by CodeRabbit
Checklist