Skip to content

fix: ci reusable workflow name#2290

Closed
Dugyu wants to merge 2 commits intolynx-family:mainfrom
Dugyu:fix/ci-workflow-name
Closed

fix: ci reusable workflow name#2290
Dugyu wants to merge 2 commits intolynx-family:mainfrom
Dugyu:fix/ci-workflow-name

Conversation

@Dugyu
Copy link
Copy Markdown
Collaborator

@Dugyu Dugyu commented Mar 2, 2026

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflows for improved CI/CD automation and testing processes.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

claude and others added 2 commits March 2, 2026 18:34
Add name: Benchmark, Build, and Reusable Test to workflow-bench.yml,
workflow-build.yml, and workflow-test.yml respectively, so they are
clearly identifiable in the GitHub Actions UI.

https://claude.ai/code/session_01GUDHcoJCmuFtj9HAxot7Pf
Add name: Benchmark, Build, and Reusable Test to `workflow-bench.yml`, 
`workflow-build.yml`, and `workflow-test.yml` respectively, 
so they are clearly identifiable in the GitHub Actions UI.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 2, 2026

⚠️ No Changeset found

Latest commit: 2c3e6bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 2, 2026

📝 Walkthrough

Walkthrough

Adds workflow names to three GitHub Actions workflow files: "Benchmark" to workflow-bench.yml, "Build" to workflow-build.yml with CODECOV_TOKEN secret, and introduces a new comprehensive reusable workflow in workflow-test.yml with secrets, inputs, permissions, environment variables, and build/test steps.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/workflow-bench.yml, .github/workflows/workflow-build.yml, .github/workflows/workflow-test.yml
Adds top-level workflow names and introduces reusable test workflow with CODECOV_TOKEN and LHCI_GITHUB_APP_TOKEN secrets, configurable inputs (runs-on, run, is-web, web-report-name, web-report-path, codecov-flags), environment variables, container configuration, and complete build/test/upload pipeline steps.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • colinaaa
  • HuJean

Poem

🐰 GitHub Actions now run clean with names so bright,
Workflows orchestrate our tests throughout the night,
Codecov tokens flow, and secrets stay secure,
Our CI/CD pipeline, steady and pure! ✨
Reusable, composable, our builds take flight!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: ci reusable workflow name' accurately describes the main change—adding explicit name fields to reusable GitHub Actions workflows for better UI identification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Mar 2, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Dugyu
❌ claude
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/workflow-test.yml (1)

102-102: Minor: Inconsistent spacing in expression.

The expression ${{ inputs.web-report-path}} is missing a space before the closing braces, unlike other expressions in this file (e.g., line 101 has ${{ inputs.web-report-name }}).

✏️ Suggested fix
-          path: ${{ inputs.web-report-path}}
+          path: ${{ inputs.web-report-path }}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/workflow-test.yml at line 102, The expression for the
workflow input path is missing a space before the closing braces which makes it
inconsistent with other expressions; update the expression `${{
inputs.web-report-path}}` to include a space before the closing braces so it
reads like `${{ inputs.web-report-path }}` to match the style used for `${{
inputs.web-report-name }}` and other placeholders.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/workflow-test.yml:
- Line 102: The expression for the workflow input path is missing a space before
the closing braces which makes it inconsistent with other expressions; update
the expression `${{ inputs.web-report-path}}` to include a space before the
closing braces so it reads like `${{ inputs.web-report-path }}` to match the
style used for `${{ inputs.web-report-name }}` and other placeholders.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ca97fe and 2c3e6bf.

📒 Files selected for processing (3)
  • .github/workflows/workflow-bench.yml
  • .github/workflows/workflow-build.yml
  • .github/workflows/workflow-test.yml

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4789 1 4788 273
View the top 1 failed test(s) by shortest run time
packages/rspeedy/plugin-qrcode/test/shortcuts.test.ts > PluginQRCode - CLI Shortcuts > open page
Stack Traces | 1.82s run time
Error: Matcher did not succeed in time.
 ❯ test/shortcuts.test.ts:163:40

Caused by: Caused by: Caused by: AssertionError: expected "Xe" to be called 2 times, but got 0 times

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 2, 2026

Merging this PR will improve performance by 9.41%

⚡ 3 improved benchmarks
✅ 69 untouched benchmarks
⏩ 3 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
basic-performance-div-10000 485.4 ms 457.4 ms +6.11%
basic-performance-div-100 7.4 ms 6.9 ms +6%
transform 1000 view elements 47.4 ms 43.3 ms +9.41%

Comparing Dugyu:fix/ci-workflow-name (2c3e6bf) with main (8ca97fe)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci bot commented Mar 2, 2026

Web Explorer

#7889 Bundle Size — 383.64KiB (0%).

2c3e6bf(current) vs 8ca97fe main#7876(baseline)

Bundle metrics  Change 1 change
                 Current
#7889
     Baseline
#7876
No change  Initial JS 154.78KiB 154.78KiB
No change  Initial CSS 35.06KiB 35.06KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 8 8
Change  Modules 238(-0.42%) 239
No change  Duplicate Modules 16 16
No change  Duplicate Code 2.99% 2.99%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#7889
     Baseline
#7876
No change  JS 252.72KiB 252.72KiB
No change  Other 95.85KiB 95.85KiB
No change  CSS 35.06KiB 35.06KiB

Bundle analysis reportBranch Dugyu:fix/ci-workflow-nameProject dashboard


Generated by RelativeCIDocumentationReport issue

@Dugyu Dugyu closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants