Skip to content

fix(renovate): read benchx_cli + support date-only tags#2285

Merged
colinaaa merged 1 commit intomainfrom
fix/renovate-benchx-cli
Mar 2, 2026
Merged

fix(renovate): read benchx_cli + support date-only tags#2285
colinaaa merged 1 commit intomainfrom
fix/renovate-benchx-cli

Conversation

@hzy
Copy link
Copy Markdown
Collaborator

@hzy hzy commented Mar 2, 2026

  • Fix managerFilePatterns for benchx_cli locked version script (build_*.sh)\n- Extend versioning regex to accept both benchx_cli-YYYYMMDDHHmm and benchx_cli-YYYYMMDD tags\n\nThis should make Renovate pick up lynx-community/benchx_cli releases and update LOCKED_VERSION accordingly.

Summary by CodeRabbit

  • Chores
    • Updated dependency update automation configuration to support additional build script file patterns and multiple historical release version formats
    • Added documentation clarifying newly supported format types

Copilot AI review requested due to automatic review settings March 2, 2026 07:56
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 2, 2026

⚠️ No Changeset found

Latest commit: e11ac5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88fbad8 and e11ac5d.

📒 Files selected for processing (1)
  • .github/renovate.json5

📝 Walkthrough

Walkthrough

The Renovate configuration's custom regex manager for benchx_cli is updated to support broader script file matching (build_*.sh pattern) and flexible version formats (with or without +build suffix), enabling detection of historical and new release version schemes.

Changes

Cohort / File(s) Summary
Renovate Configuration
.github/renovate.json5
Updated custom.regex manager managerFilePatterns to match any build_*.sh script and adjusted versioningTemplate to support multiple timestamp-based version formats (both YYYYMMDDHHmm and YYYYMMDD). Added documentation comments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • colinaaa
  • PupilTong

Poem

🐰 A regex wildcard hops with glee,
Build scripts now match so naturally!
Version formats, old and new, align,
Renovate's eye grows more fine,
History and present, both in line!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating Renovate configuration to support benchx_cli and enable date-only tag formats.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/renovate-benchx-cli

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Renovate configuration so it can correctly detect and update the locked benchx_cli release tag used by the benchx_cli build scripts, including supporting both datetime and date-only tag formats from GitHub releases.

Changes:

  • Expand managerFilePatterns to match the actual build_*.sh scripts (e.g., build_unix.sh) instead of a non-existent build.sh.
  • Extend the versioningTemplate regex to accept both benchx_cli-YYYYMMDDHHmm and benchx_cli-YYYYMMDD tag formats.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 2, 2026

Merging this PR will improve performance by ×2.9

⚡ 3 improved benchmarks
✅ 69 untouched benchmarks
⏩ 3 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
transform 1000 view elements 47.4 ms 45.1 ms +5.05%
basic-performance-image-100 10.1 ms 8.2 ms +24.15%
basic-performance-large-css 45.9 ms 16.1 ms ×2.9

Comparing fix/renovate-benchx-cli (e11ac5d) with main (88fbad8)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci bot commented Mar 2, 2026

Web Explorer

#7871 Bundle Size — 383.64KiB (0%).

e11ac5d(current) vs 88fbad8 main#7864(baseline)

Bundle metrics  Change 1 change
                 Current
#7871
     Baseline
#7864
No change  Initial JS 154.78KiB 154.78KiB
No change  Initial CSS 35.06KiB 35.06KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 8 8
Change  Modules 238(+0.42%) 237
No change  Duplicate Modules 16 16
No change  Duplicate Code 2.99% 2.99%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#7871
     Baseline
#7864
No change  JS 252.72KiB 252.72KiB
No change  Other 95.85KiB 95.85KiB
No change  CSS 35.06KiB 35.06KiB

Bundle analysis reportBranch fix/renovate-benchx-cliProject dashboard


Generated by RelativeCIDocumentationReport issue

@colinaaa colinaaa merged commit 8ca97fe into main Mar 2, 2026
84 of 86 checks passed
@colinaaa colinaaa deleted the fix/renovate-benchx-cli branch March 2, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants