fix: NativeGesture callback types correction by f0rdream · Pull Request #2130 · lynx-family/lynx-stack

f0rdream · 2026-01-22T13:53:55Z

Fix an issue that NativeGesture does not get correct types in callback

Summary by CodeRabbit

Bug Fixes
- Corrected type definitions for gesture event callbacks to include accurate parameter information such as scroll position, delta values, and boundary state tracking.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2026-01-22T13:54:01Z

🦋 Changeset detected

Latest commit: 42405af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lynx-js/gesture-runtime	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-01-22T13:54:19Z

📝 Walkthrough

Walkthrough

A patch version update for @lynx-js/gesture-runtime that fixes the NativeGestureChangeEvent interface by adding missing properties (scrollX, scrollY, deltaX, deltaY, isAtStart, isAtEnd) to the params object, ensuring the callback receives correct type information.

Changes

Cohort / File(s)	Summary
Gesture Runtime Type Definition Fix `\`.changeset/rich-signs-behave.md``,` packages/lynx/gesture-runtime/src/gestureInterface.ts`	Changeset documents patch version for gesture-runtime bug fix; NativeGestureChangeEvent interface extended with params property containing scroll and delta position properties

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

lynx-stack#2076: Adds and exports the NativeGesture class with usage patterns and tests, complementing this PR's type definition fix for the change-event callback.

Suggested reviewers

Yradex

Poem

🐰 A gesture so grand, now typed with care,
ScrollX and deltaX float through the air,
NativeGesture's params gleam bright,
Types aligned, everything's right! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing the callback types for NativeGesture by adding proper type definitions to NativeGestureChangeEvent.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-01-22T13:59:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-01-22T14:09:56Z

CodSpeed Performance Report

Merging this PR will improve performance by 9.68%

_{Comparing f0rdream:native_gesture_types (42405af) with main (af2487a)}

Summary

⚡ 2 improved benchmarks
✅ 61 untouched benchmarks
⏩ 3 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`basic-performance-div-100`	7.6 ms	6.9 ms	+9.68%
⚡	`basic-performance-small-css`	8.4 ms	7.8 ms	+8.05%

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-01-22T14:13:25Z

Web Explorer

#7308 Bundle Size — 383.78KiB (0%).

42405af(current) vs af2487a main#7306(baseline)

Bundle metrics

1 change

	Current #7308	Baseline #7306
Initial JS	`154.12KiB`	`154.12KiB`
Initial CSS	`35.05KiB`	`35.05KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`238`(`-0.42%`)	`239`
Duplicate Modules	`16`	`16`
Duplicate Code	`3%`	`3%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7308	Baseline #7306
JS	`251.71KiB`	`251.71KiB`
Other	`97.02KiB`	`97.02KiB`
CSS	`35.05KiB`	`35.05KiB`

Bundle analysis report Branch f0rdream:native_gesture_types Project dashboard

^{Generated by RelativeCI Documentation Report issue}

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/react@0.116.0 ### Minor Changes - **BREAKING CHANGE**: Bump Preact from [10.24.0](preactjs/preact@1807173) to [10.28.0](preactjs/preact@f7693b7), see diffs at [hzy/preact#6](hzy/preact#6). ([#2042](#2042)) ### Patch Changes - Add safety checks for compilation macros to prevent runtime errors when they are undefined. ([#2110](#2110)) Replaces direct usage of `__PROFILE__`, `__MAIN_THREAD__`, `__BACKGROUND__` with `typeof` checks. This improves robustness by checking variable existence before access, preventing runtime errors in environments where compilation macros are not defined. ## @lynx-js/lynx-bundle-rslib-config@0.2.0 ### Minor Changes - Use `LAYERS` exposed by DSL plugins ([#2114](#2114)) ## @lynx-js/gesture-runtime@2.1.2 ### Patch Changes - Fix an issue that `NativeGesture` does not get correct types in callback ([#2130](#2130)) ## @lynx-js/rspeedy@0.13.1 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.19.6 ## @lynx-js/react-rsbuild-plugin@0.12.6 ### Patch Changes - Support using `pluginReactLynx` in Rslib. ([#2114](#2114)) - Updated dependencies \[[`4cd7182`](4cd7182)]: - @lynx-js/template-webpack-plugin@0.10.2 - @lynx-js/react-alias-rsbuild-plugin@0.12.6 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.4 - @lynx-js/react-webpack-plugin@0.7.3 - @lynx-js/css-extract-webpack-plugin@0.7.0 ## upgrade-rspeedy@0.13.1 ### Patch Changes - Fix the issue `rslib-runtime.js` was not published in dist folder. ([#2122](#2122)) ## @lynx-js/testing-environment@0.1.10 ### Patch Changes - Fix the error "lynxTestingEnv is not defined" ([#2118](#2118)) ## @lynx-js/web-constants@0.19.6 ### Patch Changes - feat: add main-thread API: \_\_QuerySelector ([#2115](#2115)) - fix: when a list-item is deleted from list, the deleted list-item is still showed incorrectly. ([#1092](#1092)) This is because the `enqueueComponent` method does not delete the node from the Element Tree. It is only to maintain the display node on RL, and lynx web needs to delete the dom additionally. - feat: support main thread invoke ui method ([#2104](#2104)) - feat: support lynx.reload() ([#2127](#2127)) - Updated dependencies \[[`f7133c1`](f7133c1)]: - @lynx-js/web-worker-rpc@0.19.6 ## @lynx-js/web-core@0.19.6 ### Patch Changes - fix: avoid crash on CPUs that do not support SIMD ([#2133](#2133)) - feat: support lynx.reload() ([#2127](#2127)) - Updated dependencies \[[`179f984`](179f984), [`f7133c1`](f7133c1), [`6c2b51a`](6c2b51a), [`556fe9f`](556fe9f), [`5b589ab`](5b589ab)]: - @lynx-js/web-constants@0.19.6 - @lynx-js/web-mainthread-apis@0.19.6 - @lynx-js/web-worker-rpc@0.19.6 - @lynx-js/web-worker-runtime@0.19.6 ## @lynx-js/web-core-wasm@0.0.1 ### Patch Changes - Updated dependencies \[[`f7133c1`](f7133c1)]: - @lynx-js/web-worker-rpc@0.19.6 ## @lynx-js/web-mainthread-apis@0.19.6 ### Patch Changes - feat: add main-thread API: \_\_QuerySelector ([#2115](#2115)) - fix: when a list-item is deleted from list, the deleted list-item is still showed incorrectly. ([#1092](#1092)) This is because the `enqueueComponent` method does not delete the node from the Element Tree. It is only to maintain the display node on RL, and lynx web needs to delete the dom additionally. - feat: support main thread invoke ui method ([#2104](#2104)) - fix: mts && bts events can be binded both ([#2121](#2121)) - Updated dependencies \[[`179f984`](179f984), [`f7133c1`](f7133c1), [`6c2b51a`](6c2b51a), [`5b589ab`](5b589ab)]: - @lynx-js/web-constants@0.19.6 ## @lynx-js/web-worker-rpc@0.19.6 ### Patch Changes - fix: when a list-item is deleted from list, the deleted list-item is still showed incorrectly. ([#1092](#1092)) This is because the `enqueueComponent` method does not delete the node from the Element Tree. It is only to maintain the display node on RL, and lynx web needs to delete the dom additionally. ## @lynx-js/web-worker-runtime@0.19.6 ### Patch Changes - feat: support lynx.reload() ([#2127](#2127)) - Updated dependencies \[[`179f984`](179f984), [`f7133c1`](f7133c1), [`6c2b51a`](6c2b51a), [`556fe9f`](556fe9f), [`5b589ab`](5b589ab)]: - @lynx-js/web-constants@0.19.6 - @lynx-js/web-mainthread-apis@0.19.6 - @lynx-js/web-worker-rpc@0.19.6 ## @lynx-js/template-webpack-plugin@0.10.2 ### Patch Changes - Polyfill `lynx.requireModuleAsync` to allow cache same parallel requests. ([#2108](#2108)) ## create-rspeedy@0.13.1 ## @lynx-js/react-alias-rsbuild-plugin@0.12.6 ## @lynx-js/web-core-server@0.19.6 ## @lynx-js/web-rsbuild-server-middleware@0.19.6 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: NativeGesture callback types correction

42405af

f0rdream requested a review from AdrianLCA January 22, 2026 13:54

AdrianLCA approved these changes Jan 22, 2026

View reviewed changes

f0rdream requested a review from Yradex January 23, 2026 03:23

Yradex approved these changes Jan 23, 2026

View reviewed changes

Yradex merged commit 4d91dd3 into lynx-family:main Jan 23, 2026
47 checks passed

github-actions bot mentioned this pull request Jan 23, 2026

chore: Release 2026-01-23 09:19:50 #2105

Merged

f0rdream deleted the native_gesture_types branch January 23, 2026 08:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: NativeGesture callback types correction#2130

fix: NativeGesture callback types correction#2130
Yradex merged 1 commit intolynx-family:mainfrom
f0rdream:native_gesture_types

f0rdream commented Jan 22, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jan 22, 2026

Uh oh!

coderabbitai bot commented Jan 22, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov bot commented Jan 22, 2026

Uh oh!

codspeed-hq bot commented Jan 22, 2026

Uh oh!

relativeci bot commented Jan 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

f0rdream commented Jan 22, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot bot commented Jan 22, 2026

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov bot commented Jan 22, 2026

Codecov Report

Uh oh!

codspeed-hq bot commented Jan 22, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 9.68%

Summary

Performance Changes

Footnotes

Uh oh!

relativeci bot commented Jan 22, 2026

Web Explorer

#7308 Bundle Size — 383.78KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

f0rdream commented Jan 22, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 22, 2026 •

edited

Loading