fix: increment `vnode._original` to make sure the component is re-ren… by HuJean · Pull Request #2126 · lynx-family/lynx-stack

HuJean · 2026-01-22T05:38:12Z

#2125

Summary by CodeRabbit

Bug Fixes
- Ensure components reliably re-render when global properties are updated in edge cases where previous updates could be skipped.
Tests
- Expanded lifecycle tests to cover more update scenarios, hydration flows, and propagation of global prop changes.
Changelog
- Added a patch release entry documenting the behavioral fix.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2026-01-22T05:38:16Z

🦋 Changeset detected

Latest commit: 1653b8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lynx-js/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-01-22T05:38:41Z

📝 Walkthrough

Walkthrough

This change bumps vnode ORIGINAL in runWithForce to force re-renders when updateGlobalProps runs (including non-component root vnodes), adds tests covering updateGlobalProps lifecycles, and adds a changelog entry documenting the patch.

Changes

Cohort / File(s)	Summary
Changelog `\.changeset/full-clubs-train.md`	Add patch release entry describing the runWithForce ORIGINAL bump to force re-renders when updateGlobalProps is used.
Core Runtime Fix `packages/react/runtime/src/lynx/runWithForce.ts`	Modify DIFF2 hook to increment `vnode[ORIGINAL]` when new and old ORIGINAL values are equal, ensuring FORCE path triggers updates.
Tests `packages/react/runtime/__test__/lifecycle/updateGlobalProps.test.jsx`	Expand test scaffolding and add multiple scenarios validating updateGlobalProps across root/page/component render paths, hydration, and element-tree updates.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

chore: upgrade preact #1389: Changes the same runWithForce.ts/DIFF2 forced-re-render logic.
chore: bump preact to 10.28.x #2042: Also adjusts vnode ORIGINAL bump behavior to force updates in runWithForce.

Suggested reviewers

hzy
Yradex
colinaaa

Poem

🐰 I nudge the ORIGINAL, give vnodes a shove,
I wake sleepy roots with a hop and a love.
When props shift and nothing will stir,
I bump a number — render occurs!
Hooray for small hops that fix big things.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main fix: incrementing vnode._original to force component re-renders, which matches the core changes in runWithForce.ts and the changelog entry.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch p/fix-globalProps

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-01-22T05:42:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-01-22T05:50:33Z

CodSpeed Performance Report

Merging this PR will degrade performance by 5.35%

_{Comparing p/fix-globalProps (1653b8f) with main (d1b0d9e)}

Summary

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 60 untouched benchmarks
⏩ 3 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`basic-performance-nest-level-100`	7.5 ms	7.1 ms	+6.19%
❌	`basic-performance-div-10000`	456.7 ms	482.5 ms	-5.35%
⚡	`transform 1000 view elements`	46.3 ms	41.9 ms	+10.28%

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-01-22T05:55:23Z

Web Explorer

#7432 Bundle Size — 383.56KiB (0%).

1653b8f(current) vs d1b0d9e main#7429(baseline)

Bundle metrics no changes

	Current #7432	Baseline #7429
Initial JS	`154.71KiB`	`154.71KiB`
Initial CSS	`35.05KiB`	`35.05KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`237`	`237`
Duplicate Modules	`16`	`16`
Duplicate Code	`2.99%`	`2.99%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7432	Baseline #7429
JS	`252.66KiB`	`252.66KiB`
Other	`95.85KiB`	`95.85KiB`
CSS	`35.05KiB`	`35.05KiB`

Bundle analysis report Branch p/fix-globalProps Project dashboard

^{Generated by RelativeCI Documentation Report issue}

upupming · 2026-01-23T02:50:28Z


    const c = oldVNode[COMPONENT];
    if (c) {
+      if (vnode[ORIGINAL] != null && oldVNode[ORIGINAL] === vnode[ORIGINAL]) {


Suggested change

if (vnode[ORIGINAL] != null && oldVNode[ORIGINAL] === vnode[ORIGINAL]) {

if (vnode !=== oldVNode && vnode[ORIGINAL] != null && oldVNode[ORIGINAL] === vnode[ORIGINAL]) {

I think we can remove line 11-22 if we do this.

lynx-stack/packages/react/runtime/src/lynx/runWithForce.ts

Lines 11 to 22 in 62ef34d

// In https://github.com/preactjs/preact/pull/4724, preact will

// skip render if the `vnode._original` is not changed, even if `c._force` is true

// So we need to increment `vnode._original` to make sure the `__root.__jsx` is re-rendered

// This is the same logic with: https://github.com/preactjs/preact/blob/43178581442fa0f2428e5bdbca355860b2d12e5d/src/component.js#L131

if (__root.__jsx) {

const newVNode = Object.assign({}, __root.__jsx) as unknown as VNode;

if (newVNode[ORIGINAL] != null) {

newVNode[ORIGINAL] += 1;

// @ts-expect-error: __root.__jsx is a VNode

__root.__jsx = newVNode;

}

}

…dered

github-actions · 2026-03-31T17:49:47Z

This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump").

HuJean requested a review from hzy as a code owner January 22, 2026 05:38

coderabbitai bot added the framework:React label Jan 22, 2026

hzy approved these changes Jan 22, 2026

View reviewed changes

upupming reviewed Jan 23, 2026

View reviewed changes

fix: increment vnode._original to make sure the component is re-ren…

1653b8f

…dered

HuJean force-pushed the p/fix-globalProps branch from 62ef34d to 1653b8f Compare January 30, 2026 05:18

github-actions bot added the stale Inactive for 30 days. Will be closed by bots. label Mar 31, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: increment `vnode._original` to make sure the component is re-ren…#2126

fix: increment `vnode._original` to make sure the component is re-ren…#2126
HuJean wants to merge 1 commit intomainfrom
p/fix-globalProps

HuJean commented Jan 22, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 22, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

relativeci bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

upupming Jan 23, 2026

Uh oh!

upupming Jan 23, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	if (vnode[ORIGINAL] != null && oldVNode[ORIGINAL] === vnode[ORIGINAL]) {
	if (vnode !=== oldVNode && vnode[ORIGINAL] != null && oldVNode[ORIGINAL] === vnode[ORIGINAL]) {

	// In https://github.com/preactjs/preact/pull/4724, preact will
	// skip render if the `vnode._original` is not changed, even if `c._force` is true
	// So we need to increment `vnode._original` to make sure the `__root.__jsx` is re-rendered
	// This is the same logic with: https://github.com/preactjs/preact/blob/43178581442fa0f2428e5bdbca355860b2d12e5d/src/component.js#L131
	if (__root.__jsx) {
	const newVNode = Object.assign({}, __root.__jsx) as unknown as VNode;
	if (newVNode[ORIGINAL] != null) {
	newVNode[ORIGINAL] += 1;
	// @ts-expect-error: __root.__jsx is a VNode
	__root.__jsx = newVNode;
	}
	}

Conversation

HuJean commented Jan 22, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will degrade performance by 5.35%

Summary

Performance Changes

Footnotes

Uh oh!

relativeci bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#7432 Bundle Size — 383.56KiB (0%).

Uh oh!

upupming Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

upupming Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HuJean commented Jan 22, 2026 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jan 22, 2026 •

edited

Loading

coderabbitai bot commented Jan 22, 2026 •

edited

Loading

codecov bot commented Jan 22, 2026 •

edited

Loading

codspeed-hq bot commented Jan 22, 2026 •

edited

Loading

relativeci bot commented Jan 22, 2026 •

edited

Loading