fix: should clear list callbacks when `__DestroyLifetime` by gaoachao · Pull Request #2112 · lynx-family/lynx-stack

gaoachao · 2026-01-15T08:59:15Z

Summary by CodeRabbit

New Features
- Exposed a lightweight native event accessor for testing and integration.
Bug Fixes
- Fixed a memory leak by clearing list update callbacks when a list is destroyed.
Tests
- Added tests to verify list callbacks are cleared on destruction.
Chores
- Prepared a patch release entry for the package.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2026-01-15T08:59:20Z

🦋 Changeset detected

Latest commit: a34e7fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lynx-js/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-01-15T08:59:30Z

📝 Walkthrough

Walkthrough

Adds a native __DestroyLifetime listener to clear list callbacks on destruction, updates the __UpdateListCallbacks type to accept nullable callbacks, introduces tests and a test-native shim, and adds a changeset for a patch release of @lynx-js/react.

Changes

Cohort / File(s)	Summary
Runtime list cleanup `packages/react/runtime/src/snapshot/list.ts`	Register native `__DestroyLifetime` listener that calls `__UpdateListCallbacks(list, null, null, null)` to clear list callbacks when a lifetime is destroyed.
Type declaration updates `packages/react/runtime/types/types.d.ts`	Change `__UpdateListCallbacks` signature so `componentAtIndex`, `enqueueComponent`, and `componentAtIndexes` may be `
Tests & test shim `packages/react/runtime/__test__/list.test.jsx`, `packages/react/runtime/__test__/utils/globals.js`	Add test verifying callbacks are cleared after `__DestroyLifetime` dispatch; introduce/extend a test-native shim with event listener API and a `_clear` reset helper.
Testing environment API `packages/testing-library/testing-environment/src/index.ts`	Expose `lynx.getNative()` returning a lightweight native object with event listener management and messaging stubs for tests.
Release metadata `.changeset/tender-radios-lose.md`	Add a changeset indicating a patch release for `@lynx-js/react` documenting the memory-leak fix.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

ci(benchmark/react): enable list in benchmark #1635 — Modifies/uses __UpdateListCallbacks plumbing and instruments componentAtIndex, likely touching the same list-callback mechanics.

Suggested reviewers

HuJean
hzy

Poem

🐇 I hop through lists and hush the call,
When DestroyLifetime rings, I clear them all.
Callbacks tucked, no memory stew,
A nimble burrow, fresh and new. 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main fix: clearing list callbacks when the __DestroyLifetime event is triggered, which matches the core implementation across all modified files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-01-15T09:06:17Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
4715	1	4714	127

View the top 2 failed test(s) by shortest run time

packages/rspeedy/plugin-qrcode/test/shortcuts.test.ts > PluginQRCode - CLI Shortcuts > open page

Stack Traces | 1.51s run time

Error: Matcher did not succeed in time.
 ❯ test/shortcuts.test.ts:51:40

Caused by: Caused by: Caused by: AssertionError: expected "Vt" to be called 2 times, but got 0 times

tests/reactlynx.spec.ts::reactlynx3 tests › basic › basic-reload-page-only-one

Stack Traces | 13.1s run time

reactlynx.spec.ts:90:5 basic-reload-page-only-one

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

codspeed-hq · 2026-01-15T09:16:20Z

CodSpeed Performance Report

Merging this PR will improve performance by 9.45%

_{Comparing fix/update-list-callbacks (a34e7fb) with main (556fe9f)}

Summary

⚡ 1 improved benchmark
✅ 62 untouched benchmarks
⏩ 3 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`basic-performance-div-100`	7.6 ms	6.9 ms	+9.45%

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-01-15T09:21:49Z

Web Explorer

#7434 Bundle Size — 383.63KiB (+0.02%).

a34e7fb(current) vs d1b0d9e main#7429(baseline)

Bundle metrics

3 changes

1 improvement

	Current #7434	Baseline #7429
Initial JS	`154.03KiB`(`-0.45%`)	`154.71KiB`
Initial CSS	`35.05KiB`	`35.05KiB`
Cache Invalidation	`84.88%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`239`(`+0.84%`)	`237`
Duplicate Modules	`16`	`16`
Duplicate Code	`2.99%`	`2.99%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type

2 changes

1 regression

1 improvement

	Current #7434	Baseline #7429
JS	`251.56KiB` (`-0.44%`)	`252.66KiB`
Other	`97.02KiB` (`+1.22%`)	`95.85KiB`
CSS	`35.05KiB`	`35.05KiB`

Bundle analysis report Branch fix/update-list-callbacks Project dashboard

^{Generated by RelativeCI Documentation Report issue}

hzy

You will need a test to avoid regress of this leak

gaoachao · 2026-01-19T12:51:27Z

@HuJean @hzy PTAL~

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/motion@0.0.2 ### Patch Changes - Add initial support for `@lynx-js/motion` ([#1062](#1062)) ## @lynx-js/react@0.116.2 ### Patch Changes - Fix "TypeError: not a function" error caused by `replaceAll` not supported in ES5. ([#2142](#2142)) - Bump `swc_core` v56. ([#2154](#2154)) - Use `disableDeprecatedWarning` option to suppress BROKEN warnings during compilation. ([#2157](#2157)) 1. BROKEN: `getNodeRef`/`getNodeRefFromRoot`/`createSelectorQuery` on component instance is broken and MUST be migrated in ReactLynx 3.0, please use ref or lynx.createSelectorQuery instead. 2. BROKEN: `getElementById` on component instance is broken and MUST be migrated in ReactLynx 3.0, please use ref or lynx.getElementById instead. - Fix memory leak by clearing list callbacks when \_\_DestroyLifetime event is triggered. ([#2112](#2112)) ## @lynx-js/rspeedy@0.13.3 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.19.7 ## @lynx-js/qrcode-rsbuild-plugin@0.4.4 ### Patch Changes - Bump `@clack/prompts` v1.0 ([#2171](#2171)) ## @lynx-js/react-rsbuild-plugin@0.12.7 ### Patch Changes - Updated dependencies \[[`92881e7`](92881e7), [`1a5f2a1`](1a5f2a1)]: - @lynx-js/template-webpack-plugin@0.10.3 - @lynx-js/css-extract-webpack-plugin@0.7.0 - @lynx-js/react-webpack-plugin@0.7.3 - @lynx-js/react-alias-rsbuild-plugin@0.12.7 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.4 ## @lynx-js/web-constants@0.19.7 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.19.7 ## @lynx-js/web-core@0.19.7 ### Patch Changes - feat: add browser config of lynx-view, now you can customize the browser config of lynx-view: ([#2140](#2140)) lynxView.browserConfig = { pixelRatio: 1, pixelWidth: 1234, pixelHeight: 5678, } - Updated dependencies \[]: - @lynx-js/web-constants@0.19.7 - @lynx-js/web-mainthread-apis@0.19.7 - @lynx-js/web-worker-rpc@0.19.7 - @lynx-js/web-worker-runtime@0.19.7 ## @lynx-js/web-core-wasm@0.0.2 ### Patch Changes - Updated dependencies \[[`43fc7e7`](43fc7e7)]: - @lynx-js/web-elements@0.11.1 - @lynx-js/web-worker-rpc@0.19.7 ## @lynx-js/web-elements@0.11.1 ### Patch Changes - feat: add wheel event handling and corresponding tests for x-foldview-ng ([#2145](#2145)) ## @lynx-js/web-mainthread-apis@0.19.7 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.19.7 ## @lynx-js/web-worker-runtime@0.19.7 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.19.7 - @lynx-js/web-mainthread-apis@0.19.7 - @lynx-js/web-worker-rpc@0.19.7 ## @lynx-js/template-webpack-plugin@0.10.3 ### Patch Changes - Fix "Failed to load CSS update file" for lazy bundle ([#2150](#2150)) - Fix "TypeError: cannot read property 'call' of undefined" error of lazy bundle HMR. ([#2146](#2146)) ## create-rspeedy@0.13.3 ## @lynx-js/react-alias-rsbuild-plugin@0.12.7 ## upgrade-rspeedy@0.13.3 ## @lynx-js/web-core-server@0.19.7 ## @lynx-js/web-rsbuild-server-middleware@0.19.7 ## @lynx-js/web-worker-rpc@0.19.7 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: should clear list callbacks when __DestroyLifetime

afc9be6

gaoachao requested review from HuJean and hzy as code owners January 15, 2026 08:59

coderabbitai Bot added the framework:React label Jan 15, 2026

HuJean reviewed Jan 15, 2026

View reviewed changes

Comment thread packages/react/runtime/src/snapshot/list.ts Outdated

hzy requested changes Jan 18, 2026

View reviewed changes

gaoachao added the element:list label Jan 19, 2026

chore: add test

b3893ed

gaoachao added 2 commits January 19, 2026 20:53

chore: add safe check

72916be

Merge branch 'main' into fix/update-list-callbacks

a34e7fb

gaoachao requested review from HuJean and hzy January 21, 2026 12:47

HuJean approved these changes Jan 29, 2026

View reviewed changes

hzy approved these changes Jan 29, 2026

View reviewed changes

gaoachao merged commit d1b0d9e into main Jan 29, 2026
106 of 111 checks passed

gaoachao deleted the fix/update-list-callbacks branch January 29, 2026 10:03

github-actions Bot mentioned this pull request Jan 29, 2026

chore: Release 2026-02-01 03:42:02 #2141

Merged

coderabbitai Bot mentioned this pull request Feb 11, 2026

fix: properly cleanup __DestroyLifetime listeners and listCallbacks in snapshotDestroyList #2224

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: should clear list callbacks when `__DestroyLifetime`#2112

fix: should clear list callbacks when `__DestroyLifetime`#2112
gaoachao merged 4 commits intomainfrom
fix/update-list-callbacks

gaoachao commented Jan 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jan 15, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

hzy left a comment

Uh oh!

gaoachao commented Jan 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gaoachao commented Jan 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot Bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 1 Tests Failed:

Uh oh!

codspeed-hq Bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will improve performance by 9.45%

Summary

Performance Changes

Footnotes

Uh oh!

relativeci Bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#7434 Bundle Size — 383.63KiB (+0.02%).

Uh oh!

Uh oh!

hzy left a comment

Choose a reason for hiding this comment

Uh oh!

gaoachao commented Jan 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gaoachao commented Jan 15, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Jan 15, 2026 •

edited

Loading

coderabbitai Bot commented Jan 15, 2026 •

edited

Loading

codecov Bot commented Jan 15, 2026 •

edited

Loading

codspeed-hq Bot commented Jan 15, 2026 •

edited

Loading

relativeci Bot commented Jan 15, 2026 •

edited

Loading