feat: Update external bundle mini SDK version to 3.5 and export ExteralValue TS type

[luhc228]

Summary by CodeRabbit

• New Features

  • Added a public ExternalValue type to standardize external resource configuration.
  • Externals API now references the new ExternalValue shape.

• Chores

  • Minimum engine/SDK requirement raised to 3.5 (default updated).
  • Externals-loading plugin added to site docs and included as a development dependency.

• Bug Fixes / Maintenance

  • Public option renamed for consistency in external bundle configuration; tests and examples updated.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).
• Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

[changeset-bot]

🦋 Changeset detected

Latest commit: aeacb9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@lynx-js/lynx-bundle-rslib-config	Minor
@lynx-js/externals-loading-webpack-plugin	Patch
@lynx-js/external-bundle-rsbuild-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

📝 Walkthrough

Walkthrough

Renames public option/property targetSdkVersion → engineVersion and bumps its default/docs from 3.4 → 3.5 across rslib config, plugin code, and tests; introduces a new exported ExternalValue interface and switches ExternalsLoadingPluginOptions.externals to Record<string, ExternalValue>; adds changesets and website/dev tooling entries.

Changes

Cohort / File(s)	Summary
Changeset declarations \.changeset/update-min-sdk-version.md, \.changeset/wise-beds-speak.md	New changeset files documenting the rslib SDK default bump (3.4 → 3.5) and a patch release including the exported ExternalValue type.
Externals plugin public API packages/webpack/externals-loading-webpack-plugin/src/index.ts, packages/webpack/externals-loading-webpack-plugin/etc/externals-loading-webpack-plugin.api.md	Adds and exports ExternalValue (url, libraryName?, async?, background?, mainThread?, timeout?) and changes ExternalsLoadingPluginOptions.externals to Record<string, ExternalValue>; moves inline per-external docs into the interface.
rslib config & webpack plugin packages/rspeedy/lynx-bundle-rslib-config/src/...ExternalBundleWebpackPlugin.ts, packages/rspeedy/lynx-bundle-rslib-config/src/externalBundleRslibConfig.ts, packages/rspeedy/lynx-bundle-rslib-config/etc/lynx-bundle-rslib-config.api.md, packages/rspeedy/lynx-bundle-rslib-config/test/external-bundle.test.ts	Renames public fields and parameters from targetSdkVersion → engineVersion (interfaces, JSDoc, function signatures, tests); updates defaults/docs from '3.4' → '3.5' and adjusts internal call sites and emitted config paths.
Website integration website/package.json, website/rspress.config.ts	Adds @lynx-js/externals-loading-webpack-plugin as a devDependency and registers the plugin in the Webpack Plugins API sidebars (en/zh).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: init @lynx-js/lynx-bundle-rslib-config #1943 — overlaps the rename and default bump from targetSdkVersion → engineVersion (3.4 → 3.5).
• feat: introduce external-bundle-rsbuild-plugin #2006 — touches usages of ExternalsLoadingPluginOptions and may need the new ExternalValue shape.
• feat(external-loading-plugin): remove backgroundChunks and mainThreadChunks options #2002 — also modifies ExternalsLoadingPluginOptions shape/fields and could conflict with the new interface.

Suggested reviewers

• colinaaa
• upupming

Poem

I'm a rabbit with a tiny patch,
I hopped through types and bumped the batch 🐇,
engineVersion now leads the way,
externals tidy, neat display,
hops of joy for docs today.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the two main changes: updating the external bundle SDK version to 3.5 and exporting the ExternalValue TypeScript type.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87e5d57 and aeacb9d.

📒 Files selected for processing (2)

• .changeset/update-min-sdk-version.md
• packages/webpack/externals-loading-webpack-plugin/src/index.ts

🧰 Additional context used

📓 Path-based instructions (1)

.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

For contributions, generate and commit a Changeset describing your changes

Files:

• .changeset/update-min-sdk-version.md

🧠 Learnings (11)

📓 Common learnings

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:52-72
Timestamp: 2025-08-13T11:36:12.075Z
Learning: The lynx-stack project requires Node.js >=22 as specified in package.json engines, so Node.js compatibility fallbacks for features introduced before v22 are unnecessary.

📚 Learning: 2025-08-07T04:00:59.645Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts
• .changeset/update-min-sdk-version.md

📚 Learning: 2025-11-06T01:19:23.670Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts
• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-13T11:36:12.075Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:52-72
Timestamp: 2025-08-13T11:36:12.075Z
Learning: The lynx-stack project requires Node.js >=22 as specified in package.json engines, so Node.js compatibility fallbacks for features introduced before v22 are unnecessary.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts
• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-20T04:56:36.011Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1566
File: package.json:53-53
Timestamp: 2025-08-20T04:56:36.011Z
Learning: In lynx-stack, Node.js v24 is the preferred/default version for development (established in PR #1557), but Node.js v22 compatibility is maintained specifically for external CI systems like rspack-ecosystem-ci. The engines.node specification uses "^22 || ^24" to support both versions while keeping v24 as the primary target.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts
• .changeset/update-min-sdk-version.md

📚 Learning: 2025-09-12T09:43:04.847Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts
• .changeset/update-min-sdk-version.md

📚 Learning: 2025-09-12T09:43:04.847Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-07-22T09:23:07.797Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-07-22T09:26:16.722Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-14T12:54:51.143Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: .changeset/brave-melons-add.md:1-7
Timestamp: 2025-08-14T12:54:51.143Z
Learning: In the lynx-family/lynx-stack repository, packages use 0.x.x versioning where minor version bumps indicate breaking changes (not major bumps), following pre-1.0 semantic versioning conventions.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-19T11:25:36.127Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).

Applied to files:

• .changeset/update-min-sdk-version.md

🔇 Additional comments (4)

.changeset/update-min-sdk-version.md (1)

1-5: LGTM! Changeset follows conventions.

The changeset correctly declares a minor version bump for the package with a clear description of the change. The package name is properly scoped and the format follows repository conventions.

packages/webpack/externals-loading-webpack-plugin/src/index.ts (3)

11-11: Version requirement correctly updated.

The comment now properly reflects the minimum Lynx version 3.5 requirement, addressing the previous review feedback.

---

79-82: Good refactoring to use named interface.

Extracting the inline type to the named ExternalValue interface improves code organization and makes the type reusable. This is backward compatible due to TypeScript's structural typing.

---

85-200: Well-documented public interface with comprehensive examples.

The ExternalValue interface is properly structured with thorough documentation and multiple examples covering various use cases. The type definitions correctly align with webpack's externals API. The changeset .changeset/wise-beds-speak.md properly documents this new public export as a patch version bump.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 71b9083 and cc242d5.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (8)

• .changeset/update-min-sdk-version.md
• .changeset/wise-beds-speak.md
• packages/rspeedy/lynx-bundle-rslib-config/src/externalBundleRslibConfig.ts
• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
• packages/webpack/externals-loading-webpack-plugin/etc/externals-loading-webpack-plugin.api.md
• packages/webpack/externals-loading-webpack-plugin/src/index.ts
• website/package.json
• website/rspress.config.ts

🧰 Additional context used

📓 Path-based instructions (2)

packages/**/etc/*.api.md

📄 CodeRabbit inference engine (AGENTS.md)

Always commit API extractor output after running pnpm turbo api-extractor -- --local (commit updated API report files)

Files:

• packages/webpack/externals-loading-webpack-plugin/etc/externals-loading-webpack-plugin.api.md

.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

For contributions, generate and commit a Changeset describing your changes

Files:

• .changeset/wise-beds-speak.md
• .changeset/update-min-sdk-version.md

🧠 Learnings (14)

📓 Common learnings

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: .changeset/brave-melons-add.md:1-7
Timestamp: 2025-08-14T12:54:51.143Z
Learning: In the lynx-family/lynx-stack repository, packages use 0.x.x versioning where minor version bumps indicate breaking changes (not major bumps), following pre-1.0 semantic versioning conventions.

📚 Learning: 2025-11-06T01:19:23.670Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.

Applied to files:

• packages/rspeedy/lynx-bundle-rslib-config/src/externalBundleRslibConfig.ts
• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
• .changeset/update-min-sdk-version.md
• website/package.json

📚 Learning: 2025-09-12T09:43:04.847Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.

Applied to files:

• .changeset/wise-beds-speak.md
• .changeset/update-min-sdk-version.md
• website/package.json

📚 Learning: 2025-09-12T09:43:04.847Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Applied to files:

• .changeset/wise-beds-speak.md
• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
• .changeset/update-min-sdk-version.md
• website/package.json

📚 Learning: 2025-07-22T09:23:07.797Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.

Applied to files:

• .changeset/wise-beds-speak.md
• .changeset/update-min-sdk-version.md

📚 Learning: 2025-07-22T09:26:16.722Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.

Applied to files:

• .changeset/wise-beds-speak.md
• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-07T04:00:59.645Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.

Applied to files:

• .changeset/wise-beds-speak.md
• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
• .changeset/update-min-sdk-version.md
• website/package.json

📚 Learning: 2025-08-13T11:36:12.075Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:52-72
Timestamp: 2025-08-13T11:36:12.075Z
Learning: The lynx-stack project requires Node.js >=22 as specified in package.json engines, so Node.js compatibility fallbacks for features introduced before v22 are unnecessary.

Applied to files:

• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
• .changeset/update-min-sdk-version.md
• website/package.json

📚 Learning: 2025-08-20T04:56:36.011Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1566
File: package.json:53-53
Timestamp: 2025-08-20T04:56:36.011Z
Learning: In lynx-stack, Node.js v24 is the preferred/default version for development (established in PR #1557), but Node.js v22 compatibility is maintained specifically for external CI systems like rspack-ecosystem-ci. The engines.node specification uses "^22 || ^24" to support both versions while keeping v24 as the primary target.

Applied to files:

• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-27T12:42:01.095Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.

Applied to files:

• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
• website/package.json

📚 Learning: 2025-08-14T12:54:51.143Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: .changeset/brave-melons-add.md:1-7
Timestamp: 2025-08-14T12:54:51.143Z
Learning: In the lynx-family/lynx-stack repository, packages use 0.x.x versioning where minor version bumps indicate breaking changes (not major bumps), following pre-1.0 semantic versioning conventions.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-19T11:25:36.127Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).

Applied to files:

• .changeset/update-min-sdk-version.md
• website/package.json

📚 Learning: 2025-08-13T11:46:43.737Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.

Applied to files:

• website/package.json

📚 Learning: 2025-08-11T05:59:28.530Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.

Applied to files:

• website/package.json

🧬 Code graph analysis (1)

website/rspress.config.ts (1)

website/sidebars/api.ts (1)

• createAPI (155-192)

🔇 Additional comments (9)

packages/rspeedy/lynx-bundle-rslib-config/src/externalBundleRslibConfig.ts (1)

22-22: LGTM! Documentation updated correctly.

The JSDoc default value now accurately reflects the runtime default set in ExternalBundleWebpackPlugin.ts.

packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts (2)

39-39: LGTM! JSDoc updated to match runtime default.

The documentation now correctly reflects the default targetSdkVersion of '3.5'.

---

125-126: LGTM! Clear SDK requirement documentation.

The comment effectively documents the minimum SDK version requirement for the lynx.fetchBundle and lynx.loadScript APIs, and the runtime default is correctly set to '3.5'.

packages/webpack/externals-loading-webpack-plugin/src/index.ts (2)

79-82: LGTM! Type refactored for better reusability.

Extracting the inline type to a named ExternalValue interface improves API discoverability and allows consumers to reference the type directly.

---

85-198: LGTM! Comprehensive interface documentation.

The ExternalValue interface is well-documented with clear examples for each use case. The documentation explains:

• Default libraryName behavior
• How to handle multiple modules from the same bundle
• Subpath configuration with arrays

.changeset/wise-beds-speak.md (1)

1-5: LGTM! Changeset correctly documents the type export.

The patch-level changeset appropriately describes the non-breaking addition of the ExternalValue type export.

.changeset/update-min-sdk-version.md (1)

1-5: LGTM! Changeset follows repository conventions.

The minor-level bump is appropriate for this breaking change, as this repository uses 0.x.x versioning where minor bumps indicate breaking changes. The message clearly communicates the SDK version requirement update.

Based on learnings, this follows the established convention for pre-1.0 semantic versioning in this repository.

website/package.json (1)

25-25: LGTM! Dependency added correctly.

The new devDependency uses the workspace protocol consistently with other internal packages and is placed in alphabetical order.

packages/webpack/externals-loading-webpack-plugin/etc/externals-loading-webpack-plugin.api.md (1)

19-19: LGTM! API report correctly updated.

The API extractor output accurately reflects the source code changes, documenting the new ExternalValue interface and the updated externals type. As per coding guidelines, API extractor output has been properly committed.

Also applies to: 23-31

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[codspeed-hq]

CodSpeed Performance Report

Merging #2037 will not alter performance

_{Comparing luhc228:feat/update-external-bundle-min-sdk-version (aeacb9d) with main (abd5960)}

Summary

✅ 63 untouched
⏩ 3 skipped¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[relativeci]

React Example

#6670 Bundle Size — 237.01KiB (0%).

aeacb9d(current) vs abd5960 main#6648(baseline)

Bundle metrics  no changes

	Current #6670	Baseline #6648
Initial JS	0B	0B
Initial CSS	0B	0B
Cache Invalidation	0%	38.47%
Chunks	0	0
Assets	4	4
Modules	162	162
Duplicate Modules	65	65
Duplicate Code	46.75%	46.75%
Packages	2	2
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #6670	Baseline #6648
IMG	145.76KiB	145.76KiB
Other	91.25KiB	91.25KiB

Bundle analysis report Branch luhc228:feat/update-external-bun... Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[relativeci]

Web Explorer

#6830 Bundle Size — 376.4KiB (0%).

aeacb9d(current) vs abd5960 main#6808(baseline)

Bundle metrics   1 change

	Current #6830	Baseline #6808
Initial JS	149.87KiB	149.87KiB
Initial CSS	32.4KiB	32.4KiB
Cache Invalidation	0%	0%
Chunks	8	8
Assets	8	8
Modules	229(-0.87%)	231
Duplicate Modules	16	16
Duplicate Code	3.12%	3.12%
Packages	4	4
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #6830	Baseline #6808
JS	247.01KiB	247.01KiB
Other	96.98KiB	96.98KiB
CSS	32.4KiB	32.4KiB

Bundle analysis report Branch luhc228:feat/update-external-bun... Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

website/rspress.config.ts (1)

336-345: Add @lynx-js/externals-loading-webpack-plugin to webpack CHANGELOG configurations.

The plugin is a public package with an active changeset but is missing from the CHANGELOG tracking at lines 336-345 (English) and 365-375 (Chinese). Add it to both plugin lists to maintain consistency with other webpack plugins.

Also applies to: 365-375

🧹 Nitpick comments (1)

packages/webpack/externals-loading-webpack-plugin/src/index.ts (1)

11-11: Add documentation explaining why Lynx 3.5 is required.

The comment states the plugin requires Lynx 3.5 but doesn't explain what specific APIs or features introduced in Lynx 3.5 necessitate this version. Since lynx.fetchBundle() and lynx.loadScript() are the core APIs used, clarify whether these are new in 3.5 or if they existed in 3.4 with limitations. This helps developers understand version constraints.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc242d5 and 9369580.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (8)

• .changeset/update-min-sdk-version.md
• .changeset/wise-beds-speak.md
• packages/rspeedy/lynx-bundle-rslib-config/src/externalBundleRslibConfig.ts
• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
• packages/webpack/externals-loading-webpack-plugin/etc/externals-loading-webpack-plugin.api.md
• packages/webpack/externals-loading-webpack-plugin/src/index.ts
• website/package.json
• website/rspress.config.ts

🚧 Files skipped from review as they are similar to previous changes (6)

• .changeset/wise-beds-speak.md
• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
• .changeset/update-min-sdk-version.md
• packages/webpack/externals-loading-webpack-plugin/etc/externals-loading-webpack-plugin.api.md
• packages/rspeedy/lynx-bundle-rslib-config/src/externalBundleRslibConfig.ts
• website/package.json

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.

🧬 Code graph analysis (1)

website/rspress.config.ts (1)

website/sidebars/api.ts (1)

• createAPI (155-192)

🔇 Additional comments (2)

packages/webpack/externals-loading-webpack-plugin/src/index.ts (2)

85-198: LGTM! Excellent API improvement.

Extracting ExternalValue as a separate exported interface is a clean, non-breaking refactor that improves the plugin's API surface. The extensive documentation with multiple examples clearly explains each field's purpose and usage patterns, making the type reusable for consumers.

---

79-82: LGTM! Type reference correctly updated.

The change from an inline type to ExternalValue maintains full backward compatibility while referencing the newly extracted interface.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9369580 and b07ffb2.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (7)

• .changeset/update-min-sdk-version.md
• .changeset/wise-beds-speak.md
• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
• packages/webpack/externals-loading-webpack-plugin/etc/externals-loading-webpack-plugin.api.md
• packages/webpack/externals-loading-webpack-plugin/src/index.ts
• website/package.json
• website/rspress.config.ts

🚧 Files skipped from review as they are similar to previous changes (5)

• website/rspress.config.ts
• packages/webpack/externals-loading-webpack-plugin/etc/externals-loading-webpack-plugin.api.md
• .changeset/update-min-sdk-version.md
• website/package.json
• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts

🧰 Additional context used

📓 Path-based instructions (1)

.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

For contributions, generate and commit a Changeset describing your changes

Files:

• .changeset/wise-beds-speak.md

🧠 Learnings (11)

📓 Common learnings

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

📚 Learning: 2025-09-12T09:43:04.847Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Applied to files:

• .changeset/wise-beds-speak.md
• packages/webpack/externals-loading-webpack-plugin/src/index.ts

📚 Learning: 2025-09-12T09:43:04.847Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.

Applied to files:

• .changeset/wise-beds-speak.md

📚 Learning: 2025-08-27T12:42:01.095Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts

📚 Learning: 2025-08-21T08:46:54.494Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts

📚 Learning: 2025-08-13T11:46:43.737Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts

📚 Learning: 2025-09-25T14:03:25.576Z

Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts

📚 Learning: 2025-08-12T16:09:32.413Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts

📚 Learning: 2025-08-27T08:10:09.932Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts

📚 Learning: 2025-11-06T01:19:23.670Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts

📚 Learning: 2025-08-13T11:36:12.075Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:52-72
Timestamp: 2025-08-13T11:36:12.075Z
Learning: The lynx-stack project requires Node.js >=22 as specified in package.json engines, so Node.js compatibility fallbacks for features introduced before v22 are unnecessary.

Applied to files:

• packages/webpack/externals-loading-webpack-plugin/src/index.ts

🔇 Additional comments (3)

packages/webpack/externals-loading-webpack-plugin/src/index.ts (2)

79-82: LGTM! Clean refactoring to use named type.

Extracting the inline type to the ExternalValue interface improves code maintainability and enables the type to be exported for external use.

---

85-198: LGTM! Well-documented public interface.

The ExternalValue interface is properly defined with comprehensive documentation. The JSDoc comments provide clear examples for complex scenarios, document default values, and explain the behavior thoroughly.

.changeset/wise-beds-speak.md (1)

1-5: LGTM! Appropriate changeset for public API addition.

The changeset correctly documents the export of the ExternalValue type with a patch version bump, which is appropriate for this API addition.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.changeset/update-min-sdk-version.md (1)

5-5: Consider expanding the changelog message.

The current message is clear but brief. Since this PR also introduces a new public ExternalValue TypeScript type export, consider adding that detail to the changelog entry to better inform users about the scope of changes.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c904885 and 0442162.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (8)

• .changeset/update-min-sdk-version.md
• .changeset/wise-beds-speak.md
• packages/rspeedy/lynx-bundle-rslib-config/src/externalBundleRslibConfig.ts
• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts
• packages/webpack/externals-loading-webpack-plugin/etc/externals-loading-webpack-plugin.api.md
• packages/webpack/externals-loading-webpack-plugin/src/index.ts
• website/package.json
• website/rspress.config.ts

✅ Files skipped from review due to trivial changes (1)

• packages/rspeedy/lynx-bundle-rslib-config/src/externalBundleRslibConfig.ts

🚧 Files skipped from review as they are similar to previous changes (6)

• .changeset/wise-beds-speak.md
• packages/webpack/externals-loading-webpack-plugin/src/index.ts
• website/rspress.config.ts
• packages/webpack/externals-loading-webpack-plugin/etc/externals-loading-webpack-plugin.api.md
• website/package.json
• packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts

🧰 Additional context used

📓 Path-based instructions (1)

.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

For contributions, generate and commit a Changeset describing your changes

Files:

• .changeset/update-min-sdk-version.md

🧠 Learnings (11)

📓 Common learnings

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1566
File: package.json:53-53
Timestamp: 2025-08-20T04:56:36.011Z
Learning: In lynx-stack, Node.js v24 is the preferred/default version for development (established in PR #1557), but Node.js v22 compatibility is maintained specifically for external CI systems like rspack-ecosystem-ci. The engines.node specification uses "^22 || ^24" to support both versions while keeping v24 as the primary target.

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:52-72
Timestamp: 2025-08-13T11:36:12.075Z
Learning: The lynx-stack project requires Node.js >=22 as specified in package.json engines, so Node.js compatibility fallbacks for features introduced before v22 are unnecessary.

📚 Learning: 2025-09-12T09:43:04.847Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-09-12T09:43:04.847Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-07-22T09:23:07.797Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-07-22T09:26:16.722Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-14T12:54:51.143Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: .changeset/brave-melons-add.md:1-7
Timestamp: 2025-08-14T12:54:51.143Z
Learning: In the lynx-family/lynx-stack repository, packages use 0.x.x versioning where minor version bumps indicate breaking changes (not major bumps), following pre-1.0 semantic versioning conventions.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-11-06T01:19:23.670Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-13T11:36:12.075Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:52-72
Timestamp: 2025-08-13T11:36:12.075Z
Learning: The lynx-stack project requires Node.js >=22 as specified in package.json engines, so Node.js compatibility fallbacks for features introduced before v22 are unnecessary.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-19T11:25:36.127Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-20T04:56:36.011Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1566
File: package.json:53-53
Timestamp: 2025-08-20T04:56:36.011Z
Learning: In lynx-stack, Node.js v24 is the preferred/default version for development (established in PR #1557), but Node.js v22 compatibility is maintained specifically for external CI systems like rspack-ecosystem-ci. The engines.node specification uses "^22 || ^24" to support both versions while keeping v24 as the primary target.

Applied to files:

• .changeset/update-min-sdk-version.md

📚 Learning: 2025-08-07T04:00:59.645Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.

Applied to files:

• .changeset/update-min-sdk-version.md

🔇 Additional comments (2)

.changeset/update-min-sdk-version.md (2)

1-5: Verify SDK version target: PR title states 3.4 but changeset states 3.5.

The PR title specifies "Update external bundle mini SDK version to 3.4", but this changeset declares the version as 3.5. The AI summary and related code changes also reference 3.5. Clarify which is the intended target version.

---

1-3: Changeset format and structure look good.

The file follows the standard changeset format with the correct scoped package name (@lynx-js/lynx-bundle-rslib-config) and an appropriate minor version bump for the breaking API change (ExternalValue export). Based on learnings, this aligns with the expected structure and naming conventions for this repository.