chore(rspeedy/react): disable tsgo by colinaaa · Pull Request #1974 · lynx-family/lynx-stack

colinaaa · 2025-12-02T02:47:25Z

Summary by CodeRabbit

Chores
- Adjusted TypeScript declaration generation for two React plugin packages: switched the tsgo-style declaration output from enabled to disabled.
- Updated build configuration to preserve existing bundling behavior while changing how .d.ts files are produced.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2025-12-02T02:47:29Z

⚠️ No Changeset found

Latest commit: 39d15b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-02T02:47:37Z

📝 Walkthrough

Walkthrough

Updated TypeScript declaration generation flags in two rslib config files: changed dts.tsgo from true to false in both plugin React packages' library entries.

Changes

Cohort / File(s)	Summary
Build configuration — React plugins `packages/rspeedy/plugin-react-alias/rslib.config.ts`, `packages/rspeedy/plugin-react/rslib.config.ts`	Changed `dts.tsgo` from `true` to `false` in the exported `lib` configuration objects (affects TypeScript declaration generation mode).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Homogeneous, small config edits across two files — review mainly to confirm intended declaration generation behavior and any downstream build expectations.

Possibly related PRs

feat: integrate with tsgo (with Rslib) #1685: Modifies dts.tsgo settings across multiple rslib.config files; likely related to coordinated changes in declaration generation strategy.

Suggested reviewers

upupming
gaoachao
HuJean

Poem

🐰 I nudged a flag from true to false tonight,
Tiny hop of config, kept my whiskers light.
Declarations whisper different tunes,
I nibble carrots and hum to the moons,
A quiet change — the build stays bright. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore(rspeedy/react): disable tsgo' accurately describes the main change in the changeset, which is disabling the tsgo flag across two config files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 013bef1 and 4033c79.

📒 Files selected for processing (1)

packages/rspeedy/plugin-react/rslib.config.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

📚 Learning: 2025-08-06T13:28:57.182Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.

Applied to files:

packages/rspeedy/plugin-react/rslib.config.ts

📚 Learning: 2025-08-13T11:46:43.737Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.

Applied to files:

packages/rspeedy/plugin-react/rslib.config.ts

📚 Learning: 2025-08-06T13:28:57.182Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.

Applied to files:

packages/rspeedy/plugin-react/rslib.config.ts

🔇 Additional comments (1)

packages/rspeedy/plugin-react/rslib.config.ts (1)

8-8: No concerns with disabling tsgo.

The change switches the TypeScript declaration generation from the experimental tsgo engine to the standard TypeScript Compiler API. Both generate valid .d.ts files without structural differences affecting consumers. This is a safe maintenance change and does not require a BREAKING CHANGE notation in the changeset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-12-02T02:53:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

relativeci · 2025-12-02T03:01:23Z

React Example

#6286 Bundle Size — 236.33KiB (0%).

39d15b3(current) vs 5bbb439 main#6281(baseline)

Bundle metrics no changes

	Current #6286	Baseline #6281
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`38.26%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`162`	`162`
Duplicate Modules	`65`	`65`
Duplicate Code	`46.71%`	`46.71%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #6286	Baseline #6281
IMG	`145.76KiB`	`145.76KiB`
Other	`90.57KiB`	`90.57KiB`

Bundle analysis report Branch colinaaa:colin/1202/tsgo Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2025-12-02T03:01:35Z

Web Explorer

#6446 Bundle Size — 377.48KiB (0%).

39d15b3(current) vs 5bbb439 main#6441(baseline)

Bundle metrics

2 changes

	Current #6446	Baseline #6441
Initial JS	`146.31KiB`	`146.31KiB`
Initial CSS	`32.38KiB`	`32.38KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`229`(`-0.87%`)	`231`
Duplicate Modules	`16`	`16`
Duplicate Code	`2.96%`(`+0.34%`)	`2.95%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #6446	Baseline #6441
JS	`243.15KiB`	`243.15KiB`
Other	`101.94KiB`	`101.94KiB`
CSS	`32.38KiB`	`32.38KiB`

Bundle analysis report Branch colinaaa:colin/1202/tsgo Project dashboard

^{Generated by RelativeCI Documentation Report issue}

codspeed-hq · 2025-12-02T03:14:03Z

CodSpeed Performance Report

Merging #1974 will not alter performance

_{Comparing colinaaa:colin/1202/tsgo (39d15b3) with main (5bbb439)}

Summary

✅ 63 untouched
⏩ 3 skipped¹

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

## Summary by CodeRabbit * **Chores** * Adjusted TypeScript declaration generation for two React plugin packages: switched the tsgo-style declaration output from enabled to disabled. * Updated build configuration to preserve existing bundling behavior while changing how .d.ts files are produced. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>  ## Checklist  - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required). - [ ] Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

chore(rspeedy/react-alias): disable tsgo

013bef1

coderabbitai Bot added the framework:React label Dec 2, 2025

chore: disable tsgo in plugin-react

4033c79

colinaaa changed the title ~~chore(rspeedy/react-alias): disable tsgo~~ chore(rspeedy/react): disable tsgo Dec 2, 2025

Merge branch 'main' into colin/1202/tsgo

39d15b3

HuJean approved these changes Dec 2, 2025

View reviewed changes

colinaaa merged commit 8b19aff into lynx-family:main Dec 2, 2025
81 of 84 checks passed

colinaaa deleted the colin/1202/tsgo branch December 2, 2025 06:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(rspeedy/react): disable tsgo#1974

chore(rspeedy/react): disable tsgo#1974
colinaaa merged 3 commits intolynx-family:mainfrom
colinaaa:colin/1202/tsgo

colinaaa commented Dec 2, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Dec 2, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

relativeci Bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

relativeci Bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

colinaaa commented Dec 2, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

codecov Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

relativeci Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#6286 Bundle Size — 236.33KiB (0%).

Uh oh!

relativeci Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#6446 Bundle Size — 377.48KiB (0%).

Uh oh!

codspeed-hq Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #1974 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

colinaaa commented Dec 2, 2025 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Dec 2, 2025 •

edited

Loading

coderabbitai Bot commented Dec 2, 2025 •

edited

Loading

codecov Bot commented Dec 2, 2025 •

edited

Loading

relativeci Bot commented Dec 2, 2025 •

edited

Loading

relativeci Bot commented Dec 2, 2025 •

edited

Loading

codspeed-hq Bot commented Dec 2, 2025 •

edited

Loading