fix(web): x-input display add important by Sherry-hue · Pull Request #1960 · lynx-family/lynx-stack

Sherry-hue · 2025-11-26T09:08:55Z

Summary by CodeRabbit

Bug Fixes
- Fixed x-input element display styling to prevent it from being overridden by other styles.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2025-11-26T09:08:59Z

🦋 Changeset detected

Latest commit: 73c9c1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@lynx-js/web-elements	Patch
@lynx-js/web-elements-template	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-11-26T09:09:07Z

📝 Walkthrough

Walkthrough

A changeset file documents a patch release for @lynx-js/web-elements. The x-input component's CSS display property is modified to use !important, enforcing the rule to prevent unintended overrides.

Changes

Cohort / File(s)	Summary
Changeset documentation `.changeset/lazy-actors-divide.md`	New changeset file documenting patch release; specifies package name and version with fix note regarding x-input display enforcement
CSS updates `packages/web-platform/web-elements/src/XInput/x-input.css`	Added `!important` flag to `display: contents` rule for x-input element to prevent property overrides and enforce layout specificity

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Single CSS specificity update with minimal scope
Straightforward changeset documentation
No logic changes or structural modifications

Suggested labels

platform:Web

Suggested reviewers

PupilTong

Poem

🐰 A display most forceful, !important and true,
The x-input now stands, won't let overrides through,
With a hop and a change, the CSS now gleams,
Preserving the layout through all coding dreams! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main change: adding !important to the x-input display property in CSS. It aligns with the changeset and CSS modifications shown in the raw summary.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-11-26T09:15:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2025-11-26T09:23:53Z

CodSpeed Performance Report

Merging #1960 will not alter performance

_{Comparing Sherry-hue:fix/x-input-display (73c9c1f) with main (95a33f5)}

Summary

✅ 63 untouched
⏩ 3 skipped¹

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2025-11-26T09:32:19Z

Web Explorer

#6336 Bundle Size — 377.5KiB (~+0.01%).

73c9c1f(current) vs 95a33f5 main#6329(baseline)

Bundle metrics

4 changes

1 regression

	Current #6336	Baseline #6329
Initial JS	`146.32KiB`	`146.32KiB`
Initial CSS	`32.38KiB`(`+0.03%`)	`32.37KiB`
Cache Invalidation	`8.57%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`230`(`+0.44%`)	`229`
Duplicate Modules	`16`	`16`
Duplicate Code	`2.95%`(`-0.34%`)	`2.96%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #6336	Baseline #6329
JS	`243.18KiB`	`243.18KiB`
Other	`101.94KiB`	`101.94KiB`
CSS	`32.38KiB` (`+0.03%`)	`32.37KiB`

Bundle analysis report Branch Sherry-hue:fix/x-input-display Project dashboard

^{Generated by RelativeCI Documentation Report issue}

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/react@0.115.0 ### Minor Changes - **BREAKING CHANGE**: Delay the `createSnapshot` operation to `Snapshot` constructor to speed up IFR. ([#1899](#1899)) This change refactors how snapshots are created and registered: - Removed the `entryUniqID` function - Snapshots are now lazily created via `snapshotCreatorMap` instead of eagerly at bundle load time - Snapshot IDs are generated at compile time and only prefixed with `${globDynamicComponentEntry}:` for standalone lazy bundles **⚠️ Lazy Bundle Compatibility:** - **Backward compatibility (new runtime → old lazy bundles)**: ✅ **Supported**. Old lazy bundles will work with the new runtime. - **Forward compatibility (old runtime → new lazy bundles)**: ❌ **NOT Supported**. Lower version consumers **will not be able to load lazy bundles produced by this version** due to the changed snapshot creation mechanism. **Migration guidance**: If you are using lazy bundles, ensure all consumers are upgraded to this version or later **before** deploying lazy bundles built with this version. For monorepo setups, coordinate the upgrade across all consuming applications. ### Patch Changes - Preserve assignments to webpack runtime variables like `__webpack_public_path__`, `__webpack_require__.p`, etc. ([#1958](#1958)) - Fixed blank screen issues with nested lists. Lazily created nested lists were being flushed but not properly recorded, causing rendering failures. ([#1963](#1963)) - fix: export `createRef` and `useRef` from `@lynx-js/react/legacy-react-runtime` ([#1953](#1953)) ## @lynx-js/react-rsbuild-plugin@0.12.0 ### Minor Changes - **BREAKING CHANGE**: Require `@lynx-js/rspeedy` 0.12.0. ([#1951](#1951)) ### Patch Changes - Support Yarn Plug'n'Play. ([#1964](#1964)) - Updated dependencies \[[`738d44d`](738d44d), [`5bbb439`](5bbb439), [`3692a16`](3692a16), [`d2e290b`](d2e290b), [`738d44d`](738d44d)]: - @lynx-js/react-alias-rsbuild-plugin@0.12.0 - @lynx-js/css-extract-webpack-plugin@0.6.5 - @lynx-js/template-webpack-plugin@0.9.2 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.4 - @lynx-js/react-webpack-plugin@0.7.2 ## @lynx-js/react-alias-rsbuild-plugin@0.12.0 ### Minor Changes - **BREAKING CHANGE**: Use resolver from Rspack. ([#1964](#1964)) The `createLazyResolver` now requires an `rspack` parameter: ```diff - function createLazyResolver(directory: string, conditionNames: string[]): (request: string) => Promise<string>; + function createLazyResolver(rspack: rspack, directory: string, conditionNames: string[]): (request: string) => Promise<string>; ``` ### Patch Changes - Support Yarn Plug'n'Play. ([#1964](#1964)) ## @lynx-js/web-core@0.19.0 ### Minor Changes - feat: new flex:val impl ([#1979](#1979)) ### Patch Changes - Updated dependencies \[[`40c3a1a`](40c3a1a), [`46bd5ee`](46bd5ee)]: - @lynx-js/web-mainthread-apis@0.19.0 - @lynx-js/web-worker-runtime@0.19.0 - @lynx-js/web-constants@0.19.0 - @lynx-js/web-worker-rpc@0.19.0 ## @lynx-js/web-elements@0.9.0 ### Minor Changes - feat: new flex:val impl ([#1979](#1979)) ### Patch Changes - fix: x-input display should add !important to avoid override ([#1960](#1960)) - Updated dependencies \[]: - @lynx-js/web-elements-template@0.9.0 ## @lynx-js/rspeedy@0.12.1 ### Patch Changes - Bump Rsbuild v1.6.9 with Rspack v1.6.5. ([#1967](#1967)) - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.19.0 ## create-rspeedy@0.12.1 ### Patch Changes - Bump `@rsbuild/plugin-type-check` v1.3.1. ([#1964](#1964)) ## @lynx-js/lynx-bundle-rslib-config@0.0.1 ### Patch Changes - Add `@lynx-js/lynx-bundle-rslib-config` for bundling Lynx bundle with [Rslib](https://rslib.rs/): ([#1943](#1943)) ```js // rslib.config.js import { defineExternalBundleRslibConfig } from "@lynx-js/lynx-bundle-rslib-config"; export default defineExternalBundleRslibConfig({ id: "utils-lib", source: { entry: { utils: "./src/utils.ts", }, }, }); ``` ## @lynx-js/web-constants@0.19.0 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.19.0 ## @lynx-js/web-explorer@0.0.14 ### Patch Changes - chore: update web-elements version of web-explorer ([#1962](#1962)) ## @lynx-js/web-mainthread-apis@0.19.0 ### Patch Changes - fix: capture and bind event listener should be trigger correctly ([#1972](#1972)) - fix: the l-p-comp-uid of page should be '1' ([#1970](#1970)) - Updated dependencies \[]: - @lynx-js/web-constants@0.19.0 ## @lynx-js/web-worker-runtime@0.19.0 ### Patch Changes - Updated dependencies \[[`40c3a1a`](40c3a1a), [`46bd5ee`](46bd5ee)]: - @lynx-js/web-mainthread-apis@0.19.0 - @lynx-js/web-constants@0.19.0 - @lynx-js/web-worker-rpc@0.19.0 ## @lynx-js/css-extract-webpack-plugin@0.6.5 ### Patch Changes - Set main thread JS basename to `lepusCode.filename` in tasm encode data. It will ensure a filename is reported on MTS error without devtools enabled. ([#1949](#1949)) ## @lynx-js/template-webpack-plugin@0.9.2 ### Patch Changes - Set main thread JS basename to `lepusCode.filename` in tasm encode data. It will ensure a filename is reported on MTS error without devtools enabled. ([#1949](#1949)) - Upgrade `@lynx-js/tasm` to `0.0.20`. ([#1943](#1943)) - refactor: move web style info generation to the encode phase ([#1975](#1975)) ## upgrade-rspeedy@0.12.1 ## @lynx-js/web-core-server@0.19.0 ## @lynx-js/web-elements-template@0.9.0 ## @lynx-js/web-rsbuild-server-middleware@0.19.0 ## @lynx-js/web-worker-rpc@0.19.0 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/react@0.115.0 ### Minor Changes - **BREAKING CHANGE**: Delay the `createSnapshot` operation to `Snapshot` constructor to speed up IFR. ([lynx-family#1899](lynx-family#1899)) This change refactors how snapshots are created and registered: - Removed the `entryUniqID` function - Snapshots are now lazily created via `snapshotCreatorMap` instead of eagerly at bundle load time - Snapshot IDs are generated at compile time and only prefixed with `${globDynamicComponentEntry}:` for standalone lazy bundles **⚠️ Lazy Bundle Compatibility:** - **Backward compatibility (new runtime → old lazy bundles)**: ✅ **Supported**. Old lazy bundles will work with the new runtime. - **Forward compatibility (old runtime → new lazy bundles)**: ❌ **NOT Supported**. Lower version consumers **will not be able to load lazy bundles produced by this version** due to the changed snapshot creation mechanism. **Migration guidance**: If you are using lazy bundles, ensure all consumers are upgraded to this version or later **before** deploying lazy bundles built with this version. For monorepo setups, coordinate the upgrade across all consuming applications. ### Patch Changes - Preserve assignments to webpack runtime variables like `__webpack_public_path__`, `__webpack_require__.p`, etc. ([lynx-family#1958](lynx-family#1958)) - Fixed blank screen issues with nested lists. Lazily created nested lists were being flushed but not properly recorded, causing rendering failures. ([lynx-family#1963](lynx-family#1963)) - fix: export `createRef` and `useRef` from `@lynx-js/react/legacy-react-runtime` ([lynx-family#1953](lynx-family#1953)) ## @lynx-js/react-rsbuild-plugin@0.12.0 ### Minor Changes - **BREAKING CHANGE**: Require `@lynx-js/rspeedy` 0.12.0. ([lynx-family#1951](lynx-family#1951)) ### Patch Changes - Support Yarn Plug'n'Play. ([lynx-family#1964](lynx-family#1964)) - Updated dependencies \[[`738d44d`](lynx-family@738d44d), [`5bbb439`](lynx-family@5bbb439), [`3692a16`](lynx-family@3692a16), [`d2e290b`](lynx-family@d2e290b), [`738d44d`](lynx-family@738d44d)]: - @lynx-js/react-alias-rsbuild-plugin@0.12.0 - @lynx-js/css-extract-webpack-plugin@0.6.5 - @lynx-js/template-webpack-plugin@0.9.2 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.4 - @lynx-js/react-webpack-plugin@0.7.2 ## @lynx-js/react-alias-rsbuild-plugin@0.12.0 ### Minor Changes - **BREAKING CHANGE**: Use resolver from Rspack. ([lynx-family#1964](lynx-family#1964)) The `createLazyResolver` now requires an `rspack` parameter: ```diff - function createLazyResolver(directory: string, conditionNames: string[]): (request: string) => Promise<string>; + function createLazyResolver(rspack: rspack, directory: string, conditionNames: string[]): (request: string) => Promise<string>; ``` ### Patch Changes - Support Yarn Plug'n'Play. ([lynx-family#1964](lynx-family#1964)) ## @lynx-js/web-core@0.19.0 ### Minor Changes - feat: new flex:val impl ([lynx-family#1979](lynx-family#1979)) ### Patch Changes - Updated dependencies \[[`40c3a1a`](lynx-family@40c3a1a), [`46bd5ee`](lynx-family@46bd5ee)]: - @lynx-js/web-mainthread-apis@0.19.0 - @lynx-js/web-worker-runtime@0.19.0 - @lynx-js/web-constants@0.19.0 - @lynx-js/web-worker-rpc@0.19.0 ## @lynx-js/web-elements@0.9.0 ### Minor Changes - feat: new flex:val impl ([lynx-family#1979](lynx-family#1979)) ### Patch Changes - fix: x-input display should add !important to avoid override ([lynx-family#1960](lynx-family#1960)) - Updated dependencies \[]: - @lynx-js/web-elements-template@0.9.0 ## @lynx-js/rspeedy@0.12.1 ### Patch Changes - Bump Rsbuild v1.6.9 with Rspack v1.6.5. ([lynx-family#1967](lynx-family#1967)) - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.19.0 ## create-rspeedy@0.12.1 ### Patch Changes - Bump `@rsbuild/plugin-type-check` v1.3.1. ([lynx-family#1964](lynx-family#1964)) ## @lynx-js/lynx-bundle-rslib-config@0.0.1 ### Patch Changes - Add `@lynx-js/lynx-bundle-rslib-config` for bundling Lynx bundle with [Rslib](https://rslib.rs/): ([lynx-family#1943](lynx-family#1943)) ```js // rslib.config.js import { defineExternalBundleRslibConfig } from "@lynx-js/lynx-bundle-rslib-config"; export default defineExternalBundleRslibConfig({ id: "utils-lib", source: { entry: { utils: "./src/utils.ts", }, }, }); ``` ## @lynx-js/web-constants@0.19.0 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.19.0 ## @lynx-js/web-explorer@0.0.14 ### Patch Changes - chore: update web-elements version of web-explorer ([lynx-family#1962](lynx-family#1962)) ## @lynx-js/web-mainthread-apis@0.19.0 ### Patch Changes - fix: capture and bind event listener should be trigger correctly ([lynx-family#1972](lynx-family#1972)) - fix: the l-p-comp-uid of page should be '1' ([lynx-family#1970](lynx-family#1970)) - Updated dependencies \[]: - @lynx-js/web-constants@0.19.0 ## @lynx-js/web-worker-runtime@0.19.0 ### Patch Changes - Updated dependencies \[[`40c3a1a`](lynx-family@40c3a1a), [`46bd5ee`](lynx-family@46bd5ee)]: - @lynx-js/web-mainthread-apis@0.19.0 - @lynx-js/web-constants@0.19.0 - @lynx-js/web-worker-rpc@0.19.0 ## @lynx-js/css-extract-webpack-plugin@0.6.5 ### Patch Changes - Set main thread JS basename to `lepusCode.filename` in tasm encode data. It will ensure a filename is reported on MTS error without devtools enabled. ([lynx-family#1949](lynx-family#1949)) ## @lynx-js/template-webpack-plugin@0.9.2 ### Patch Changes - Set main thread JS basename to `lepusCode.filename` in tasm encode data. It will ensure a filename is reported on MTS error without devtools enabled. ([lynx-family#1949](lynx-family#1949)) - Upgrade `@lynx-js/tasm` to `0.0.20`. ([lynx-family#1943](lynx-family#1943)) - refactor: move web style info generation to the encode phase ([lynx-family#1975](lynx-family#1975)) ## upgrade-rspeedy@0.12.1 ## @lynx-js/web-core-server@0.19.0 ## @lynx-js/web-elements-template@0.9.0 ## @lynx-js/web-rsbuild-server-middleware@0.19.0 ## @lynx-js/web-worker-rpc@0.19.0 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix(web): x-input display add important

73c9c1f

Sherry-hue requested a review from PupilTong as a code owner November 26, 2025 09:08

coderabbitai bot added the platform:Web label Nov 26, 2025

PupilTong approved these changes Nov 26, 2025

View reviewed changes

Sherry-hue enabled auto-merge (squash) November 26, 2025 09:18

Sherry-hue merged commit 55cb796 into lynx-family:main Nov 26, 2025
118 of 151 checks passed

github-actions bot mentioned this pull request Nov 26, 2025

chore: Release 2025-12-05 07:48:08 #1961

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(web): x-input display add important#1960

fix(web): x-input display add important#1960
Sherry-hue merged 1 commit intolynx-family:mainfrom
Sherry-hue:fix/x-input-display

Sherry-hue commented Nov 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Nov 26, 2025

Uh oh!

coderabbitai bot commented Nov 26, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Uh oh!

codecov bot commented Nov 26, 2025

Uh oh!

codspeed-hq bot commented Nov 26, 2025

Uh oh!

relativeci bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Sherry-hue commented Nov 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot bot commented Nov 26, 2025

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

codecov bot commented Nov 26, 2025

Codecov Report

Uh oh!

codspeed-hq bot commented Nov 26, 2025

CodSpeed Performance Report

Merging #1960 will not alter performance

Summary

Footnotes

Uh oh!

relativeci bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#6336 Bundle Size — 377.5KiB (~+0.01%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sherry-hue commented Nov 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 26, 2025 •

edited

Loading

relativeci bot commented Nov 26, 2025 •

edited

Loading