feat(react/transform): auto define lynx.loadLazyBundle#1956
Merged
Conversation
🦋 Changeset detectedLatest commit: 5fd6201 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 WalkthroughWalkthroughRefactors React runtime to import Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
HuJean
changed the title
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (1)
45-45: Consider a more descriptive field name.The field
has_dynamic_importspecifically tracks relative path dynamic imports (not all dynamic imports). A more descriptive name likehas_local_dynamic_importorhas_relative_dynamic_importwould make the intent clearer, as external URL imports are also "dynamic imports" but don't set this flag.pub struct DynamicImportVisitor<C> where C: Comments, { opts: DynamicImportVisitorConfig, - has_dynamic_import: bool, + has_local_dynamic_import: bool, named_imports: HashSet<Ident>, comments: Option<C>, }packages/rspeedy/plugin-react-alias/src/index.ts (1)
127-138: Alias support forexperimental/lazy/lynxis wired correctly; consider centralizing entry namesAdding
'experimental/lazy/lynx'totransformedEntriescorrectly ensures@lynx-js/react/experimental/lazy/lynx$is aliased alongside the other transform‑generated imports.To avoid future drift between react‑transform and this alias plugin, you might consider centralizing these entry names (e.g., a shared constants module) rather than maintaining the list here and in the transform separately.
packages/react/package.json (1)
31-34: New./experimental/lazy/lynxexport and types mapping look consistent; ensure release metadata is updatedThe new
./experimental/lazy/lynxexport and itstypesVersionsentry both point to./runtime/lazy/lynx.{js,d.ts}, which matches the new runtime/type files and keeps the JS/types surfaces aligned.Since this adds a new public subpath for
@lynx-js/react, make sure there’s a corresponding changeset entry for@lynx-js/reactusing the exact package name, so release notes capture this API addition (as per existing changeset guidelines in this repo).Also applies to: 122-124
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
.changeset/four-rice-guess.md(1 hunks)packages/react/package.json(2 hunks)packages/react/runtime/lazy/lynx.d.ts(1 hunks)packages/react/runtime/lazy/lynx.js(1 hunks)packages/react/runtime/src/index.ts(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs(6 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_not_import_lazy.js(0 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js(1 hunks)packages/rspeedy/plugin-react-alias/src/index.ts(1 hunks)packages/rspeedy/plugin-react-alias/test/index.test.ts(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx(1 hunks)
💤 Files with no reviewable changes (1)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_not_import_lazy.js
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
For contributions, generate and commit a Changeset describing your changes
Files:
.changeset/four-rice-guess.md
🧠 Learnings (30)
📓 Common learnings
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/template-webpack-plugin/src/LynxCacheEventsSetupListRuntimeModule.ts:21-25
Timestamp: 2025-08-19T12:49:05.875Z
Learning: In the Lynx cache events system, there are two separate runtime modules with distinct responsibilities: `LynxCacheEventsSetupListRuntimeModule` is only responsible for initializing the setup list with the setup functions, while `LynxCacheEventsRuntimeModule` guarantees the initialization of `loaded` and `cachedActions` properties. The modules have a dependency relationship where `lynxCacheEventsSetupList` is required by `lynxCacheEvents`.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/react/runtime/lazy/lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx.changeset/four-rice-guess.mdpackages/rspeedy/plugin-react-alias/test/index.test.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/lazy/lynx.d.tspackages/react/runtime/src/index.ts
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/react/runtime/lazy/lynx.jspackages/react/package.json.changeset/four-rice-guess.mdpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/runtime/lazy/lynx.d.ts
📚 Learning: 2025-08-27T12:42:01.095Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/react/runtime/lazy/lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js.changeset/four-rice-guess.mdpackages/rspeedy/plugin-react-alias/test/index.test.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/lazy/lynx.d.tspackages/react/runtime/src/index.ts
📚 Learning: 2025-08-27T08:10:09.932Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/react/package.jsonpackages/react/runtime/lazy/lynx.d.ts
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/react/runtime/lazy/lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js.changeset/four-rice-guess.mdpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/lazy/lynx.d.tspackages/react/runtime/src/index.ts
📚 Learning: 2025-11-06T01:19:23.670Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/react/package.json.changeset/four-rice-guess.md
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/rspeedy/plugin-react-alias/test/index.test.ts
📚 Learning: 2025-08-11T05:57:18.212Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/testing-library/testing-environment/src/index.ts:255-258
Timestamp: 2025-08-11T05:57:18.212Z
Learning: In the ReactLynx testing environment (`packages/testing-library/testing-environment/src/index.ts`), the dual assignment pattern `target.console.method = console.method = () => {}` is required for rstest compatibility. This is because rstest provides `console` in an IIFE (Immediately Invoked Function Expression), and both the target and global console need to have these methods defined for proper test execution.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/rspeedy/plugin-react-alias/test/index.test.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.ts
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/react/runtime/lazy/lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/lazy/lynx.d.ts
📚 Learning: 2025-08-11T05:59:28.530Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/react/runtime/lazy/lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx.changeset/four-rice-guess.mdpackages/rspeedy/plugin-react-alias/test/index.test.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/lazy/lynx.d.tspackages/react/runtime/src/index.ts
📚 Learning: 2025-08-13T11:46:43.737Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/react/runtime/lazy/lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js.changeset/four-rice-guess.mdpackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/lazy/lynx.d.tspackages/react/runtime/src/index.ts
📚 Learning: 2025-07-18T04:27:18.291Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1238
File: packages/react/runtime/src/debug/component-stack.ts:70-90
Timestamp: 2025-07-18T04:27:18.291Z
Learning: The component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork from https://github.com/preactjs/preact/blob/main/debug/src/component-stack.js. The team prefers to keep it aligned with the upstream Preact version and may contribute improvements back to Preact in the future.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/react/runtime/src/index.ts
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.tspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.jspackages/rspeedy/plugin-react-alias/test/index.test.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/lazy/lynx.d.ts
📚 Learning: 2025-09-25T14:03:25.576Z
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Applied to files:
packages/react/runtime/lazy/lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Applied to files:
packages/react/runtime/lazy/lynx.js.changeset/four-rice-guess.mdpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.ts
📚 Learning: 2025-08-19T12:49:05.875Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/template-webpack-plugin/src/LynxCacheEventsSetupListRuntimeModule.ts:21-25
Timestamp: 2025-08-19T12:49:05.875Z
Learning: In the Lynx cache events system, there are two separate runtime modules with distinct responsibilities: `LynxCacheEventsSetupListRuntimeModule` is only responsible for initializing the setup list with the setup functions, while `LynxCacheEventsRuntimeModule` guarantees the initialization of `loaded` and `cachedActions` properties. The modules have a dependency relationship where `lynxCacheEventsSetupList` is required by `lynxCacheEvents`.
Applied to files:
packages/react/runtime/lazy/lynx.js
📚 Learning: 2025-11-04T10:15:14.965Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
Applied to files:
packages/react/package.jsonpackages/react/runtime/src/index.ts
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.
Applied to files:
packages/react/package.json.changeset/four-rice-guess.mdpackages/react/runtime/lazy/lynx.d.ts
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx.changeset/four-rice-guess.md
📚 Learning: 2025-08-11T06:00:04.376Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:59-61
Timestamp: 2025-08-11T06:00:04.376Z
Learning: In the lynx-family/lynx-stack repository, the `testingLibraryPlugin` in `packages/react/testing-library/src/plugins/vitest.ts` intentionally uses `process.exit` when jsdom installation fails, maintaining consistency with the previous implementation from `packages/react/testing-library/src/vitest.config.js`. This behavior should not be changed to use `this.error` despite being a Vite plugin best practice.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/rspeedy/plugin-react-alias/test/index.test.ts
📚 Learning: 2025-10-29T10:28:27.519Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.jspackages/rspeedy/plugin-react-alias/test/index.test.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-11-05T03:26:52.546Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Applied to files:
.changeset/four-rice-guess.mdpackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js
📚 Learning: 2025-10-11T06:16:12.517Z
Learnt from: Sherry-hue
Repo: lynx-family/lynx-stack PR: 1820
File: packages/web-platform/web-tests/tests/react.spec.ts:834-856
Timestamp: 2025-10-11T06:16:12.517Z
Learning: In packages/web-platform/web-tests/tests/react.spec.ts, the tests `basic-bindmouse` and `basic-mts-bindtouchstart` are NOT duplicates despite having similar test structures. They test different event types: `basic-bindmouse` validates mouse events (mousedown, mouseup, mousemove) with mouse-specific properties (button, buttons, x, y, pageX, pageY, clientX, clientY), while `basic-mts-bindtouchstart` validates touch events (touchstart) with touch arrays (touches, targetTouches, changedTouches). The similar test structure is coincidental and follows testing conventions.
Applied to files:
packages/rspeedy/plugin-react-alias/test/index.test.ts
📚 Learning: 2025-08-13T09:20:00.936Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1502
File: packages/react/testing-library/types/entry.d.ts:71-71
Timestamp: 2025-08-13T09:20:00.936Z
Learning: In lynx-js/react testing library, wrapper components must have children as a required prop because they are always called with `h(WrapperComponent, null, innerElement)` where innerElement is passed as children. The type `React.JSXElementConstructor<{ children: React.ReactNode }>` correctly requires children to be mandatory.
Applied to files:
packages/rspeedy/plugin-react-alias/test/index.test.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.ts
📚 Learning: 2025-09-10T11:42:36.855Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1714
File: packages/react/transform/Cargo.toml:19-19
Timestamp: 2025-09-10T11:42:36.855Z
Learning: In packages/react/transform/Cargo.toml, the crate uses serde derive macros (#[derive(Serialize, Deserialize)]) in multiple files including src/esbuild.rs and src/swc_plugin_extract_str/mod.rs, so the "derive" feature is required when migrating to workspace dependencies.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js
📚 Learning: 2025-08-21T07:21:51.621Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1562
File: packages/react/transform/src/swc_plugin_snapshot/jsx_helpers.rs:261-283
Timestamp: 2025-08-21T07:21:51.621Z
Learning: In packages/react/transform/src/swc_plugin_snapshot/jsx_helpers.rs, the team prefers to keep the original unreachable! logic for JSXSpreadChild in jsx_is_children_full_dynamic function rather than implementing defensive error handling.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js
🧬 Code graph analysis (1)
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (1)
new(67-71)packages/react/transform/swc-plugin-reactlynx/index.d.ts (1)
DynamicImportVisitorConfig(166-171)
🪛 LanguageTool
.changeset/four-rice-guess.md
[grammar] ~6-~6: Use a hyphen to join words.
Context: ... patch "@lynx-js/react": patch --- Auto import `@lynx-js/react/experimental/lazy...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (13)
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js (1)
1-2: LGTM!The snapshot correctly reflects the new lazy import injection behavior. The
@lynx-js/react/experimental/lazy/lynximport is prepended when relative path dynamic imports are detected (e.g.,./index.js), while@lynx-js/react/experimental/lazy/importis added for external URL imports that use__dynamicImport.packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js (1)
1-4: LGTM!The snapshot correctly demonstrates the isolated case: when only relative path dynamic imports exist (without external URLs), only the
@lynx-js/react/experimental/lazy/lynximport is injected. ThewebpackChunkNamecomment is properly added.packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js (1)
1-9: LGTM!The snapshot correctly demonstrates the isolated case: when only external URL dynamic imports exist (without relative paths), only the
@lynx-js/react/experimental/lazy/importimport is injected, and__dynamicImportis used for the external URL..changeset/four-rice-guess.md (1)
1-6: LGTM!The changeset correctly documents the new feature with appropriate patch version bumps for both affected packages. The package names follow the repository conventions (using exact scoped names from package.json).
packages/react/runtime/lazy/lynx.js (1)
1-2: LGTM!The implementation correctly exposes
loadLazyBundleon the globallynxobject. This aligns with the codebase pattern where the Lynx Engine provides thelynxglobal at runtime.packages/react/runtime/src/index.ts (1)
18-21: LGTM!Clean refactoring that directly re-exports
lazyfrompreact/compat. Thelynx.loadLazyBundlesetup responsibility is now properly separated into@lynx-js/react/experimental/lazy/lynx, which is auto-imported by the SWC plugin when needed.packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (3)
114-131: LGTM!The
create_lazy_import_declhelper cleanly generates the import declarations. The string replacementreplace("/internal", "")correctly transforms@lynx-js/react/internalto@lynx-js/reactfor the experimental lazy paths.
336-384: LGTM!Good test coverage for the new lazy import behavior:
should_import_lazy_import: external URL only → lazy/import injectedshould_import_lazy_lynx: relative path only → lazy/lynx injectedshould_not_import_lazy: template literal → no lazy imports (correctly ignored as context imports)
267-277: The review comment is based on a misunderstanding of the intended design.The conditional logic is correct and working as intended. The plugin uses different lazy runtimes for different import types:
- Relative path imports (e.g.,
import("./index.js")) →has_dynamic_import=true→ injects onlylazy/lynx- External URL imports (e.g.,
import("https://...")) →named_imports={__dynamicImport}→ injects onlylazy/importThe snapshots confirm this behavior is expected: each import type receives the appropriate lazy runtime dependency it needs. There is no missing dependency issue or bug here. The lazy runtime dependencies are correctly satisfied in both scenarios.
Likely an incorrect or invalid review comment.
packages/rspeedy/plugin-react-alias/test/index.test.ts (1)
71-76: New lazy Lynx alias assertion is consistent with plugin aliasingThe added expectation for
@lynx-js/react/experimental/lazy/lynx$correctly matches the alias key the plugin sets and points to the expectedruntime/lazy/lynx.jspath, in line with the existingexperimental/lazy/importassertion.packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx (1)
28-28: Confirmlynx.loadLazyBundleis available in all environments this test runs inYou assert
lynx.loadLazyBundlebefore branching on__BACKGROUND__, while the other expectations uselynx[...]only in background andglobalThis[...]otherwise. Please double‑check thatlynx(andlynx.loadLazyBundle) is indeed defined in all relevant environments; if not, you may need to mirror the conditional pattern used below.packages/react/runtime/lazy/lynx.d.ts (1)
1-1: Side‑effect‑only declaration file looks appropriateUsing
export {};to declare the module without value exports fits a runtime that’s only meant to be imported for side effects (e.g., installinglynx.loadLazyBundle) and not to provide typed imports.packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx (1)
3-5: Dynamicimport('./foo.js')usage aligns with lazy‑bundle test intentUsing a top‑level
import('./foo.js').then(...)is a straightforward way to exercise relativeimport()for this webpack case, so the lazy‑bundle machinery can be validated without changing test assertions.
CodSpeed Performance ReportMerging #1956 will not alter performanceComparing Summary
Footnotes
|
React Example#6388 Bundle Size — 236.9KiB (0%).5fd6201(current) vs 6400f87 main#6360(baseline) Bundle metrics
|
| Current #6388 |
Baseline #6360 |
|
|---|---|---|
 Initial JS |
0B |
0B |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
0% |
0% |
| Chunks |
0 |
0 |
| Assets |
4 |
4 |
| Modules |
162 |
162 |
| Duplicate Modules |
65 |
65 |
 Duplicate Code |
46.74%(-0.02%) |
46.75% |
| Packages |
2 |
2 |
| Duplicate Packages |
0 |
0 |
Bundle size by type no changes
| Current #6388 |
Baseline #6360 |
|
|---|---|---|
| IMG |
145.76KiB |
145.76KiB |
| Other |
91.14KiB |
91.14KiB |
Bundle analysis report Branch p/hujing/lazy-bundle Project dashboard
Generated by RelativeCI Documentation Report issue
Web Explorer#6548 Bundle Size — 372.73KiB (0%).5fd6201(current) vs 6400f87 main#6520(baseline) Bundle metrics
|
| Current #6548 |
Baseline #6520 |
|
|---|---|---|
| Initial JS |
146.31KiB |
146.31KiB |
| Initial CSS |
32.4KiB |
32.4KiB |
| Cache Invalidation |
0% |
11.74% |
| Chunks |
8 |
8 |
| Assets |
8 |
8 |
| Modules |
229(-0.43%) |
230 |
| Duplicate Modules |
16 |
16 |
| Duplicate Code |
2.97% |
2.97% |
| Packages |
4 |
4 |
| Duplicate Packages |
0 |
0 |
Bundle size by type no changes
| Current #6548 |
Baseline #6520 |
|
|---|---|---|
| JS |
243.35KiB |
243.35KiB |
| Other |
96.98KiB |
96.98KiB |
| CSS |
32.4KiB |
32.4KiB |
Bundle analysis report Branch p/hujing/lazy-bundle Project dashboard
Generated by RelativeCI Documentation Report issue
HuJean
force-pushed
the
p/hujing/lazy-bundle
branch
3 times, most recently
from
d3d6324 to
fbcd88d
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx (1)
22-28: The assertion forlynx.loadLazyBundleis incorrect for external URL imports.Based on the webpack plugin's transform logic, external URL imports (like
https://www/a.js) only inject the "import" lazy module to provide React APIs. The "lynx" lazy module—which defineslynx.loadLazyBundle—is only injected for relative/local imports.The test checks for
lynx.loadLazyBundleon line 28, but this property will not be defined when using external URLs. Either use a relative import path to test the "lynx" lazy module, or remove thelynx.loadLazyBundleassertion and keep only the React API symbol checks.
🧹 Nitpick comments (2)
.changeset/four-rice-guess.md (1)
1-6: Changeset packages and description look correctPackage names match scoped package.json names and patch bumps are appropriate for this bugfix-level behavior change. The one-line description is clear and specific to the new auto-import behavior. If you care about wording nits, you could change “Auto import” to “Auto-import”, but that’s optional.
Based on learnings, this matches the repo’s changeset conventions.
packages/react/runtime/lazy/lynx.js (1)
1-2: Runtime wiring is correct; consider guarding thelynxglobalThe import and assignment correctly expose
loadLazyBundleonlynx. This assumes a globallynxis always present where this module runs; if there are environments (e.g., Node tests/SSR) wherelynxmight be absent, you could optionally guard the write to avoid a ReferenceError, e.g.:-import { loadLazyBundle } from '@lynx-js/react/internal'; -lynx.loadLazyBundle = loadLazyBundle; +import { loadLazyBundle } from '@lynx-js/react/internal'; +if (typeof lynx !== 'undefined') { + lynx.loadLazyBundle = loadLazyBundle; +}If this file only ever executes under the Lynx engine where
lynxis guaranteed, the current version is fine.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (17)
.changeset/four-rice-guess.md(1 hunks)packages/react/package.json(2 hunks)packages/react/runtime/lazy/lynx.d.ts(1 hunks)packages/react/runtime/lazy/lynx.js(1 hunks)packages/react/runtime/src/index.ts(1 hunks)packages/react/runtime/vitest.config.ts(1 hunks)packages/react/transform/__test__/fixture.spec.js(3 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs(6 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_not_import_lazy.js(0 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js(1 hunks)packages/rspeedy/plugin-react-alias/src/index.ts(1 hunks)packages/rspeedy/plugin-react-alias/test/index.test.ts(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx(1 hunks)
💤 Files with no reviewable changes (1)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_not_import_lazy.js
🚧 Files skipped from review as they are similar to previous changes (8)
- packages/rspeedy/plugin-react-alias/src/index.ts
- packages/rspeedy/plugin-react-alias/test/index.test.ts
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx
- packages/react/runtime/lazy/lynx.d.ts
- packages/react/package.json
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_import_lazy_import.js
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_transform_import_call.js
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
For contributions, generate and commit a Changeset describing your changes
Files:
.changeset/four-rice-guess.md
🧠 Learnings (30)
📓 Common learnings
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/template-webpack-plugin/src/LynxCacheEventsSetupListRuntimeModule.ts:21-25
Timestamp: 2025-08-19T12:49:05.875Z
Learning: In the Lynx cache events system, there are two separate runtime modules with distinct responsibilities: `LynxCacheEventsSetupListRuntimeModule` is only responsible for initializing the setup list with the setup functions, while `LynxCacheEventsRuntimeModule` guarantees the initialization of `loaded` and `cachedActions` properties. The modules have a dependency relationship where `lynxCacheEventsSetupList` is required by `lynxCacheEvents`.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
📚 Learning: 2025-08-27T12:42:01.095Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/src/index.tspackages/react/transform/__test__/fixture.spec.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/runtime/vitest.config.tspackages/react/runtime/lazy/lynx.js.changeset/four-rice-guess.md
📚 Learning: 2025-10-29T10:28:27.519Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/transform/__test__/fixture.spec.js
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.tspackages/react/transform/__test__/fixture.spec.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/runtime/lazy/lynx.js.changeset/four-rice-guess.md
📚 Learning: 2025-11-05T03:26:52.546Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs.changeset/four-rice-guess.md
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/src/index.tspackages/react/transform/__test__/fixture.spec.jspackages/react/runtime/vitest.config.tspackages/react/runtime/lazy/lynx.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-13T11:46:43.737Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/src/index.tspackages/react/transform/__test__/fixture.spec.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/runtime/vitest.config.tspackages/react/runtime/lazy/lynx.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/__test__/fixture.spec.jspackages/react/runtime/vitest.config.ts
📚 Learning: 2025-08-11T05:59:28.530Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/src/index.tspackages/react/transform/__test__/fixture.spec.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/runtime/vitest.config.tspackages/react/runtime/lazy/lynx.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-11T05:57:18.212Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/testing-library/testing-environment/src/index.ts:255-258
Timestamp: 2025-08-11T05:57:18.212Z
Learning: In the ReactLynx testing environment (`packages/testing-library/testing-environment/src/index.ts`), the dual assignment pattern `target.console.method = console.method = () => {}` is required for rstest compatibility. This is because rstest provides `console` in an IIFE (Immediately Invoked Function Expression), and both the target and global console need to have these methods defined for proper test execution.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/__test__/fixture.spec.jspackages/react/runtime/vitest.config.ts
📚 Learning: 2025-09-25T14:03:25.576Z
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/__test__/fixture.spec.jspackages/react/runtime/lazy/lynx.js
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/src/index.tspackages/react/transform/__test__/fixture.spec.jspackages/react/runtime/lazy/lynx.js
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/src/index.tspackages/react/transform/__test__/fixture.spec.jspackages/react/runtime/vitest.config.tspackages/react/runtime/lazy/lynx.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-13T09:20:00.936Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1502
File: packages/react/testing-library/types/entry.d.ts:71-71
Timestamp: 2025-08-13T09:20:00.936Z
Learning: In lynx-js/react testing library, wrapper components must have children as a required prop because they are always called with `h(WrapperComponent, null, innerElement)` where innerElement is passed as children. The type `React.JSXElementConstructor<{ children: React.ReactNode }>` correctly requires children to be mandatory.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.tspackages/react/transform/__test__/fixture.spec.js
📚 Learning: 2025-08-11T06:00:04.376Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:59-61
Timestamp: 2025-08-11T06:00:04.376Z
Learning: In the lynx-family/lynx-stack repository, the `testingLibraryPlugin` in `packages/react/testing-library/src/plugins/vitest.ts` intentionally uses `process.exit` when jsdom installation fails, maintaining consistency with the previous implementation from `packages/react/testing-library/src/vitest.config.js`. This behavior should not be changed to use `this.error` despite being a Vite plugin best practice.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-11-04T10:15:14.965Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
Applied to files:
packages/react/runtime/src/index.tspackages/react/transform/__test__/fixture.spec.js
📚 Learning: 2025-07-18T04:27:18.291Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1238
File: packages/react/runtime/src/debug/component-stack.ts:70-90
Timestamp: 2025-07-18T04:27:18.291Z
Learning: The component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork from https://github.com/preactjs/preact/blob/main/debug/src/component-stack.js. The team prefers to keep it aligned with the upstream Preact version and may contribute improvements back to Preact in the future.
Applied to files:
packages/react/runtime/src/index.ts
📚 Learning: 2025-09-23T08:54:39.966Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1670
File: packages/webpack/css-extract-webpack-plugin/test/hotCases/hot/hot-update-json/dual-thread/__snapshot__/index.css:6-8
Timestamp: 2025-09-23T08:54:39.966Z
Learning: In the lynx-stack CSS extract webpack plugin tests, many test fixture CSS files intentionally use invalid CSS syntax like `color: 'red';` with quoted values. The snapshots correctly reflect this invalid CSS from the source fixtures. To fix CSS validation issues, the source fixture files should be updated first, then snapshots regenerated, rather than manually editing snapshots.
Applied to files:
packages/react/transform/__test__/fixture.spec.js
📚 Learning: 2025-08-18T08:46:20.001Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1547
File: packages/rspeedy/core/src/config/loadConfig.ts:11-11
Timestamp: 2025-08-18T08:46:20.001Z
Learning: `#register` and similar imports starting with "#" are Node.js subpath imports defined in the "imports" field of package.json, not TypeScript path mapping aliases. These are natively supported by both Node.js and TypeScript without requiring additional tsconfig.json configuration like "moduleResolution" or "resolvePackageJsonImports" settings.
Applied to files:
packages/react/transform/__test__/fixture.spec.js
📚 Learning: 2025-09-10T11:42:36.855Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1714
File: packages/react/transform/Cargo.toml:19-19
Timestamp: 2025-09-10T11:42:36.855Z
Learning: In packages/react/transform/Cargo.toml, the crate uses serde derive macros (#[derive(Serialize, Deserialize)]) in multiple files including src/esbuild.rs and src/swc_plugin_extract_str/mod.rs, so the "derive" feature is required when migrating to workspace dependencies.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/react/runtime/vitest.config.ts
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
packages/react/runtime/vitest.config.tspackages/react/runtime/lazy/lynx.js.changeset/four-rice-guess.md
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.
Applied to files:
packages/react/runtime/vitest.config.ts.changeset/four-rice-guess.md
📚 Learning: 2025-08-27T08:10:09.932Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.
Applied to files:
packages/react/runtime/vitest.config.ts
📚 Learning: 2025-11-06T01:19:23.670Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.
Applied to files:
packages/react/runtime/vitest.config.ts.changeset/four-rice-guess.md
📚 Learning: 2025-09-28T08:46:43.177Z
Learnt from: f0rdream
Repo: lynx-family/lynx-stack PR: 1835
File: packages/react/worklet-runtime/src/workletRuntime.ts:52-55
Timestamp: 2025-09-28T08:46:43.177Z
Learning: The legacy worklet path with `_lepusWorkletHash` in `packages/react/worklet-runtime/src/workletRuntime.ts` is preserved for compatibility with MTS (Mini-app Threading Service) that doesn't support Initial Frame Rendering. This path will not be touched in current implementations.
Applied to files:
packages/react/runtime/vitest.config.ts
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
.changeset/four-rice-guess.md
🧬 Code graph analysis (1)
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (1)
new(67-71)packages/react/transform/swc-plugin-reactlynx/index.d.ts (1)
DynamicImportVisitorConfig(166-171)
🪛 LanguageTool
.changeset/four-rice-guess.md
[grammar] ~6-~6: Use a hyphen to join words.
Context: ... patch "@lynx-js/react": patch --- Auto import `@lynx-js/react/experimental/lazy...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (7)
packages/react/transform/__test__/fixture.spec.js (1)
909-1003: Dynamic import “badcase” snapshot correctly exercises lazy runtime auto-importThe added
await import("./index.js");input, together with the updated snapshot (newimport "@lynx-js/react/experimental/lazy/lynx";, preservedexperimental/lazy/import, and the webpackChunkName comment on the relative import) cleanly verifies the new auto-import behavior, and the shifted error location (:6:8:) stays consistent with the modified source template. No issues from the test side.packages/react/runtime/vitest.config.ts (1)
64-64: LGTM!The new alias for the experimental lazy runtime is correctly configured and follows the existing pattern. The ordering is appropriate since more specific paths should precede less specific ones.
packages/react/runtime/src/index.ts (1)
18-18: Clean refactor - direct re-export oflazyfrom preact/compat.The Lynx-specific
loadLazyBundlewiring is now correctly separated into@lynx-js/react/experimental/lazy/lynx, which gets auto-imported by the SWC transform when dynamic imports are detected.packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (3)
114-131: Well-structured helper for lazy import generation.The path manipulation using
.replace("/internal", "")correctly transforms the default runtime package from@lynx-js/react/internalto@lynx-js/react/experimental/lazy/{name}. The empty specifiers correctly generate a side-effect-only import.
267-277: Correct conditional lazy import injection.The logic correctly differentiates between:
- External URL imports (
named_importsnot empty) → adds "import" lazy module- Relative/local dynamic imports (
has_dynamic_importtrue) → adds "lynx" lazy moduleBoth can coexist when a file has both import types.
336-384: Good test coverage for the new lazy import scenarios.The tests appropriately cover:
- External URL imports requiring "import" lazy module
- Relative path imports requiring "lynx" lazy module
- Template literal imports that should not inject lazy modules
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js (1)
1-4: Snapshot correctly reflects the lazy lynx import injection.The auto-generated snapshot shows the expected behavior: relative path dynamic imports trigger the injection of
@lynx-js/react/experimental/lazy/lynxand the webpackChunkName comment is properly generated.
upupming
reviewed
Nov 25, 2025
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
Outdated
Show resolved
Hide resolved
HuJean
force-pushed
the
p/hujing/lazy-bundle
branch
from
fbcd88d to
f91c760
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/four-rice-guess.md (1)
6-6: Optional: Consider minor grammar improvement.The description is clear, but per English grammar conventions, compound modifiers before nouns should be hyphenated: "Auto-import" or "Automatically import".
-Auto import `@lynx-js/react/experimental/lazy/lynx` when using `import(/* relative path */)` to define lynx.loadLazyBundle. +Auto-import `@lynx-js/react/experimental/lazy/lynx` when using `import(/* relative path */)` to define lynx.loadLazyBundle.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (17)
.changeset/four-rice-guess.md(1 hunks)packages/react/package.json(2 hunks)packages/react/runtime/lazy/lynx.d.ts(1 hunks)packages/react/runtime/lazy/lynx.js(1 hunks)packages/react/runtime/src/index.ts(1 hunks)packages/react/runtime/vitest.config.ts(1 hunks)packages/react/transform/__test__/fixture.spec.js(3 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs(6 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_not_import_lazy.js(0 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js(1 hunks)packages/rspeedy/plugin-react-alias/src/index.ts(1 hunks)packages/rspeedy/plugin-react-alias/test/index.test.ts(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx(1 hunks)
💤 Files with no reviewable changes (1)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_not_import_lazy.js
🚧 Files skipped from review as they are similar to previous changes (8)
- packages/react/runtime/vitest.config.ts
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_transform_import_call.js
- packages/rspeedy/plugin-react-alias/test/index.test.ts
- packages/react/runtime/lazy/lynx.d.ts
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_import_lazy_import.js
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx
- packages/rspeedy/plugin-react-alias/src/index.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
For contributions, generate and commit a Changeset describing your changes
Files:
.changeset/four-rice-guess.md
🧠 Learnings (30)
📓 Common learnings
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/template-webpack-plugin/src/LynxCacheEventsSetupListRuntimeModule.ts:21-25
Timestamp: 2025-08-19T12:49:05.875Z
Learning: In the Lynx cache events system, there are two separate runtime modules with distinct responsibilities: `LynxCacheEventsSetupListRuntimeModule` is only responsible for initializing the setup list with the setup functions, while `LynxCacheEventsRuntimeModule` guarantees the initialization of `loaded` and `cachedActions` properties. The modules have a dependency relationship where `lynxCacheEventsSetupList` is required by `lynxCacheEvents`.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
📚 Learning: 2025-08-27T12:42:01.095Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/react/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.ts.changeset/four-rice-guess.md
📚 Learning: 2025-10-29T10:28:27.519Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js
📚 Learning: 2025-09-23T08:54:39.966Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1670
File: packages/webpack/css-extract-webpack-plugin/test/hotCases/hot/hot-update-json/dual-thread/__snapshot__/index.css:6-8
Timestamp: 2025-09-23T08:54:39.966Z
Learning: In the lynx-stack CSS extract webpack plugin tests, many test fixture CSS files intentionally use invalid CSS syntax like `color: 'red';` with quoted values. The snapshots correctly reflect this invalid CSS from the source fixtures. To fix CSS validation issues, the source fixture files should be updated first, then snapshots regenerated, rather than manually editing snapshots.
Applied to files:
packages/react/transform/__test__/fixture.spec.js
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js
📚 Learning: 2025-08-11T05:57:18.212Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/testing-library/testing-environment/src/index.ts:255-258
Timestamp: 2025-08-11T05:57:18.212Z
Learning: In the ReactLynx testing environment (`packages/testing-library/testing-environment/src/index.ts`), the dual assignment pattern `target.console.method = console.method = () => {}` is required for rstest compatibility. This is because rstest provides `console` in an IIFE (Immediately Invoked Function Expression), and both the target and global console need to have these methods defined for proper test execution.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js
📚 Learning: 2025-08-13T11:46:43.737Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/react/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.ts.changeset/four-rice-guess.md
📚 Learning: 2025-08-11T05:59:28.530Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/react/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.ts.changeset/four-rice-guess.md
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/react/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.ts.changeset/four-rice-guess.md
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/react/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.ts.changeset/four-rice-guess.md
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/react/runtime/lazy/lynx.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.ts.changeset/four-rice-guess.md
📚 Learning: 2025-08-18T08:46:20.001Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1547
File: packages/rspeedy/core/src/config/loadConfig.ts:11-11
Timestamp: 2025-08-18T08:46:20.001Z
Learning: `#register` and similar imports starting with "#" are Node.js subpath imports defined in the "imports" field of package.json, not TypeScript path mapping aliases. These are natively supported by both Node.js and TypeScript without requiring additional tsconfig.json configuration like "moduleResolution" or "resolvePackageJsonImports" settings.
Applied to files:
packages/react/transform/__test__/fixture.spec.js
📚 Learning: 2025-09-25T14:03:25.576Z
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/react/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.ts
📚 Learning: 2025-08-13T09:20:00.936Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1502
File: packages/react/testing-library/types/entry.d.ts:71-71
Timestamp: 2025-08-13T09:20:00.936Z
Learning: In lynx-js/react testing library, wrapper components must have children as a required prop because they are always called with `h(WrapperComponent, null, innerElement)` where innerElement is passed as children. The type `React.JSXElementConstructor<{ children: React.ReactNode }>` correctly requires children to be mandatory.
Applied to files:
packages/react/transform/__test__/fixture.spec.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.jspackages/react/runtime/src/index.ts
📚 Learning: 2025-08-11T06:00:04.376Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:59-61
Timestamp: 2025-08-11T06:00:04.376Z
Learning: In the lynx-family/lynx-stack repository, the `testingLibraryPlugin` in `packages/react/testing-library/src/plugins/vitest.ts` intentionally uses `process.exit` when jsdom installation fails, maintaining consistency with the previous implementation from `packages/react/testing-library/src/vitest.config.js`. This behavior should not be changed to use `this.error` despite being a Vite plugin best practice.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx.changeset/four-rice-guess.md
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
packages/react/runtime/lazy/lynx.jspackages/react/package.json.changeset/four-rice-guess.md
📚 Learning: 2025-08-19T12:49:05.875Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/template-webpack-plugin/src/LynxCacheEventsSetupListRuntimeModule.ts:21-25
Timestamp: 2025-08-19T12:49:05.875Z
Learning: In the Lynx cache events system, there are two separate runtime modules with distinct responsibilities: `LynxCacheEventsSetupListRuntimeModule` is only responsible for initializing the setup list with the setup functions, while `LynxCacheEventsRuntimeModule` guarantees the initialization of `loaded` and `cachedActions` properties. The modules have a dependency relationship where `lynxCacheEventsSetupList` is required by `lynxCacheEvents`.
Applied to files:
packages/react/runtime/lazy/lynx.js
📚 Learning: 2025-11-04T10:15:14.965Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
Applied to files:
packages/react/package.jsonpackages/react/runtime/src/index.ts
📚 Learning: 2025-11-06T01:19:23.670Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.
Applied to files:
packages/react/package.json.changeset/four-rice-guess.md
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.
Applied to files:
packages/react/package.json.changeset/four-rice-guess.md
📚 Learning: 2025-10-10T08:22:12.051Z
Learnt from: Sherry-hue
Repo: lynx-family/lynx-stack PR: 1837
File: packages/web-platform/web-mainthread-apis/src/prepareMainThreadAPIs.ts:266-266
Timestamp: 2025-10-10T08:22:12.051Z
Learning: In packages/web-platform/web-mainthread-apis, the handleUpdatedData function returned from prepareMainThreadAPIs is internal-only, used to serve web-core. It does not require public documentation, type exports, or SSR support.
Applied to files:
packages/react/package.json
📚 Learning: 2025-08-27T08:10:09.932Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.
Applied to files:
packages/react/package.json
📚 Learning: 2025-11-05T03:26:52.546Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js.changeset/four-rice-guess.md
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js
📚 Learning: 2025-09-10T11:42:36.855Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1714
File: packages/react/transform/Cargo.toml:19-19
Timestamp: 2025-09-10T11:42:36.855Z
Learning: In packages/react/transform/Cargo.toml, the crate uses serde derive macros (#[derive(Serialize, Deserialize)]) in multiple files including src/esbuild.rs and src/swc_plugin_extract_str/mod.rs, so the "derive" feature is required when migrating to workspace dependencies.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-07-18T04:27:18.291Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1238
File: packages/react/runtime/src/debug/component-stack.ts:70-90
Timestamp: 2025-07-18T04:27:18.291Z
Learning: The component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork from https://github.com/preactjs/preact/blob/main/debug/src/component-stack.js. The team prefers to keep it aligned with the upstream Preact version and may contribute improvements back to Preact in the future.
Applied to files:
packages/react/runtime/src/index.ts
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.changeset/four-rice-guess.md
🪛 LanguageTool
.changeset/four-rice-guess.md
[grammar] ~6-~6: Use a hyphen to join words.
Context: ... patch "@lynx-js/react": patch --- Auto import `@lynx-js/react/experimental/lazy...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (11)
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx (1)
28-28: LGTM! Test assertion correctly verifies the new runtime behavior.The assertion confirms that
lynx.loadLazyBundleis available after the experimental lazy/lynx module is auto-imported, which aligns with the PR objectives.packages/react/runtime/lazy/lynx.js (1)
1-2: LGTM! Side-effect module correctly exposes loadLazyBundle.This module intentionally mutates the global
lynxobject to makeloadLazyBundleavailable when auto-imported by the transform plugin. The side-effect nature is appropriate for this use case.packages/react/runtime/src/index.ts (1)
18-18: LGTM! Simplifies runtime by importing lazy directly from preact/compat.The removal of the local lazy wrapper is appropriate since the
loadLazyBundlewiring is now handled separately in the dedicatedexperimental/lazy/lynxmodule. This separation improves modularity.packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js (1)
1-4: LGTM! Snapshot correctly reflects the expected transformation.This auto-generated snapshot shows that relative-path dynamic imports trigger the auto-import of
@lynx-js/react/experimental/lazy/lynx, which exposeslynx.loadLazyBundlefor the lazy bundle handling.packages/react/package.json (1)
31-34: LGTM! New export path appropriately exposes the experimental lazy/lynx runtime.The export path is necessary because this module has side effects (assigns
lynx.loadLazyBundle) that need to be triggered via import. The structure is consistent with the existing./experimental/lazy/importexport.packages/react/transform/__test__/fixture.spec.js (1)
917-917: LGTM! Test correctly validates the auto-import behavior.The test demonstrates that relative-path dynamic imports trigger auto-import of both:
@lynx-js/react/experimental/lazy/lynx(for lynx.loadLazyBundle)@lynx-js/react/experimental/lazy/import(for external lazy handling)The comprehensive test coverage is provided by the Rust implementation tests (should_import_lazy_import, should_import_lazy_lynx, should_not_import_lazy).
Also applies to: 942-943, 949-949
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (5)
45-45: LGTM! Field correctly tracks whether relative-path dynamic imports are present.The
has_inner_lazy_bundleflag appropriately distinguishes between:
- Inner lazy bundles (relative paths that webpack bundles together)
- External lazy resources (URLs/dynamic paths handled by
__dynamicImport)The naming is precise and the flag is used correctly to conditionally emit the
lazy/lynximport.Also applies to: 67-67
114-131: LGTM! Helper function cleanly generates lazy import declarations.The
create_lazy_import_declfunction appropriately:
- Generates import declarations for
{runtime_pkg}/experimental/lazy/{name}- Strips
/internalfrom the runtime package path- Creates evaluation-phase imports with no specifiers (side-effect imports)
The comment clarifies the distinction between
lazy/import(external standalone bundles) andlazy/lynx(auto-generated bundles).
220-220: LGTM! Correctly sets flag for relative-path dynamic imports.The flag is set only when a string-literal, non-external, relative-path dynamic import is detected (line 196-210 validates these conditions). This ensures the
lazy/lynximport is only added when needed for webpack-bundled lazy modules.
267-277: LGTM! Import prepending logic is correct.The order is appropriate:
- Prepends
lazy/importwhen named imports exist (external resources)- Prepends
lazy/lynxwhen inner lazy bundles are detected (relative imports)Since
prepend_stmtadds to the beginning, the final order will belazy/lynxthenlazy/import, which is correct.
336-384: LGTM! Comprehensive test coverage for lazy import scenarios.The new tests appropriately cover:
should_import_lazy_import: Only external URL imports (lazy/import only)should_import_lazy_lynx: Only relative-path imports (lazy/lynx only)should_not_import_lazy: Template literal imports (no lazy imports)This addresses the previous review concern about test case coverage.
HuJean
force-pushed
the
p/hujing/lazy-bundle
branch
from
7a4b124 to
9698a0d
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
packages/react/runtime/lazy/lynx.js (1)
1-2: Side-effect import correctly wires the lazy runtime.This module is auto-imported by the SWC transform when dynamic imports are detected, ensuring
lynx.loadLazyBundleis available before any lazy bundle loading occurs. The implementation is minimal and follows the established pattern for exposing runtime functions on thelynxglobal.packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (1)
45-45: Consider the naming suggestion from a previous review.A past review comment suggested renaming
has_inner_lazy_bundletohas_lazy_bundle. The current naming distinguishes "inner" (bundled with main bundle) from "external" (standalone) lazy bundles, which aligns with the comments at lines 114-115. Either naming works; consider whether the distinction is valuable for readers.
🧹 Nitpick comments (3)
packages/rspeedy/plugin-react-alias/src/index.ts (1)
152-158: Alias added correctly, but uses a different resolution pattern.This alias uses
path.joindirectly rather than theresolve()helper used for othertransformedEntries. This is likely intentional sincelazy/lynx.jsis a new file that may not be configured in the package's exports map yet.If the runtime package's
package.jsonexports are later updated to include this entry, consider consolidating this intotransformedEntriesfor consistency..changeset/four-rice-guess.md (1)
1-6: Changeset correctly documents the patch release.Package names match the exact scoped names from package.json. The description clearly explains the new auto-import behavior and the version requirement.
Minor grammar nit: Consider "Auto-import" (hyphenated) for consistency.
-Auto import `@lynx-js/react/experimental/lazy/lynx` when using `import(/* relative path */)` to define lynx.loadLazyBundle. This requires `@lynx-js/react-rsbuild-plugin` v0.11.5 to work. +Auto-import `@lynx-js/react/experimental/lazy/lynx` when using `import(/* relative path */)` to define lynx.loadLazyBundle. This requires `@lynx-js/react-rsbuild-plugin` v0.11.5 to work.packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (1)
124-126: String replacement may cause unintended behavior with custom runtime packages.The
.replace("/internal", "")will replace the first occurrence of/internalin the string, which could be problematic if a customruntime_pkgcontains/internalelsewhere in the path.For example, if
runtime_pkgis@my-org/internal-react/internal, the result would be:
- Input:
@my-org/internal-react/internal/experimental/lazy/lynx- Output:
@my-org-react/internal/experimental/lazy/lynx(incorrect)Consider using
strip_suffixortrim_end_matchesif the intent is to only remove a trailing/internal:- value: format!("{runtime_pkg}/experimental/lazy/{name}") - .replace("/internal", "") - .into(), + value: { + let base = runtime_pkg.strip_suffix("/internal").unwrap_or(runtime_pkg); + format!("{base}/experimental/lazy/{name}").into() + },
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
.changeset/four-rice-guess.md(1 hunks)packages/react/runtime/lazy/lynx.d.ts(1 hunks)packages/react/runtime/lazy/lynx.js(1 hunks)packages/react/runtime/src/index.ts(1 hunks)packages/react/runtime/vitest.config.ts(1 hunks)packages/react/transform/__test__/fixture.spec.js(3 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs(6 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_not_import_lazy.js(0 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js(1 hunks)packages/rspeedy/plugin-react-alias/src/index.ts(1 hunks)packages/rspeedy/plugin-react-alias/test/index.test.ts(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx(1 hunks)
💤 Files with no reviewable changes (1)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_not_import_lazy.js
🚧 Files skipped from review as they are similar to previous changes (9)
- packages/rspeedy/plugin-react-alias/test/index.test.ts
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx
- packages/react/transform/test/fixture.spec.js
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_import_lazy_lynx.js
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js
- packages/react/runtime/src/index.ts
- packages/react/runtime/lazy/lynx.d.ts
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_transform_import_call.js
- packages/react/runtime/vitest.config.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
For contributions, generate and commit a Changeset describing your changes
Files:
.changeset/four-rice-guess.md
🧠 Learnings (25)
📓 Common learnings
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
📚 Learning: 2025-08-27T12:42:01.095Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.jspackages/rspeedy/plugin-react-alias/src/index.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs.changeset/four-rice-guess.md
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/rspeedy/plugin-react-alias/src/index.ts
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.js
📚 Learning: 2025-08-11T05:59:28.530Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/rspeedy/plugin-react-alias/src/index.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs.changeset/four-rice-guess.md
📚 Learning: 2025-09-25T14:03:25.576Z
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.js
📚 Learning: 2025-08-11T05:57:18.212Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/testing-library/testing-environment/src/index.ts:255-258
Timestamp: 2025-08-11T05:57:18.212Z
Learning: In the ReactLynx testing environment (`packages/testing-library/testing-environment/src/index.ts`), the dual assignment pattern `target.console.method = console.method = () => {}` is required for rstest compatibility. This is because rstest provides `console` in an IIFE (Immediately Invoked Function Expression), and both the target and global console need to have these methods defined for proper test execution.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/rspeedy/plugin-react-alias/src/index.ts
📚 Learning: 2025-08-11T06:00:04.376Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:59-61
Timestamp: 2025-08-11T06:00:04.376Z
Learning: In the lynx-family/lynx-stack repository, the `testingLibraryPlugin` in `packages/react/testing-library/src/plugins/vitest.ts` intentionally uses `process.exit` when jsdom installation fails, maintaining consistency with the previous implementation from `packages/react/testing-library/src/vitest.config.js`. This behavior should not be changed to use `this.error` despite being a Vite plugin best practice.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/rspeedy/plugin-react-alias/src/index.ts.changeset/four-rice-guess.md
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx.changeset/four-rice-guess.md
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.jspackages/rspeedy/plugin-react-alias/src/index.ts.changeset/four-rice-guess.md
📚 Learning: 2025-08-13T11:46:43.737Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/lazy/lynx.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.jspackages/rspeedy/plugin-react-alias/src/index.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs.changeset/four-rice-guess.md
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
packages/react/runtime/lazy/lynx.jspackages/rspeedy/plugin-react-alias/src/index.ts.changeset/four-rice-guess.md
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Applied to files:
packages/react/runtime/lazy/lynx.jspackages/rspeedy/plugin-react-alias/src/index.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs.changeset/four-rice-guess.md
📚 Learning: 2025-10-29T10:28:27.519Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-11-05T03:26:52.546Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs.changeset/four-rice-guess.md
📚 Learning: 2025-08-27T08:10:09.932Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.ts
📚 Learning: 2025-11-04T10:15:14.965Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.ts
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.ts
📚 Learning: 2025-11-06T01:19:23.670Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.
Applied to files:
packages/rspeedy/plugin-react-alias/src/index.ts.changeset/four-rice-guess.md
📚 Learning: 2025-09-10T11:42:36.855Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1714
File: packages/react/transform/Cargo.toml:19-19
Timestamp: 2025-09-10T11:42:36.855Z
Learning: In packages/react/transform/Cargo.toml, the crate uses serde derive macros (#[derive(Serialize, Deserialize)]) in multiple files including src/esbuild.rs and src/swc_plugin_extract_str/mod.rs, so the "derive" feature is required when migrating to workspace dependencies.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.changeset/four-rice-guess.md
🧬 Code graph analysis (1)
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (1)
new(67-71)packages/react/transform/swc-plugin-reactlynx/index.d.ts (1)
DynamicImportVisitorConfig(166-171)
🪛 LanguageTool
.changeset/four-rice-guess.md
[grammar] ~6-~6: Use a hyphen to join words.
Context: ... patch "@lynx-js/react": patch --- Auto import `@lynx-js/react/experimental/lazy...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (5)
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js (1)
1-9: Snapshot correctly captures the expected transform behavior.The snapshot shows the SWC plugin now auto-imports
@lynx-js/react/experimental/lazy/importalongside the__dynamicImporthelper when processing dynamic imports. This aligns with the PR's objective to ensure lazy runtime availability.Based on learnings, this is an auto-generated snapshot file and any issues should be addressed in the transform logic, not the snapshot itself.
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx (1)
22-28: Test correctly validates the auto-import behavior.The assertion at line 28 directly validates the fix for issue #1954, ensuring
lynx.loadLazyBundleis defined when code uses dynamic imports. Based on learnings, webpack properties are injected at compile time, so this assertion doesn't need to wait for the dynamic import to complete.packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (3)
196-220: LGTM!The flag
has_inner_lazy_bundleis correctly set when a string literal dynamic import is detected (excluding explicitly external URLs). This ensures the@lynx-js/react/experimental/lazy/lynxruntime is auto-imported for internal lazy bundles as intended by the PR objective.
267-277: LGTM!The prepend logic correctly handles two scenarios:
- External dynamic imports (non-string-literal or external URLs) → adds
experimental/lazy/importruntime- Internal lazy bundles (relative path string literals) → adds
experimental/lazy/lynxruntimeThe use of separate conditionals allows both imports to be added when both conditions are met.
323-384: LGTM!The new tests provide good coverage for the three main scenarios:
should_import_lazy_import- external URL with component type assertion triggers__dynamicImportandlazy/importshould_import_lazy_lynx- relative path import triggerslazy/lynxauto-importshould_not_import_lazy- template literal imports are ignored (webpack context imports)These tests align well with the PR objectives of auto-importing the lazy runtime based on import patterns.
HuJean
force-pushed
the
p/hujing/lazy-bundle
branch
from
9698a0d to
7675333
Compare
HuJean
changed the title
HuJean
force-pushed
the
p/hujing/lazy-bundle
branch
3 times, most recently
from
bdc8ce7 to
ee46fb1
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx (1)
2-6: Test now correctly targets plain dynamic importsThe async test with two awaited relative
import()calls exercises the intended scenario (dynamic imports withoutlazywrapper) and then checkslynx.loadLazyBundleis defined, which matches the linked bug’s intent. As a minor optional tweak, you could run the imports in parallel for slightly faster tests:await Promise.all([import('./foo.js'), import('./foo2.js')]);But the current version is perfectly fine functionally.
examples/react-lazy-bundle/lynx.config.js (1)
1-25: VerifypluginQRCodeschema return typeThe overall rsbuild config looks good, but the custom QR schema:
schema(url) { return `${url}?fullscreen=true`; }differs from the plugin’s documented default of returning an object like
{ http: url }. IfregisterConsoleShortcuts(downstream ofpluginQRCode) expects that object shape, this change may break QR payloads. You might instead want:schema(url) { return { http: `${url}?fullscreen=true` }; }Please double‑check the plugin’s expected schema shape.
examples/react-lazy-bundle/src/App.tsx (1)
1-61: Component logic is solid; consider renaming innerresfor clarityThe dynamic imports in
useEffectnicely exercise relative string‑literal imports and theonTaphandler cleanly togglesalterLogo; overall behavior looks correct for this example.Minor readability nit: in
void import('./utils/dynamic.js').then((res) => { console.info('dynamic import dynamic'); void res.dynamicAdd(1, 2).then(res => { console.info('dynamic add', res); }); });the inner
resshadows the outer one. Renaming the inner parameter (e.g. tosumorresult) would avoid confusion:void res.dynamicAdd(1, 2).then(result => { console.info('dynamic add', result); });
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
examples/react-lazy-bundle/src/assets/arrow.pngis excluded by!**/*.pngexamples/react-lazy-bundle/src/assets/lynx-logo.pngis excluded by!**/*.pngexamples/react-lazy-bundle/src/assets/react-logo.pngis excluded by!**/*.pngpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (21)
.changeset/four-rice-guess.md(1 hunks)examples/react-lazy-bundle/lynx.config.js(1 hunks)examples/react-lazy-bundle/package.json(1 hunks)examples/react-lazy-bundle/src/App.css(1 hunks)examples/react-lazy-bundle/src/App.tsx(1 hunks)examples/react-lazy-bundle/src/index.tsx(1 hunks)examples/react-lazy-bundle/src/rspeedy-env.d.ts(1 hunks)examples/react-lazy-bundle/src/utils/add.ts(1 hunks)examples/react-lazy-bundle/src/utils/dynamic.ts(1 hunks)examples/react-lazy-bundle/src/utils/minus.ts(1 hunks)examples/react-lazy-bundle/tsconfig.json(1 hunks)packages/react/runtime/src/index.ts(1 hunks)packages/react/transform/__test__/fixture.spec.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs(6 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_lynx.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_not_import_lazy.js(0 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx(1 hunks)
💤 Files with no reviewable changes (1)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_not_import_lazy.js
✅ Files skipped from review due to trivial changes (1)
- examples/react-lazy-bundle/package.json
🚧 Files skipped from review as they are similar to previous changes (6)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_transform_import_call.js
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
- packages/react/transform/test/fixture.spec.js
- packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
- packages/react/runtime/src/index.ts
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_import_lazy_lynx.js
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
For contributions, generate and commit a Changeset describing your changes
Files:
.changeset/four-rice-guess.md
🧠 Learnings (26)
📓 Common learnings
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
📚 Learning: 2025-07-18T04:27:18.291Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1238
File: packages/react/runtime/src/debug/component-stack.ts:70-90
Timestamp: 2025-07-18T04:27:18.291Z
Learning: The component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork from https://github.com/preactjs/preact/blob/main/debug/src/component-stack.js. The team prefers to keep it aligned with the upstream Preact version and may contribute improvements back to Preact in the future.
Applied to files:
examples/react-lazy-bundle/src/index.tsx
📚 Learning: 2025-08-27T12:42:01.095Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Applied to files:
examples/react-lazy-bundle/src/index.tsx.changeset/four-rice-guess.mdpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/src/rspeedy-env.d.tsexamples/react-lazy-bundle/lynx.config.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
examples/react-lazy-bundle/src/index.tsxexamples/react-lazy-bundle/src/App.tsx.changeset/four-rice-guess.mdpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/lynx.config.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Applied to files:
.changeset/four-rice-guess.mdpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/src/rspeedy-env.d.tsexamples/react-lazy-bundle/lynx.config.jsexamples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
.changeset/four-rice-guess.mdexamples/react-lazy-bundle/lynx.config.jsexamples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-08-13T11:46:43.737Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Applied to files:
.changeset/four-rice-guess.mdpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/src/rspeedy-env.d.tsexamples/react-lazy-bundle/lynx.config.jsexamples/react-lazy-bundle/tsconfig.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-08-11T05:59:28.530Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.
Applied to files:
.changeset/four-rice-guess.mdpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-09-25T14:03:25.576Z
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Applied to files:
.changeset/four-rice-guess.mdpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/lynx.config.jsexamples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-08-11T05:57:18.212Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/testing-library/testing-environment/src/index.ts:255-258
Timestamp: 2025-08-11T05:57:18.212Z
Learning: In the ReactLynx testing environment (`packages/testing-library/testing-environment/src/index.ts`), the dual assignment pattern `target.console.method = console.method = () => {}` is required for rstest compatibility. This is because rstest provides `console` in an IIFE (Immediately Invoked Function Expression), and both the target and global console need to have these methods defined for proper test execution.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/src/rspeedy-env.d.tsexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-10-29T10:28:27.519Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-08-27T08:10:09.932Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.tsexamples/react-lazy-bundle/lynx.config.jsexamples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.tsexamples/react-lazy-bundle/lynx.config.jsexamples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-11-04T10:15:14.965Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.ts
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.ts
📚 Learning: 2025-11-03T08:47:17.714Z
Learnt from: Sherry-hue
Repo: lynx-family/lynx-stack PR: 1911
File: packages/web-platform/web-tests/tests/react/basic-element-list-estimated-main-axis-size-px/index.jsx:14-24
Timestamp: 2025-11-03T08:47:17.714Z
Learning: In the autoScroll method for XList components in the lynx-family/lynx-stack repository, the `rate` parameter supports plain strings like `'100'` in addition to numbers and strings with unit suffixes (`${number}px`, `${number}rpx`, `${number}ppx`), even though the TypeScript type definition may appear more restrictive.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.ts
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Applied to files:
examples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-11-06T01:19:23.670Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.
Applied to files:
examples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-11-05T03:26:52.546Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-09-18T08:12:56.802Z
Learnt from: Sherry-hue
Repo: lynx-family/lynx-stack PR: 1770
File: packages/web-platform/web-mainthread-apis/src/utils/processStyleInfo.ts:316-318
Timestamp: 2025-09-18T08:12:56.802Z
Learning: In packages/web-platform/web-mainthread-apis/src/utils/processStyleInfo.ts, the current implementation uses cardStyleElement.textContent += for lazy component styles. While this could theoretically invalidate rule indices by reparsing the stylesheet, Sherry-hue indicated that UIDs don't repeat for the same element, making this approach acceptable for now. A future optimization to use separate style elements per entry was discussed but deferred to a separate PR to keep the current lazy bundle PR focused.
Applied to files:
examples/react-lazy-bundle/src/App.css
🧬 Code graph analysis (3)
examples/react-lazy-bundle/src/utils/dynamic.ts (1)
examples/react-lazy-bundle/src/utils/add.ts (1)
add(1-3)
examples/react-lazy-bundle/src/index.tsx (1)
examples/react-lazy-bundle/src/App.tsx (1)
App(8-61)
examples/react-lazy-bundle/lynx.config.js (1)
packages/rspeedy/plugin-qrcode/src/index.ts (1)
pluginQRCode(91-155)
🪛 LanguageTool
.changeset/four-rice-guess.md
[grammar] ~5-~5: Use a hyphen to join words.
Context: --- "@lynx-js/react": patch --- Auto define lynx.loadLazyBundle when using `i...
(QB_NEW_EN_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build / Build (Windows)
- GitHub Check: build / Build (Ubuntu)
- GitHub Check: test-rust / Test (Ubuntu)
🔇 Additional comments (9)
examples/react-lazy-bundle/src/rspeedy-env.d.ts (1)
1-1: LGTM!The triple-slash reference follows the established pattern for Rspeedy templates. The
@lynx-js/rspeedydependency is correctly listed in devDependencies, so the type reference to@lynx-js/rspeedy/clientis valid.packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js (1)
1-9: Snapshot output looks consistent with the intended dynamic‑import transformThe side‑effect import of
@lynx-js/react/experimental/lazy/importand the explicit__dynamicImportcall inside an async IIFE are both valid and aligned with the expected runtime wiring; there are no correctness issues here.packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js (1)
1-3: Simple helper module looks good
foo2is a clear, side‑effect‑free helper that fits the test case needs; no changes suggested.examples/react-lazy-bundle/src/utils/minus.ts (1)
1-3: Utility implementation is correct
minusdoes exactly what its name suggests with clear types and no edge‑case issues for this example.examples/react-lazy-bundle/src/utils/add.ts (1)
1-3: Add helper looks goodStraightforward, typed
addhelper; matches how it’s used elsewhere.examples/react-lazy-bundle/tsconfig.json (1)
1-19: TS config is consistent for an example appThe JSX/runtime settings and
noEmit+allowJs/checkJscombo make sense for a purely type‑checked example, and the includes/references look coherent assuming those referenced tsconfig files exist and are composite projects.If you haven’t already, quickly run
pnpm ts:check(or the equivalent) from the repo root to confirm the new project reference chain doesn’t introduce any circular or missing‑project errors.examples/react-lazy-bundle/src/utils/dynamic.ts (1)
1-4: Dynamic wrapper aroundaddis appropriate
dynamicAddcleanly demonstrates a relative string‑literal dynamic import and delegates toadd, which is exactly the pattern this PR is targeting.If this is meant to exercise the SWC transform, ensure there’s a corresponding test that snapshots or asserts the transformed import for
./add.js.examples/react-lazy-bundle/src/index.tsx (1)
1-17: Entry setup and dynamic import look goodThe entry correctly wires
root.render(<App />)and uses a top‑levelvoid import('./utils/minus.js')to exercise relative dynamic imports; the minimal webpack HMR hook is also fine for this example.Consider adding or updating a transform test that covers this exact
import('./utils/minus.js')shape so regressions in the lazy‑bundle injection are caught automatically.examples/react-lazy-bundle/src/App.css (1)
1-119: Styling matches the component structure and is syntactically soundThe CSS classes line up with the elements in
App.tsx, animations and layout properties are well‑formed, and there are no apparent issues that would block this example from rendering correctly.
hzy
previously approved these changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (1)
219-219: Naming aligned with internal lazy bundle semantics.The field
has_inner_lazy_bundlecorrectly distinguishes relative-path imports (which create inner lazy bundles) from external URL imports (handled via__dynamicImportin the else branch). The naming accurately reflects the specific behavior being tracked..changeset/four-rice-guess.md (1)
5-5: Minor grammar fix needed: hyphenate "Auto-define".As per static analysis, use a hyphen to join the compound modifier.
-Auto define lynx.loadLazyBundle when using `import(/* relative path */)`. +Auto-define lynx.loadLazyBundle when using `import(/* relative path */)`.
🧹 Nitpick comments (2)
examples/react-lazy-bundle/lynx.config.js (1)
17-24: Consider documenting the purpose of the empty web environment.The
web: {}environment is defined but empty. If this example primarily targets the Lynx environment, consider adding a brief comment explaining why the web environment is included (e.g., for potential dual-target builds or future expansion).packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (1)
266-278: Consider a more robust path transformation approach.The string replacement
.replace("/internal", "")on line 269 is fragile and could produce unexpected results ifruntime_pkgcontains "/internal" in an unexpected position (e.g., a custom package path like@company/internal-react/internal).Consider using a more explicit approach:
- create_import_decl( - &format!("{}/experimental/lazy/import", self.opts.runtime_pkg).replace("/internal", ""), - ), + create_import_decl( + &self.opts.runtime_pkg + .strip_suffix("/internal") + .map(|pkg| format!("{}/experimental/lazy/import", pkg)) + .unwrap_or_else(|| format!("{}/experimental/lazy/import", self.opts.runtime_pkg)), + ),
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (25)
.changeset/four-rice-guess.md(1 hunks)examples/react-lazy-bundle/lynx.config.js(1 hunks)examples/react-lazy-bundle/package.json(1 hunks)examples/react-lazy-bundle/src/App.css(1 hunks)examples/react-lazy-bundle/src/App.tsx(1 hunks)examples/react-lazy-bundle/src/index.tsx(1 hunks)examples/react-lazy-bundle/src/rspeedy-env.d.ts(1 hunks)examples/react-lazy-bundle/src/utils/add.ts(1 hunks)examples/react-lazy-bundle/src/utils/dynamic.ts(1 hunks)examples/react-lazy-bundle/src/utils/minus.ts(1 hunks)examples/react-lazy-bundle/tsconfig.json(1 hunks)packages/react/runtime/src/index.ts(1 hunks)packages/react/runtime/vitest.config.ts(1 hunks)packages/react/transform/__test__/fixture.spec.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs(8 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_not_import_lazy.js(0 hunks)packages/react/transform/index.d.ts(1 hunks)packages/react/transform/rspack-napi/src/index.ts(1 hunks)packages/react/transform/swc-plugin-reactlynx/index.d.ts(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx(1 hunks)
💤 Files with no reviewable changes (1)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_not_import_lazy.js
🚧 Files skipped from review as they are similar to previous changes (14)
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx
- examples/react-lazy-bundle/src/utils/dynamic.ts
- examples/react-lazy-bundle/src/index.tsx
- examples/react-lazy-bundle/src/rspeedy-env.d.ts
- examples/react-lazy-bundle/src/App.tsx
- examples/react-lazy-bundle/src/utils/minus.ts
- packages/react/transform/test/fixture.spec.js
- examples/react-lazy-bundle/package.json
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_import_lazy_import.js
- examples/react-lazy-bundle/src/utils/add.ts
- examples/react-lazy-bundle/src/App.css
- examples/react-lazy-bundle/tsconfig.json
- packages/react/runtime/src/index.ts
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
For contributions, generate and commit a Changeset describing your changes
Files:
.changeset/four-rice-guess.md
🧠 Learnings (25)
📓 Common learnings
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
📚 Learning: 2025-11-04T10:15:14.965Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
Applied to files:
packages/react/transform/index.d.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js
📚 Learning: 2025-08-27T12:42:01.095Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Applied to files:
packages/react/transform/index.d.tspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/rspack-napi/src/index.tspackages/react/runtime/vitest.config.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/swc-plugin-reactlynx/index.d.tsexamples/react-lazy-bundle/lynx.config.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs.changeset/four-rice-guess.md
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
packages/react/transform/index.d.tspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/rspack-napi/src/index.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/swc-plugin-reactlynx/index.d.tsexamples/react-lazy-bundle/lynx.config.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/vitest.config.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/vitest.config.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jsexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-09-25T14:03:25.576Z
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-11T05:59:28.530Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/vitest.config.ts.changeset/four-rice-guess.md
📚 Learning: 2025-08-11T06:00:04.376Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:59-61
Timestamp: 2025-08-11T06:00:04.376Z
Learning: In the lynx-family/lynx-stack repository, the `testingLibraryPlugin` in `packages/react/testing-library/src/plugins/vitest.ts` intentionally uses `process.exit` when jsdom installation fails, maintaining consistency with the previous implementation from `packages/react/testing-library/src/vitest.config.js`. This behavior should not be changed to use `this.error` despite being a Vite plugin best practice.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/vitest.config.ts
📚 Learning: 2025-08-11T05:57:18.212Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/testing-library/testing-environment/src/index.ts:255-258
Timestamp: 2025-08-11T05:57:18.212Z
Learning: In the ReactLynx testing environment (`packages/testing-library/testing-environment/src/index.ts`), the dual assignment pattern `target.console.method = console.method = () => {}` is required for rstest compatibility. This is because rstest provides `console` in an IIFE (Immediately Invoked Function Expression), and both the target and global console need to have these methods defined for proper test execution.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/runtime/vitest.config.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx.changeset/four-rice-guess.md
📚 Learning: 2025-09-23T08:54:39.966Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1670
File: packages/webpack/css-extract-webpack-plugin/test/hotCases/hot/hot-update-json/dual-thread/__snapshot__/index.css:6-8
Timestamp: 2025-09-23T08:54:39.966Z
Learning: In the lynx-stack CSS extract webpack plugin tests, many test fixture CSS files intentionally use invalid CSS syntax like `color: 'red';` with quoted values. The snapshots correctly reflect this invalid CSS from the source fixtures. To fix CSS validation issues, the source fixture files should be updated first, then snapshots regenerated, rather than manually editing snapshots.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/rspack-napi/src/index.tspackages/react/runtime/vitest.config.tspackages/react/transform/swc-plugin-reactlynx/index.d.tsexamples/react-lazy-bundle/lynx.config.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-13T11:46:43.737Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/rspack-napi/src/index.tspackages/react/runtime/vitest.config.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jsexamples/react-lazy-bundle/lynx.config.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
packages/react/transform/rspack-napi/src/index.tsexamples/react-lazy-bundle/lynx.config.js.changeset/four-rice-guess.md
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Applied to files:
packages/react/transform/rspack-napi/src/index.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/swc-plugin-reactlynx/index.d.tsexamples/react-lazy-bundle/lynx.config.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs.changeset/four-rice-guess.md
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/react/runtime/vitest.config.tsexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-10-29T10:28:27.519Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Applied to files:
packages/react/runtime/vitest.config.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/swc-plugin-reactlynx/index.d.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-11-05T03:26:52.546Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/crates/swc_plugin_dynamic_import/napi.rspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-09-10T11:42:36.855Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1714
File: packages/react/transform/Cargo.toml:19-19
Timestamp: 2025-09-10T11:42:36.855Z
Learning: In packages/react/transform/Cargo.toml, the crate uses serde derive macros (#[derive(Serialize, Deserialize)]) in multiple files including src/esbuild.rs and src/swc_plugin_extract_str/mod.rs, so the "derive" feature is required when migrating to workspace dependencies.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/napi.rspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-08-27T08:10:09.932Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.
Applied to files:
examples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.
Applied to files:
examples/react-lazy-bundle/lynx.config.js.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.changeset/four-rice-guess.md
🧬 Code graph analysis (1)
examples/react-lazy-bundle/lynx.config.js (1)
packages/rspeedy/plugin-qrcode/src/index.ts (1)
pluginQRCode(91-155)
🪛 LanguageTool
.changeset/four-rice-guess.md
[grammar] ~5-~5: Use a hyphen to join words.
Context: --- "@lynx-js/react": patch --- Auto define lynx.loadLazyBundle when using `i...
(QB_NEW_EN_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build / Build (Ubuntu)
- GitHub Check: build / Build (Windows)
- GitHub Check: test-rust / Test (Ubuntu)
🔇 Additional comments (10)
examples/react-lazy-bundle/lynx.config.js (1)
1-25: LGTM! Clean example configuration for demonstrating lazy bundle functionality.The configuration correctly integrates the React Lynx plugin, QR code generation, and conditional performance profiling. The structure follows RSBuild/Rspeedy conventions and provides a solid foundation for the lazy bundle example.
packages/react/runtime/vitest.config.ts (1)
39-39: ChangedynamicImport: falsetodynamicImport: trueor document the intentional exclusion.Runtime tests extensively use dynamic imports (
await import(...)) across multiple test files, includinglazy-bundle.test.jswhich directly testsloadLazyBundlewith dynamic imports. SettingdynamicImport: falseprevents the new lazy bundle auto-injection feature from being applied to these test files, creating a gap in test coverage for the PR's primary objective. Either enable the transform to validate the feature works in tests, or add a comment explaining why this intentional opt-out is necessary.⛔ Skipped due to learnings
Learnt from: colinaaa Repo: lynx-family/lynx-stack PR: 1453 File: vitest.config.ts:49-61 Timestamp: 2025-08-06T13:28:57.182Z Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.Learnt from: colinaaa Repo: lynx-family/lynx-stack PR: 1453 File: vitest.config.ts:49-61 Timestamp: 2025-08-06T13:28:57.182Z Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.Learnt from: upupming Repo: lynx-family/lynx-stack PR: 1305 File: packages/react/testing-library/src/plugins/vitest.ts:4-6 Timestamp: 2025-08-11T05:59:28.530Z Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.Learnt from: upupming Repo: lynx-family/lynx-stack PR: 1616 File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3 Timestamp: 2025-08-27T12:42:01.095Z Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.Learnt from: upupming Repo: lynx-family/lynx-stack PR: 1305 File: packages/react/testing-library/src/plugins/vitest.ts:59-61 Timestamp: 2025-08-11T06:00:04.376Z Learning: In the lynx-family/lynx-stack repository, the `testingLibraryPlugin` in `packages/react/testing-library/src/plugins/vitest.ts` intentionally uses `process.exit` when jsdom installation fails, maintaining consistency with the previous implementation from `packages/react/testing-library/src/vitest.config.js`. This behavior should not be changed to use `this.error` despite being a Vite plugin best practice.Learnt from: gaoachao Repo: lynx-family/lynx-stack PR: 1771 File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2 Timestamp: 2025-09-18T04:43:54.426Z Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx (1)
22-28: LGTM!The test correctly validates that
lynx.loadLazyBundleis defined after a dynamic import attempt. Based on learnings, webpack properties are injected at compile/build time, so the assertion doesn't need to wait for the dynamic import to complete.packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
117-130: LGTM!The helper function
create_import_declcorrectly creates a side-effect-only import declaration with the appropriate SWC AST structure. Good extraction of repeated logic.
338-386: Good test coverage for lazy bundle injection scenarios.The tests properly cover:
should_import_lazy_import: external URL withinject_lazy_bundledefault (true)should_import_lazy_bundle: relative path import triggering inner lazy bundleshould_not_import_lazy: template literal imports (context imports) correctly excludedpackages/react/transform/swc-plugin-reactlynx/index.d.ts (1)
166-173: LGTM!The
injectLazyBundlefield correctly mirrors the Rust configuration (inject_lazy_bundle) and follows TypeScript naming conventions. Properly marked as@internal.packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (1)
29-36: Verify intentional hardcoding ofinject_lazy_bundle.The N-API struct
DynamicImportVisitorConfig(lines 13-18) doesn't exposeinject_lazy_bundle, so it's hardcoded totrueduring conversion. This means N-API consumers cannot disable lazy bundle injection.If this is intentional (always enable for N-API consumers), consider adding a brief comment explaining why. If configurability is needed, the field should be added to the N-API struct.
packages/react/transform/rspack-napi/src/index.ts (1)
78-82: LGTM! Default enables lazy bundle auto-injection.The new
injectLazyBundle: truedefault aligns with the PR objective to automatically definelynx.loadLazyBundlewhen dynamic imports are used. This prevents the runtime error mentioned in issue #1954.packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js (1)
2-4: LGTM! Standard dynamic import pattern.The async IIFE with dynamic import correctly demonstrates the use case that triggers lazy bundle injection. The
webpackChunkNamecomment provides helpful metadata for webpack's code splitting.packages/react/transform/index.d.ts (1)
427-428: LGTM! Type definition is correct.The
injectLazyBundle: booleanfield is properly typed and documented as@internal, consistent with the other internal configuration fields inDynamicImportVisitorConfig.
HuJean
force-pushed
the
p/hujing/lazy-bundle
branch
from
72115af to
b13040f
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (1)
216-216: Consider renaming for clarity.The field name
has_inner_lazy_bundlewas previously flagged. Since this tracks whether any relative-path dynamic import was found (triggering lazy bundle injection), a name likehas_lazy_bundleorneeds_lazy_bundle_importmight be clearer..changeset/four-rice-guess.md (1)
5-5: Hyphenate compound modifier: use "Auto-define" instead of "Auto define".As previously noted, the compound modifier should be hyphenated for grammatical correctness.
-Auto define lynx.loadLazyBundle when using `import(/* relative path */)`. +Auto-define lynx.loadLazyBundle when using `import(/* relative path */)`.
🧹 Nitpick comments (4)
examples/react-lazy-bundle/src/index.tsx (1)
7-9: Consider adding error handling for the dynamic import.While this works for a demo, adding
.catch()would make the example more robust and demonstrate proper error handling for lazy bundle loading.Apply this diff to add error handling:
void import('./utils/minus.js').then((res) => { console.info('dynamic import minus', res.minus(1, 2)); +}).catch((err) => { + console.error('Failed to load minus module:', err); });examples/react-lazy-bundle/src/utils/dynamic.ts (1)
1-4: Consider caching the dynamic import to improve performance.The function performs a dynamic import on every call. While JavaScript engines may cache module loads, explicitly caching the import promise would be more efficient and demonstrate best practices for lazy loading.
Apply this diff to cache the import:
+let addModulePromise: Promise<typeof import('./add.js')> | null = null; + export async function dynamicAdd(a: number, b: number) { - const { add } = await import('./add.js'); + if (!addModulePromise) { + addModulePromise = import('./add.js'); + } + const { add } = await addModulePromise; return add(a, b); }packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (1)
263-268: String manipulation for path construction is fragile.The
.replace("/internal", "")approach assumesruntime_pkgalways contains/internalsuffix. If the config ever changes or someone provides a customruntime_pkgwithout that suffix, the path construction will be incorrect.Consider making this more explicit:
- create_import_decl( - &format!("{}/experimental/lazy/import", self.opts.runtime_pkg).replace("/internal", ""), - ), + create_import_decl("@lynx-js/react/experimental/lazy/import"),Alternatively, if the base package needs to be configurable, consider adding a separate config field for the base package name.
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js (1)
1-1: Data-URL side-effect import wiringlynx.loadLazyBundlelooks correct; please verify URL/encoding and generation pathThe new top-level import ensures
lynx.loadLazyBundleis assigned before any dynamic imports run in this module, which matches the PR goal of avoidinglynx.loadLazyBundle is not a functionat runtime.Two things to double‑check:
The
data:text/javascript;charset=utf-8,...specifier currently embeds raw JS (import { loadLazyBundle } ...;lynx.loadLazyBundle = loadLazyBundle;) without URL-encoding. Some loaders/runtimes (especially browser/Node URL parsers) can be strict about data: URLs being valid URLs, which may require percent‑encoding spaces and certain punctuation. Please confirm this exact specifier works across the bundlers/runtimes you support; if not, consider having the transform encode the body (e.g., viaencodeURIComponentor equivalent) rather than changing the snapshot by hand.Since files under
tests/__swc_snapshots__/are auto-generated, ensure this change is the result of the updatedswc_plugin_dynamic_importtransform logic, not a manual edit to the snapshot. Based on learnings, snapshot files should only reflect generator changes, not be the primary place to implement logic.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (23)
.changeset/four-rice-guess.md(1 hunks)examples/react-lazy-bundle/lynx.config.js(1 hunks)examples/react-lazy-bundle/package.json(1 hunks)examples/react-lazy-bundle/src/App.css(1 hunks)examples/react-lazy-bundle/src/App.tsx(1 hunks)examples/react-lazy-bundle/src/index.tsx(1 hunks)examples/react-lazy-bundle/src/rspeedy-env.d.ts(1 hunks)examples/react-lazy-bundle/src/utils/add.ts(1 hunks)examples/react-lazy-bundle/src/utils/dynamic.ts(1 hunks)examples/react-lazy-bundle/src/utils/minus.ts(1 hunks)examples/react-lazy-bundle/tsconfig.json(1 hunks)packages/react/runtime/src/index.ts(1 hunks)packages/react/runtime/vitest.config.ts(1 hunks)packages/react/transform/__test__/fixture.spec.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs(6 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_not_import_lazy.js(0 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js(1 hunks)packages/react/transform/rspack-napi/src/index.ts(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx(1 hunks)
💤 Files with no reviewable changes (1)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_not_import_lazy.js
🚧 Files skipped from review as they are similar to previous changes (10)
- examples/react-lazy-bundle/src/App.tsx
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx
- examples/react-lazy-bundle/src/rspeedy-env.d.ts
- packages/react/runtime/src/index.ts
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_import_lazy_bundle.js
- examples/react-lazy-bundle/src/App.css
- examples/react-lazy-bundle/tsconfig.json
- packages/react/transform/test/fixture.spec.js
- examples/react-lazy-bundle/src/utils/add.ts
- examples/react-lazy-bundle/lynx.config.js
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
For contributions, generate and commit a Changeset describing your changes
Files:
.changeset/four-rice-guess.md
🧠 Learnings (26)
📓 Common learnings
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:52-72
Timestamp: 2025-08-13T11:36:12.075Z
Learning: The lynx-stack project requires Node.js >=22 as specified in package.json engines, so Node.js compatibility fallbacks for features introduced before v22 are unnecessary.
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/react/runtime/vitest.config.tsexamples/react-lazy-bundle/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/react/runtime/vitest.config.tsexamples/react-lazy-bundle/package.json
📚 Learning: 2025-08-11T05:59:28.530Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.
Applied to files:
packages/react/runtime/vitest.config.tsexamples/react-lazy-bundle/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx.changeset/four-rice-guess.md
📚 Learning: 2025-08-11T06:00:04.376Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:59-61
Timestamp: 2025-08-11T06:00:04.376Z
Learning: In the lynx-family/lynx-stack repository, the `testingLibraryPlugin` in `packages/react/testing-library/src/plugins/vitest.ts` intentionally uses `process.exit` when jsdom installation fails, maintaining consistency with the previous implementation from `packages/react/testing-library/src/vitest.config.js`. This behavior should not be changed to use `this.error` despite being a Vite plugin best practice.
Applied to files:
packages/react/runtime/vitest.config.tspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-08-27T12:42:01.095Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Applied to files:
packages/react/runtime/vitest.config.tsexamples/react-lazy-bundle/src/index.tsxexamples/react-lazy-bundle/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.jsexamples/react-lazy-bundle/src/utils/dynamic.ts.changeset/four-rice-guess.mdpackages/react/transform/rspack-napi/src/index.ts
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Applied to files:
packages/react/runtime/vitest.config.tsexamples/react-lazy-bundle/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rs.changeset/four-rice-guess.mdpackages/react/transform/rspack-napi/src/index.ts
📚 Learning: 2025-10-29T10:28:27.519Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Applied to files:
packages/react/runtime/vitest.config.tspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-08-11T05:57:18.212Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/testing-library/testing-environment/src/index.ts:255-258
Timestamp: 2025-08-11T05:57:18.212Z
Learning: In the ReactLynx testing environment (`packages/testing-library/testing-environment/src/index.ts`), the dual assignment pattern `target.console.method = console.method = () => {}` is required for rstest compatibility. This is because rstest provides `console` in an IIFE (Immediately Invoked Function Expression), and both the target and global console need to have these methods defined for proper test execution.
Applied to files:
packages/react/runtime/vitest.config.tspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-07-18T04:27:18.291Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1238
File: packages/react/runtime/src/debug/component-stack.ts:70-90
Timestamp: 2025-07-18T04:27:18.291Z
Learning: The component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork from https://github.com/preactjs/preact/blob/main/debug/src/component-stack.js. The team prefers to keep it aligned with the upstream Preact version and may contribute improvements back to Preact in the future.
Applied to files:
examples/react-lazy-bundle/src/index.tsx
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
examples/react-lazy-bundle/src/index.tsxexamples/react-lazy-bundle/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js.changeset/four-rice-guess.mdpackages/react/transform/rspack-napi/src/index.ts
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
examples/react-lazy-bundle/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js.changeset/four-rice-guess.mdpackages/react/transform/rspack-napi/src/index.ts
📚 Learning: 2025-11-06T01:19:23.670Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.
Applied to files:
examples/react-lazy-bundle/package.json
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.
Applied to files:
examples/react-lazy-bundle/package.json.changeset/four-rice-guess.md
📚 Learning: 2025-08-27T08:10:09.932Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.
Applied to files:
examples/react-lazy-bundle/package.json
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
examples/react-lazy-bundle/package.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js
📚 Learning: 2025-09-25T14:03:25.576Z
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx.changeset/four-rice-guess.md
📚 Learning: 2025-09-23T08:54:39.966Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1670
File: packages/webpack/css-extract-webpack-plugin/test/hotCases/hot/hot-update-json/dual-thread/__snapshot__/index.css:6-8
Timestamp: 2025-09-23T08:54:39.966Z
Learning: In the lynx-stack CSS extract webpack plugin tests, many test fixture CSS files intentionally use invalid CSS syntax like `color: 'red';` with quoted values. The snapshots correctly reflect this invalid CSS from the source fixtures. To fix CSS validation issues, the source fixture files should be updated first, then snapshots regenerated, rather than manually editing snapshots.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-08-13T11:46:43.737Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js.changeset/four-rice-guess.md
📚 Learning: 2025-11-05T03:26:52.546Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/rspack-napi/src/index.ts
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.jspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-09-10T11:42:36.855Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1714
File: packages/react/transform/Cargo.toml:19-19
Timestamp: 2025-09-10T11:42:36.855Z
Learning: In packages/react/transform/Cargo.toml, the crate uses serde derive macros (#[derive(Serialize, Deserialize)]) in multiple files including src/esbuild.rs and src/swc_plugin_extract_str/mod.rs, so the "derive" feature is required when migrating to workspace dependencies.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.changeset/four-rice-guess.md
🧬 Code graph analysis (3)
examples/react-lazy-bundle/src/index.tsx (1)
examples/react-lazy-bundle/src/App.tsx (1)
App(5-30)
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (1)
new(67-71)packages/react/transform/swc-plugin-reactlynx/index.d.ts (1)
DynamicImportVisitorConfig(166-171)
examples/react-lazy-bundle/src/utils/dynamic.ts (1)
examples/react-lazy-bundle/src/utils/add.ts (1)
add(1-3)
🪛 GitHub Check: code-style-check
packages/react/transform/rspack-napi/src/index.ts
[failure] 81-81:
Type 'boolean | DynamicImportVisitorConfig | { runtimePkg: string; layer: string; injectLazyBundle: true; }' is not assignable to type 'boolean | DynamicImportVisitorConfig'.
🪛 LanguageTool
.changeset/four-rice-guess.md
[grammar] ~5-~5: Use a hyphen to join words.
Context: --- "@lynx-js/react": patch --- Auto define lynx.loadLazyBundle when using `i...
(QB_NEW_EN_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build / Build (Windows)
- GitHub Check: build / Build (Ubuntu)
- GitHub Check: test-rust / Test (Ubuntu)
🔇 Additional comments (10)
examples/react-lazy-bundle/package.json (1)
1-22: Package structure follows monorepo conventions; verify supporting example files and version strategy.The configuration correctly uses
workspace:*for local packages and marks itself as private. However, a few items warrant verification:
- Supporting files: Ensure all necessary example assets are included in the PR (lynx.config.js, App.tsx, utility files demonstrating lazy bundle usage, etc.).
- Preact-devtools version: Line 15 pins an experimental build (
^5.0.1-cf9aef5). Confirm this is intentional for this example.- Types version: Line 19 pins
@lynx-js/types@3.4.11without a caret. Verify this aligns with version pinning strategy used in other example packages.- Metadata fields: Confirm that omitting
description,author, andlicensefields is the convention for example packages in this monorepo.packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js (1)
1-3: LGTM! Test fixture is appropriate.This test fixture is correctly implemented for validating the lazy bundle loading functionality. The simple function returning a constant value is suitable for testing dynamic imports and verifying that
lynx.loadLazyBundleis properly defined.examples/react-lazy-bundle/src/utils/minus.ts (1)
1-3: LGTM! Clean example utility.The function is correctly implemented and serves its purpose as a test case for lazy bundle loading.
examples/react-lazy-bundle/src/index.tsx (2)
1-5: LGTM! Proper setup imports.The imports correctly set up the development environment and bring in necessary components.
11-17: LGTM! Standard render and HMR setup.The rendering logic and hot module replacement configuration are correctly implemented.
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
334-361: Test coverage looks good.The new tests (
should_import_lazy_import,should_import_lazy_bundle,should_not_import_lazy) cover the key scenarios:
- External URL imports that need
__dynamicImportwrapper- Relative path imports that trigger lazy bundle injection
- Template literal imports that should be ignored
270-275: Data URL import approach is correct and guaranteed to work.The data URL effectively injects
lynx.loadLazyBundleduring module evaluation. Thelynxglobal is guaranteed to exist because webpack's runtime-wrapper-webpack-plugin injectslynx = lynx || {};as part of the module wrapper initialization. The unencoded data URL is safe for this use case since the content contains only ASCII characters with no special characters requiring encoding.packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js (1)
1-9: Snapshot correctly reflects external URL handling.The transformed output shows:
- The experimental lazy import is prepended
- The
__dynamicImporthelper is imported from internal- External URL (
https://) is wrapped with__dynamicImportinstead of nativeimport()This aligns with the transform logic where external URLs use the
__dynamicImportwrapper path.packages/react/runtime/vitest.config.ts (1)
39-39: Disabling dynamic import transform for runtime tests is appropriate.Setting
dynamicImport: falseprevents the new lazy bundle injection from affecting runtime unit tests, which should test runtime behavior in isolation rather than transform behavior.packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx (1)
22-28: Test correctly validates the bug fix.The test structure is appropriate:
- Attempts a dynamic import (which triggers the transform to inject
loadLazyBundle)- Catches and ignores the expected network error
- Verifies
lynx.loadLazyBundleis definedBased on learnings, webpack properties are injected at compile time, so the assertion correctly runs synchronously after the import attempt.
HuJean
force-pushed
the
p/hujing/lazy-bundle
branch
from
b13040f to
8c5b505
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
.changeset/four-rice-guess.md (1)
5-5: Hyphenate “Auto-define” in the changeset description.Change the leading phrase to use a hyphen for correct compound wording:
-Auto define lynx.loadLazyBundle when using `import(/* relative path */)`. +Auto-define lynx.loadLazyBundle when using `import(/* relative path */)`.
🧹 Nitpick comments (4)
examples/react-lazy-bundle/src/utils/dynamic.ts (1)
1-4: Dynamic import helper is correct; consider adding explicit return typeThe lazy import and delegation to
add(a, b)look good and match the relative-path dynamic import requirement. You might optionally add an explicit return type for clarity:-export async function dynamicAdd(a: number, b: number) { +export async function dynamicAdd(a: number, b: number): Promise<number> {This makes the intent of returning a
Promise<number>obvious at call sites, but is not strictly required.examples/react-lazy-bundle/lynx.config.js (1)
1-25: Confirm QR codeschemareturn type (string vs{ http: url }).
pluginQRCode’s defaultschemamaps the URL to an object like{ http: url }, while this example overrides it to return a plain string:schema(url) { return `${url}?fullscreen=true`; }If
registerConsoleShortcuts/ the QR plugin expect the original object shape, consider:schema(url) { return { http: `${url}?fullscreen=true` }; }Otherwise, please double‑check the types to ensure this override is valid and doesn’t break QR code generation.
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
40-48: Scope ofhas_inner_lazy_bundleand lazy-bundle injection.
has_inner_lazy_bundleis set for any non‑external string‑literal dynamic import:
- It fires for
import("./index.js")andimport("./index.js", { with: { type: "component" } })(good, matches the issue intent).- It also fires for bare specifiers like
import("some-pkg")and other non‑URL string literals, which will also cause the data‑URL lazy‑bundle import to be prepended.If the goal is only to auto‑define
lynx.loadLazyBundlefor “internal”/relative paths, you might want to narrow this condition, e.g. to prefixes like"./"/"../"(or however “relative” is defined in your bundlers). If it’s intentional to cover all non‑URL string specifiers, this is fine, but might be worth a short comment to avoid surprises for future readers.Also applies to: 63-70, 168-193, 216-217, 232-276
114-127: Checkprepend_stmtinsertion order for the three injected imports.Given how
prepend_stmtworks, calling it in this order:
- runtime named import (
__dynamicImport),- lazy runtime import via
create_import_decl("{runtimePkg}/experimental/lazy/import"),- data‑URL import that assigns
lynx.loadLazyBundle,likely results in the final module order being:
- data‑URL import,
- lazy/import side‑effect import,
- runtime named import.
If any of these need to run in a specific order (e.g.,
lazy/importexpectinglynx.loadLazyBundleto be assigned only after its own side‑effects), it may be safer to assert/adjust the order explicitly (or add a brief comment documenting that this order is intentional and tested across bundlers).Also applies to: 263-275
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (22)
.changeset/four-rice-guess.md(1 hunks)examples/react-lazy-bundle/lynx.config.js(1 hunks)examples/react-lazy-bundle/package.json(1 hunks)examples/react-lazy-bundle/src/App.css(1 hunks)examples/react-lazy-bundle/src/App.tsx(1 hunks)examples/react-lazy-bundle/src/index.tsx(1 hunks)examples/react-lazy-bundle/src/rspeedy-env.d.ts(1 hunks)examples/react-lazy-bundle/src/utils/add.ts(1 hunks)examples/react-lazy-bundle/src/utils/dynamic.ts(1 hunks)examples/react-lazy-bundle/src/utils/minus.ts(1 hunks)examples/react-lazy-bundle/tsconfig.json(1 hunks)packages/react/runtime/src/index.ts(1 hunks)packages/react/runtime/vitest.config.ts(1 hunks)packages/react/transform/__test__/fixture.spec.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs(6 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_not_import_lazy.js(0 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx(1 hunks)
💤 Files with no reviewable changes (1)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_not_import_lazy.js
✅ Files skipped from review due to trivial changes (1)
- examples/react-lazy-bundle/src/rspeedy-env.d.ts
🚧 Files skipped from review as they are similar to previous changes (13)
- examples/react-lazy-bundle/src/index.tsx
- examples/react-lazy-bundle/src/App.tsx
- packages/react/runtime/vitest.config.ts
- examples/react-lazy-bundle/src/App.css
- examples/react-lazy-bundle/src/utils/minus.ts
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_import_lazy_bundle.js
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_transform_import_call.js
- examples/react-lazy-bundle/tsconfig.json
- packages/react/transform/test/fixture.spec.js
- examples/react-lazy-bundle/src/utils/add.ts
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_import_lazy_import.js
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
For contributions, generate and commit a Changeset describing your changes
Files:
.changeset/four-rice-guess.md
🧠 Learnings (25)
📓 Common learnings
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.
Applied to files:
.changeset/four-rice-guess.mdexamples/react-lazy-bundle/package.jsonexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Applied to files:
.changeset/four-rice-guess.mdpackages/react/runtime/src/index.tsexamples/react-lazy-bundle/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/lib.rsexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
.changeset/four-rice-guess.mdexamples/react-lazy-bundle/package.jsonexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-08-27T12:42:01.095Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Applied to files:
.changeset/four-rice-guess.mdpackages/react/runtime/src/index.tsexamples/react-lazy-bundle/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/lib.rsexamples/react-lazy-bundle/lynx.config.jsexamples/react-lazy-bundle/src/utils/dynamic.ts
📚 Learning: 2025-08-13T11:46:43.737Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Applied to files:
.changeset/four-rice-guess.mdpackages/react/runtime/src/index.tsexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
.changeset/four-rice-guess.mdpackages/react/runtime/src/index.tsexamples/react-lazy-bundle/package.jsonexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-08-11T05:59:28.530Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.
Applied to files:
.changeset/four-rice-guess.mdpackages/react/runtime/src/index.tsexamples/react-lazy-bundle/package.json
📚 Learning: 2025-09-25T14:03:25.576Z
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-18T04:27:18.291Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1238
File: packages/react/runtime/src/debug/component-stack.ts:70-90
Timestamp: 2025-07-18T04:27:18.291Z
Learning: The component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork from https://github.com/preactjs/preact/blob/main/debug/src/component-stack.js. The team prefers to keep it aligned with the upstream Preact version and may contribute improvements back to Preact in the future.
Applied to files:
packages/react/runtime/src/index.ts
📚 Learning: 2025-11-04T10:15:14.965Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
Applied to files:
packages/react/runtime/src/index.ts
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
packages/react/runtime/src/index.tsexamples/react-lazy-bundle/package.json
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Applied to files:
packages/react/runtime/src/index.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rsexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-08-13T09:20:00.936Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1502
File: packages/react/testing-library/types/entry.d.ts:71-71
Timestamp: 2025-08-13T09:20:00.936Z
Learning: In lynx-js/react testing library, wrapper components must have children as a required prop because they are always called with `h(WrapperComponent, null, innerElement)` where innerElement is passed as children. The type `React.JSXElementConstructor<{ children: React.ReactNode }>` correctly requires children to be mandatory.
Applied to files:
packages/react/runtime/src/index.ts
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
examples/react-lazy-bundle/package.jsonexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-11-06T01:19:23.670Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.
Applied to files:
examples/react-lazy-bundle/package.json
📚 Learning: 2025-08-27T08:10:09.932Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.
Applied to files:
examples/react-lazy-bundle/package.jsonexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.
Applied to files:
examples/react-lazy-bundle/package.jsonexamples/react-lazy-bundle/lynx.config.js
📚 Learning: 2025-11-05T03:26:52.546Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-09-10T11:42:36.855Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1714
File: packages/react/transform/Cargo.toml:19-19
Timestamp: 2025-09-10T11:42:36.855Z
Learning: In packages/react/transform/Cargo.toml, the crate uses serde derive macros (#[derive(Serialize, Deserialize)]) in multiple files including src/esbuild.rs and src/swc_plugin_extract_str/mod.rs, so the "derive" feature is required when migrating to workspace dependencies.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-10-29T10:28:27.519Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
🧬 Code graph analysis (3)
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (1)
new(67-71)packages/react/transform/swc-plugin-reactlynx/index.d.ts (1)
DynamicImportVisitorConfig(166-171)
examples/react-lazy-bundle/lynx.config.js (1)
packages/rspeedy/plugin-qrcode/src/index.ts (1)
pluginQRCode(91-155)
examples/react-lazy-bundle/src/utils/dynamic.ts (1)
examples/react-lazy-bundle/src/utils/add.ts (1)
add(1-3)
🪛 LanguageTool
.changeset/four-rice-guess.md
[grammar] ~5-~5: Use a hyphen to join words.
Context: --- "@lynx-js/react": patch --- Auto define lynx.loadLazyBundle when using `i...
(QB_NEW_EN_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build / Build (Ubuntu)
- GitHub Check: build / Build (Windows)
- GitHub Check: test-rust / clippy
- GitHub Check: test-rust / Test (Ubuntu)
🔇 Additional comments (4)
packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js (1)
1-3: foo2 test helper looks fine.Simple named export returning a constant is clear and matches typical test fixture patterns; no issues.
examples/react-lazy-bundle/package.json (1)
1-22: Example package.json looks consistent.Workspace wiring, scripts (
rspeedy build/dev,vitest --typecheck.only), and dependencies/devDependencies all look reasonable for an internal example package.packages/react/runtime/src/index.ts (1)
5-21: Importinglazydirectly frompreact/compatis appropriate.Pulling
lazyfrompreact/compatand re‑exporting it (both via the default export object and named exports) keeps the public API intact while removing the custom wrapper; this aligns with offloadinglynx.loadLazyBundlewiring to the transform/runtime side.packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (1)
334-382: New tests nicely cover the lazy-import and lazy-bundle cases.The added tests (
should_import_lazy_import,should_import_lazy_bundle,should_not_import_lazy) exercise:
- external URL +
{ with: { type: "component" } },- plain relative import,
- template literal import ignored by the transform,
which gives good regression coverage for both the new injection paths and the “no-op” case.
HuJean
force-pushed
the
p/hujing/lazy-bundle
branch
from
8c5b505 to
5cb8f8c
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
.changeset/four-rice-guess.md (1)
1-5: Minor wording: hyphenate “Auto‑define”Consider changing the description to:
Auto-define lynx.loadLazyBundle when using `import(/* relative path */)`.to match standard compound‑verb hyphenation.
🧹 Nitpick comments (1)
examples/react-lazy-bundle/src/utils/dynamic.ts (1)
1-4: Consider adding explicit return type annotation.The function correctly demonstrates lazy loading via dynamic import with a relative path, which aligns with the PR's objective to auto-define
lynx.loadLazyBundle. The implementation is clean and correct.For improved clarity in example code, consider adding an explicit return type annotation:
-export async function dynamicAdd(a: number, b: number) { +export async function dynamicAdd(a: number, b: number): Promise<number> { const { add } = await import('./add.js'); return add(a, b); }
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (23)
.changeset/four-rice-guess.md(1 hunks)examples/react-lazy-bundle/lynx.config.js(1 hunks)examples/react-lazy-bundle/package.json(1 hunks)examples/react-lazy-bundle/src/App.css(1 hunks)examples/react-lazy-bundle/src/App.tsx(1 hunks)examples/react-lazy-bundle/src/index.tsx(1 hunks)examples/react-lazy-bundle/src/rspeedy-env.d.ts(1 hunks)examples/react-lazy-bundle/src/utils/add.ts(1 hunks)examples/react-lazy-bundle/src/utils/dynamic.ts(1 hunks)examples/react-lazy-bundle/src/utils/minus.ts(1 hunks)examples/react-lazy-bundle/tsconfig.json(1 hunks)packages/react/runtime/src/index.ts(1 hunks)packages/react/runtime/vitest.config.ts(1 hunks)packages/react/testing-library/src/vitest.config.js(1 hunks)packages/react/transform/__test__/fixture.spec.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs(6 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_not_import_lazy.js(0 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_transform_import_call.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx(1 hunks)
💤 Files with no reviewable changes (1)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_not_import_lazy.js
🚧 Files skipped from review as they are similar to previous changes (13)
- examples/react-lazy-bundle/src/App.tsx
- examples/react-lazy-bundle/src/utils/add.ts
- examples/react-lazy-bundle/src/index.tsx
- examples/react-lazy-bundle/lynx.config.js
- packages/react/runtime/vitest.config.ts
- packages/react/runtime/src/index.ts
- examples/react-lazy-bundle/src/utils/minus.ts
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_transform_import_call.js
- packages/react/transform/test/fixture.spec.js
- examples/react-lazy-bundle/src/rspeedy-env.d.ts
- examples/react-lazy-bundle/tsconfig.json
- examples/react-lazy-bundle/src/App.css
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
For contributions, generate and commit a Changeset describing your changes
Files:
.changeset/four-rice-guess.md
🧠 Learnings (26)
📓 Common learnings
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Learnt from: Sherry-hue
Repo: lynx-family/lynx-stack PR: 1770
File: packages/web-platform/web-mainthread-apis/src/utils/processStyleInfo.ts:316-318
Timestamp: 2025-09-18T08:12:56.802Z
Learning: In packages/web-platform/web-mainthread-apis/src/utils/processStyleInfo.ts, the current implementation uses cardStyleElement.textContent += for lazy component styles. While this could theoretically invalidate rule indices by reparsing the stylesheet, Sherry-hue indicated that UIDs don't repeat for the same element, making this approach acceptable for now. A future optimization to use separate style elements per entry was discussed but deferred to a separate PR to keep the current lazy bundle PR focused.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1238
File: packages/react/runtime/src/debug/component-stack.ts:70-90
Timestamp: 2025-07-18T04:27:18.291Z
Learning: The component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork from https://github.com/preactjs/preact/blob/main/debug/src/component-stack.js. The team prefers to keep it aligned with the upstream Preact version and may contribute improvements back to Preact in the future.
📚 Learning: 2025-08-27T12:42:01.095Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/package.jsonpackages/react/testing-library/src/vitest.config.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxexamples/react-lazy-bundle/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/package.jsonpackages/react/testing-library/src/vitest.config.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js
📚 Learning: 2025-08-11T05:59:28.530Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/package.jsonpackages/react/testing-library/src/vitest.config.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-11T05:57:18.212Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/testing-library/testing-environment/src/index.ts:255-258
Timestamp: 2025-08-11T05:57:18.212Z
Learning: In the ReactLynx testing environment (`packages/testing-library/testing-environment/src/index.ts`), the dual assignment pattern `target.console.method = console.method = () => {}` is required for rstest compatibility. This is because rstest provides `console` in an IIFE (Immediately Invoked Function Expression), and both the target and global console need to have these methods defined for proper test execution.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/testing-library/src/vitest.config.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js
📚 Learning: 2025-09-25T14:03:25.576Z
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js.changeset/four-rice-guess.md
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/package.jsonpackages/react/testing-library/src/vitest.config.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-11T06:00:04.376Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:59-61
Timestamp: 2025-08-11T06:00:04.376Z
Learning: In the lynx-family/lynx-stack repository, the `testingLibraryPlugin` in `packages/react/testing-library/src/plugins/vitest.ts` intentionally uses `process.exit` when jsdom installation fails, maintaining consistency with the previous implementation from `packages/react/testing-library/src/vitest.config.js`. This behavior should not be changed to use `this.error` despite being a Vite plugin best practice.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/testing-library/src/vitest.config.js
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxexamples/react-lazy-bundle/package.jsonpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js.changeset/four-rice-guess.md
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx.changeset/four-rice-guess.md
📚 Learning: 2025-08-13T11:46:43.737Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js.changeset/four-rice-guess.md
📚 Learning: 2025-11-05T03:26:52.546Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/testing-library/src/vitest.config.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js
📚 Learning: 2025-09-10T11:42:36.855Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1714
File: packages/react/transform/Cargo.toml:19-19
Timestamp: 2025-09-10T11:42:36.855Z
Learning: In packages/react/transform/Cargo.toml, the crate uses serde derive macros (#[derive(Serialize, Deserialize)]) in multiple files including src/esbuild.rs and src/swc_plugin_extract_str/mod.rs, so the "derive" feature is required when migrating to workspace dependencies.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-10-29T10:28:27.519Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsxpackages/react/testing-library/src/vitest.config.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.jspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
examples/react-lazy-bundle/package.json.changeset/four-rice-guess.md
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.
Applied to files:
examples/react-lazy-bundle/package.json.changeset/four-rice-guess.md
📚 Learning: 2025-08-27T08:10:09.932Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.
Applied to files:
examples/react-lazy-bundle/package.json
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
examples/react-lazy-bundle/package.jsonpackages/react/testing-library/src/vitest.config.js
📚 Learning: 2025-11-06T01:19:23.670Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.
Applied to files:
examples/react-lazy-bundle/package.json
📚 Learning: 2025-09-23T08:54:39.966Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1670
File: packages/webpack/css-extract-webpack-plugin/test/hotCases/hot/hot-update-json/dual-thread/__snapshot__/index.css:6-8
Timestamp: 2025-09-23T08:54:39.966Z
Learning: In the lynx-stack CSS extract webpack plugin tests, many test fixture CSS files intentionally use invalid CSS syntax like `color: 'red';` with quoted values. The snapshots correctly reflect this invalid CSS from the source fixtures. To fix CSS validation issues, the source fixture files should be updated first, then snapshots regenerated, rather than manually editing snapshots.
Applied to files:
packages/react/testing-library/src/vitest.config.js
📚 Learning: 2025-11-04T10:15:14.965Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.changeset/four-rice-guess.md
🧬 Code graph analysis (2)
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (1)
new(67-71)packages/react/transform/swc-plugin-reactlynx/index.d.ts (1)
DynamicImportVisitorConfig(166-171)
examples/react-lazy-bundle/src/utils/dynamic.ts (1)
examples/react-lazy-bundle/src/utils/add.ts (1)
add(1-3)
🪛 LanguageTool
.changeset/four-rice-guess.md
[grammar] ~5-~5: Use a hyphen to join words.
Context: --- "@lynx-js/react": patch --- Auto define lynx.loadLazyBundle when using `i...
(QB_NEW_EN_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build / Build (Windows)
- GitHub Check: build / Build (Ubuntu)
- GitHub Check: test-rust / Test (Ubuntu)
🔇 Additional comments (10)
examples/react-lazy-bundle/package.json (1)
1-21: ✓ Package metadata and configuration look good.The package.json is well-structured for the new lazy-bundle example:
- Name, scoping, and privacy settings follow monorepo conventions
- Build tooling (rspeedy, plugins) is consistent with other React examples
- Dependencies are minimal and focused: only
@lynx-js/reactwith workspace reference- DevDependencies are appropriate for a Lynx/React example project
Note: The package correctly avoids explicitly depending on lazy-bundle runtime, which aligns with the PR objective of auto-defining
lynx.loadLazyBundlevia the SWC transform.Please verify that the example source code (under
examples/react-lazy-bundle/src) correctly demonstrates dynamic imports with relative paths (e.g.,import("./Component")) and that these imports resolve correctly after the SWC transform is applied.packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (4)
40-48: Internal flag wiring for lazy bundle import looks sound
has_inner_lazy_bundleis correctly introduced and initialized, and the struct’s default still flows throughDynamicImportVisitor::new, so there’s no risk of an uninitialized or stale flag between runs. This keeps the new behavior fully internal to the visitor.Also applies to: 59-70
114-127: Helpercreate_import_declkeeps import construction consistentExtracting the side‑effect import creation into
create_import_declavoids duplicating theImportDeclboilerplate and ensures both theexperimental/lazy/importand data‑URL imports share identical flags (ImportPhase::Evaluation,type_only,with). No issues here.
185-217: Lazy‑bundle auto‑definition behavior matches the issue goalsFor non‑external string‑literal
import()calls (e.g.import('./index.js')), you:
- Reject invalid option objects as before.
- Attach the
webpackChunkNamecomment.- Set
has_inner_lazy_bundle = true, which later prepends the data‑URL import that defineslynx.loadLazyBundle.External URLs (
https://,http://,//) continue to go through__dynamicImportplusexperimental/lazy/importwithout triggering the inner lazy‑bundle import, which keeps the “relative / non‑external” case special as described in the issue.Combined modules that mix local and external dynamic imports will get both imports (lazy/import + data‑URL) once, which is acceptable.
Looks correct and well‑scoped.
Also applies to: 270-275
321-382: New dynamic‑import tests cover key branchesThe added tests exercise:
- External URL with
{ with: { type: "component" } }→should_import_lazy_import.- Relative path string literal →
should_import_lazy_bundle.- Template literal context import →
should_not_import_lazy.That gives good coverage of the new behavior and the intentional “ignore template imports” path. No additional cases seem strictly necessary for this PR.
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx (1)
22-29: Good assertion to lock in lazy runtime availabilityThe extra
expect(lynx.loadLazyBundle).not.toBeUndefined();after the dynamic import (with errors swallowed) is a solid regression test that the lazy runtime is wired even when the external URL fails to load.packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js (1)
1-9: Snapshot matches new dynamic‑import transformThis snapshot correctly reflects the transform: side‑effect import of
@lynx-js/react/experimental/lazy/importplus a named import of__dynamicImportfrom the internal runtime, then delegating theimport("https://…", { with: { type: "component" } })call to__dynamicImport. No manual edits needed; future changes should continue to flow from the transform logic.packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js (1)
1-4: Snapshot correctly captures inner lazy‑bundle wiringThe generated code—data‑URL import that assigns
lynx.loadLazyBundle, followed by the annotatedimport("./index.js")—is exactly what the newhas_inner_lazy_bundlepath is supposed to emit. This looks consistent with the transform; no further changes needed.packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx (1)
2-7: Updated test appropriately targets relative dynamic importsSwitching to an async test that
await import('./foo.js')andawait import('./foo2.js')before assertinglynx.loadLazyBundleis defined directly validates the new behavior for local code‑split bundles. This is a clear regression test for the original bug.packages/react/testing-library/src/vitest.config.js (1)
224-250: This setting is intentional and correct.dynamicImport: falsedisables the dynamic‑import transform in the test environment, which is appropriate since tests should not apply transforms that require special runtime support. This is consistent with the internal runtime test config and maintains a clear separation between test (transform disabled) and production (transform enabled) behavior.
HuJean
force-pushed
the
p/hujing/lazy-bundle
branch
from
5cb8f8c to
3afd3e9
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
.changeset/four-rice-guess.md (1)
5-5: Hyphenate “Auto define” in the changeset summary.Use the compound modifier form for clarity and consistency with prior feedback.
-Auto define lynx.loadLazyBundle when using `import(/* relative path */)`. +Auto-define lynx.loadLazyBundle when using `import(/* relative path */)`.
🧹 Nitpick comments (1)
examples/react-lazy-bundle/src/App.tsx (1)
11-15: Consider renaming the innerresparameter for clarityIn the nested
res.dynamicAdd(1, 2).then(res => { ... }), the innerresshadows the outer module namespace, which can be mildly confusing when reading. Renaming the inner one (e.g. tovalueorresult) would improve readability without behavior changes.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (27)
.changeset/four-rice-guess.md(1 hunks)examples/react-lazy-bundle/lynx.config.js(1 hunks)examples/react-lazy-bundle/package.json(1 hunks)examples/react-lazy-bundle/src/App.css(1 hunks)examples/react-lazy-bundle/src/App.tsx(1 hunks)examples/react-lazy-bundle/src/index.tsx(1 hunks)examples/react-lazy-bundle/src/rspeedy-env.d.ts(1 hunks)examples/react-lazy-bundle/src/utils/add.ts(1 hunks)examples/react-lazy-bundle/src/utils/dynamic.ts(1 hunks)examples/react-lazy-bundle/src/utils/minus.ts(1 hunks)examples/react-lazy-bundle/tsconfig.json(1 hunks)packages/react/runtime/src/index.ts(1 hunks)packages/react/runtime/vitest.config.ts(1 hunks)packages/react/testing-library/src/vitest.config.js(1 hunks)packages/react/transform/__test__/fixture.spec.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs(8 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs(3 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_not_import_lazy.js(0 hunks)packages/react/transform/index.d.ts(1 hunks)packages/react/transform/swc-plugin-reactlynx/index.d.ts(1 hunks)packages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/rspack.txt(1 hunks)packages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/webpack.txt(4 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx(1 hunks)
💤 Files with no reviewable changes (1)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_not_import_lazy.js
✅ Files skipped from review due to trivial changes (1)
- packages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/rspack.txt
🚧 Files skipped from review as they are similar to previous changes (12)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_import_lazy_import.js
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js
- examples/react-lazy-bundle/package.json
- examples/react-lazy-bundle/src/rspeedy-env.d.ts
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx
- examples/react-lazy-bundle/lynx.config.js
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_import_lazy_bundle.js
- packages/react/transform/test/fixture.spec.js
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
- examples/react-lazy-bundle/src/utils/dynamic.ts
- examples/react-lazy-bundle/tsconfig.json
- examples/react-lazy-bundle/src/index.tsx
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
For contributions, generate and commit a Changeset describing your changes
Files:
.changeset/four-rice-guess.md
🧠 Learnings (29)
📓 Common learnings
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
examples/react-lazy-bundle/src/App.tsx.changeset/four-rice-guess.mdpackages/react/runtime/src/index.ts
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Applied to files:
examples/react-lazy-bundle/src/App.tsxpackages/react/runtime/vitest.config.tspackages/react/transform/swc-plugin-reactlynx/index.d.ts.changeset/four-rice-guess.mdpackages/react/runtime/src/index.tspackages/react/testing-library/src/vitest.config.js
📚 Learning: 2025-08-27T12:42:01.095Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Applied to files:
examples/react-lazy-bundle/src/App.tsxpackages/react/runtime/vitest.config.tspackages/react/transform/swc-plugin-reactlynx/index.d.ts.changeset/four-rice-guess.mdpackages/react/runtime/src/index.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/testing-library/src/vitest.config.js
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/react/runtime/vitest.config.tspackages/react/testing-library/src/vitest.config.js
📚 Learning: 2025-08-11T05:59:28.530Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.
Applied to files:
packages/react/runtime/vitest.config.ts.changeset/four-rice-guess.mdpackages/react/runtime/src/index.tspackages/react/testing-library/src/vitest.config.js
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
packages/react/runtime/vitest.config.tspackages/react/testing-library/src/vitest.config.js
📚 Learning: 2025-08-11T06:00:04.376Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:59-61
Timestamp: 2025-08-11T06:00:04.376Z
Learning: In the lynx-family/lynx-stack repository, the `testingLibraryPlugin` in `packages/react/testing-library/src/plugins/vitest.ts` intentionally uses `process.exit` when jsdom installation fails, maintaining consistency with the previous implementation from `packages/react/testing-library/src/vitest.config.js`. This behavior should not be changed to use `this.error` despite being a Vite plugin best practice.
Applied to files:
packages/react/runtime/vitest.config.tspackages/react/testing-library/src/vitest.config.js
📚 Learning: 2025-10-29T10:28:27.519Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Applied to files:
packages/react/runtime/vitest.config.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/testing-library/src/vitest.config.jspackages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/webpack.txt
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Applied to files:
packages/react/transform/swc-plugin-reactlynx/index.d.tspackages/react/runtime/src/index.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/testing-library/src/vitest.config.js
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Applied to files:
packages/react/transform/swc-plugin-reactlynx/index.d.tspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/napi.rs
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
.changeset/four-rice-guess.mdpackages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/webpack.txt
📚 Learning: 2025-09-29T06:43:40.182Z
Learnt from: CR
Repo: lynx-family/lynx-stack PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-09-29T06:43:40.182Z
Learning: Applies to .changeset/*.md : For contributions, generate and commit a Changeset describing your changes
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-08-13T11:46:43.737Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Applied to files:
.changeset/four-rice-guess.mdpackages/react/runtime/src/index.ts
📚 Learning: 2025-09-25T14:03:25.576Z
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-18T04:27:18.291Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1238
File: packages/react/runtime/src/debug/component-stack.ts:70-90
Timestamp: 2025-07-18T04:27:18.291Z
Learning: The component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork from https://github.com/preactjs/preact/blob/main/debug/src/component-stack.js. The team prefers to keep it aligned with the upstream Preact version and may contribute improvements back to Preact in the future.
Applied to files:
packages/react/runtime/src/index.ts
📚 Learning: 2025-11-04T10:15:14.965Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
Applied to files:
packages/react/runtime/src/index.tspackages/react/testing-library/src/vitest.config.jspackages/react/transform/index.d.ts
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
packages/react/runtime/src/index.ts
📚 Learning: 2025-08-13T09:20:00.936Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1502
File: packages/react/testing-library/types/entry.d.ts:71-71
Timestamp: 2025-08-13T09:20:00.936Z
Learning: In lynx-js/react testing library, wrapper components must have children as a required prop because they are always called with `h(WrapperComponent, null, innerElement)` where innerElement is passed as children. The type `React.JSXElementConstructor<{ children: React.ReactNode }>` correctly requires children to be mandatory.
Applied to files:
packages/react/runtime/src/index.ts
📚 Learning: 2025-11-05T03:26:52.546Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/napi.rs
📚 Learning: 2025-09-10T11:42:36.855Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1714
File: packages/react/transform/Cargo.toml:19-19
Timestamp: 2025-09-10T11:42:36.855Z
Learning: In packages/react/transform/Cargo.toml, the crate uses serde derive macros (#[derive(Serialize, Deserialize)]) in multiple files including src/esbuild.rs and src/swc_plugin_extract_str/mod.rs, so the "derive" feature is required when migrating to workspace dependencies.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/napi.rs
📚 Learning: 2025-08-11T05:57:18.212Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/testing-library/testing-environment/src/index.ts:255-258
Timestamp: 2025-08-11T05:57:18.212Z
Learning: In the ReactLynx testing environment (`packages/testing-library/testing-environment/src/index.ts`), the dual assignment pattern `target.console.method = console.method = () => {}` is required for rstest compatibility. This is because rstest provides `console` in an IIFE (Immediately Invoked Function Expression), and both the target and global console need to have these methods defined for proper test execution.
Applied to files:
packages/react/testing-library/src/vitest.config.js
📚 Learning: 2025-09-18T08:12:56.802Z
Learnt from: Sherry-hue
Repo: lynx-family/lynx-stack PR: 1770
File: packages/web-platform/web-mainthread-apis/src/utils/processStyleInfo.ts:316-318
Timestamp: 2025-09-18T08:12:56.802Z
Learning: In packages/web-platform/web-mainthread-apis/src/utils/processStyleInfo.ts, the current implementation uses cardStyleElement.textContent += for lazy component styles. While this could theoretically invalidate rule indices by reparsing the stylesheet, Sherry-hue indicated that UIDs don't repeat for the same element, making this approach acceptable for now. A future optimization to use separate style elements per entry was discussed but deferred to a separate PR to keep the current lazy bundle PR focused.
Applied to files:
examples/react-lazy-bundle/src/App.css
📚 Learning: 2025-09-23T08:54:39.966Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1670
File: packages/webpack/css-extract-webpack-plugin/test/hotCases/hot/hot-update-json/dual-thread/__snapshot__/index.css:6-8
Timestamp: 2025-09-23T08:54:39.966Z
Learning: In the lynx-stack CSS extract webpack plugin tests, many test fixture CSS files intentionally use invalid CSS syntax like `color: 'red';` with quoted values. The snapshots correctly reflect this invalid CSS from the source fixtures. To fix CSS validation issues, the source fixture files should be updated first, then snapshots regenerated, rather than manually editing snapshots.
Applied to files:
packages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/webpack.txt
📚 Learning: 2025-09-23T08:53:56.927Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1670
File: packages/webpack/css-extract-webpack-plugin/src/loader.ts:244-251
Timestamp: 2025-09-23T08:53:56.927Z
Learning: In webpack CSS extraction plugins, when storing per-module dependencies in a compiler-scoped map like cssModuleId2Deps, the map should not be reset at compilation start because in incremental compilation (watch mode/HMR), only changed files pass through the loader. Unchanged modules need their dependency information to persist between compilations so the plugin can access all modules' dependencies when generating CSS output.
Applied to files:
packages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/webpack.txt
🧬 Code graph analysis (4)
examples/react-lazy-bundle/src/App.tsx (1)
packages/react/transform/src/wasm.js (1)
view(24-28)
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
packages/react/transform/index.d.ts (1)
DynamicImportVisitorConfig(422-429)packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (2)
default(23-29)default(63-65)
packages/react/testing-library/src/vitest.config.js (1)
packages/react/testing-library/loaders/jsx-loader.js (1)
runtimePkgName(9-9)
packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (3)
packages/react/transform/index.d.ts (1)
DynamicImportVisitorConfig(422-429)packages/react/transform/swc-plugin-reactlynx/index.d.ts (1)
DynamicImportVisitorConfig(166-173)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
default(34-40)default(57-59)
🪛 LanguageTool
.changeset/four-rice-guess.md
[grammar] ~5-~5: Use a hyphen to join words.
Context: --- "@lynx-js/react": patch --- Auto define lynx.loadLazyBundle when using `i...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (12)
packages/webpack/css-extract-webpack-plugin/test/diagnostic/error/sass/expected/webpack.txt (1)
8-8: Verify that manual edits to expected output files are appropriate.This file appears to be an expected test output used for diagnostic comparison. According to learnings from prior reviews, similar auto-generated test outputs should not be manually edited; instead, the source fixtures should be updated and outputs regenerated.
Additionally, the connection between these path changes (absolute
<ROOT>→ relative../../../../../../../) and the PR objective (auto-definelynx.loadLazyBundlefor dynamic imports) is unclear. This file is for CSS extraction plugin diagnostics, not dynamic import handling.Please clarify:
- Is this an auto-generated expected output file, or is it manually maintained?
- What is the relationship between these path changes and the lazy bundle feature described in the PR objectives?
- If manually maintained, what prompted the change from absolute to relative paths?
Also applies to: 18-18, 36-36, 49-49
examples/react-lazy-bundle/src/utils/minus.ts (1)
1-3: LGTM!The utility function is correct and appropriate for demonstrating lazy bundle loading with dynamic imports.
examples/react-lazy-bundle/src/utils/add.ts (1)
1-3: Utility function implementation looks correctTyped signature and implementation are straightforward and correct for the intended demo usage.
examples/react-lazy-bundle/src/App.tsx (1)
5-17: Dynamic import usage aligns with lazy-bundle objectivesThe useEffect hook’s fire-and-forget dynamic imports with relative
.jspaths (for./utils/add.jsand./utils/dynamic.js) cleanly exercise the lazy-bundle transform without extra runtime wiring, which fits the repo’s preference for minimal runtime checks in demo code. Based on learnings, this style is consistent with the stack’s compile-time–first approach.examples/react-lazy-bundle/src/App.css (1)
1-34: Styles match component structure and are consistentCSS classes and the global
textrule line up with the JSX structure inApp.tsx; looks good for the example use case.packages/react/runtime/vitest.config.ts (1)
27-48: Disabling dynamic-import transform for runtime tests looks appropriate.Setting
dynamicImport: falsehere keeps the runtime Vitest setup free from dynamic-import side effects while the transform itself is covered in its own test suite.packages/react/runtime/src/index.ts (1)
7-84: Usingpreact/compat’slazydirectly is consistent and safe.Importing
lazyfrompreact/compatand exposing it via both default and named exports keeps the runtime surface aligned with Preact, while lazy-bundle wiring is now handled by the dynamic-import transform.packages/react/transform/index.d.ts (1)
422-429:injectLazyBundleflag is correctly surfaced in the public TS config.The optional
injectLazyBundle?: booleanonDynamicImportVisitorConfigmatches the Rustinject_lazy_bundle: Option<bool>and preserves default-on behavior (None treated as enabled), which is what you want for existing callers.Please double-check other call sites of
dynamicImportin this repo to ensure any explicit config objects that should disable auto lazy-bundle injection now setinjectLazyBundle: falseexplicitly.packages/react/transform/swc-plugin-reactlynx/index.d.ts (1)
166-173: Dynamic-import typings stay consistent across transform entry points.Adding
injectLazyBundle?: booleanhere keeps the SWC plugin typings in sync withpackages/react/transform/index.d.tsand the Rust config, so consumers of this d.ts see the same internal flag shape everywhere.If any tooling generates these d.ts files, please ensure the generator is also updated so
injectLazyBundledoesn’t get dropped on the next regen.packages/react/testing-library/src/vitest.config.js (1)
224-254: ExplicitdynamicImportconfig for testing-library is coherent.Routing dynamic-import through the transform with
dynamicImport: { injectLazyBundle: false, layer: 'test', runtimePkg: `${runtimePkgName}/internal`, }keeps
__dynamicImportwired to the correct runtime while intentionally disabling the autolynx.loadLazyBundledata-URI import in this Vitest environment, which makes sense for a generic testing helper.packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (1)
13-50: NAPI config cleanly propagates the newinject_lazy_bundleflag.The added
inject_lazy_bundle: Option<bool>field, itsDefaultofSome(true), and the updatedFromconversions keep the NAPI-facing config in sync with the core Rust config while preserving default-on behavior for auto lazy-bundle injection.packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (1)
22-41: Dynamic-import visitor correctly wires autolynx.loadLazyBundleinjection with an escape hatch.Implementation details look solid:
Config & state:
DynamicImportVisitorConfiggainsinject_lazy_bundle: Option<bool>with a default ofSome(true).- The visitor tracks
has_inner_lazy_bundleseparately fromnamed_imports, which lets you distinguish “inner lazy bundle present” (string-literal, non-URL import) from “needs runtime__dynamicImporthelper.”Call-site handling:
- For
import("./foo")(string literal, non-explicitly-external), you:
- validate the options object shape if present,
- inject the
webpackChunkNamecomment,- set
self.has_inner_lazy_bundle = truewithout rewriting the call, letting the bundler handle chunking.- For other imports (URLs, expressions, etc.), you still rewrite to
__dynamicImportand populatenamed_importsas before.Module-level imports:
- When
named_importsis non-empty, you prepend:
import { __dynamicImport } from runtime_pkg;import "<runtime_pkg>/experimental/lazy/import"(with/internalstripped), ensuring the lazy runtime is present whenever__dynamicImportis used.- Independently, when
inject_lazy_bundleis enabled (Some(true)orNone) andhas_inner_lazy_bundleis true, you prepend the data-URI import that pullsloadLazyBundlefrom@lynx-js/react/internaland assignslynx.loadLazyBundle. This directly addresses the “lynx.loadLazyBundleis not a function” bug for relative-path dynamic imports.Defaults & tests:
- Treating
Noneas enabled in thematchoninject_lazy_bundleensures older configs automatically gain the fix.- The updated and added tests (
should_transform_import_call,should_import_lazy_import,should_import_lazy_bundle,should_not_import_lazy) cover both the “off” switch and the new injection behaviors.Overall, the logic matches the PR objectives and remains backward-compatible, with
inject_lazy_bundleproviding a clear opt-out when needed.Also applies to: 43-72, 117-131, 188-283, 297-391
HuJean
force-pushed
the
p/hujing/lazy-bundle
branch
from
3afd3e9 to
c37c6fb
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx (1)
24-24: Use a relative path import to test the lazy loading feature consistently.This test should use a relative path import (e.g.,
import('./module.js')) instead of the absolute URLimport('https://www/a.js')to align with the PR objectives for detecting and injecting lazy runtime for relative path dynamic imports. Theload-lazy-bundletest case already properly validates this behavior with relative paths likeimport('./foo.js').
♻️ Duplicate comments (1)
.changeset/four-rice-guess.md (1)
5-5: Hyphenate compound modifier: use "Auto-define" instead of "Auto define".The compound verb phrase should be hyphenated for correct grammar.
Apply this diff:
-Auto define lynx.loadLazyBundle when using `import(/* relative path */)`. +Auto-define lynx.loadLazyBundle when using `import(/* relative path */)`.Based on coding guidelines and static analysis hints.
🧹 Nitpick comments (3)
examples/react-lazy-bundle/src/index.tsx (1)
7-9: Good demonstration of the dynamic import feature, but consider adding error handling.This dynamic import correctly demonstrates the PR's core feature—automatic injection of
lynx.loadLazyBundlefor relative path imports. The top-level execution is appropriate for an example.However, since this is an example that developers may reference, consider adding error handling to demonstrate best practices:
-void import('./utils/minus.js').then((res) => { - console.info('dynamic import minus', res.minus(1, 2)); -}); +void import('./utils/minus.js') + .then((res) => { + console.info('dynamic import minus', res.minus(1, 2)); + }) + .catch((err) => { + console.error('Failed to load minus module:', err); + });packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (2)
268-271: Consider more robust path manipulation.The
.replace("/internal", "")assumes runtime_pkg ends with "/internal". While this works with the current default, a more robust approach would verify the assumption or use a configurable base path.Consider this safer alternative:
let base_pkg = self.opts.runtime_pkg .strip_suffix("/internal") .unwrap_or(&self.opts.runtime_pkg); create_import_decl(&format!("{}/experimental/lazy/import", base_pkg))
273-277: Simplify boolean pattern matching.The match expression for inject_lazy_bundle can be simplified using unwrap_or.
Apply this diff:
- if match self.opts.inject_lazy_bundle { - Some(true) => true, - Some(false) => false, - None => true, - } && self.has_inner_lazy_bundle + if self.opts.inject_lazy_bundle.unwrap_or(true) && self.has_inner_lazy_bundle
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (25)
.changeset/four-rice-guess.md(1 hunks)examples/react-lazy-bundle/lynx.config.js(1 hunks)examples/react-lazy-bundle/package.json(1 hunks)examples/react-lazy-bundle/src/App.css(1 hunks)examples/react-lazy-bundle/src/App.tsx(1 hunks)examples/react-lazy-bundle/src/index.tsx(1 hunks)examples/react-lazy-bundle/src/rspeedy-env.d.ts(1 hunks)examples/react-lazy-bundle/src/utils/add.ts(1 hunks)examples/react-lazy-bundle/src/utils/dynamic.ts(1 hunks)examples/react-lazy-bundle/src/utils/minus.ts(1 hunks)examples/react-lazy-bundle/tsconfig.json(1 hunks)packages/react/runtime/src/index.ts(1 hunks)packages/react/runtime/vitest.config.ts(1 hunks)packages/react/testing-library/src/vitest.config.js(1 hunks)packages/react/transform/__test__/fixture.spec.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs(8 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs(3 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_bundle.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js(1 hunks)packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_not_import_lazy.js(0 hunks)packages/react/transform/index.d.ts(1 hunks)packages/react/transform/swc-plugin-reactlynx/index.d.ts(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js(1 hunks)packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx(1 hunks)
💤 Files with no reviewable changes (1)
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_not_import_lazy.js
🚧 Files skipped from review as they are similar to previous changes (16)
- examples/react-lazy-bundle/src/App.tsx
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/foo2.js
- packages/react/runtime/vitest.config.ts
- packages/webpack/react-webpack-plugin/test/cases/code-splitting/load-lazy-bundle/index.jsx
- examples/react-lazy-bundle/src/utils/dynamic.ts
- packages/react/transform/index.d.ts
- examples/react-lazy-bundle/package.json
- examples/react-lazy-bundle/src/utils/add.ts
- examples/react-lazy-bundle/lynx.config.js
- examples/react-lazy-bundle/src/utils/minus.ts
- examples/react-lazy-bundle/src/App.css
- packages/react/runtime/src/index.ts
- packages/react/testing-library/src/vitest.config.js
- packages/react/transform/crates/swc_plugin_dynamic_import/tests/swc_snapshots/lib.rs/should_import_lazy_bundle.js
- packages/react/transform/test/fixture.spec.js
- packages/react/transform/swc-plugin-reactlynx/index.d.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
For contributions, generate and commit a Changeset describing your changes
Files:
.changeset/four-rice-guess.md
🧠 Learnings (29)
📓 Common learnings
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
📚 Learning: 2025-08-27T08:10:09.932Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.tsexamples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.ts.changeset/four-rice-guess.mdexamples/react-lazy-bundle/tsconfig.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.tsexamples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-11-04T10:15:14.965Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/runtime/__test__/snapshotPatch.test.jsx:725-749
Timestamp: 2025-11-04T10:15:14.965Z
Learning: In packages/react/runtime/src/snapshot.ts, the snapshotCreatorMap type signature uses `Record<string, (uniqId: string) => string>` (returning string) rather than void for backward compatibility. Old lazy bundles still use the pattern `const snapshot_xxx = createSnapshot(...)` directly, which requires createSnapshot to return a value. The snapshotCreatorMap creators that wrap createSnapshot calls must maintain the same return type to support these legacy bundles.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.ts
📚 Learning: 2025-08-13T11:46:43.737Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:5-6
Timestamp: 2025-08-13T11:46:43.737Z
Learning: In the lynx-stack codebase, default imports are consistently used for Node.js built-in modules (e.g., `import os from 'node:os'`, `import fs from 'node:fs'`). The TypeScript configuration supports esModuleInterop and allowSyntheticDefaultImports, making default imports the preferred pattern over namespace imports for Node.js built-ins.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.ts.changeset/four-rice-guess.mdexamples/react-lazy-bundle/tsconfig.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-08-11T05:57:18.212Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/testing-library/testing-environment/src/index.ts:255-258
Timestamp: 2025-08-11T05:57:18.212Z
Learning: In the ReactLynx testing environment (`packages/testing-library/testing-environment/src/index.ts`), the dual assignment pattern `target.console.method = console.method = () => {}` is required for rstest compatibility. This is because rstest provides `console` in an IIFE (Immediately Invoked Function Expression), and both the target and global console need to have these methods defined for proper test execution.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.tspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-08-27T12:42:01.095Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1616
File: packages/webpack/cache-events-webpack-plugin/test/cases/not-cache-events/lazy-bundle/index.js:3-3
Timestamp: 2025-08-27T12:42:01.095Z
Learning: In webpack, properties like __webpack_require__.lynx_ce are injected during compilation/build time when webpack processes modules and generates bundles, not at runtime when dynamic imports execute. Tests for such properties don't need to wait for dynamic imports to complete.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.ts.changeset/four-rice-guess.mdpackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxexamples/react-lazy-bundle/src/index.tsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-08-21T08:46:54.494Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: packages/webpack/cache-events-webpack-plugin/src/LynxCacheEventsRuntimeModule.ts:23-27
Timestamp: 2025-08-21T08:46:54.494Z
Learning: In Lynx webpack runtime modules, the team prioritizes performance and simplicity over defensive runtime error handling. They prefer relying on compile-time type safety (TypeScript) rather than adding runtime checks like try-catch blocks or type validation, especially for performance-critical code like cache event setup/cleanup functions.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.tspackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-11-03T08:47:17.714Z
Learnt from: Sherry-hue
Repo: lynx-family/lynx-stack PR: 1911
File: packages/web-platform/web-tests/tests/react/basic-element-list-estimated-main-axis-size-px/index.jsx:14-24
Timestamp: 2025-11-03T08:47:17.714Z
Learning: In the autoScroll method for XList components in the lynx-family/lynx-stack repository, the `rate` parameter supports plain strings like `'100'` in addition to numbers and strings with unit suffixes (`${number}px`, `${number}rpx`, `${number}ppx`), even though the TypeScript type definition may appear more restrictive.
Applied to files:
examples/react-lazy-bundle/src/rspeedy-env.d.ts
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
Applied to files:
.changeset/four-rice-guess.mdexamples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
.changeset/four-rice-guess.mdpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-09-29T06:43:40.182Z
Learnt from: CR
Repo: lynx-family/lynx-stack PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-09-29T06:43:40.182Z
Learning: Applies to .changeset/*.md : For contributions, generate and commit a Changeset describing your changes
Applied to files:
.changeset/four-rice-guess.md
📚 Learning: 2025-08-12T16:09:32.413Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1497
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_full_static.js:9-10
Timestamp: 2025-08-12T16:09:32.413Z
Learning: In the Lynx stack, functions prefixed with `__` that are called in transformed code may be injected globally by the Lynx Engine at runtime rather than exported from the React runtime package. For example, `__CreateFrame` is injected globally by the Lynx Engine, not exported from lynx-js/react.
Applied to files:
.changeset/four-rice-guess.mdpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsxexamples/react-lazy-bundle/src/index.tsxpackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-08-11T05:59:28.530Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.
Applied to files:
.changeset/four-rice-guess.mdexamples/react-lazy-bundle/tsconfig.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-09-25T14:03:25.576Z
Learnt from: PupilTong
Repo: lynx-family/lynx-stack PR: 1834
File: packages/web-platform/web-worker-runtime/src/backgroundThread/background-apis/createChunkLoading.ts:162-171
Timestamp: 2025-09-25T14:03:25.576Z
Learning: In the lynx-stack codebase, for loadScriptAsync implementations in createChunkLoading.ts, unhandled promise rejections from readScriptAsync are intentionally not caught - the caller is expected to handle errors rather than the loadScriptAsync method itself invoking the callback with error messages.
Applied to files:
.changeset/four-rice-guess.mdpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-11-05T03:26:52.546Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1916
File: packages/react/transform/crates/swc_plugin_snapshot/lib.rs:9-9
Timestamp: 2025-11-05T03:26:52.546Z
Learning: In the lynx-stack repository's swc_core v47 upgrade (PR #1916), the import `use swc_core::atoms as swc_atoms;` is required in files that use the `quote!` macro (e.g., packages/react/transform/crates/swc_plugin_snapshot/lib.rs, swc_plugin_list/lib.rs, swc_plugin_worklet/gen_stmt.rs) even though swc_atoms may not appear explicitly in the source code. This is because the quote! macro generates code that internally references swc_atoms. Removing this import causes compiler error: "failed to resolve: use of unresolved module or unlinked crate `swc_atoms`".
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/napi.rspackages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-08-06T13:28:57.182Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/react/testing-library/src/vitest.config.js` is source code for the testing library that gets exported for users, not a test configuration that should be included in the main vitest projects array.
Applied to files:
examples/react-lazy-bundle/tsconfig.jsonpackages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-08-18T08:46:20.001Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1547
File: packages/rspeedy/core/src/config/loadConfig.ts:11-11
Timestamp: 2025-08-18T08:46:20.001Z
Learning: `#register` and similar imports starting with "#" are Node.js subpath imports defined in the "imports" field of package.json, not TypeScript path mapping aliases. These are natively supported by both Node.js and TypeScript without requiring additional tsconfig.json configuration like "moduleResolution" or "resolvePackageJsonImports" settings.
Applied to files:
examples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-11-06T01:19:23.670Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.
Applied to files:
examples/react-lazy-bundle/tsconfig.json
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In packages/react/transform/src/swc_plugin_compat/mod.rs, the `add_pure_comment` function at lines 478-482 is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs. These are two distinct code paths that should be treated differently.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rspackages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
📚 Learning: 2025-09-18T04:43:54.426Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1771
File: packages/react/transform/tests/__swc_snapshots__/src/swc_plugin_snapshot/mod.rs/basic_component_with_static_sibling.js:2-2
Timestamp: 2025-09-18T04:43:54.426Z
Learning: In the lynx-family/lynx-stack repository, the `add_pure_comment` function in packages/react/transform/src/swc_plugin_compat/mod.rs (around lines 478-482) is specifically for `wrapWithLynxComponent` calls, not `createSnapshot` calls. The PURE comment injection for `createSnapshot` is handled separately in swc_plugin_snapshot/mod.rs.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-09-10T11:42:36.855Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1714
File: packages/react/transform/Cargo.toml:19-19
Timestamp: 2025-09-10T11:42:36.855Z
Learning: In packages/react/transform/Cargo.toml, the crate uses serde derive macros (#[derive(Serialize, Deserialize)]) in multiple files including src/esbuild.rs and src/swc_plugin_extract_str/mod.rs, so the "derive" feature is required when migrating to workspace dependencies.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs
📚 Learning: 2025-08-11T06:00:04.376Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:59-61
Timestamp: 2025-08-11T06:00:04.376Z
Learning: In the lynx-family/lynx-stack repository, the `testingLibraryPlugin` in `packages/react/testing-library/src/plugins/vitest.ts` intentionally uses `process.exit` when jsdom installation fails, maintaining consistency with the previous implementation from `packages/react/testing-library/src/vitest.config.js`. This behavior should not be changed to use `this.error` despite being a Vite plugin best practice.
Applied to files:
packages/webpack/react-webpack-plugin/test/cases/code-splitting/lazy-imports/index.jsx
📚 Learning: 2025-07-18T04:27:18.291Z
Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1238
File: packages/react/runtime/src/debug/component-stack.ts:70-90
Timestamp: 2025-07-18T04:27:18.291Z
Learning: The component-stack.ts file in packages/react/runtime/src/debug/component-stack.ts is a direct fork from https://github.com/preactjs/preact/blob/main/debug/src/component-stack.js. The team prefers to keep it aligned with the upstream Preact version and may contribute improvements back to Preact in the future.
Applied to files:
examples/react-lazy-bundle/src/index.tsx
📚 Learning: 2025-10-29T10:28:27.519Z
Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1899
File: packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/lib.rs/should_static_extract_dynamic_inline_style.js:20-24
Timestamp: 2025-10-29T10:28:27.519Z
Learning: Files inside packages/react/transform/crates/swc_plugin_snapshot/tests/__swc_snapshots__/ are auto-generated test snapshot files and should not be manually updated. Any issues with the generated code should be addressed in the code generator/transform logic, not in the snapshots themselves.
Applied to files:
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js
🧬 Code graph analysis (2)
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (3)
packages/react/transform/index.d.ts (1)
DynamicImportVisitorConfig(422-429)packages/react/transform/swc-plugin-reactlynx/index.d.ts (1)
DynamicImportVisitorConfig(166-173)packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (2)
default(23-29)default(63-65)
examples/react-lazy-bundle/src/index.tsx (1)
examples/react-lazy-bundle/src/App.tsx (1)
App(5-30)
🪛 LanguageTool
.changeset/four-rice-guess.md
[grammar] ~5-~5: Use a hyphen to join words.
Context: --- "@lynx-js/react": patch --- Auto define lynx.loadLazyBundle when using `i...
(QB_NEW_EN_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build / Build (Ubuntu)
- GitHub Check: build / Build (Windows)
- GitHub Check: test-rust / clippy
- GitHub Check: test-rust / Test (Ubuntu)
🔇 Additional comments (13)
examples/react-lazy-bundle/src/rspeedy-env.d.ts (1)
1-1: LGTM! Follows the established Rspeedy pattern.The triple-slash reference directive correctly includes type declarations from
@lynx-js/rspeedy/client, which is the standard pattern for Rspeedy-based projects in this repository.Based on learnings, Rspeedy templates use
lynx-js/rspeedy/clienttypes viarspeedy-env.d.tsinstead ofvite/clienttypes.examples/react-lazy-bundle/src/index.tsx (3)
1-3: LGTM!The imports correctly set up debugging tools and the React runtime for the example application.
11-13: LGTM!The root rendering logic is correct and follows the standard Lynx React pattern.
15-17: LGTM!The HMR setup follows the standard webpack hot module replacement pattern, enabling a better development experience.
packages/react/transform/crates/swc_plugin_dynamic_import/napi.rs (3)
18-19: LGTM! Field addition follows existing pattern.The inject_lazy_bundle field is properly declared with Option type and @internal documentation, consistent with other internal fields in the struct.
27-27: LGTM! Default enables auto-injection.Setting inject_lazy_bundle to Some(true) by default aligns with the PR objective to automatically define lynx.loadLazyBundle when using dynamic imports with relative paths.
37-37: LGTM! Field properly propagated.The inject_lazy_bundle field is correctly propagated through both From trait implementations, maintaining consistency between DynamicImportVisitorConfig and CoreConfig.
Also applies to: 47-47
packages/react/transform/crates/swc_plugin_dynamic_import/tests/__swc_snapshots__/lib.rs/should_import_lazy_import.js (1)
1-9: Auto-generated snapshot looks correct.This snapshot demonstrates the expected transform output: importing the lazy/import module, importing __dynamicImport, and calling it with an external URL and component type.
packages/react/transform/crates/swc_plugin_dynamic_import/lib.rs (5)
29-30: LGTM! Config field added consistently.The inject_lazy_bundle field is properly added to DynamicImportVisitorConfig with a sensible default of Some(true), enabling auto-injection by default.
Also applies to: 38-38
48-48: LGTM! State tracking added for inner lazy bundles.The has_inner_lazy_bundle field correctly tracks when relative-path imports requiring lazy bundle loading are detected, initialized to false and set to true at line 219 when appropriate.
Also applies to: 70-70
117-130: LGTM! Helper function reduces duplication.The create_import_decl helper properly constructs side-effect import declarations, eliminating code duplication for lazy import generation.
306-306: LGTM! Tests cover key scenarios.The test suite properly covers:
- Disabling lazy bundle injection with inject_lazy_bundle: Some(false)
- External URL imports requiring lazy/import
- Relative path imports requiring lazy bundle injection
- Template literal imports (no lazy handling)
Also applies to: 343-391
279-282: The data URL approach is established and the concerns are addressed by Lynx's architecture.The global
lynxobject is guaranteed to exist via shimming (lynx = lynx || {}in RuntimeWrapperWebpackPlugin),loadLazyBundleis properly exported from@lynx-js/react/internal, and webpack bundlers support this data: URL pattern as evidenced by existing test snapshots. This approach is not unconventional in this codebase—it's an established pattern already used in generated code and tested consistently. Similar to how__-prefixed functions are injected globally by the Lynx Engine, thelynxobject is shimmed at bundle initialization to ensure it's always available.
upupming
approved these changes
Dec 2, 2025
Collaborator
upupming
left a comment
upupming
left a comment
There was a problem hiding this comment.
LGTM! Just one question~
colinaaa
approved these changes
Dec 7, 2025
gaoachao
approved these changes
Dec 8, 2025
hzy
approved these changes
Dec 8, 2025
3 tasks
colinaaa
added a commit
that referenced
this pull request
Dec 9, 2025
<!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> <!-- The AI summary below will be auto-generated - feel free to replace it with your own. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Added support for a newer version of a related build tool while maintaining compatibility with previous versions. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Add missing `peerDependnecies` for #1956. ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required). - [ ] Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).
colinaaa
pushed a commit
that referenced
this pull request
Dec 14, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/css-extract-webpack-plugin@0.7.0 ### Minor Changes - **BREAKING CHANGE**: Require `@lynx-js/template-webpack-plugin` 0.10.0. ([#1965](#1965)) - Merge all css chunk and generate a `.css.hot-update.json` file for each bundle. ([#1965](#1965)) ## @lynx-js/template-webpack-plugin@0.10.0 ### Minor Changes - Merge all css chunk and generate a `.css.hot-update.json` file for each bundle. ([#1965](#1965)) ## @lynx-js/react@0.115.1 ### Patch Changes - Auto define lynx.loadLazyBundle when using `import(/* relative path */)`. ([#1956](#1956)) - feat: support declaring cross-thread shared modules via Import Attributes, enabling Main Thread Functions to call standard JS functions directly. ([#1968](#1968)) - Usage: Add `with { runtime: "shared" }` to the `import` statement. For example: ```ts import { func } from './utils.js' with { runtime: 'shared' }; function worklet() { 'main thread'; func(); // callable inside a main thread function } ``` - Limitations: - Only directly imported identifiers are treated as shared; assigning the import to a new variable will result in the loss of this shared capability. - Functions defined within shared modules do not automatically become Main Thread Functions. Accessing main-thread-only APIs (e.g., `MainThreadRef`) will cause errors. ## @lynx-js/rspeedy@0.12.2 ### Patch Changes - Bump Rsbuild v1.6.13 with Rspack v1.6.6. ([#1995](#1995)) - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.19.1 ## @lynx-js/react-rsbuild-plugin@0.12.1 ### Patch Changes - Avoid injecting hot update runtime when dev.hmr or dev.liveReload is set to false. ([#1980](#1980)) - Updated dependencies \[[`553ece1`](553ece1), [`8cdb69d`](8cdb69d), [`8cdb69d`](8cdb69d)]: - @lynx-js/react-webpack-plugin@0.7.3 - @lynx-js/css-extract-webpack-plugin@0.7.0 - @lynx-js/template-webpack-plugin@0.10.0 - @lynx-js/react-alias-rsbuild-plugin@0.12.1 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.4 ## @lynx-js/web-constants@0.19.1 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.19.1 ## @lynx-js/web-core@0.19.1 ### Patch Changes - fix: support CSP for mts ([#1994](#1994)) - Updated dependencies \[[`f7256d5`](f7256d5)]: - @lynx-js/web-mainthread-apis@0.19.1 - @lynx-js/web-worker-runtime@0.19.1 - @lynx-js/web-constants@0.19.1 - @lynx-js/web-worker-rpc@0.19.1 ## @lynx-js/web-mainthread-apis@0.19.1 ### Patch Changes - fix: fix reload lynx-view when `enableCSSSelector` false may cause css style lost ([#1982](#1982)) - Updated dependencies \[]: - @lynx-js/web-constants@0.19.1 ## @lynx-js/web-worker-runtime@0.19.1 ### Patch Changes - Updated dependencies \[[`f7256d5`](f7256d5)]: - @lynx-js/web-mainthread-apis@0.19.1 - @lynx-js/web-constants@0.19.1 - @lynx-js/web-worker-rpc@0.19.1 ## @lynx-js/react-webpack-plugin@0.7.3 ### Patch Changes - Support `@lynx-js/template-webpack-plugin` v0.10.0. ([#1992](#1992)) ## create-rspeedy@0.12.2 ## @lynx-js/react-alias-rsbuild-plugin@0.12.1 ## upgrade-rspeedy@0.12.2 ## @lynx-js/web-core-server@0.19.1 ## @lynx-js/web-rsbuild-server-middleware@0.19.1 ## @lynx-js/web-worker-rpc@0.19.1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
f0rdream
pushed a commit
to f0rdream/lynx-stack
that referenced
this pull request
Dec 18, 2025
) Auto define lynx.loadLazyBundle when using `import(/* relative path */)`. close lynx-family#1954 <!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> <!-- The AI summary below will be auto-generated - feel free to replace it with your own. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Automatic `lynx.loadLazyBundle` integration with dynamic imports for streamlined code-splitting * New React lazy-bundle example project demonstrating advanced code-splitting patterns * Enhanced component lazy-loading with experimental import capabilities * **Tests** * Expanded test coverage for dynamic import transformations and lazy-loading scenarios <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required). - [ ] Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).
f0rdream
pushed a commit
to f0rdream/lynx-stack
that referenced
this pull request
Dec 18, 2025
<!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> <!-- The AI summary below will be auto-generated - feel free to replace it with your own. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Added support for a newer version of a related build tool while maintaining compatibility with previous versions. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Add missing `peerDependnecies` for lynx-family#1956. ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required). - [ ] Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).
f0rdream
pushed a commit
to f0rdream/lynx-stack
that referenced
this pull request
Dec 18, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/css-extract-webpack-plugin@0.7.0 ### Minor Changes - **BREAKING CHANGE**: Require `@lynx-js/template-webpack-plugin` 0.10.0. ([lynx-family#1965](lynx-family#1965)) - Merge all css chunk and generate a `.css.hot-update.json` file for each bundle. ([lynx-family#1965](lynx-family#1965)) ## @lynx-js/template-webpack-plugin@0.10.0 ### Minor Changes - Merge all css chunk and generate a `.css.hot-update.json` file for each bundle. ([lynx-family#1965](lynx-family#1965)) ## @lynx-js/react@0.115.1 ### Patch Changes - Auto define lynx.loadLazyBundle when using `import(/* relative path */)`. ([lynx-family#1956](lynx-family#1956)) - feat: support declaring cross-thread shared modules via Import Attributes, enabling Main Thread Functions to call standard JS functions directly. ([lynx-family#1968](lynx-family#1968)) - Usage: Add `with { runtime: "shared" }` to the `import` statement. For example: ```ts import { func } from './utils.js' with { runtime: 'shared' }; function worklet() { 'main thread'; func(); // callable inside a main thread function } ``` - Limitations: - Only directly imported identifiers are treated as shared; assigning the import to a new variable will result in the loss of this shared capability. - Functions defined within shared modules do not automatically become Main Thread Functions. Accessing main-thread-only APIs (e.g., `MainThreadRef`) will cause errors. ## @lynx-js/rspeedy@0.12.2 ### Patch Changes - Bump Rsbuild v1.6.13 with Rspack v1.6.6. ([lynx-family#1995](lynx-family#1995)) - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.19.1 ## @lynx-js/react-rsbuild-plugin@0.12.1 ### Patch Changes - Avoid injecting hot update runtime when dev.hmr or dev.liveReload is set to false. ([lynx-family#1980](lynx-family#1980)) - Updated dependencies \[[`553ece1`](lynx-family@553ece1), [`8cdb69d`](lynx-family@8cdb69d), [`8cdb69d`](lynx-family@8cdb69d)]: - @lynx-js/react-webpack-plugin@0.7.3 - @lynx-js/css-extract-webpack-plugin@0.7.0 - @lynx-js/template-webpack-plugin@0.10.0 - @lynx-js/react-alias-rsbuild-plugin@0.12.1 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.4 ## @lynx-js/web-constants@0.19.1 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.19.1 ## @lynx-js/web-core@0.19.1 ### Patch Changes - fix: support CSP for mts ([lynx-family#1994](lynx-family#1994)) - Updated dependencies \[[`f7256d5`](lynx-family@f7256d5)]: - @lynx-js/web-mainthread-apis@0.19.1 - @lynx-js/web-worker-runtime@0.19.1 - @lynx-js/web-constants@0.19.1 - @lynx-js/web-worker-rpc@0.19.1 ## @lynx-js/web-mainthread-apis@0.19.1 ### Patch Changes - fix: fix reload lynx-view when `enableCSSSelector` false may cause css style lost ([lynx-family#1982](lynx-family#1982)) - Updated dependencies \[]: - @lynx-js/web-constants@0.19.1 ## @lynx-js/web-worker-runtime@0.19.1 ### Patch Changes - Updated dependencies \[[`f7256d5`](lynx-family@f7256d5)]: - @lynx-js/web-mainthread-apis@0.19.1 - @lynx-js/web-constants@0.19.1 - @lynx-js/web-worker-rpc@0.19.1 ## @lynx-js/react-webpack-plugin@0.7.3 ### Patch Changes - Support `@lynx-js/template-webpack-plugin` v0.10.0. ([lynx-family#1992](lynx-family#1992)) ## create-rspeedy@0.12.2 ## @lynx-js/react-alias-rsbuild-plugin@0.12.1 ## upgrade-rspeedy@0.12.2 ## @lynx-js/web-core-server@0.19.1 ## @lynx-js/web-rsbuild-server-middleware@0.19.1 ## @lynx-js/web-worker-rpc@0.19.1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto define lynx.loadLazyBundle when using
import(/* relative path */).close #1954
Summary by CodeRabbit
New Features
Examples & Documentation
Tests
✏️ Tip: You can customize this high-level summary in your review settings.
Checklist