Skip to content

chore: rename web-mainthread-apis/src to ./ts#1945

Merged
PupilTong merged 1 commit intolynx-family:mainfrom
PupilTong:p/hw/rust-refactor-0
Nov 20, 2025
Merged

chore: rename web-mainthread-apis/src to ./ts#1945
PupilTong merged 1 commit intolynx-family:mainfrom
PupilTong:p/hw/rust-refactor-0

Conversation

@PupilTong
Copy link
Collaborator

@PupilTong PupilTong commented Nov 20, 2025

This is a part of #1937

Summary by CodeRabbit

  • Chores
    • Updated TypeScript project configuration paths for the web mainthread APIs package.
    • Added build system configuration to enable faster incremental builds and improve build pipeline orchestration.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: 15e01c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

📝 Walkthrough

Walkthrough

Build configuration updates in the web-mainthread-apis package: TypeScript configuration redirects source root directory from ./src to ./ts, and a new Turbo configuration file is added to define incremental build task orchestration with specified input and output paths.

Changes

Cohort / File(s) Summary
Build Configuration
packages/web-platform/web-mainthread-apis/tsconfig.json, packages/web-platform/web-mainthread-apis/turbo.json
Updated TypeScript rootDir and include paths to reference ts directory instead of src; added Turbo repository configuration with build task dependencies and input/output mappings for incremental builds

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that the ts directory exists and contains the expected TypeScript source files
  • Confirm the Turbo build task configuration correctly maps inputs (ts/** and src/**) and outputs (dist/**)
  • Ensure no remaining references to the old ./src path in related build scripts

Suggested labels

platform:Web

Suggested reviewers

  • Sherry-hue

Poem

🐰 A hop, a skip, paths realigned,
From src to ts, the configs refined,
With Turbo's touch, the builds take flight,
Incremental magic done just right!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: renaming the web-mainthread-apis/src directory to ./ts, which is reflected in both the tsconfig.json rootDir update and the turbo.json configuration changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d232388 and 15e01c7.

📒 Files selected for processing (2)
  • packages/web-platform/web-mainthread-apis/tsconfig.json (1 hunks)
  • packages/web-platform/web-mainthread-apis/turbo.json (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: Sherry-hue
Repo: lynx-family/lynx-stack PR: 1837
File: packages/web-platform/web-mainthread-apis/src/prepareMainThreadAPIs.ts:266-266
Timestamp: 2025-10-10T08:22:12.051Z
Learning: In packages/web-platform/web-mainthread-apis, the handleUpdatedData function returned from prepareMainThreadAPIs is internal-only, used to serve web-core. It does not require public documentation, type exports, or SSR support.
📚 Learning: 2025-09-29T06:43:40.182Z
Learnt from: CR
Repo: lynx-family/lynx-stack PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-09-29T06:43:40.182Z
Learning: Applies to packages/**/etc/*.api.md : Always commit API extractor output after running `pnpm turbo api-extractor -- --local` (commit updated API report files)

Applied to files:

  • packages/web-platform/web-mainthread-apis/turbo.json
📚 Learning: 2025-10-10T08:22:12.051Z
Learnt from: Sherry-hue
Repo: lynx-family/lynx-stack PR: 1837
File: packages/web-platform/web-mainthread-apis/src/prepareMainThreadAPIs.ts:266-266
Timestamp: 2025-10-10T08:22:12.051Z
Learning: In packages/web-platform/web-mainthread-apis, the handleUpdatedData function returned from prepareMainThreadAPIs is internal-only, used to serve web-core. It does not require public documentation, type exports, or SSR support.

Applied to files:

  • packages/web-platform/web-mainthread-apis/tsconfig.json
🔇 Additional comments (1)
packages/web-platform/web-mainthread-apis/tsconfig.json (1)

5-5: TypeScript configuration updated correctly for directory rename.

The changes to rootDir and include appropriately reflect the source directory rename from ./src to ./ts.

Also applies to: 9-9

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 20, 2025

CodSpeed Performance Report

Merging #1945 will improve performances by 6.54%

Comparing PupilTong:p/hw/rust-refactor-0 (15e01c7) with main (d232388)

Summary

⚡ 1 improvement
✅ 62 untouched
⏩ 3 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
basic-performance-small-css 7.3 ms 6.9 ms +6.54%

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link

relativeci bot commented Nov 20, 2025

Web Explorer

#6251 Bundle Size — 366.97KiB (0%).

15e01c7(current) vs d232388 main#6249(baseline)

Bundle metrics  no changes
                 Current
#6251
     Baseline
#6249
No change  Initial JS 146.27KiB 146.27KiB
No change  Initial CSS 32.37KiB 32.37KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 8 8
No change  Modules 221 221
No change  Duplicate Modules 16 16
No change  Duplicate Code 3.21% 3.21%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#6251
     Baseline
#6249
No change  JS 240.8KiB 240.8KiB
No change  Other 93.8KiB 93.8KiB
No change  CSS 32.37KiB 32.37KiB

Bundle analysis reportBranch PupilTong:p/hw/rust-refactor-0Project dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link

relativeci bot commented Nov 20, 2025

React Example

#6181 Bundle Size — 234.35KiB (0%).

15e01c7(current) vs 0f2da6b main#6177(baseline)

Bundle metrics  no changes
                 Current
#6181
     Baseline
#6177
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 164 164
No change  Duplicate Modules 66 66
No change  Duplicate Code 46.71% 46.71%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#6181
     Baseline
#6177
No change  IMG 145.76KiB 145.76KiB
No change  Other 88.59KiB 88.59KiB

Bundle analysis reportBranch PupilTong:p/hw/rust-refactor-0Project dashboard


Generated by RelativeCIDocumentationReport issue

@PupilTong PupilTong merged commit 12f6fb3 into lynx-family:main Nov 20, 2025
83 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants